Files
buzz/.github/workflows
Matt Toohey 056788026d fix(desktop): stage bundled ACP tools in OSS release builds
The bundling series wired ACP tool staging into `just dev`, `just
staging`, and `just desktop-release-build`, and flagged the internal
sprout-releases pipeline as follow-up — but the OSS release workflow
was missed entirely. None of release.yml's four platform jobs ran
prepare-acp-tools-resource.sh before `pnpm tauri build`, so every OSS
release artifact (DMGs, deb/AppImage, NSIS installer) shipped an empty
resources/acp: the app silently fell back to unpinned user-installed
bridges, which is exactly the drift the bundling series exists to
prevent, while the catalog's "ships with the Buzz desktop app…
Reinstall Buzz" copy pointed users at a reinstall that could never fix
it.

Add a "Stage bundled ACP tools" step to all four jobs, after the
sidecar build and before the Tauri build (tauri.conf.json already
bundles resources/acp):

- macOS arm64 / Intel and Linux stage their target's pinned npm trees
  and bash wrapper shims; node + npm come from the already-activated
  hermit toolchain.
- Windows runs the same script under Git Bash (the job already runs
  every step with `shell: bash`; node comes from setup-node). The lock
  currently pins no windows-msvc entries, so the step is a visible
  no-op — ensure-acp-tools.sh prints its empty-target notice to the
  build log and stages nothing — until the Windows bundling lands.

Ensuring the staging scripts run before every `tauri build` invocation
path was the first work item of the Windows-bundling plan, independent
of the Windows decision itself.

Verification:
- prepare-acp-tools-resource.sh aarch64-apple-darwin: staged wrappers
  report the pinned 0.58.1 / 1.1.2 versions (same invocation the new
  steps run, on the same runner OS as the arm64 job).
- ensure-acp-tools.sh --target x86_64-pc-windows-msvc (pre-Windows-
  bundling lock state): "No ACP tools locked" notice on stderr, empty
  staging, exit 0 — the Windows job stays green before the lock gains
  windows entries.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Signed-off-by: Matt Toohey <contact@matttoohey.com>
2026-07-15 13:52:14 +10:00
..