jerry/buzz

mirror of https://github.com/block/buzz.git synced 2026-10-29 21:41:33 +00:00

Files

Duncan 05993fbe7a fix(personas): honest terminal copy and command-path team-refresh regression

Fix 1 (IMPORTANT 1 — false recovery instruction): both terminal branches in
agentSaveCoordinator.ts now say only that the profile saved locally but could
not be published to the catalog, with no recovery instruction of any kind.
A fresh reopen seeds persisted values → emitAgentFormDiff emits null →
coordinator never re-attempts publish, so 'Reopen the editor and save again'
was a false promise. Updated family-11 assertions to pin the exact new copy
with a positive fragment match and fragment-level bans on 'reopen' and
'retried automatically' — ban is robust to any rewording with intervening words.

Fix 2 (IMPORTANT 2 — stand-in regression): replace the stand-in Rust test
that called refresh_for_persona_at directly (passed even when the production
wiring was removed) with a true command-path test:

- Extract pub(crate) publish_and_refresh_teams_at from set_persona_shared —
  the two-step sequence (publish_prepared_persona + refresh_for_persona_at)
  that production calls. Deleting the refresh from this function turns the
  new test RED; restoring returns GREEN. Verified by mutation.
- Promote refresh_for_persona_at from #[cfg(test)] pub(super) to pub(crate),
  re-exported via commands::teams. Promote read_json_store_pub to non-test.
  Promote PreparedPersonaPublication and prepare_persona_publication_at to
  pub(crate) for test accessibility.
- New test test_set_persona_shared_publish_retry_refreshes_shared_team_head
  in teams/pending/tests.rs calls publish_and_refresh_teams_at directly,
  mirrors the exact set_persona_shared dispatch sequence, and observes the
  30178 retained team head updating after the persona content changes.

Co-authored-by: Will Pfleger <pfleger.will@gmail.com>
Signed-off-by: Will Pfleger <pfleger.will@gmail.com>

2026-08-29 19:35:18 -04:00