Wes 97aa9e3185 fix(desktop): preserve Welcome banner dismissal (#5406) ...

## Summary

- remove the complete Welcome guidance surface when dismissal reaches
`hidden`
- preserve dismissal across the private and starter Welcome channels for
the active identity
- assert the starter channel's actual `welcome-everyone` title on
re-entry

## Why

PR #5330 introduced two deterministic Desktop E2E failures:

- the inner banner unmounted, but `welcome-composer-guidance-layer`
remained
- the re-entry test expected case-sensitive `Welcome` while navigating
to `welcome-everyone`

The state hook also scoped completion to channel IDs while `ChannelPane`
remounts during navigation. The Welcome guidance is one experience
spanning both Welcome channels, so completion now survives that remount
while remaining identity-scoped.

## Validation

At `b577eb42edffe889f63566f2457eacea720f3593`:

- `pnpm -C desktop typecheck`
- focused Biome check for all four changed files
- E2E build
- both `welcome-everywhere banner` integration tests repeated three
times: **6/6 passed**
- mandatory pre-push desktop check, typecheck, and full desktop unit
suite: **4,535 passed**
- `git diff --check`

Signed-off-by: Wes <wesbillman@users.noreply.github.com>
Co-authored-by: Carl <c7ebe626f000404285d3686e1dc74cc07cc60a9754a150041ba132e14bd3e2ec@buzz.block.builderlab.xyz>

2026-08-09 09:05:47 -07:00

..

fixtures

feat(desktop+acp): spawn a harness per (agent, community) pair at GUI startup — warm sockets, lazy LLM pool (#2122)

2026-07-22 13:24:46 -07:00

helpers

Make relay reconnect backoff authoritative (#3774)

2026-07-30 11:25:08 -07:00

active-turn-resilience.spec.ts

feat(profile): embed live activity feed in profile aux panel (#1380)

2026-07-03 15:40:29 +00:00

activity-scope-label-screenshots.spec.ts

feat(desktop): improve agent activity header ui (#3321)

2026-07-30 12:34:35 -07:00

add-community-screenshots.spec.ts

fix(desktop): remove join API token control (#4897)

2026-08-05 11:56:14 -07:00

agent-access-warning.spec.ts

fix(desktop): explain open agent access (#2561)

2026-07-30 13:32:40 +00:00

agent-error-state-screenshots.spec.ts

fix(agents): harden structured error-code classification edge cases (#1663)

2026-07-08 18:18:44 -04:00

agent-lifecycle-feedback.spec.ts

Clarify agent harness defaults in create flow (#2601)

2026-07-24 01:23:31 +01:00

agent-numeric-tuning.spec.ts

feat(agents): model-tuning parity in global Agent Defaults editor (#4578)

2026-08-03 18:09:24 -04:00

agent-provider-dropdowns.spec.ts

Clarify agent harness defaults in create flow (#2601)

2026-07-24 01:23:31 +01:00

agent-readiness-screenshots.spec.ts

feat(desktop): unify add agent flows (#5015)

2026-08-07 16:25:49 -07:00

agent-snapshot-recipient.spec.ts

feat(desktop): refine agent catalog sharing (#2439)

2026-07-28 15:01:03 -04:00

agents-everywhere.live.spec.ts

feat(desktop+acp): spawn a harness per (agent, community) pair at GUI startup — warm sockets, lazy LLM pool (#2122)

2026-07-22 13:24:46 -07:00

agents.spec.ts

feat(desktop): unify add agent flows (#5015)

2026-08-07 16:25:49 -07:00

animated-avatar.spec.ts

Polish onboarding avatar capture (#2118)

2026-07-19 11:14:06 -07:00

badge.spec.ts

Polish sidebar unread hierarchy (#4573)

2026-08-04 15:39:45 +00:00

boot-splash.spec.ts

refactor(clients): standardize product naming on community (#1858)

2026-07-14 11:11:02 -07:00

buzz-theme-screenshots.spec.ts

Polish Buzz theme and sidebar (#1971)

2026-07-17 11:40:05 +00:00

channel-activity-popover.spec.ts

Polish sidebar unread hierarchy (#4573)

2026-08-04 15:39:45 +00:00

channel-add-screenshots.spec.ts

unify channel add + search into one entry point (#1964)

2026-07-16 18:01:53 +00:00

channel-browser.spec.ts

fix(desktop): avoid forwarding click event as channel callback (#2174)

2026-07-20 14:44:08 -07:00

channel-composer-overflow.spec.ts

Polish composer activity layout and transitions (#3151)

2026-07-27 15:47:04 -07:00

channel-controls.spec.ts

fix(desktop): defer channel visibility change to Save (#5203)

2026-08-07 17:25:13 +00:00

channel-dense-second-reach.spec.ts

GUI read-model overhaul: server-assembled channel windows (Correct™ pagination + relay-signed bounds) (#1500)

2026-07-04 11:51:58 -04:00

channel-mute.spec.ts

Polish sidebar unread hierarchy (#4573)

2026-08-04 15:39:45 +00:00

channel-shared-header-backdrop.spec.ts

Fix channel header shared blur layering (#1336)

2026-06-29 06:42:31 -07:00

channel-sort.spec.ts

feat(desktop): unify sidebar section actions into a per-section ⋮ menu (#1577)

2026-07-07 07:29:02 -07:00

channel-star.spec.ts

Clean up screenshot e2e tests (#1284)

2026-06-25 09:25:34 -07:00

channel-window-mock-paging.spec.ts

GUI read-model overhaul: server-assembled channel windows (Correct™ pagination + relay-signed bounds) (#1500)

2026-07-04 11:51:58 -04:00

channels.spec.ts

fix(desktop): retain distinct agent instances in autocomplete (#5202)

2026-08-07 17:31:59 +00:00

cold-switch-longtask.perf.ts

feat(desktop): re-land virtualized timeline to fix macOS beachball (#1250)

2026-06-26 18:09:07 +00:00

community-rail.spec.ts

feat(desktop): show selected community in rail (#5000)

2026-08-06 07:39:36 -07:00

composer-image-draw.spec.ts

fix(desktop): rename generic attachment action from 'Attach image' to 'Attach file' (#2381) (#4304)

2026-08-05 15:16:32 -07:00

composer-link-shortcut.spec.ts

feat(desktop): adding rich link previews to messages (#3818)

2026-08-07 10:56:08 -07:00

composer-selection-formatting.spec.ts

feat: paste composer text without formatting (#4801)

2026-08-04 16:16:14 -07:00

composer-tooltip-dismiss.spec.ts

feat(composer): compose spoiler, annotation, and tooltip controls (#1491)

2026-07-06 16:36:01 -07:00

config-bridge-screenshots.spec.ts

feat(desktop): show read-only MCP server config (#1780)

2026-07-13 16:29:21 -04:00

core-memory-screenshots.spec.ts

fix(desktop): separate system prompt from turn context (#1754)

2026-07-11 13:40:16 -04:00

custom-emoji-ui.spec.ts

refactor(clients): standardize product naming on community (#1858)

2026-07-14 11:11:02 -07:00

custom-emoji.spec.ts

fix(desktop): integer-align custom reaction emoji (#4779)

2026-08-04 20:38:19 +00:00

deep-link-invite.spec.ts

Make public starter channels best effort (#5192)

2026-08-07 09:21:29 -07:00

dm-double-notification.spec.ts

fix(desktop): stop DMs from firing duplicate desktop notifications (#2105)

2026-07-18 23:16:00 -04:00

dm-new-message-screenshots.spec.ts

feat(desktop): add conversation-style DM composer (#1768)

2026-07-14 16:50:22 +01:00

doctor-cta-screenshots.spec.ts

Improve agent runtime settings (#2026)

2026-07-19 19:01:38 +00:00

doctor-states.spec.ts

feat(desktop): raise the install ceiling and make installs observable (#3368)

2026-07-30 17:07:22 -04:00

drafts-all-fix-screenshots.spec.ts

fix(desktop): keep drafts out of the Inbox All view (#3217)

2026-07-28 19:37:12 +01:00

drafts-screenshots.spec.ts

Inbox refactor (#2045)

2026-07-27 16:45:34 -04:00

edit-agent-run-on.spec.ts

feat(desktop): show saved Run on settings when editing an agent (#4539)

2026-08-03 12:08:29 -04:00

edit-agent.spec.ts

feat(desktop): unify add agent flows (#5015)

2026-08-07 16:25:49 -07:00

empty-edit-delete.spec.ts

fix(desktop): widen post-Enter timeouts in empty-edit-delete spec (#4792)

2026-08-04 17:08:29 -04:00

file-attachment.spec.ts

fix(desktop): rename generic attachment action from 'Attach image' to 'Attach file' (#2381) (#4304)

2026-08-05 15:16:32 -07:00

global-agent-config-screenshots.spec.ts

feat(desktop): unify add agent flows (#5015)

2026-08-07 16:25:49 -07:00

harness-catalog-screenshots.spec.ts

feat(desktop): redesign agent runtime settings (#3093)

2026-07-27 11:01:42 -07:00

harness-management.spec.ts

feat(desktop): locally stored NIP-49 encrypted key backup (#2937)

2026-07-30 20:58:03 -04:00

home-collapsed-top-chrome.spec.ts

fix(desktop): align inbox layout and draft details (#2143)

2026-07-20 00:53:53 +02:00

hosted-communities-settings-screenshots.spec.ts

Refine community management flows (#2738)

2026-07-24 19:30:33 -07:00

huddle-transcription.spec.ts

Polish Huddle voice controls (#4694)

2026-08-04 13:07:50 -07:00

human-edit-agent-content.spec.ts

feat(desktop): replace placeholder icon with actual app icon on welcome screen (#1527)

2026-07-06 06:55:58 -07:00

identity-archive-hide.spec.ts

fix(desktop): prefer live agent mentions (#2149)

2026-07-20 08:58:48 -07:00

identity-archive.spec.ts

fix: skip membership lookup for open relays (#2107)

2026-07-20 15:35:40 +00:00

identity-key-help.spec.ts

fix(desktop): keep identity key help dialog readable in dark mode (#2854)

2026-07-27 09:47:02 -07:00

identity-lost.spec.ts

feat(identity): recover desktop identity from a signed-in phone (#4845)

2026-08-06 11:47:18 -07:00

image-attachment-gallery.spec.ts

fix(desktop): rename generic attachment action from 'Attach image' to 'Attach file' (#2381) (#4304)

2026-08-05 15:16:32 -07:00

inbox-edit.spec.ts

feat(desktop): adding rich link previews to messages (#3818)

2026-08-07 10:56:08 -07:00

inbox-live-update.spec.ts

fix(desktop): route text copies through native clipboard (#2054)

2026-07-18 00:01:24 +00:00

inbox-reactions.spec.ts

fix(desktop): align inbox layout and draft details (#2143)

2026-07-20 00:53:53 +02:00

inbox-refactor-screenshots.spec.ts

fix(desktop): restore the inbox icon in the sidebar (#3341)

2026-07-28 14:01:18 -04:00

inline-custom-harness.spec.ts

feat(desktop): unify add agent flows (#5015)

2026-08-07 16:25:49 -07:00

integration.spec.ts

Inbox refactor (#2045)

2026-07-27 16:45:34 -04:00

invite-link-copy.spec.ts

Refine community invite links (#4734)

2026-08-04 10:39:09 -07:00

invites-settings-screenshots.spec.ts

Refine community invite links (#4734)

2026-08-04 10:39:09 -07:00

key-import-reveal.spec.ts

Add identity key help and reveal toggle to machine onboarding (#2064)

2026-07-18 15:45:41 +00:00

live-broadcast-reply-timeline.spec.ts

GUI read-model overhaul: server-assembled channel windows (Correct™ pagination + relay-signed bounds) (#1500)

2026-07-04 11:51:58 -04:00

local-archive-screenshots.spec.ts

feat(archive): add local-save archive with observer-feed default-on option (#1442)

2026-07-06 17:41:56 -04:00

markdown-parse-cache.spec.ts

perf(desktop): cache parsed markdown across channel-switch remounts (#1635)

2026-07-08 14:38:52 -07:00

mentions.spec.ts

fix(desktop): allow shared agent mentions (#4913)

2026-08-05 11:15:11 -07:00

mesh-compute.spec.ts

Polish Share Compute settings (#3735)

2026-08-03 14:12:21 -07:00

message-feedback-snapshots.spec.ts

Fix pending message feedback (#3543)

2026-07-30 07:46:56 -07:00

messaging.spec.ts

feat(desktop): adding rich link previews to messages (#3818)

2026-08-07 10:56:08 -07:00

mobile-pairing-qr.spec.ts

Improve desktop mobile pairing flow (#5024)

2026-08-06 07:45:21 -07:00

navigation.spec.ts

fix(desktop): back/forward via keyboard chords, mouse X1/X2 buttons, and swipe gestures (#3778)

2026-08-02 14:53:01 -04:00

needs-restart-screenshots.spec.ts

Refine agent runtime controls (#5026)

2026-08-06 08:21:35 -07:00

nostr-bind.spec.ts

feat(desktop): streamline nostr identity pairing (#1974)

2026-07-16 12:44:14 -07:00

observer-archive-policy.spec.ts

fix(local-archive): default both archive settings to enabled (#4750)

2026-08-04 16:02:34 -04:00

observer-feed-screenshots.spec.ts

fix(desktop): parse runtime team instructions section (#2645)

2026-07-24 12:10:09 -04:00

onboarding-agent-defaults.spec.ts

feat(desktop): make onboarding model defaults skippable (#3968)

2026-08-03 13:05:47 -07:00

onboarding-avatar-skip.spec.ts

fix(desktop): recover first community joins (#2087)

2026-07-18 15:31:17 -07:00

onboarding-backup.spec.ts

fix(desktop): next/back navigation during key creation onboarding (#4978)

2026-08-06 17:13:55 -07:00

onboarding-docked-cta-screenshots.spec.ts

feat(desktop): locally stored NIP-49 encrypted key backup (#2937)

2026-07-30 20:58:03 -04:00

onboarding.spec.ts

fix(desktop): preserve Welcome banner dismissal (#5406)

2026-08-09 09:05:47 -07:00

overscroll-boundary.spec.ts

feat: ship Buzz Term (#4347)

2026-08-03 21:51:17 -04:00

parity-ancestor-island.spec.ts

GUI read-model overhaul: server-assembled channel windows (Correct™ pagination + relay-signed bounds) (#1500)

2026-07-04 11:51:58 -04:00

persistent-agent-audience.spec.ts

Preserve persistent agent audience order (#1989)

2026-07-16 16:18:07 -07:00

persona-env-vars.spec.ts

feat(desktop): unify add agent flows (#5015)

2026-08-07 16:25:49 -07:00

persona-model-combobox-screenshots.spec.ts

feat(desktop): unify add agent flows (#5015)

2026-08-07 16:25:49 -07:00

persona-sync.spec.ts

feat(desktop): refine agent catalog sharing (#2439)

2026-07-28 15:01:03 -04:00

profile-active-turn.spec.ts

feat(profile): embed live activity feed in profile aux panel (#1380)

2026-07-03 15:40:29 +00:00

profile-backup-settings.spec.ts

feat(desktop): add password-protected backups in settings (#3701)

2026-07-30 11:15:39 -07:00

profile-custom-emoji-status.spec.ts

…

profile-nsec-reveal.spec.ts

feat(desktop): add key backup and agent defaults to onboarding, make avatar optional (#1767)

2026-07-12 18:46:02 -04:00

profile.spec.ts

feat(desktop): improve channel template discovery (#4549)

2026-08-03 09:30:15 -07:00

project-commit-detail.spec.ts

feat(desktop): adding rich link previews to messages (#3818)

2026-08-07 10:56:08 -07:00

project-inbox.spec.ts

feat(projects): support multiple repositories (#4671)

2026-08-04 17:30:12 -04:00

project-issue-comments.spec.ts

feat(projects): support multiple repositories (#4671)

2026-08-04 17:30:12 -04:00

project-pr-review.spec.ts

feat(projects): support multiple repositories (#4671)

2026-08-04 17:30:12 -04:00

pubkey-display-screenshots.spec.ts

fix(ui): relabel agent owner attribution from "owned by" to "managed by" (#2133)

2026-07-19 14:39:59 -04:00

reaction-names.spec.ts

fix(reactions): wrap long popover names (#3834)

2026-08-03 14:09:46 -07:00

reaction-order.spec.ts

Fix desktop launch motion and reaction spacing (#1717)

2026-07-12 08:42:31 -07:00

relay-connectivity.spec.ts

fix(relay-reconnect): resilient reconnect with fast-path, escalation, and polling (#1456)

2026-07-02 19:30:24 +00:00

relay-reconnect-affordance.spec.ts

Clean up screenshot e2e tests (#1284)

2026-06-25 09:25:34 -07:00

relay-reconnect.spec.ts

fix(desktop): stop rate-limited reconnect backfill from tearing down the authenticated socket (#4990)

2026-08-06 07:39:17 -07:00

relay-restart.live.spec.ts

Make relay reconnect backoff authoritative (#3774)

2026-07-30 11:25:08 -07:00

reminder-click-repro.spec.ts

fix(desktop): dedupe react-dismissable-layer to stop modal menu → dialog freezes (#1899)

2026-07-15 07:34:50 -07:00

reminders.spec.ts

Inbox refactor (#2045)

2026-07-27 16:45:34 -04:00

scroll-history.spec.ts

fix(desktop): consolidate prepend scroll correction (#2855)

2026-07-25 16:49:56 -07:00

scroll-smoothness.perf.ts

fix(desktop): single-owner anchored scroll for dynamic loading (#1115)

2026-06-18 20:40:05 -04:00

scrollback-buzzbugs.perf.ts

chore(desktop): use dot access for host header assignment (#1548)

2026-07-06 13:58:15 -04:00

send-channel-binding.spec.ts

fix(desktop): bind channel and thread context at compose time to prevent wrong-channel send (#1472)

2026-07-02 20:15:44 +00:00

sidebar-more-unread-overlap.spec.ts

Fix sidebar unread indicator placement (#1319)

2026-06-29 09:18:16 -07:00

sidebar-relay-card.spec.ts

fix(desktop): deduplicate relay outage notification (#3579)

2026-07-29 15:48:06 -04:00

sidebar.spec.ts

fix(desktop): remove join API token control (#4897)

2026-08-05 11:56:14 -07:00

signout-confirmation.spec.ts

feat(desktop): locally stored NIP-49 encrypted key backup (#2937)

2026-07-30 20:58:03 -04:00

signout-screenshots.spec.ts

fix(desktop): align data deletion labels (#2230)

2026-07-30 15:47:35 -07:00

smoke.spec.ts

feat(desktop): unify add agent flows (#5015)

2026-08-07 16:25:49 -07:00

spoiler.spec.ts

fix(desktop): rename generic attachment action from 'Attach image' to 'Attach file' (#2381) (#4304)

2026-08-05 15:16:32 -07:00

stream.spec.ts

Stabilize persona and stream end-to-end tests (#1865)

2026-07-14 12:14:41 -07:00

team-mentions.spec.ts

feat(desktop): expand owned team mentions (#1918)

2026-07-15 18:39:39 -04:00

team-snapshot.spec.ts

feat(desktop): refine agent catalog sharing (#2439)

2026-07-28 15:01:03 -04:00

terminal-wheel.spec.ts

Dock Buzz Term within channel workspace (#4724)

2026-08-04 11:10:47 -07:00

thread-focus-mode.spec.ts

test(desktop): await thread scroll anchor (#3174)

2026-08-06 15:04:39 +00:00

thread-reply-anchor-roleplay.spec.ts

Polish thread reply hover states (#1329)

2026-06-27 06:27:51 -07:00

thread-unread.spec.ts

Add channel activity hover menu (#3935)

2026-08-03 09:26:06 -07:00

threadpane-ultrawide.spec.ts

fix(desktop): clamp thread panel to channel surface (#4965)

2026-08-05 15:40:40 -07:00

timeline-no-shift.spec.ts

fix(desktop): consolidate prepend scroll correction (#2855)

2026-07-25 16:49:56 -07:00

top-chrome-zoom-clearance.spec.ts

Polish Buzz theme and sidebar (#1971)

2026-07-17 11:40:05 +00:00

typing-latency.perf.ts

fix(desktop): route text copies through native clipboard (#2054)

2026-07-18 00:01:24 +00:00

unread-pill.spec.ts

Polish sidebar unread hierarchy (#4573)

2026-08-04 15:39:45 +00:00

video-attachment.spec.ts

Improve video review readiness and controls (#5161)

2026-08-07 07:45:18 -07:00

virtualization.spec.ts

fix(desktop): retire prepend mode on every reader wheel (#2913)

2026-07-25 17:22:15 -07:00

voice-settings.spec.ts

feat(desktop): import local Pocket voices (#3259)

2026-07-31 11:15:09 -04:00

warm-switch-markdown.perf.ts

perf(desktop): cache parsed markdown across channel-switch remounts (#1635)

2026-07-08 14:38:52 -07:00

welcome-agent-modal-screenshots.spec.ts

Remove agent creation success modal (#5063)

2026-08-07 17:03:16 +01:00

where-to-run-config.spec.ts

feat(desktop): unify add agent flows (#5015)

2026-08-07 16:25:49 -07:00

workflows.spec.ts

…