Files
buzz/crates
Duncan 255ed62a42 fix(acp): clippy borrow and MessageRow memo gaps for permission gate
B1: Remove needless borrow in description_from_request_permission call.
The function accepts `&serde_json::Value`; `msg` is already that type —
`&msg` was a double-reference that Clippy correctly flagged.

B2: Add three missing inputs to the MessageRow memo comparator that are
consumed by selectPermissionRequest: message.signerPubkey,
message.preEditBody, and channelId. Without these, a memo-cached row
retains stale authorization state across prop changes — a trusted→forged
signer flip keeps the card rendered, and a channelId change keeps stale
card routing.

Two new integrated rerender regressions in MessageRowProseGate.test.mjs:
- test_trusted_to_forged_signer_rerender_restores_prose: mutation dropping
  signerPubkey comparison → test fails (nonce absent after rerender).
- test_null_channelid_rerender_removes_card_restores_prose: mutation
  dropping channelId comparison → test fails (nonce absent after rerender).

MessageRow split-count held at 1000 (three comment lines collapsed to
recover headroom for the three new comparator lines).

Co-authored-by: Will Pfleger <pfleger.will@gmail.com>
Signed-off-by: Will Pfleger <pfleger.will@gmail.com>
2026-08-29 20:54:09 -04:00
..