mirror of
https://github.com/block/buzz.git
synced 2026-10-27 20:41:57 +00:00
## Summary - make the differential file-size ratchet a first-class repository gate - run the same unfiltered gate from pre-push, `just check`, and CI - remove hidden file-size coupling from Desktop, Web, and Mobile lint commands - isolate ratchet Git subprocesses from hook-exported repository state ## Why The Desktop ratchet grew to govern `desktop/src-tauri/crates/**`, but the pre-push `desktop-check` command remained path-filtered to non-Tauri files. That contract drift allowed a Tauri Rust file-size regression through local validation. The ratchet already computes its own merge-base diff, so duplicating governed paths in Lefthook and CI adds drift risk without meaningful runtime savings. One root gate owns the policy now. ## Testing - `just file-size-check` - oversized untracked probe under `desktop/src-tauri/crates/**` fails with the 1,000-line ceiling - file-size core tests with hook-style `GIT_DIR` / `GIT_WORK_TREE` environment - `lefthook dump` confirms the unfiltered pre-push command - mandatory pre-push suite passed on `3217003db10c84d8a0c5f636ec4c92936777a002` - `git diff --check` Signed-off-by: Wes <wesbillman@users.noreply.github.com> Co-authored-by: Carl <c7ebe626f000404285d3686e1dc74cc07cc60a9754a150041ba132e14bd3e2ec@buzz.block.builderlab.xyz>
120 lines
3.6 KiB
JavaScript
120 lines
3.6 KiB
JavaScript
import assert from "node:assert/strict";
|
|
import { execFileSync } from "node:child_process";
|
|
import { mkdtempSync } from "node:fs";
|
|
import { tmpdir } from "node:os";
|
|
import path from "node:path";
|
|
import test from "node:test";
|
|
import {
|
|
allowedLineCount,
|
|
countLines,
|
|
evaluateFileSize,
|
|
parseChangedFiles,
|
|
resolveBaseRef,
|
|
} from "./check-file-sizes-core.mjs";
|
|
|
|
function git(repo, ...args) {
|
|
// These fixture repositories inherit both hook configuration and Git's
|
|
// repository-local environment when this test runs from pre-push. Isolate
|
|
// them completely so fixture commits cannot recurse into the real checkout.
|
|
const env = Object.fromEntries(
|
|
Object.entries(process.env).filter(([key]) => !key.startsWith("GIT_")),
|
|
);
|
|
return execFileSync("git", ["-c", "core.hooksPath=/dev/null", ...args], {
|
|
cwd: repo,
|
|
encoding: "utf8",
|
|
env,
|
|
}).trim();
|
|
}
|
|
|
|
test("local base resolution uses the branch merge-base and fails without origin/main", () => {
|
|
const repo = mkdtempSync(path.join(tmpdir(), "file-size-base-"));
|
|
git(repo, "init", "-b", "main");
|
|
git(repo, "config", "user.name", "Test");
|
|
git(repo, "config", "user.email", "test@example.com");
|
|
git(repo, "commit", "--allow-empty", "-m", "base");
|
|
git(repo, "remote", "add", "origin", repo);
|
|
git(repo, "fetch", "origin", "main:refs/remotes/origin/main");
|
|
const base = git(repo, "rev-parse", "HEAD");
|
|
git(repo, "switch", "-c", "feature");
|
|
git(repo, "commit", "--allow-empty", "-m", "first branch commit");
|
|
git(repo, "commit", "--allow-empty", "-m", "second branch commit");
|
|
|
|
assert.equal(resolveBaseRef(repo, {}), base);
|
|
git(repo, "update-ref", "-d", "refs/remotes/origin/main");
|
|
assert.throws(
|
|
() => resolveBaseRef(repo, {}),
|
|
/Fetch origin\/main or set CHECK_FILE_SIZES_BASE/,
|
|
);
|
|
});
|
|
|
|
test("counts empty, LF, and CRLF content with the existing semantics", () => {
|
|
assert.equal(countLines(""), 0);
|
|
assert.equal(countLines("one\n"), 2);
|
|
assert.equal(countLines("one\r\ntwo"), 2);
|
|
});
|
|
|
|
test("new files use the configured ceiling", () => {
|
|
assert.equal(allowedLineCount(null, 1000), 1000);
|
|
assert.deepEqual(
|
|
evaluateFileSize({ baseLines: null, candidateLines: 1000, maxLines: 1000 }),
|
|
{
|
|
limit: 1000,
|
|
violates: false,
|
|
},
|
|
);
|
|
assert.equal(
|
|
evaluateFileSize({ baseLines: null, candidateLines: 1001, maxLines: 1000 })
|
|
.violates,
|
|
true,
|
|
);
|
|
});
|
|
|
|
test("a compliant file may not cross the ceiling", () => {
|
|
assert.equal(
|
|
evaluateFileSize({ baseLines: 996, candidateLines: 1000, maxLines: 1000 })
|
|
.violates,
|
|
false,
|
|
);
|
|
assert.equal(
|
|
evaluateFileSize({ baseLines: 996, candidateLines: 1003, maxLines: 1000 })
|
|
.violates,
|
|
true,
|
|
);
|
|
});
|
|
|
|
test("parses modifications, deletions, and renames from Git's NUL format", () => {
|
|
assert.deepEqual(
|
|
parseChangedFiles(
|
|
"M\0desktop/src/a.ts\0D\0desktop/src/b.ts\0R100\0desktop/src/old.ts\0desktop/src/new.ts\0",
|
|
),
|
|
[
|
|
{ status: "M", path: "desktop/src/a.ts" },
|
|
{ status: "D", path: "desktop/src/b.ts" },
|
|
{
|
|
status: "R",
|
|
oldPath: "desktop/src/old.ts",
|
|
path: "desktop/src/new.ts",
|
|
},
|
|
],
|
|
);
|
|
});
|
|
|
|
test("an inherited oversized file may hold or shrink but not grow", () => {
|
|
assert.equal(allowedLineCount(1026, 1000), 1026);
|
|
assert.equal(
|
|
evaluateFileSize({ baseLines: 1026, candidateLines: 1026, maxLines: 1000 })
|
|
.violates,
|
|
false,
|
|
);
|
|
assert.equal(
|
|
evaluateFileSize({ baseLines: 1026, candidateLines: 1001, maxLines: 1000 })
|
|
.violates,
|
|
false,
|
|
);
|
|
assert.equal(
|
|
evaluateFileSize({ baseLines: 1026, candidateLines: 1027, maxLines: 1000 })
|
|
.violates,
|
|
true,
|
|
);
|
|
});
|