Files
buzz/mobile/test/features/agents/agents_sheet_test.dart
klopez4212 a12ad1cdd2 feat(mobile): refine agent profiles and model selection (#8773)
## Summary
- Simplify agent profiles with Message/Bestie actions, relay-authored
published instructions (unavailable without a config channel),
management details, public-key copying, and a separate final Delete
section.
- Sort the Agents directory by name and mark the selected Bestie with a
muted filled star.
- Place Model and Thinking together below Name. Use native iOS Liquid
Glass menus and preserve selection callbacks as controls become enabled.

Related: #8685.

## Validation
Full mobile checks passed. Regression coverage includes relay-author
filtering, unavailable instructions, metadata retry, resizing native
pickers, accurate deletion state, selection after loading, and Bestie
switching. Real iOS simulator taps verified both pickers; the user
confirmed the earlier iPhone build works. Review fixes were checked with
widget journeys and the native UIKit resize/selection probe.

<details>
<summary>Previews</summary>

Synthetic fixture renders:

| Profile | Create agent | Bestie card |
| --- | --- | --- |
| ![Profile with separate Delete
section](https://github.com/user-attachments/assets/4b6e7cf5-b152-43a3-99d9-7c1ee65d0c70)
| ![Model and Thinking
settings](https://github.com/user-attachments/assets/c81dc138-d5d3-43bb-873b-a64171155a7d)
| ![Muted Bestie
star](https://github.com/user-attachments/assets/5ce95e3b-2403-41c5-b6d6-52b8b60cc7d6)
|

Native iOS simulator interaction with a synthetic catalog:

![Both picker values updated after native menu
selections](https://github.com/user-attachments/assets/a3ee6d4d-91e0-4df6-b4cf-b66d5c1a2e87)

</details>

---------

Signed-off-by: kenny lopez <klopez4212@gmail.com>
Co-authored-by: Terp <5856f6900e8e0a4e0ea1f4f8d2ee33e4753d2119bc122f94ecafc660b46c0511@buzz.block.builderlab.xyz>
2026-10-31 11:28:14 -06:00

290 lines
11 KiB
Dart
Raw Blame History

This file contains ambiguous Unicode characters

This file contains Unicode characters that might be confused with other characters. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.

import 'package:flutter/services.dart';
import 'package:buzz/shared/widgets/app_list_card.dart';
import 'package:buzz/shared/agents/remote_agents.dart';
import 'package:buzz/shared/me/me_sync.dart';
import 'package:buzz/shared/me/default_agent.dart';
import 'package:hooks_riverpod/hooks_riverpod.dart';
import 'package:buzz/features/channels/default_agent_launcher.dart';
import 'package:buzz/features/agents/agents_page.dart';
import 'package:buzz/features/agents/agent_card.dart';
import 'package:buzz/features/profile/user_profile_sheet.dart';
import 'package:flutter/material.dart';
import 'package:buzz/features/home/home_page.dart';
import 'package:flutter_test/flutter_test.dart';
import 'agents_harness.dart';
import '../../helpers/remote_agents_fixture.dart';
void main() {
final existing = existingDesktopKeys.public;
testWidgets('agent profile sheet closes back to the full-page directory', (
tester,
) async {
tester.binding.defaultBinaryMessenger.setMockMethodCallHandler(
const MethodChannel('dev.fluttercommunity.plus/connectivity_status'),
(_) async => null,
);
addTearDown(
() => tester.binding.defaultBinaryMessenger.setMockMethodCallHandler(
const MethodChannel('dev.fluttercommunity.plus/connectivity_status'),
null,
),
);
tester.view.physicalSize = const Size(390, 844);
tester.view.devicePixelRatio = 1;
addTearDown(tester.view.resetPhysicalSize);
addTearDown(tester.view.resetDevicePixelRatio);
addTearDown(tester.platformDispatcher.clearTextScaleFactorTestValue);
final h = await AgentsHarness.create();
await h.open(
tester,
directory: [existing, otherAgentKeys.public],
botDirectory: ['b' * 64],
);
expect(find.byKey(ValueKey(otherAgentKeys.public)), findsNothing);
expect(find.byKey(ValueKey('b' * 64)), findsNothing);
if (!supportsRemoteAgents(h.community)) {
expect(find.text('Sign in to create an agent'), findsNothing);
for (final button in tester.widgetList<IconButton>(
find.byWidgetPredicate(
(widget) => widget is IconButton && widget.tooltip == 'Add agent',
),
)) {
expect(button.onPressed, isNull);
}
}
await h.controller.run(() async {
throw StateError('Resume unfinished setup');
});
await tester.pumpAndSettle();
expect(find.textContaining('Resume unfinished setup'), findsNothing);
expect(find.byType(LinearProgressIndicator), findsNothing);
final list = tester.element(find.byType(AgentsPage));
final container = ProviderScope.containerOf(list);
expect(find.text('Set as default'), findsNothing);
expect(find.text('Model not shared'), findsNothing);
expect(find.byIcon(Icons.star), findsNothing);
expect(find.text('Manage on desktop'), findsOneWidget);
expect(find.byIcon(Icons.keyboard_arrow_down), findsNothing);
await tester.tap(find.byKey(ValueKey(existing)));
await tester.pump();
await tester.pumpAndSettle();
expect(find.byType(BottomSheet), findsOneWidget);
expect(find.byType(UserProfileSheet), findsOneWidget);
expect(find.text('Model not shared'), findsNothing);
expect(list.mounted, isTrue);
expect(find.text('Identity'), findsNothing);
expect(find.text('Settings'), findsNothing);
expect(
find.descendant(
of: find.byType(UserProfileSheet),
matching: find.text('Manage on desktop'),
),
findsNothing,
);
expect(
find.descendant(
of: find.byType(UserProfileSheet),
matching: find.text('Unknown'),
),
findsNothing,
);
expect(find.text('Instructions'), findsOneWidget);
expect(find.text('Management'), findsOneWidget);
expect(
find.textContaining('Keep Buzz open and your desktop online'),
findsOneWidget,
);
expect(
find.textContaining('Instructions aren’t available'),
findsOneWidget,
);
await tester.pumpAndSettle();
expect(find.byTooltip('Copy public key'), findsOneWidget);
final semantics = tester.ensureSemantics();
final platformCalls = <MethodCall>[];
tester.binding.defaultBinaryMessenger.setMockMethodCallHandler(
SystemChannels.platform,
(call) async {
platformCalls.add(call);
return null;
},
);
addTearDown(
() => tester.binding.defaultBinaryMessenger.setMockMethodCallHandler(
SystemChannels.platform,
null,
),
);
final keyRow = find.byTooltip('Copy public key');
await tester.ensureVisible(keyRow);
await tester.tapAt(tester.getTopLeft(keyRow) + const Offset(8, 8));
await tester.pumpAndSettle();
expect(
platformCalls.where((call) => call.method == 'Clipboard.setData'),
hasLength(1),
);
expect(
platformCalls.where((call) => call.method == 'HapticFeedback.vibrate'),
hasLength(1),
);
expect(find.bySemanticsLabel('Copied public key'), findsOneWidget);
semantics.dispose();
await tester.pumpAndSettle();
expect(find.byTooltip('Delete agent'), findsNothing);
// Reopen through the real reader, recover a failed network query, then
// verify the registered instruction text appears rather than profile bio.
await tester.tap(find.byTooltip('Close sheet'));
await tester.pumpAndSettle();
h.onQuery = (_) async => throw StateError('Offline');
await tester.tap(find.byKey(ValueKey(existing)));
await tester.pumpAndSettle();
expect(find.text('Could not load instructions.'), findsOneWidget);
h.onQuery = (_) async => [];
h.authorityDown = true;
await tester.ensureVisible(find.text('Retry'));
await tester.tap(find.text('Retry'));
await tester.pumpAndSettle();
expect(find.text('Could not load instructions.'), findsOneWidget);
h.authorityDown = false;
await tester.ensureVisible(find.text('Retry'));
await tester.tap(find.text('Retry'));
await tester.pumpAndSettle();
expect(
find.textContaining('Instructions aren’t available'),
findsOneWidget,
);
tester.platformDispatcher.textScaleFactorTestValue = 2;
await tester.pumpAndSettle();
await tester.pumpAndSettle();
await tester.ensureVisible(find.byTooltip('Copy public key'));
expect(tester.takeException(), isNull);
tester.platformDispatcher.clearTextScaleFactorTestValue();
await tester.pumpAndSettle();
await tester.pumpAndSettle();
h.relay.loseAcknowledgment = true;
await tester.ensureVisible(find.text('Make Bestie'));
await tester.tap(find.text('Make Bestie'));
await tester.pumpAndSettle();
expect(find.textContaining('Could not save Bestie.'), findsOneWidget);
h.relay.loseAcknowledgment = false;
h.relay.events = []; // The unacknowledged write was not retained.
await tester.ensureVisible(find.text('Make Bestie'));
await tester.tap(find.text('Make Bestie'));
await tester.pumpAndSettle();
expect(find.text('Your Bestie'), findsOneWidget);
final savedSync = container.read(meSyncProvider);
expect(decodeDefaultAgent(h.relay.events.single, savedSync), existing);
expect(
savedSync.prefs!.containsKey(
'main-agent:${savedSync.community}:${savedSync.pubkey}',
),
isTrue,
);
await tester.tap(find.byTooltip('Close sheet'));
await tester.pumpAndSettle();
expect(find.byType(UserProfileSheet), findsNothing);
expect(find.byKey(ValueKey(existing)), findsOneWidget);
expect(tester.element(find.byType(AgentsPage)), same(list));
expect(
tester.widget<AgentCard>(find.byKey(ValueKey(existing))).isBestie,
isTrue,
);
expect(
find.descendant(
of: find.byKey(ValueKey(existing)),
matching: find.byIcon(Icons.star),
),
findsOneWidget,
);
if (supportsRemoteAgents(h.community)) {
h.registry.listed = [
{
'agent_pubkey': fakeAgent,
'agent_id': 'remote-id',
'agent_name': 'Scout',
},
];
await h.controller.run(h.controller.refresh);
await tester.pumpAndSettle();
await tester.tap(find.byKey(ValueKey(fakeAgent)));
await tester.pumpAndSettle();
expect(
find.textContaining('This agent runs on Builderbot.'),
findsOneWidget,
);
await tester.pumpAndSettle();
await tester.ensureVisible(find.text('Delete agent'));
expect(
tester.getTopLeft(find.text('Delete agent')).dy,
greaterThan(tester.getTopLeft(find.text('Public key')).dy),
);
final deleteCard = find.ancestor(
of: find.text('Delete agent'),
matching: find.byType(AppListCard),
);
expect(deleteCard, findsOneWidget);
expect(
find.descendant(of: deleteCard, matching: find.text('Public key')),
findsNothing,
);
await tester.tap(find.text('Delete agent'));
await tester.pumpAndSettle();
await tester.tap(find.text('Cancel'));
await tester.pumpAndSettle();
await tester.pumpAndSettle();
h.relay.events = [];
await tester.ensureVisible(find.text('Make Bestie'));
await tester.tap(find.text('Make Bestie'));
await tester.pumpAndSettle();
expect(find.text('Your Bestie'), findsOneWidget);
expect(decodeDefaultAgent(h.relay.events.single, savedSync), fakeAgent);
await tester.tap(find.byTooltip('Close sheet'));
await tester.pumpAndSettle();
expect(
tester.widget<AgentCard>(find.byKey(ValueKey(existing))).isBestie,
isFalse,
);
expect(
tester.widget<AgentCard>(find.byKey(ValueKey(fakeAgent))).isBestie,
isTrue,
);
}
ScaffoldMessenger.of(list).clearSnackBars();
await tester.tap(find.byTooltip('Close agents'));
await tester.pumpAndSettle();
expect(find.byType(BottomSheet), findsNothing);
h.relay.events = [];
final sync = container.read(meSyncProvider);
await sync.prefs!.remove('main-agent:${sync.community}:${sync.pubkey}');
await h.open(
tester,
directory: [existing],
home: HomePage(
onAgents: showAgents,
defaultAgentBuilder: (context) =>
DefaultAgentLauncher(onChooseAgent: () => showAgents(context)),
settingsPageBuilder: (_) => const SizedBox.shrink(),
mePageBuilder: (_, _, _) =>
const SliverToBoxAdapter(child: Text('Solo workspace')),
),
);
await tester.tap(find.byTooltip('Bestie'));
await tester.pumpAndSettle();
await tester.tap(find.byKey(ValueKey(existing)));
await tester.pumpAndSettle();
expect(find.byType(UserProfileSheet), findsOneWidget);
expect(find.text('Model not shared'), findsNothing);
await tester.binding.handlePopRoute();
await tester.pumpAndSettle();
expect(find.byType(UserProfileSheet), findsNothing);
await tester.tap(find.byTooltip('Close agents'));
await tester.pumpAndSettle();
expect(find.byTooltip('Search'), findsOneWidget);
});
}