Files
buzz/desktop
Duncan 3697c8d23f fix(agents): rebuild P1/P2 regressions and wire description field
Item 1 — P1-2 race regression (shared-team lock scope):
Seed a real kind:30178 head T in the retention DB before the test,
write teams.json with the real shared team so refresh_for_persona_at
finds it, and write a modified persona so the rebuild content differs
from T (avoiding the idempotency skip). Move REFRESH_READ_OBSERVER
from sharing.rs into commands/teams/pending.rs and fire it inside
refresh_or_retract_shared_head_at after the shared-T read, before
retain. The observer asserts try_lock().is_err() (lock held), then
signals a Barrier(2) so the race thread unblocks. Race thread acquires
managed_agents_store_lock and retains an unshared T+1; since it runs
last, the final retained head is UNSHARED. Mutation (move refresh
outside lock): observer fires with lock released, try_lock() succeeds,
assertion panics — RED.

Item 2 — P2 real-seam acceptance (update_persona_and_publish):
Extract update_persona_and_publish_inner<R: tauri::Runtime> as the
generic core; the #[tauri::command] wrapper becomes a one-line delegate.
Test calls update_persona_and_publish_inner through a MockRuntime
AppHandle, resolves the active retention scope (so the production
prepare_persona_publication resolver is exercised), then sabotages the
DB path by replacing it with a directory. The production command path
hits prepare_persona_publication, which returns EISDIR; phase-2 relay
sync must still fire before the error propagates. Mutation (retain_result?
before phase 2): counter = 0 → RED.

Item 3 — Description field regression (built-in persona edits persist):
Add description: string to AgentFormModel (D-owned), seed it from
def.description, carry it through buildNextAgentFormModel, emit it in
emitAgentFormDiff's dChanged check and personaInput. Wire description
state through AgentEditMergedDialog and AgentEditMergedDSection.
Replace the D-section's hand-rolled displayName block with
AgentIdentityFields (from AgentDescriptionField.tsx) which renders
both Agent name and Description with the #7126 clamp/counter semantics.
The agents.spec.ts 'built-in persona edits persist' test can now find
getByLabel('Description') in the merged dialog.

Co-authored-by: Will Pfleger <pfleger.will@gmail.com>
Signed-off-by: Will Pfleger <pfleger.will@gmail.com>
2026-09-01 17:21:34 -04:00
..
…

Buzz

Desktop chat shell with:

  • Tauri + React + TypeScript + Vite
  • Tailwind CSS
  • shadcn/ui-ready shared components
  • Biome (lint/format/check)
  • Feature-driven frontend structure

Scripts

  • pnpm dev - run the web frontend
  • pnpm tauri dev - run the desktop app
  • pnpm build - typecheck and build frontend
  • pnpm typecheck - TypeScript checks
  • pnpm lint - Biome lint
  • pnpm format - Biome format (write)
  • pnpm check - Biome check

Structure

  • src/shared - reusable app-wide code (ui, lib, styles)
  • src/features - feature modules (vertical slices)
  • src/app - top-level app composition