mirror of
https://github.com/block/buzz.git
synced 2026-10-28 04:51:40 +00:00
Prepared by Brain on Wes’s behalf. ## Summary Reduce startup request amplification and let quota-refused background work recover without changing relay quotas or bypassing the existing Send gate. - Coalesce nest regeneration into one worker plus the latest pending generation. Keep the stale-write fence; bound the archive read so an old workspace cannot strand newer work. - Claim pending channel subscriptions before awaiting setup; cancel removed/unmounted entries and preserve still-owned subscriptions across reconnect handoff. - Recheck extended cooldown deadlines before retry dispatch; distinguish an explicit zero-second hint from a missing hint. - Recover native finite/unread queries within their original caller deadline and a three-retry budget, preserving verified unique events, complete filters and terminal errors. - Pace renderer initial/live-CLOSED REQs at one per 250ms: visible channel and explicitly interactive TTS/read-state/observer owners first, then live-only auxiliaries, then background history. Publication and finite queries bypass this queue. Reconnect replay now promotes explicit interactive owners alongside the visible channel with stable registration-order ties; its existing capped batches and cooldown remain intact. **Scope at `867495426`:** 39 source/test files, including 15 production files (+665/-235) and 24 test/fixture files. The diagnostic recorder, HTTP instrumentation, trace launcher and raw captures are deliberately excluded. No profile reset, grouping, quota increase or new global scheduler. ## Before / after evidence These are observations from instrumented, human-operated development Tauri/Vite runs against a production relay, plus explicitly identified controlled regressions—not a packaged-release startup benchmark. | Measurement | Before | After | Evidence boundary | | --- | --- | --- | --- | | Archive snapshot requests (kind 13535) | 290 | 3 | Recorder-only baseline → nest-only intermediate candidate; unequal 67.436s / 39.273s captures and hydration differences | | Archive responses: HTTP 200 / 429 | 277 / 13 | 3 / 0 | Same baseline/nest-only captures; not a claim that all quota pressure disappeared | | Successful archive responses’ advertised content-length sum | 21,208,505 bytes | 229,695 bytes | Header values, not actual transferred bytes | | 154-channel StrictMode replay | 308 REQs | 154 REQs | Controlled real React hook → real session → mocked Tauri transport regression | | Add one channel while 154 setups are pending | 309 REQs | 155 REQs | Same production-boundary regression; ordinary mount remains 154 → 154 | | Broad renderer request burst / spacing | 110 broad REQs within 10.766ms in pre-drain capture | 250.061ms minimum / 252.131ms median between broad REQ writes in final longer capture | Different attended runs; pacing rather than a universal request-rate cap | | Native unread query outcomes | Baseline: 8 EOSE / 146 quota CLOSED out of 154 queries | Final longer run: all 156 observed queries reach EOSE; eight refused queries each recover after two refusals | Different runs/workloads; query completion, not badge rendering | ### Timing metrics | Observation | Measured value | | --- | ---: | | Baseline’s two accepted chat EVENT socket writes → positive OK | 173.340ms / 85.556ms | | Nest-only intermediate candidate’s two accepted writes → positive OK | 277.854ms / 78.775ms | | Final candidate, short run, accepted chat writes → positive OK | 80.636ms / 77.506ms | | Final candidate, longer run, accepted chat writes → positive OK | 120.712ms / 86.895ms | | Last initial EOSE among 163 observed broad channel registrations, longer run | 64.550s after trace start | | Last EOSE among 156 observed native unread queries, longer run | 73.972s after trace start | | Native retry waits after 3s then 0s hints, longer run | 3000.7–3002.8ms, then 2001.5–2002.6ms | | Renderer finite-query retry after a 2s hint, longer run | 2061.365ms | Both Sends in each final run were accepted, with no recorded negative OK. Every quota-refused query in the longer run subsequently completed the same query. Its two Sends happened early (17.878s and 21.655s), not near the end. These small samples do not support a percentage latency improvement. **Tradeoffs and limits** - 296 background subscriptions imply about 74s of paced registration before extra cooldowns/high-priority work. The longer capture observed 163 registrations; it did not independently enumerate the expected membership set or record a queue-empty marker. - This is not a global 4-REQ/s cap: finite queries, native requests and reconnect replay are outside the drain and still share relay quota. Quota refusals recover rather than disappear. - Socket-write → OK starts after composer submission and any publisher gate wait. No click-to-visible, launch-to-usable or badge-paint latency is claimed. - Native EOSE is not proof of command return, classification, React state application or visible unread badges. Existing per-channel kinds, since floors, limits, h-less routing, unread lease/scope guard and eight-query concurrency remain intact. - The attended measurements belong to the instrumented candidate, not a fresh release run of this fixes-only commit. At the initial packaging checkpoint (`1bf3d060`), eighteen of twenty files were byte-identical; the other two removed diagnostic gate calls and isolated the nest test’s temporary paths. The subsequent interactive priority/reconnect and readiness fixes have controlled hook/session/browser evidence, not another attended voice/performance run. ### Evidence provenance (captures retained locally, not uploaded) | Capture | SHA-256 | | --- | --- | | Baseline `STARTUP_20260921T194814Z_98811.jsonl` | `f4f0a89ad9aea91084bd6a7432510488166de4cbc906600d88c26d557f380994` | | Nest-only `STARTUP_20260921T202610Z_28642.jsonl` | `ce517b02a3f717c36d96b36bb8616e8fa80b03b12b356bacfd40475925ea3f3e` | | Final short `STARTUP_20260922T013628Z_13506.jsonl` | `bfea6f3cf80cd7b7e4e676632a3df2f16271fade5bfa0edec72b7bcbbe7839ff` | | Final longer `STARTUP_20260922T014637Z_15846.jsonl` | `f4abece613d108c4c2fe3cb808e633a0486bdc9993ca92323822dc00c3fae6ec` | Final instrumented build fingerprint: `b0b4fc27d793c3e643f4e10289b5afdb4620ee2e13a8b33fa0595dd3417fd5ca`. All observed dropped-record counters in these final captures were zero. Source manifests and offline correlation analyses are retained locally; no raw captures, profile data or agent sessions are part of this PR. ## Validation Current head: `86749542657a60abdfe82eed5cc576d3e162fe5d`, based on `77729abfb692b25a0f4ec4a69add86af2e32c0dd`. Review follow-ups: - `8842dbd8`: explicit interactive TTS admission using the existing main-window owner, independent of companion/timeline selection. Real-hook/session/IPC coverage with 296 cold owners proves initial and CLOSED priority, unchanged filters/cooldown/pacing, background progress and deduplicated speech. - `8cb088106`: reconnect preserves interactive priority even with no visible channel. Stable ordering among foreground ties; real hook/session reconnect regressions cover cooldown, capped batching, all 297 owners, deduplication and unmount cancellation. Independent reviewer mutation restored the prior replay implementation, failed both reconnect rows, then passed the restored candidate. - `68e76d7c`: read-state and observer reuse interactive priority. Stop and ModelPicker wait on the existing observer owner inside send callbacks, after installing result listeners/deadlines. No new owner, timer or scheduler; inherited CLOSED/fallback/error semantics remain, rather than a new strict EOSE guarantee. The real Stop panel browser probe holds observer IPC across the click and checks observer-before-control order and correlated outcome. ModelPicker component ordering is source-reviewed only. - Mock live admission now replays matching stored history with per-filter time/limit constraints, deduplication, untagged auxiliary channel fallback and authoritative explicit h-tags. Kind-specific fixture admission waits and retry-resolving hover actions fix startup-dependent test setup without weakening event/badge assertions. - `48e9c0dad` and `867495426`: steady-state scroll-prepend setup observes live admission, subsequent head dispatch, successful/idle query completion and initial bottom geometry. Phase-2 genuine-growth and ≤32px anchor assertions are unchanged. This isolates steady-state prepending: it **does not fix or certify production early-scroll/head-reset behavior**. Current validation: - Normal push hooks at `867495426`: **6,582/6,582 renderer tests**, zero failed/skipped/cancelled; lint/static checks, typecheck and differential file-size gate passed. Native source is unchanged from the earlier checkpoint; no new native run is claimed for these renderer/test follow-ups. - E2E build passed at `48e9c0dad` plus the exact subsequently committed test-only delta (spec blob `469be2eed868c677ba80b859cc871208000fee60`). The completed affected-smoke run passed **153/153** across agent-control, badge, entity links, messaging, profile status and scroll history; the full scroll file additionally passed twice (**36/36**). No full CI-smoke pass is claimed from this six-file local run. - Pinky independently reviewed production and test follow-ups, including the final scroll spec blob `469be2eed868c677ba80b859cc871208000fee60`, with no blocking finding. Review is source evidence, not an independent test run. - **Not merge-ready:** new-head required CI must complete, exact-range security review requires authorization, and GitHub currently reports REVIEW_REQUIRED; fresh exact-head reviewer approval is still needed. No approval, dismissal or merge performed. No new packaged/native audio, launch-to-usable or badge-paint observation is claimed. Initial fixes-only checkpoint validation (`1bf3d06024d284a63326fdd353baced0842aeb81`): - Pre-commit formatting hooks passed; worktree clean. - Renderer package hooks: 6,570 tests passed, zero failed/skipped/cancelled; lint/static checks, TypeScript and differential file-size gate passed. - Native package hook passed: default and mesh-enabled all-target Clippy, then the complete native workspace test suite. App library: 3,222 passed / 0 failed / 19 ignored; terminal/integration suites passed. The real nest trigger/stalled-body test passed on macOS. - Independent whole-change source review: no blocking findings at this commit; all 20 file hashes matched the committed blobs and review/validation manifests. - Regression coverage includes real hook/session cancellation, StrictMode/membership re-entry, reconnect ownership, extended/zero cooldowns, burst pacing, auxiliary readiness (including EOSE before IPC settles), native socket refusal/retry/deadline/cancellation, unread fetch/classification and real nest trigger/HTTP/file persistence. - Earlier isolated renderer mutations that started readiness before enqueue or removed auxiliary priority each failed the real presence regression; restored controls passed. No native mutation claim. - Nest fixture uses explicit app-data/nest paths instead of assuming Windows known-folder APIs obey HOME/APPDATA. Windows runtime execution is not claimed; CI/build results remain separate. Originating conversation: buzz://message?channel=46ced308-71df-495d-a144-4ebf08334703&id=bc43c3422a3b0b2141268d0fa149b898421c824992b662aed8b73c4eee50404f No approval or merge recommendation is implied by opening this PR. --------- Signed-off-by: Brain <1a02c72794dcd0f07058a353bc3a81f4028b8c77c92c87fce6d5c8b85970a20b@buzz.block.builderlab.xyz> Co-authored-by: Brain <1a02c72794dcd0f07058a353bc3a81f4028b8c77c92c87fce6d5c8b85970a20b@buzz.block.builderlab.xyz>
540 lines
16 KiB
JavaScript
540 lines
16 KiB
JavaScript
// Exercise the production session from live registration/refusal through actual IPC dispatch.
|
|
// The IPC transport and clock are fake; no native app or external relay is used.
|
|
import assert from "node:assert/strict";
|
|
import { after, beforeEach, afterEach, test } from "node:test";
|
|
|
|
const originalNow = Date.now;
|
|
const originalWindow = globalThis.window;
|
|
let now = 0;
|
|
let nextTimerId = 1;
|
|
const timers = new Map();
|
|
const writes = [];
|
|
const clients = [];
|
|
let onSend;
|
|
globalThis.window = {
|
|
setTimeout(fn, ms) {
|
|
const id = nextTimerId++;
|
|
timers.set(id, { fn, at: now + ms });
|
|
return id;
|
|
},
|
|
clearTimeout(id) {
|
|
timers.delete(id);
|
|
},
|
|
__TAURI_INTERNALS__: {
|
|
async invoke(command, args) {
|
|
if (command === "plugin:websocket|send") {
|
|
writes.push({
|
|
socket: args.id,
|
|
frame: JSON.parse(args.message.data),
|
|
at: now,
|
|
});
|
|
await onSend?.(writes.at(-1));
|
|
return;
|
|
}
|
|
if (command === "plugin:websocket|disconnect") return;
|
|
assert.fail(`unexpected IPC: ${command}`);
|
|
},
|
|
},
|
|
};
|
|
Date.now = () => now;
|
|
const { RelayClient } = await import("./relayClientSession.ts");
|
|
const { resetRateLimitGate } = await import("./relayRateLimitGate.ts");
|
|
|
|
const { openPresenceSubscription } = await import(
|
|
"./presenceRelaySubscription.ts"
|
|
);
|
|
|
|
beforeEach(() => {
|
|
resetRateLimitGate();
|
|
now = 0;
|
|
timers.clear();
|
|
writes.length = 0;
|
|
onSend = undefined;
|
|
});
|
|
afterEach(() => {
|
|
for (const client of clients.splice(0)) client.disconnect();
|
|
resetRateLimitGate();
|
|
assert.equal(
|
|
timers.size,
|
|
0,
|
|
"subscriptions and gate must release their timers",
|
|
);
|
|
});
|
|
after(() => {
|
|
Date.now = originalNow;
|
|
globalThis.window = originalWindow;
|
|
});
|
|
|
|
async function flush() {
|
|
for (let i = 0; i < 20; i++) await Promise.resolve();
|
|
}
|
|
async function tickTo(target) {
|
|
assert.ok(target >= now);
|
|
let fired = 0;
|
|
for (;;) {
|
|
const next = [...timers]
|
|
.filter(([, timer]) => timer.at <= target)
|
|
.sort((a, b) => a[1].at - b[1].at || a[0] - b[0])[0];
|
|
if (!next) break;
|
|
assert.ok(++fired < 1000, "timer loop must make progress");
|
|
now = next[1].at;
|
|
timers.delete(next[0]);
|
|
next[1].fn();
|
|
await flush();
|
|
}
|
|
now = target;
|
|
await flush();
|
|
}
|
|
function deliver(client, frame) {
|
|
return client.handleWsMessage(
|
|
{ type: "Text", data: JSON.stringify(frame) },
|
|
client.connectionGeneration,
|
|
);
|
|
}
|
|
function frames(op) {
|
|
return writes.filter((write) => write.frame[0] === op);
|
|
}
|
|
|
|
function session() {
|
|
const client = new RelayClient();
|
|
client.wsId = 7;
|
|
clients.push(client);
|
|
return client;
|
|
}
|
|
function start(client, count) {
|
|
return Array.from({ length: count }, (_, i) => {
|
|
const filter = {
|
|
kinds: [9, 5, 7],
|
|
"#h": [`channel-${i}`],
|
|
since: 123,
|
|
limit: 1000,
|
|
};
|
|
const controller = new AbortController();
|
|
const ready = [];
|
|
const promise = client.subscribeLive(
|
|
filter,
|
|
() => {},
|
|
(r) => ready.push(r),
|
|
250,
|
|
controller.signal,
|
|
);
|
|
void promise.catch(() => {});
|
|
return { filter, controller, ready, promise };
|
|
});
|
|
}
|
|
|
|
test("cold setup drains at most one live REQ per 250ms, prioritizes visible channel and preserves every filter", async () => {
|
|
const client = session();
|
|
const entries = start(client, 296);
|
|
await flush();
|
|
assert.equal(frames("REQ").length, 1, "startup must not dump 296 REQs");
|
|
assert.deepEqual(
|
|
entries[295].ready,
|
|
[],
|
|
"queued setup is not yet a readiness timeout",
|
|
);
|
|
client.setVisibleChannelId("channel-295");
|
|
await tickTo(250);
|
|
assert.deepEqual(frames("REQ")[1].frame[2], entries[295].filter);
|
|
await tickTo(73750);
|
|
assert.equal(frames("REQ").length, 296);
|
|
const requests = frames("REQ");
|
|
for (let i = 1; i < requests.length; i++)
|
|
assert.ok(requests[i].at - requests[i - 1].at >= 250);
|
|
assert.deepEqual(
|
|
new Set(requests.map((r) => JSON.stringify(r.frame[2]))),
|
|
new Set(entries.map((e) => JSON.stringify(e.filter))),
|
|
);
|
|
for (const { frame } of requests) await deliver(client, ["EOSE", frame[1]]);
|
|
await Promise.all(entries.map((e) => e.promise));
|
|
});
|
|
|
|
test("observer control-result subscription takes the next paced slot ahead of cold channels", async () => {
|
|
const { relayClient: client } = await import("./relayClient.ts");
|
|
const { subscribeToAgentObserverFrames } = await import("./observerRelay.ts");
|
|
client.wsId = 7;
|
|
clients.push(client);
|
|
start(client, 296);
|
|
await flush();
|
|
const received = [];
|
|
const pending = subscribeToAgentObserverFrames("owner", (event) =>
|
|
received.push(event),
|
|
);
|
|
void pending.catch(() => {});
|
|
await tickTo(249);
|
|
assert.equal(frames("REQ").length, 1, "observer priority must retain pacing");
|
|
await tickTo(250);
|
|
const request = frames("REQ")[1].frame;
|
|
assert.deepEqual(request[2], {
|
|
kinds: [24200],
|
|
"#p": ["owner"],
|
|
limit: 1000,
|
|
since: -300,
|
|
});
|
|
const result = { id: "result", kind: 24200, tags: [["p", "owner"]] };
|
|
await deliver(client, ["EVENT", request[1], result]);
|
|
await deliver(client, ["EOSE", request[1]]);
|
|
const dispose = await pending;
|
|
assert.deepEqual(
|
|
received,
|
|
[result],
|
|
"ephemeral control results reach the admitted consumer",
|
|
);
|
|
await dispose();
|
|
await tickTo(266); // Flush the session's existing event batch timer.
|
|
});
|
|
|
|
test("read-state initialization takes the next paced slot ahead of cold channels", async () => {
|
|
const { ReadStateManager } = await import(
|
|
"../../features/channels/readState/readStateManager.ts"
|
|
);
|
|
const { KIND_READ_STATE } = await import("../constants/kinds.ts");
|
|
const previousDocument = globalThis.document;
|
|
const previousStorage = globalThis.localStorage;
|
|
const store = new Map();
|
|
const events = new EventTarget();
|
|
Object.assign(window, {
|
|
localStorage: {
|
|
getItem: (key) => store.get(key) ?? null,
|
|
setItem: (key, value) => store.set(key, value),
|
|
removeItem: (key) => store.delete(key),
|
|
},
|
|
addEventListener: events.addEventListener.bind(events),
|
|
removeEventListener: events.removeEventListener.bind(events),
|
|
});
|
|
globalThis.localStorage = window.localStorage;
|
|
globalThis.document = new EventTarget();
|
|
const client = session();
|
|
const background = start(client, 296);
|
|
await flush();
|
|
onSend = async ({ frame }) => {
|
|
if (frame[0] === "REQ") await deliver(client, ["EOSE", frame[1]]);
|
|
};
|
|
const pubkey = "a".repeat(64);
|
|
const manager = new ReadStateManager(pubkey, client);
|
|
let ready = false;
|
|
const initialized = manager.initialize().then(() => {
|
|
ready = true;
|
|
});
|
|
try {
|
|
await tickTo(249);
|
|
assert.equal(
|
|
ready,
|
|
false,
|
|
"initialization must retain its live readiness gate",
|
|
);
|
|
assert.equal(
|
|
frames("REQ").filter(({ frame }) => frame[1].startsWith("live-")).length,
|
|
1,
|
|
);
|
|
await tickTo(250);
|
|
assert.equal(
|
|
ready,
|
|
true,
|
|
"unread UI must not wait behind 295 cold channels",
|
|
);
|
|
await initialized;
|
|
const live = frames("REQ").filter(({ frame }) =>
|
|
frame[1].startsWith("live-"),
|
|
);
|
|
assert.equal(live.length, 2);
|
|
assert.equal(
|
|
live[1].at,
|
|
250,
|
|
"read-state must retain ordinary request pacing",
|
|
);
|
|
assert.deepEqual(live[1].frame[2], {
|
|
kinds: [KIND_READ_STATE],
|
|
authors: [pubkey],
|
|
"#t": ["read-state"],
|
|
limit: 500,
|
|
});
|
|
} finally {
|
|
manager.destroy();
|
|
for (const entry of background) entry.controller.abort();
|
|
client.disconnect();
|
|
await initialized;
|
|
globalThis.document = previousDocument;
|
|
globalThis.localStorage = previousStorage;
|
|
delete window.localStorage;
|
|
delete window.addEventListener;
|
|
delete window.removeEventListener;
|
|
}
|
|
});
|
|
|
|
test("125 refused live subscriptions cannot stampede beside a publish when cooldown releases", async () => {
|
|
const client = session();
|
|
const entries = start(client, 125);
|
|
await flush();
|
|
await tickTo(31250);
|
|
const initial = frames("REQ");
|
|
assert.equal(initial.length, 125);
|
|
for (const { frame } of initial) await deliver(client, ["EOSE", frame[1]]);
|
|
await Promise.all(entries.map((e) => e.promise));
|
|
for (const { frame } of initial)
|
|
await deliver(client, [
|
|
"CLOSED",
|
|
frame[1],
|
|
"rate-limited: quota exceeded; retry in 4s",
|
|
]);
|
|
const event = { id: "a".repeat(64), kind: 9 };
|
|
const published = client.publishEvent(event, "timeout", "send failed");
|
|
void published.catch(() => {});
|
|
await tickTo(35250);
|
|
assert.ok(
|
|
frames("REQ").length <= 126,
|
|
"only one retry may join Send at gate release",
|
|
);
|
|
assert.equal(
|
|
frames("EVENT").length,
|
|
1,
|
|
"Send must not await the live backlog",
|
|
);
|
|
await deliver(client, ["OK", event.id, true, ""]);
|
|
assert.equal(await published, event);
|
|
await tickTo(66250);
|
|
assert.equal(frames("REQ").length, 250);
|
|
const retries = frames("REQ").slice(125);
|
|
assert.deepEqual(
|
|
retries.map((r) => r.frame.slice(1)),
|
|
initial.map((r) => r.frame.slice(1)),
|
|
);
|
|
for (let i = 1; i < retries.length; i++)
|
|
assert.ok(retries[i].at - retries[i - 1].at >= 250);
|
|
});
|
|
|
|
test("presence waits beyond its 5s budget behind the gate, then EOSE before IPC settles succeeds", async () => {
|
|
const client = session();
|
|
const background = start(client, 32);
|
|
await flush();
|
|
await deliver(client, [
|
|
"NOTICE",
|
|
"rate-limited: quota exceeded; retry in 6s",
|
|
]);
|
|
let outcome = "pending";
|
|
const presence = openPresenceSubscription(
|
|
["a".repeat(64)],
|
|
() => {},
|
|
client.subscribeLive.bind(client),
|
|
);
|
|
presence.then(
|
|
() => {
|
|
outcome = "ready";
|
|
},
|
|
() => {
|
|
outcome = "failed";
|
|
},
|
|
);
|
|
await flush();
|
|
await tickTo(5999);
|
|
assert.equal(outcome, "pending");
|
|
const presenceEntry = [...client.subscriptions].find(
|
|
([, sub]) => sub.filter.limit === 0,
|
|
);
|
|
assert.ok(presenceEntry, "presence remains owned while queued");
|
|
assert.equal(frames("REQ").length, 1);
|
|
const sent = Promise.withResolvers();
|
|
onSend = async ({ frame }) => {
|
|
if (frame[0] !== "REQ" || frame[1] !== presenceEntry[0]) return;
|
|
await deliver(client, ["EOSE", frame[1]]);
|
|
await sent.promise;
|
|
};
|
|
try {
|
|
await tickTo(6000);
|
|
assert.equal(
|
|
frames("REQ")[1].frame[1],
|
|
presenceEntry[0],
|
|
"limit:0 outranks the background backlog",
|
|
);
|
|
await tickTo(12000);
|
|
assert.equal(outcome, "pending", "setup still awaits transport completion");
|
|
sent.resolve();
|
|
await flush();
|
|
const dispose = await presence;
|
|
assert.equal(
|
|
outcome,
|
|
"ready",
|
|
"queued time must not consume presence readiness",
|
|
);
|
|
assert.ok(client.subscriptions.has(presenceEntry[0]));
|
|
await dispose();
|
|
} finally {
|
|
sent.resolve();
|
|
for (const entry of background) entry.controller.abort();
|
|
}
|
|
});
|
|
|
|
test("a later gate extension pauses an active drain without changing filters or counting another retry", async () => {
|
|
const client = session();
|
|
const entries = start(client, 4);
|
|
await flush();
|
|
await tickTo(750);
|
|
const initial = frames("REQ");
|
|
for (const { frame } of initial) await deliver(client, ["EOSE", frame[1]]);
|
|
await Promise.all(entries.map((e) => e.promise));
|
|
for (const { frame } of initial)
|
|
await deliver(client, ["CLOSED", frame[1], "error: temporary failure"]);
|
|
await tickTo(1750);
|
|
assert.equal(frames("REQ").length, 5);
|
|
await tickTo(1800);
|
|
await deliver(client, [
|
|
"NOTICE",
|
|
"rate-limited: quota exceeded; retry in 4s",
|
|
]);
|
|
await tickTo(3000);
|
|
await deliver(client, [
|
|
"NOTICE",
|
|
"rate-limited: quota exceeded; retry in 4s",
|
|
]);
|
|
await tickTo(6999);
|
|
assert.equal(frames("REQ").length, 5);
|
|
for (const { frame } of initial)
|
|
assert.equal(client.subscriptions.get(frame[1]).closedRetryAttempt, 1);
|
|
await tickTo(7500);
|
|
assert.deepEqual(
|
|
frames("REQ")
|
|
.slice(4)
|
|
.map((r) => r.at),
|
|
[1750, 7000, 7250, 7500],
|
|
);
|
|
assert.deepEqual(
|
|
frames("REQ")
|
|
.slice(4)
|
|
.map((r) => r.frame),
|
|
initial.map((r) => r.frame),
|
|
);
|
|
});
|
|
|
|
for (const stop of ["abort", "terminal CLOSED", "workspace switch"]) {
|
|
test(`${stop} retires queued cold setup without a later REQ`, async () => {
|
|
const client = session();
|
|
const entries = start(client, 2);
|
|
await flush();
|
|
const [id] = [...client.subscriptions].find(
|
|
([, sub]) => sub.filter["#h"][0] === "channel-1",
|
|
);
|
|
if (stop === "abort") entries[1].controller.abort();
|
|
if (stop === "terminal CLOSED")
|
|
await deliver(client, ["CLOSED", id, "restricted: denied"]);
|
|
if (stop === "workspace switch") {
|
|
client.disconnect();
|
|
client.wsId = 8;
|
|
}
|
|
const result = await Promise.allSettled([entries[1].promise]);
|
|
assert.equal(
|
|
result[0].status,
|
|
stop === "terminal CLOSED" ? "fulfilled" : "rejected",
|
|
);
|
|
assert.ok(!client.subscriptions.has(id));
|
|
await tickTo(60000);
|
|
assert.equal(frames("REQ").length, 1);
|
|
assert.ok(!writes.some((w) => w.socket === 8));
|
|
});
|
|
}
|
|
|
|
for (const stop of [
|
|
"dispose",
|
|
"EOSE",
|
|
"EVENT",
|
|
"terminal CLOSED",
|
|
"workspace switch",
|
|
]) {
|
|
test(`${stop} cancels a retry already queued in the drain`, async () => {
|
|
const client = session();
|
|
const entries = start(client, 2);
|
|
await flush();
|
|
await tickTo(250);
|
|
const initial = frames("REQ");
|
|
for (const { frame } of initial) await deliver(client, ["EOSE", frame[1]]);
|
|
const disposers = await Promise.all(entries.map((e) => e.promise));
|
|
for (const { frame } of initial)
|
|
await deliver(client, ["CLOSED", frame[1], "error: temporary failure"]);
|
|
await tickTo(1250);
|
|
assert.equal(frames("REQ").length, 3);
|
|
const id = initial[1].frame[1];
|
|
if (stop === "dispose") await disposers[1]();
|
|
if (stop === "EOSE") await deliver(client, ["EOSE", id]);
|
|
if (stop === "EVENT")
|
|
await deliver(client, [
|
|
"EVENT",
|
|
id,
|
|
{ id: "recovered", kind: 9, created_at: 123 },
|
|
]);
|
|
if (stop === "terminal CLOSED")
|
|
await deliver(client, ["CLOSED", id, "restricted: denied"]);
|
|
if (stop === "workspace switch") {
|
|
client.disconnect();
|
|
client.wsId = 8;
|
|
}
|
|
await tickTo(60000);
|
|
assert.equal(frames("REQ").length, 3);
|
|
assert.ok(!writes.some((w) => w.socket === 8));
|
|
});
|
|
}
|
|
|
|
for (const stage of ["setup", "CLOSED retry"]) {
|
|
test(`reconnect takes over queued ${stage} without a second drain dispatch`, async () => {
|
|
const client = session();
|
|
const entries = start(client, 3);
|
|
await flush();
|
|
if (stage === "CLOSED retry") {
|
|
await tickTo(500);
|
|
for (const { frame } of frames("REQ"))
|
|
await deliver(client, ["EOSE", frame[1]]);
|
|
await Promise.all(entries.map((e) => e.promise));
|
|
for (const { frame } of frames("REQ"))
|
|
await deliver(client, ["CLOSED", frame[1], "error: temporary failure"]);
|
|
await tickTo(1500);
|
|
assert.equal(frames("REQ").length, 4);
|
|
}
|
|
const originalIds = [...client.subscriptions.keys()];
|
|
client.resetConnection(new Error("socket lost"));
|
|
// Only connection establishment is fake; ownership/reset and replay are production.
|
|
window.clearTimeout(client.reconnectTimeout);
|
|
client.reconnectTimeout = null;
|
|
entries[2].controller.abort();
|
|
client.wsId = 8;
|
|
await client.replayLiveSubscriptions();
|
|
client.reconnectWaiters.settle();
|
|
await flush();
|
|
await tickTo(now + 60000);
|
|
const replay = frames("REQ").filter((w) => w.socket === 8);
|
|
assert.deepEqual(
|
|
replay.map((w) => w.frame[1]),
|
|
originalIds.slice(0, 2),
|
|
);
|
|
assert.deepEqual(
|
|
replay.map((w) => w.frame[2]),
|
|
entries.slice(0, 2).map((e) => e.filter),
|
|
);
|
|
await Promise.allSettled(entries.map((e) => e.promise));
|
|
});
|
|
}
|
|
|
|
test("finite history and its CLOSED retry bypass a live backlog without consuming queued response budget", async () => {
|
|
const client = session();
|
|
start(client, 296);
|
|
await flush();
|
|
const filter = { kinds: [7], "#e": ["message"], limit: 1000 };
|
|
const history = client.fetchEvents(filter);
|
|
void history.catch(() => {});
|
|
await flush();
|
|
const initial = frames("REQ").find((w) => w.frame[1].startsWith("history-"));
|
|
assert.ok(initial);
|
|
assert.equal(initial.at, 0);
|
|
await deliver(client, [
|
|
"CLOSED",
|
|
initial.frame[1],
|
|
"rate-limited: quota exceeded; retry in 4s",
|
|
]);
|
|
await tickTo(4000);
|
|
const retry = frames("REQ").filter((w) =>
|
|
w.frame[1].startsWith("history-"),
|
|
)[1];
|
|
assert.ok(retry, "history retry is not queued behind 295 live entries");
|
|
assert.equal(retry.at, 4000);
|
|
assert.deepEqual(retry.frame[2], filter);
|
|
await deliver(client, ["EOSE", retry.frame[1]]);
|
|
assert.deepEqual(await history, []);
|
|
});
|