mirror of
https://github.com/block/buzz.git
synced 2026-10-27 12:40:30 +00:00
## Summary Introduces a protected-build boundary for the default-off Bestie experiment without adding any Bestie product surface. - Official OSS builds select an empty protected-feature module and emit no Bestie/Chief metadata or implementation content. - Protected internal builds select a separate module graph containing the Bestie experiment definition. - Within an internal build, Bestie remains disabled until the user opts in under Settings → Experiments. - The production build runs an artifact matrix and fails if OSS output contains protected content or internal output lacks the Bestie manifest. ## Build contract | Build variant | User opt-in | Result | | --- | --- | --- | | Official OSS | Any/forged | Bestie absent from the compiled artifact | | Protected internal | Off | Bestie available but disabled | | Protected internal | On | Bestie enabled | The companion protected-release change is squareup/buzz-releases#91. It sets `VITE_BUZZ_BESTIE=1`, requires that exact value, forwards it into the signed macOS build, and asserts the contract in release validation. ## Why this is separate This gives later Bestie PRs one build-selected import seam. Protected implementations must be reachable only from the internal module so they never enter the official OSS module graph. ## Non-goals - No Bestie persona or provisioning - No sidebar, app-chrome, or message-toolbar UI - No entitlement or secrecy claim: the source is public; this boundary controls official Block artifacts ## Verification - Exact commit `523cf49ced03cba9be43836a54d6aa5d6923cc82` - Full `just ci`: 5,673 Desktop tests, 2,773 Tauri tests, 1,860 mobile tests, Rust/Tauri/web/mobile static checks and builds - OSS production artifact: scanner confirms no `Bestie`, `Chief of Staff`, or `builtin:bestie` content - Internal production artifact: scanner confirms the protected Bestie manifest is emitted - Both build orders verified; `dist` retains the requested variant for Vite/Tauri packaging --------- Signed-off-by: Arjun Mahanti <arjun@squareup.com> Signed-off-by: Fizz <fizz@buzz.local> Signed-off-by: Fizz <dae5f6af70b8695a8b83c8deae555f63be41630ec2b8cd493e41a439c9527dd8@buzz.block.builderlab.xyz> Co-authored-by: Codex <noreply@openai.com> Co-authored-by: Fizz <fizz@buzz.local> Co-authored-by: Fizz <dae5f6af70b8695a8b83c8deae555f63be41630ec2b8cd493e41a439c9527dd8@buzz.block.builderlab.xyz>
64 lines
2.1 KiB
JavaScript
64 lines
2.1 KiB
JavaScript
import { spawnSync } from "node:child_process";
|
|
import { readFileSync } from "node:fs";
|
|
import { mkdtempSync, rmSync } from "node:fs";
|
|
import { tmpdir } from "node:os";
|
|
import path from "node:path";
|
|
import { fileURLToPath } from "node:url";
|
|
|
|
const desktopRoot = path.resolve(
|
|
path.dirname(fileURLToPath(import.meta.url)),
|
|
"..",
|
|
);
|
|
const tauriPackageJsonPath = fileURLToPath(
|
|
import.meta.resolve("@tauri-apps/cli/package.json"),
|
|
);
|
|
const tauriPackage = JSON.parse(readFileSync(tauriPackageJsonPath, "utf8"));
|
|
const defaultTauriEntrypoint = path.resolve(
|
|
path.dirname(tauriPackageJsonPath),
|
|
tauriPackage.bin.tauri,
|
|
);
|
|
|
|
function runTauri(args, options = {}) {
|
|
const entrypoint =
|
|
process.env.BUZZ_TAURI_CLI_ENTRYPOINT ?? defaultTauriEntrypoint;
|
|
const result = spawnSync(process.execPath, [entrypoint, ...args], {
|
|
cwd: desktopRoot,
|
|
env: { ...process.env, ...options.env },
|
|
stdio: "inherit",
|
|
});
|
|
if (result.error) throw result.error;
|
|
return result.status ?? 1;
|
|
}
|
|
|
|
export function runTauriCommand(args) {
|
|
if (args[0] !== "build") return runTauri(args);
|
|
|
|
// Tauri runs beforeBuildCommand and then consumes frontendDist. Give the
|
|
// entire invocation a private directory so concurrent OSS/internal packages
|
|
// cannot replace one another's assets between those two operations.
|
|
const invocationRoot = mkdtempSync(
|
|
path.join(tmpdir(), "buzz-tauri-package-assets-"),
|
|
);
|
|
const frontendDist = path.join(invocationRoot, "dist");
|
|
const outputOverride = JSON.stringify({ build: { frontendDist } });
|
|
|
|
try {
|
|
const delimiterIndex = args.indexOf("--");
|
|
const configIndex = delimiterIndex === -1 ? args.length : delimiterIndex;
|
|
const tauriArgs = [...args];
|
|
tauriArgs.splice(configIndex, 0, "--config", outputOverride);
|
|
return runTauri(tauriArgs, {
|
|
env: { BUZZ_PROTECTED_BUILD_OUTPUT: frontendDist },
|
|
});
|
|
} finally {
|
|
rmSync(invocationRoot, { recursive: true, force: true });
|
|
}
|
|
}
|
|
|
|
if (
|
|
process.argv[1] &&
|
|
path.resolve(process.argv[1]) === fileURLToPath(import.meta.url)
|
|
) {
|
|
process.exitCode = runTauriCommand(process.argv.slice(2));
|
|
}
|