Files
buzz/desktop/scripts
Matt Toohey 70ee9a0344 refactor(desktop): retire the claude-code-acp catalog resolution fallback
The claude catalog entry still listed the retired Zed-era
claude-code-acp adapter as a resolution fallback after
claude-agent-acp. Since the bundling series, the bundled
claude-agent-acp always resolves first, so the fallback is
unreachable in the discovery sweep, readiness classification, and
install verification — and were the bundle ever broken, silently
spawning a stray install of the deprecated package is exactly the
drift the series exists to prevent. Reporting adapter_missing (with
the reinstall-Buzz hint) is the correct outcome there.

Move the name from the claude entry's commands to its aliases:
known_acp_runtime still maps stored records, override pins, and
avatar lookups carrying the legacy command to the claude runtime
(the override tests feeding claude-code-acp all pass unchanged), but
no resolution path sweeps for it anymore. The commands/aliases split
this makes load-bearing is now documented on the KnownAcpRuntime
fields, and comments claiming discovery "may select an installed
alias" are reworded to the stored-record reality. The
default_agent_args normalization arm and the frontend/buzz-acp
normalization paths (agentReuse.ts, buzz-acp config.rs) deliberately
keep the name for stored records, as does KNOWN_AGENT_BINARIES for
orphan-process cleanup.

Completes item B.3 of the post-bundling cleanup plan. The
discovery.rs file-size ledger is ratcheted 1134 -> 1139 for the five
new comment lines (the file sat exactly at its limit).

Verification:
- cargo test --lib (desktop/src-tauri): 1423 passed, 0 failed,
  11 ignored — including the avatar-url and override-pin tests that
  exercise claude-code-acp identity mapping via the alias path
- cargo clippy --lib --tests -D warnings: clean
- cargo fmt --check: clean
- node desktop/scripts/check-file-sizes.mjs: pass

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Signed-off-by: Matt Toohey <contact@matttoohey.com>
2026-07-15 13:45:59 +10:00
..