mirror of
https://github.com/block/buzz.git
synced 2026-10-31 22:41:12 +00:00
## Summary Test-side fixes for ten desktop E2E flake clusters and six long-tail rows from the 21–28 Oct 2026 CI audit. Each spec now waits for the state it assumes (a rendered row, a mounted listener, a finished animation, a held boot read), not a fixed delay or a one-shot probe. Two mock-bridge seams support this. The PR changes test code and mock-bridge seams only, apart from one product constant extracted with its value unchanged. It is one of seven PRs split out of the `flakey-tests` branch (siblings below). ### Related issue None found. - #8622, #8244 and #8386 touch some of these spec files, but not the tests fixed here. - §7 mode A (`navigation:472`) is left to open PR #6852, which already sets the width and measures in one polled evaluate. - Draft #8279 queues cold-launch nostr-bind links in the product. Its mock returns null, so the §12 listener seam is still needed. ### Mock-bridge seams - `__BUZZ_E2E_EVENT_LISTENER_COUNT__(event)` counts live **app** listeners per Tauri event. It wraps the mocked `plugin:event|listen`/`unlisten`. The spec-facing `__TAURI_INTERNALS__.listen` passes a marker target that the wrapper skips, so a spec's own subscription can't satisfy the wait. Tauri 2.11.1's mock ignores targets, so delivery is unchanged. - `deferFirstChannelsRead` arms the existing channels-read hold at boot. `__BUZZ_E2E_RELEASE_CHANNELS_READ__` releases it. - `CREATE_PROJECT_REFOCUS_DELAY_MS` moves to `createProjectFormFocus.ts` with its value unchanged (50 ms). Both `CreateProjectFormContent` and `project-commit-detail.spec` import it. ### Flaky tests fixed | Test | Failing runs | Cause | Change | |---|---|---|---| | §2 `overscroll-boundary.spec.ts:34` (and its sibling) | 39601763602, 40367495044, 40583830861, 40597484657, 40373404267 | The `message-timeline` test id first lands on the loading skeleton, which doesn't overflow, so the scroll lock rightly cancels the wheel. | Wait for a rendered row, and content taller than the viewport, before dispatching wheels. | | §4 `project-conversation-load-failure.spec.ts:73` | 40367495044 (all 3 attempts), 40608383847, 40583830861; PRs 39541263507, 40509460168 | The seeded root and reply were dated `now`. The panel's live REQ (`since = floor(now)`) still replayed the reply, so the error card never appeared. | Date both events a minute in the past, and correct the comment. | | §6 `workflows.spec.ts` `createWorkflow` cluster (:222, :365, :297, :525, :471, :406, :614, :997) | 14 of 50 main jobs; :222 ×4, e.g. 40353619362 | `AnimatePresence mode="wait"` keeps the trigger body mounted through its exit, so "Message text" could fill the trigger's field (:222 and the callers). For :297, `isVisible()` read "closed" one frame before the dialog opened its own channel list. | Wait for the step body's "Step details" control before filling. Create dialogs wait for the list; only the duplicate dialog clicks it. | | §12 `nostr-bind.spec.ts` (:156, :198, :228, :247, :260, :335, :417, :447) | 8 main jobs, each test once | The spec emitted `deep-link-nostr-bind` before the app subscribed, and the mock drops events that have no listener. | Wait for `__BUZZ_E2E_EVENT_LISTENER_COUNT__` to report the app listener before emitting. | | §15 `profile.spec.ts:1128` (integration) | 7 of 50 main jobs | The 320 ms motion-sampling window started before the click. | Start the window when `activeTab` reads "runtime". | | §17 `agent-availability.spec.ts:602`, both shutdown-failure variants (integration) | 6 jobs (4 disconnected-online, 2 failed-online) | The "shutdown refused" toast sits over the Delete row and pauses while the pointer is on it, so the retry click is intercepted. | Assert the toast, then retry with focus + Enter. The toaster has no close button. | | §19 `virtualization.spec.ts:247` "08 — cascading older pages…" | 4 of 50 main jobs; PR 40605736093 (all 3 attempts) | The 120 ms and 400 ms windows were timed from before the wheel bursts, and CDP can deliver wheels late. | Count the wheels the page receives. Each window opens at the first wheel and closes only after all have landed, then waits for still frames. **A second, product-side mode remains** (see below). | | §20 `message-copy-link.spec.ts:160` | 4 of 50 main jobs (5 failed attempts), e.g. 40595483966 | The huddle row reused `"d".repeat(64)`, which is a seeded ordinary `#general` message. | Use ids that no seed uses, and emit only after `waitForMockChannelHeadReady`. | | §21 `navigation.spec.ts:687` | 4 of 50 main jobs | The pending chip's `boundingBox()` was read once, and can be null while the row mounts. | Poll until the chip has a width. | | §23 `sidebar-snapshot.spec.ts:358`, `:388`, `:438` | PR 40427822003 (all 3 attempts); never on main | The 500 ms loading-state budget counted app boot, so a slow runner finished the channels read first. | Hold the first channels read with `deferFirstChannelsRead`, assert the loading state, then release it. | | `project-commit-detail.spec.ts:259` | 1–2 CI failures (audit long tail) | A 50 ms refocus timer can land mid-fill and type the description into the name field. | Once the name field is focused, wait out a page timer of `CREATE_PROJECT_REFOCUS_DELAY_MS`; equal-delay timers fire in order. | | `project-pr-review.spec.ts:3520` | 1–2 CI failures | The same timer pattern in `CreateProjectWorkItemDialog`. | Wait for `toBeFocused()` on the title, which only that timer can satisfy. | | `thread-load-failure.spec.ts:79` | 1–2 CI failures | `openWelcomeThread` branched on a one-shot `count()` and fell back to a hover-only Reply click. | Wait for the summary row, then click it. | | `virtualization.spec.ts:201` | 1–2 CI failures | The drop point sat 2 px above the target's bottom edge, after two fixed frames. | Drop at the centre, after dnd-kit's live region names the target. | | `channel-composer-overflow.spec.ts:217` | 1–2 CI failures | Same-second emits sort by id, and the clearance was checked once. | `createdAt: base + i` and `expect.poll`. | | `scroll-history.spec.ts:1289` | 1–2 CI failures | A fixed 250 ms wait before idle sampling. | Poll for coverage first. | Local before/after counts are from the original `flakey-tests` commits (e286a6ae0, 816c7c35e, 67185df6a). Each used a forcing that made `main`'s copy fail with CI's signature: | Test | Before | After | |---|---|---| | §2 | 3/15 | 15/15 | | §4 | 0/10 | 10/10 | | §6 :222 | 0/3 | 3/3 | | §6 :297 | 0/3 | 3/3 | | §12 | 0/3 | 3/3 | | §15 | 0/3 | 3/3 | | §17 | 1/4 | 4/4 | | §19 late-wheel modes | 0/3 | 3/3 and 2/3 | | §23 | 2/6 | 6/6 | | project-commit-detail | 0/3 | 3/3 | | project-pr-review | 0/3 | 3/3 | §20, §21, `thread-load-failure:79`, `virtualization:201`, `channel-composer-overflow:217` and `scroll-history:1289` were not reproduced; they get the fix that matches their CI signature. Not fixed (follow-up): `virtualization:247` also has a product-side mode. In one frame after a prepend, `scrollHeight` can drop 458–639 px while `scrollTop` moves only 50–114 px, so the anchor row jumps 382–457 px. That is lost anchor compensation, and this test can still fail on it. ### Verification This branch was pushed without local re-verification, by the user's choice: local test runs were overloading the machine and failing for that reason. **Hosted CI is the check.** It was pushed with `git push --no-verify`, because the pre-push hook runs typecheck and the unit suites. #8613's flake-check lane will also repeat the changed specs. - Every file except `virtualization.spec.ts` is byte-identical to its final version on `flakey-tests` (67185df6a). That file carries only this PR's hunks; see "Merge order". - Checked for this PR: `git diff --check`, biome on the partial spec (no changes, the same as on `main`), and a conflict-free merge with all six siblings onto `main`. ### Readiness Test and mock-bridge change; the one product edit is a constant extraction with its value unchanged. AGENTS.md's readiness steps (agent review, then human confirmation) are still outstanding, so `buzz-review-completed` is not set. ### Merge order No required order. `desktop/tests/e2e/virtualization.spec.ts` is also edited by **flakey-tests-desktop-races**, which adds one test after line 929; this PR's hunks are all above line 551. They don't touch, so the two merge cleanly in either order, as checked with `git merge-tree`. ### Sibling PRs Split from `flakey-tests` (one PR per area): #8676 (PostgreSQL lease + lane), #8677 (relay E2E helper + Windows shell), #8678 (mobile), #8679 (Tauri apt cache + Windows Rust cap), #8680 (desktop product races), #8682 (desktop E2E composer + row actions). 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Signed-off-by: Matt Toohey <contact@matttoohey.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Jitter <2b2e6415e748c35180847a37aadae06a11e30dddc76b784e7fd9354c4eb42e7a@buzz.block.builderlab.xyz>
153 lines
6.2 KiB
TypeScript
153 lines
6.2 KiB
TypeScript
import { expect, test, type Page } from "@playwright/test";
|
|
|
|
import { TEST_IDENTITIES, installMockBridge } from "../helpers/bridge";
|
|
|
|
/**
|
|
* End-to-end guard for the false-empty thread-load bug (PR #6447). A terminal
|
|
* thread-replies fetch failure must paint the error/Retry card and NEVER the
|
|
* "No replies in this branch yet" empty card — the two look similar but a failed
|
|
* load presented as an authoritative empty is the user-visible defect.
|
|
*
|
|
* Unit tests cover `ThreadReplyRegion` in isolation, but they cannot mount the
|
|
* full panel (Tiptap/React-Query), so they never observe the production
|
|
* panel→region handoff. This spec drives the REAL panel wiring through the mock
|
|
* bridge, so any regression at that seam (e.g. a static `isError={false}` at the
|
|
* call site) ships a visible false-empty and turns this case red.
|
|
*/
|
|
|
|
// Fail every get_thread_replies fetch at the IPC boundary while the flag is on,
|
|
// then let the real mock handler answer once it is cleared. Wrapping
|
|
// __TAURI_INTERNALS__.invoke (installed by the mock bridge) exercises the whole
|
|
// thread-load path — query hook, retry, panel, region — exactly as production
|
|
// does, with no source seam to bypass. A boolean gate (rather than a failure
|
|
// countdown) is deterministic: stray thread-reply prefetches during channel
|
|
// open can't drain it, so the panel's own load reliably reaches the terminal
|
|
// error state, and clearing the flag makes the Retry fetch reliably succeed.
|
|
async function installThreadFailureSwitch(page: Page) {
|
|
await page.evaluate(() => {
|
|
const w = window as typeof window & {
|
|
__FAIL_THREAD_REPLIES__?: boolean;
|
|
__TAURI_INTERNALS__: {
|
|
invoke: (
|
|
command: string,
|
|
payload: unknown,
|
|
options: unknown,
|
|
) => Promise<unknown>;
|
|
};
|
|
};
|
|
w.__FAIL_THREAD_REPLIES__ = false;
|
|
const original = w.__TAURI_INTERNALS__.invoke.bind(w.__TAURI_INTERNALS__);
|
|
w.__TAURI_INTERNALS__.invoke = async (command, payload, options) => {
|
|
if (command === "get_thread_replies" && w.__FAIL_THREAD_REPLIES__) {
|
|
throw new Error("relay unreachable: request timed out");
|
|
}
|
|
return original(command, payload, options);
|
|
};
|
|
});
|
|
}
|
|
|
|
async function setThreadRepliesFailing(page: Page, failing: boolean) {
|
|
await page.evaluate((failing) => {
|
|
(
|
|
window as typeof window & { __FAIL_THREAD_REPLIES__?: boolean }
|
|
).__FAIL_THREAD_REPLIES__ = failing;
|
|
}, failing);
|
|
}
|
|
|
|
// Open the welcome thread from its "1 reply" summary row. The row appears only
|
|
// once the channel window has materialized the seeded reply, which can lag, so
|
|
// wait for it rather than probing it once.
|
|
async function openWelcomeThread(page: Page) {
|
|
const summary = page.locator(
|
|
'[data-testid="message-thread-summary"][data-thread-head-id="mock-general-welcome"]',
|
|
);
|
|
await expect(summary).toBeVisible();
|
|
await summary.click();
|
|
await expect(page.getByTestId("message-thread-panel")).toBeVisible();
|
|
}
|
|
|
|
test.describe("thread load failure", () => {
|
|
test("terminal fetch failure shows error card, never false-empty; Retry recovers", async ({
|
|
page,
|
|
}) => {
|
|
await installMockBridge(page);
|
|
await page.goto("/");
|
|
|
|
// Seed a reply into the mock store BEFORE opening general, i.e. before its
|
|
// live subscription exists. The reply lands in the channel window (so the
|
|
// "1 reply" thread summary renders) but is never live-pushed into the
|
|
// thread-replies cache — so the thread opens with an empty reply cache and
|
|
// the failed get_thread_replies has nothing to fall back to. If it were
|
|
// emitted while general was open, the live handler would seed the thread
|
|
// cache and the panel would render the list branch, masking the error card.
|
|
//
|
|
// Wait for the emitter to be installed first: emitting before the app has
|
|
// booted is a silent no-op (the helper is undefined), which would leave the
|
|
// store empty and the recovery assertion with nothing to render.
|
|
await expect
|
|
.poll(() =>
|
|
page.evaluate(
|
|
() =>
|
|
typeof (
|
|
window as typeof window & {
|
|
__BUZZ_E2E_EMIT_MOCK_MESSAGE__?: unknown;
|
|
}
|
|
).__BUZZ_E2E_EMIT_MOCK_MESSAGE__ === "function",
|
|
),
|
|
)
|
|
.toBe(true);
|
|
await page.evaluate((pubkey) => {
|
|
(
|
|
window as typeof window & {
|
|
__BUZZ_E2E_EMIT_MOCK_MESSAGE__?: (input: {
|
|
channelName: string;
|
|
content: string;
|
|
parentEventId?: string;
|
|
pubkey?: string;
|
|
createdAt?: number;
|
|
}) => unknown;
|
|
}
|
|
).__BUZZ_E2E_EMIT_MOCK_MESSAGE__?.({
|
|
channelName: "general",
|
|
content: "First reply to welcome",
|
|
parentEventId: "mock-general-welcome",
|
|
pubkey,
|
|
createdAt: Math.floor(Date.now() / 1000) - 10,
|
|
});
|
|
}, TEST_IDENTITIES.alice.pubkey);
|
|
|
|
await page.getByTestId("channel-general").click();
|
|
await expect(page.getByTestId("chat-title")).toHaveText("general");
|
|
await installThreadFailureSwitch(page);
|
|
|
|
// Fail every thread-replies fetch, then open the thread: the panel query and
|
|
// its retry both fail, driving the terminal error state.
|
|
await setThreadRepliesFailing(page, true);
|
|
await openWelcomeThread(page);
|
|
|
|
// The load-bearing assertion: a terminal failure paints the error/Retry
|
|
// card and NEVER the false-empty "No replies in this branch yet" state.
|
|
await expect(
|
|
page.getByTestId("message-thread-replies-error"),
|
|
).toContainText("Couldn't load replies", { timeout: 15_000 });
|
|
await expect(page.getByTestId("message-thread-replies-retry")).toHaveText(
|
|
"Retry",
|
|
);
|
|
await expect(page.getByText("No replies in this branch yet")).toHaveCount(
|
|
0,
|
|
);
|
|
|
|
// Retry with fetches succeeding again: the reply loads and renders — the
|
|
// error card is gone and no false-empty appears.
|
|
await setThreadRepliesFailing(page, false);
|
|
await page.getByTestId("message-thread-replies-retry").click();
|
|
await expect(page.getByTestId("message-thread-replies-error")).toHaveCount(
|
|
0,
|
|
);
|
|
await expect(page.getByText("First reply to welcome")).toBeVisible();
|
|
await expect(page.getByText("No replies in this branch yet")).toHaveCount(
|
|
0,
|
|
);
|
|
});
|
|
});
|