mirror of
https://github.com/block/buzz.git
synced 2026-11-03 07:51:22 +00:00
## Summary Deletes mobile code that no longer has a user-reachable path and has no counterpart in buzz-app, so it is unlikely to come back for parity. Net: 104 files, about 5,500 lines removed. No intended behavior change. - **iOS native message menu and action surface:** `NativeMessageMenu.swift` and `NativeMessageActionSurface.swift`, the `message`/`supportsMessage` coordinator branches, and the Dart selection hook. Dart stopped creating this view in [#8280](https://github.com/block/buzz/pull/8280). The native reactions sheet in the same coordinator is kept. - **Old home quick-actions launcher and `ComposeMorphIcon`:** only instantiated in tests since the nav-bar creation actions replaced them. - **Retired local theme stack:** `ThemeNotifier`, `AccentNotifier`, `SchemeNotifier`, `adaptive_theme.dart`, `AccentPickerPage`, the appearance-mode sheet and their helpers. These predate per-community theme sync. The legacy prefs migration in `community_theme_preference.dart` is kept. - **Unused widgets:** `ProfileAvatar` and `MaskedAvatarBadge`. - **Push permission-status plumbing:** the iOS `notificationAuthorizationStatus`/`openNotificationSettings` handlers, plus the uncalled strict age-gate snapshot registration and its Swift `syncAgeGatePushSnapshot` path. - **Orphaned files** with no importer: `profile_text_edit_sheet`, `editor_option_button`, `retained_page_transition`, `tappable_flapping_bee`, `agent_model_info`, `community_bot_profiles`, `sheet_divider`, `success_haptic`. - **Uncalled helpers:** the `pickAndUpload*`/camera helpers in `media_upload.dart`, unused `NostrFilters` builders, `mediaGetHeadersFor*`, and about 20 other uncalled functions, providers and styles. - **Removed-UI leftovers:** the never-wired invite directory providers, `AuthNotifier.signOut` and `removeActiveCommunityForSignOut` (the Sign out row is gone), `renameCommunity`, `HomePage.profilePageBuilder`/`SettingsPage.embedded`, and the create-forum branches of the create-channel sheet. Forum viewing is unchanged. Tests that only covered deleted code are removed. Tests of surviving code that used deleted helpers as drivers were repointed to the surviving API. An audit of `mobile/android` found no dead Kotlin, resources, manifest entries or Gradle dependencies, so Android code is unchanged. ## Validation - `flutter analyze`: no issues. - After rebasing onto main ([93b8b8f](https://github.com/block/buzz/commit/93b8b8febc)), `just mobile-check` is clean (format and analyze), and `just mobile-test` passes (4,070 passed, 35 skipped, 0 failed, plus the push-unconfigured and secp256k1 suites). - `dart format`: clean. - Android: `just mobile-build-android` builds the debug APK, and `./gradlew :app:testDebugUnitTest` passes. - iOS: `build-for-testing` succeeds and BuzzPushKit `swift test` passes (65 tests). In RunnerTests, 97 of 98 pass. `testNativeNavigationTitleExpandsAgainAtTop` fails, but it fails the same way on unmodified `main` (acf56fff6f) on the same machine (Xcode 27, iPhone 17 Pro simulator), so it is not caused by this change. - Agent review of the diff ran. Its one blocker (stale `project.pbxproj` entries for the deleted Swift files) is fixed. - In-app smoke run at [66141c1](66141c10b9): a debug build on a fresh iPhone 17 Pro simulator (iOS 27), signed in to the internal community. The following flows all worked with no errors: - Home: the New menu (channel, DM, workspace, chat) and the create-channel sheet, including its channel-type options. - A chat, with the message action sheet (reactions row, Reply, Copy link, Remind me, Mark unread, Copy text, Edit and Delete). - Appearance: the previews, and cycling the System and Light modes. - Settings: the profile header, the display name editor, and Edit photo (Image and Emoji tabs). - The Agents directory. - Search, including the Channels filter, plus opening a team channel from the results. - Tapping a reaction summary, which opens the native iOS Reactions sheet. - The recording isn't attached here because it shows internal channels and messages. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Signed-off-by: Tom Brow <tomb@squareup.com> Co-authored-by: Tom Brow <tomb@squareup.com> Co-authored-by: studio <dc2fc481343672df31a689840c09299972e704dac592e0da6f18486646a7ee3e@buzz.block.builderlab.xyz> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
131 lines
3.4 KiB
Dart
131 lines
3.4 KiB
Dart
import 'package:flutter/material.dart';
|
|
|
|
import 'grid.dart';
|
|
|
|
const _fontFamily = 'Inter';
|
|
|
|
/// Avatar size for full channel and thread messages.
|
|
const messageAvatarSize = 42.0;
|
|
|
|
/// Avatar size for conversation-oriented Activity rows.
|
|
const activityAvatarSize = messageAvatarSize;
|
|
|
|
/// Avatar size for compact message-result rows.
|
|
const compactMessageAvatarSize = messageAvatarSize;
|
|
|
|
/// Horizontal space between a message avatar and its content.
|
|
const messageAvatarContentGap = Grid.twelve;
|
|
|
|
/// Primary message copy: 15sp regular on a 20sp line height.
|
|
const messageBodyTextStyle = TextStyle(
|
|
fontFamily: _fontFamily,
|
|
fontSize: 15,
|
|
fontWeight: FontWeight.w400,
|
|
height: 20 / 15,
|
|
letterSpacing: 0,
|
|
);
|
|
|
|
/// Message author names: 15sp semibold on a 17sp line height.
|
|
const messageUsernameTextStyle = TextStyle(
|
|
fontFamily: _fontFamily,
|
|
fontSize: 15,
|
|
fontWeight: FontWeight.w600,
|
|
height: 17 / 15,
|
|
letterSpacing: 0,
|
|
);
|
|
|
|
/// Secondary author metadata: 15sp regular on a tight 17sp line height.
|
|
const messageMetadataTextStyle = TextStyle(
|
|
fontFamily: _fontFamily,
|
|
fontSize: 15,
|
|
fontWeight: FontWeight.w400,
|
|
height: 17 / 15,
|
|
letterSpacing: 0,
|
|
);
|
|
|
|
/// Message timestamps: 13.1sp regular, one step below 15sp author names.
|
|
const messageTimestampTextStyle = TextStyle(
|
|
fontFamily: _fontFamily,
|
|
fontSize: 13.1,
|
|
fontWeight: FontWeight.w400,
|
|
height: 17 / 13.1,
|
|
letterSpacing: 0,
|
|
);
|
|
|
|
/// Reaction counts: 13.1sp medium on a 17sp line height.
|
|
const reactionCountTextStyle = TextStyle(
|
|
fontFamily: _fontFamily,
|
|
fontSize: 13.1,
|
|
fontWeight: FontWeight.w500,
|
|
height: 17 / 13.1,
|
|
letterSpacing: 0,
|
|
);
|
|
|
|
/// Channel and thread titles: 20sp bold on a 24sp line height.
|
|
const channelTitleTextStyle = TextStyle(
|
|
fontFamily: _fontFamily,
|
|
fontSize: 20,
|
|
fontWeight: FontWeight.w700,
|
|
height: 24 / 20,
|
|
letterSpacing: 0,
|
|
);
|
|
|
|
/// Primary labels in compact content lists.
|
|
const contentListTitleTextStyle = messageUsernameTextStyle;
|
|
|
|
/// Titles shared by Home channel rows and Solo chat rows.
|
|
const navigationChatTitleTextStyle = TextStyle(
|
|
fontFamily: _fontFamily,
|
|
fontSize: 17,
|
|
fontWeight: FontWeight.w400,
|
|
height: 22 / 17,
|
|
letterSpacing: 0,
|
|
);
|
|
|
|
/// Secondary copy in compact content lists.
|
|
const contentListBodyTextStyle = TextStyle(
|
|
fontFamily: _fontFamily,
|
|
fontSize: 13.1,
|
|
fontWeight: FontWeight.w400,
|
|
height: 17 / 13.1,
|
|
letterSpacing: 0,
|
|
);
|
|
|
|
/// Filter chip labels use a tighter 15sp Inter treatment.
|
|
const filterChipTextStyle = TextStyle(
|
|
fontFamily: _fontFamily,
|
|
fontSize: 15,
|
|
fontWeight: FontWeight.w400,
|
|
height: 1,
|
|
letterSpacing: 0,
|
|
);
|
|
|
|
/// Search fields use the primary 15sp body treatment.
|
|
const searchInputTextStyle = messageBodyTextStyle;
|
|
|
|
/// Activity sender names share the primary author style.
|
|
const activityUsernameTextStyle = messageUsernameTextStyle;
|
|
|
|
/// Activity timestamps share the compact message timestamp treatment.
|
|
const activityTimestampTextStyle = messageTimestampTextStyle;
|
|
|
|
/// Activity context labels: 13.1sp medium on a 17sp line height.
|
|
const activityContextTextStyle = TextStyle(
|
|
fontFamily: _fontFamily,
|
|
fontSize: 13.1,
|
|
fontWeight: FontWeight.w500,
|
|
height: 17 / 13.1,
|
|
letterSpacing: 0,
|
|
);
|
|
|
|
/// Activity message previews use the primary message copy style.
|
|
const activityPreviewTextStyle = messageBodyTextStyle;
|
|
|
|
/// Inventory labels shared by Solo and Team navigation sections.
|
|
const navigationSectionTextStyle = TextStyle(
|
|
fontFamily: _fontFamily,
|
|
fontSize: 15,
|
|
height: 20 / 15,
|
|
fontWeight: FontWeight.w500,
|
|
);
|