mirror of
https://github.com/block/buzz.git
synced 2026-11-03 16:01:35 +00:00
## Summary Deletes mobile code that no longer has a user-reachable path and has no counterpart in buzz-app, so it is unlikely to come back for parity. Net: 104 files, about 5,500 lines removed. No intended behavior change. - **iOS native message menu and action surface:** `NativeMessageMenu.swift` and `NativeMessageActionSurface.swift`, the `message`/`supportsMessage` coordinator branches, and the Dart selection hook. Dart stopped creating this view in [#8280](https://github.com/block/buzz/pull/8280). The native reactions sheet in the same coordinator is kept. - **Old home quick-actions launcher and `ComposeMorphIcon`:** only instantiated in tests since the nav-bar creation actions replaced them. - **Retired local theme stack:** `ThemeNotifier`, `AccentNotifier`, `SchemeNotifier`, `adaptive_theme.dart`, `AccentPickerPage`, the appearance-mode sheet and their helpers. These predate per-community theme sync. The legacy prefs migration in `community_theme_preference.dart` is kept. - **Unused widgets:** `ProfileAvatar` and `MaskedAvatarBadge`. - **Push permission-status plumbing:** the iOS `notificationAuthorizationStatus`/`openNotificationSettings` handlers, plus the uncalled strict age-gate snapshot registration and its Swift `syncAgeGatePushSnapshot` path. - **Orphaned files** with no importer: `profile_text_edit_sheet`, `editor_option_button`, `retained_page_transition`, `tappable_flapping_bee`, `agent_model_info`, `community_bot_profiles`, `sheet_divider`, `success_haptic`. - **Uncalled helpers:** the `pickAndUpload*`/camera helpers in `media_upload.dart`, unused `NostrFilters` builders, `mediaGetHeadersFor*`, and about 20 other uncalled functions, providers and styles. - **Removed-UI leftovers:** the never-wired invite directory providers, `AuthNotifier.signOut` and `removeActiveCommunityForSignOut` (the Sign out row is gone), `renameCommunity`, `HomePage.profilePageBuilder`/`SettingsPage.embedded`, and the create-forum branches of the create-channel sheet. Forum viewing is unchanged. Tests that only covered deleted code are removed. Tests of surviving code that used deleted helpers as drivers were repointed to the surviving API. An audit of `mobile/android` found no dead Kotlin, resources, manifest entries or Gradle dependencies, so Android code is unchanged. ## Validation - `flutter analyze`: no issues. - After rebasing onto main ([93b8b8f](https://github.com/block/buzz/commit/93b8b8febc)), `just mobile-check` is clean (format and analyze), and `just mobile-test` passes (4,070 passed, 35 skipped, 0 failed, plus the push-unconfigured and secp256k1 suites). - `dart format`: clean. - Android: `just mobile-build-android` builds the debug APK, and `./gradlew :app:testDebugUnitTest` passes. - iOS: `build-for-testing` succeeds and BuzzPushKit `swift test` passes (65 tests). In RunnerTests, 97 of 98 pass. `testNativeNavigationTitleExpandsAgainAtTop` fails, but it fails the same way on unmodified `main` (acf56fff6f) on the same machine (Xcode 27, iPhone 17 Pro simulator), so it is not caused by this change. - Agent review of the diff ran. Its one blocker (stale `project.pbxproj` entries for the deleted Swift files) is fixed. - In-app smoke run at [66141c1](66141c10b9): a debug build on a fresh iPhone 17 Pro simulator (iOS 27), signed in to the internal community. The following flows all worked with no errors: - Home: the New menu (channel, DM, workspace, chat) and the create-channel sheet, including its channel-type options. - A chat, with the message action sheet (reactions row, Reply, Copy link, Remind me, Mark unread, Copy text, Edit and Delete). - Appearance: the previews, and cycling the System and Light modes. - Settings: the profile header, the display name editor, and Edit photo (Image and Emoji tabs). - The Agents directory. - Search, including the Channels filter, plus opening a team channel from the results. - Tapping a reaction summary, which opens the native iOS Reactions sheet. - The recording isn't attached here because it shows internal channels and messages. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Signed-off-by: Tom Brow <tomb@squareup.com> Co-authored-by: Tom Brow <tomb@squareup.com> Co-authored-by: studio <dc2fc481343672df31a689840c09299972e704dac592e0da6f18486646a7ee3e@buzz.block.builderlab.xyz> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
85 lines
3.3 KiB
Dart
85 lines
3.3 KiB
Dart
import 'package:flutter/material.dart';
|
|
import 'package:hooks_riverpod/hooks_riverpod.dart';
|
|
import 'package:shared_preferences/shared_preferences.dart';
|
|
|
|
import 'buzz_theme.dart';
|
|
import 'theme_catalog.dart';
|
|
import 'theme_pairs.dart';
|
|
|
|
/// Buzz ships as the default: the first-party pair, so a fresh install gets the
|
|
/// branded top-section gradient without picking a theme first.
|
|
const defaultSchemeName = buzzThemeName;
|
|
|
|
/// Pre-loaded SharedPreferences instance, overridden in main().
|
|
final savedPrefsProvider = Provider<SharedPreferences>(
|
|
(_) => throw UnimplementedError('Must be overridden'),
|
|
);
|
|
|
|
/// Returns a scheme that can honor [mode] without silently pinning brightness.
|
|
///
|
|
/// System mode only offers paired themes because they have both light and dark
|
|
/// variants. Switching to it from an unpaired or unknown selection therefore
|
|
/// falls back to the first paired theme, matching the picker ordering.
|
|
String? schemeForAppearanceMode(String? schemeName, ThemeMode mode) {
|
|
if (mode != ThemeMode.system) return schemeName;
|
|
|
|
final selected = findTheme(schemeName ?? defaultSchemeName);
|
|
if (selected != null && isPairedTheme(selected.name)) return schemeName;
|
|
|
|
return themeGroups().paired.firstOrNull?.name ?? schemeName;
|
|
}
|
|
|
|
/// The theme whose colors are actually applied for [schemeName] under [mode].
|
|
///
|
|
/// In [ThemeMode.system] that is the selected theme itself — its pair covers the
|
|
/// other brightness. In the pinned modes it is the theme coerced to the pinned
|
|
/// brightness, which is what the picker highlights so the checkmark always
|
|
/// tracks what is on screen.
|
|
ThemeColors? effectiveTheme(String? schemeName, ThemeMode mode) {
|
|
final selected =
|
|
findTheme(schemeName ?? defaultSchemeName) ??
|
|
findTheme(defaultSchemeName);
|
|
if (selected == null) return null;
|
|
|
|
return switch (mode) {
|
|
ThemeMode.system => selected,
|
|
ThemeMode.light => _themeForBrightness(selected, wantDark: false),
|
|
ThemeMode.dark => _themeForBrightness(selected, wantDark: true),
|
|
};
|
|
}
|
|
|
|
/// Coerces [selected] to the requested brightness: itself when it already
|
|
/// matches, otherwise its pair, otherwise the first catalog theme of that
|
|
/// brightness. Keeps a stored light theme usable after switching to Dark mode
|
|
/// without rewriting the user's saved selection.
|
|
ThemeColors _themeForBrightness(
|
|
ThemeColors selected, {
|
|
required bool wantDark,
|
|
}) {
|
|
if (selected.isDark == wantDark) return selected;
|
|
|
|
final pairName = themePairFor(selected.name);
|
|
final paired = pairName == null ? null : findTheme(pairName);
|
|
if (paired != null && paired.isDark == wantDark) return paired;
|
|
|
|
// Match desktop's paired-first picker ordering: an unpaired selection falls
|
|
// back through the first-party default pair, not whichever borrowed theme
|
|
// sorts first in the full brightness group.
|
|
final defaultTheme = findTheme(defaultSchemeName);
|
|
if (defaultTheme != null) {
|
|
if (defaultTheme.isDark == wantDark) return defaultTheme;
|
|
|
|
final defaultPairName = themePairFor(defaultTheme.name);
|
|
final defaultPair = defaultPairName == null
|
|
? null
|
|
: findTheme(defaultPairName);
|
|
if (defaultPair != null && defaultPair.isDark == wantDark) {
|
|
return defaultPair;
|
|
}
|
|
}
|
|
|
|
final groups = themeGroups();
|
|
final fallback = wantDark ? groups.dark : groups.light;
|
|
return fallback.isEmpty ? selected : fallback.first;
|
|
}
|