mirror of
https://github.com/block/buzz.git
synced 2026-11-03 07:51:22 +00:00
## Summary Deletes mobile code that no longer has a user-reachable path and has no counterpart in buzz-app, so it is unlikely to come back for parity. Net: 104 files, about 5,500 lines removed. No intended behavior change. - **iOS native message menu and action surface:** `NativeMessageMenu.swift` and `NativeMessageActionSurface.swift`, the `message`/`supportsMessage` coordinator branches, and the Dart selection hook. Dart stopped creating this view in [#8280](https://github.com/block/buzz/pull/8280). The native reactions sheet in the same coordinator is kept. - **Old home quick-actions launcher and `ComposeMorphIcon`:** only instantiated in tests since the nav-bar creation actions replaced them. - **Retired local theme stack:** `ThemeNotifier`, `AccentNotifier`, `SchemeNotifier`, `adaptive_theme.dart`, `AccentPickerPage`, the appearance-mode sheet and their helpers. These predate per-community theme sync. The legacy prefs migration in `community_theme_preference.dart` is kept. - **Unused widgets:** `ProfileAvatar` and `MaskedAvatarBadge`. - **Push permission-status plumbing:** the iOS `notificationAuthorizationStatus`/`openNotificationSettings` handlers, plus the uncalled strict age-gate snapshot registration and its Swift `syncAgeGatePushSnapshot` path. - **Orphaned files** with no importer: `profile_text_edit_sheet`, `editor_option_button`, `retained_page_transition`, `tappable_flapping_bee`, `agent_model_info`, `community_bot_profiles`, `sheet_divider`, `success_haptic`. - **Uncalled helpers:** the `pickAndUpload*`/camera helpers in `media_upload.dart`, unused `NostrFilters` builders, `mediaGetHeadersFor*`, and about 20 other uncalled functions, providers and styles. - **Removed-UI leftovers:** the never-wired invite directory providers, `AuthNotifier.signOut` and `removeActiveCommunityForSignOut` (the Sign out row is gone), `renameCommunity`, `HomePage.profilePageBuilder`/`SettingsPage.embedded`, and the create-forum branches of the create-channel sheet. Forum viewing is unchanged. Tests that only covered deleted code are removed. Tests of surviving code that used deleted helpers as drivers were repointed to the surviving API. An audit of `mobile/android` found no dead Kotlin, resources, manifest entries or Gradle dependencies, so Android code is unchanged. ## Validation - `flutter analyze`: no issues. - After rebasing onto main ([93b8b8f](https://github.com/block/buzz/commit/93b8b8febc)), `just mobile-check` is clean (format and analyze), and `just mobile-test` passes (4,070 passed, 35 skipped, 0 failed, plus the push-unconfigured and secp256k1 suites). - `dart format`: clean. - Android: `just mobile-build-android` builds the debug APK, and `./gradlew :app:testDebugUnitTest` passes. - iOS: `build-for-testing` succeeds and BuzzPushKit `swift test` passes (65 tests). In RunnerTests, 97 of 98 pass. `testNativeNavigationTitleExpandsAgainAtTop` fails, but it fails the same way on unmodified `main` (acf56fff6f) on the same machine (Xcode 27, iPhone 17 Pro simulator), so it is not caused by this change. - Agent review of the diff ran. Its one blocker (stale `project.pbxproj` entries for the deleted Swift files) is fixed. - In-app smoke run at [66141c1](66141c10b9): a debug build on a fresh iPhone 17 Pro simulator (iOS 27), signed in to the internal community. The following flows all worked with no errors: - Home: the New menu (channel, DM, workspace, chat) and the create-channel sheet, including its channel-type options. - A chat, with the message action sheet (reactions row, Reply, Copy link, Remind me, Mark unread, Copy text, Edit and Delete). - Appearance: the previews, and cycling the System and Light modes. - Settings: the profile header, the display name editor, and Edit photo (Image and Emoji tabs). - The Agents directory. - Search, including the Channels filter, plus opening a team channel from the results. - Tapping a reaction summary, which opens the native iOS Reactions sheet. - The recording isn't attached here because it shows internal channels and messages. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Signed-off-by: Tom Brow <tomb@squareup.com> Co-authored-by: Tom Brow <tomb@squareup.com> Co-authored-by: studio <dc2fc481343672df31a689840c09299972e704dac592e0da6f18486646a7ee3e@buzz.block.builderlab.xyz> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
362 lines
13 KiB
Dart
362 lines
13 KiB
Dart
import 'dart:async';
|
|
import 'dart:convert';
|
|
|
|
import 'package:buzz/features/settings/settings_page.dart';
|
|
import 'package:buzz/shared/auth/auth_provider.dart';
|
|
import 'package:buzz/shared/community/community.dart';
|
|
import 'package:buzz/shared/community/community_provider.dart';
|
|
import 'package:buzz/shared/community/community_storage.dart';
|
|
import 'package:buzz/shared/push/dev_push_lease.dart';
|
|
import 'package:buzz/shared/push/push_bootstrap.dart';
|
|
import 'package:buzz/shared/push/push_lease_revocation_outbox.dart';
|
|
import 'package:buzz/shared/crypto/nip44.dart';
|
|
import 'package:buzz/shared/relay/nostr_models.dart';
|
|
import 'package:buzz/shared/relay/signed_event_relay.dart';
|
|
import 'package:buzz/shared/push/push_bridge.dart';
|
|
import 'package:buzz/shared/push/push_relay_capability_provider.dart';
|
|
import 'package:buzz/shared/push/push_subscription.dart';
|
|
import 'package:buzz/shared/relay/app_lifecycle_provider.dart';
|
|
import 'package:buzz/shared/relay/relay_provider.dart';
|
|
import 'package:buzz/shared/relay/relay_session.dart';
|
|
import 'package:buzz/shared/theme/theme.dart';
|
|
import 'package:flutter/foundation.dart';
|
|
import 'package:flutter/material.dart';
|
|
import 'package:flutter/services.dart';
|
|
import 'package:flutter_test/flutter_test.dart';
|
|
import 'package:hooks_riverpod/hooks_riverpod.dart';
|
|
import 'package:package_info_plus/package_info_plus.dart';
|
|
import 'package:nostr/nostr.dart' as nostr;
|
|
import 'package:shared_preferences/shared_preferences.dart';
|
|
|
|
import '../../shared/community/community_storage_test.dart';
|
|
|
|
void main() {
|
|
TestWidgetsFlutterBinding.ensureInitialized();
|
|
setUpAll(() async {
|
|
final fonts = FontLoader('Inter')
|
|
..addFont(rootBundle.load('assets/fonts/InterVariable.ttf'));
|
|
await fonts.load();
|
|
});
|
|
for (final outcome in [
|
|
'accepted',
|
|
'failed',
|
|
'pending',
|
|
'scaled',
|
|
'unset preference',
|
|
]) {
|
|
testWidgets('off then on remains usable with $outcome cleanup', (
|
|
tester,
|
|
) async {
|
|
final semantics = tester.ensureSemantics();
|
|
// iPhone 12 mini width; use a wider screen for the 2x single-line case.
|
|
tester.view.physicalSize = Size(outcome == 'scaled' ? 430 : 375, 1800);
|
|
tester.view.devicePixelRatio = 1;
|
|
addTearDown(tester.view.reset);
|
|
if (outcome == 'scaled') {
|
|
tester.platformDispatcher.textScaleFactorTestValue = 2;
|
|
addTearDown(tester.platformDispatcher.clearTextScaleFactorTestValue);
|
|
}
|
|
debugDefaultTargetPlatformOverride = TargetPlatform.iOS;
|
|
addTearDown(() => debugDefaultTargetPlatformOverride = null);
|
|
PackageInfo.setMockInitialValues(
|
|
appName: 'Buzz',
|
|
packageName: 'buzz',
|
|
version: '1.0.0',
|
|
buildNumber: '1',
|
|
buildSignature: '',
|
|
);
|
|
SharedPreferences.setMockInitialValues({});
|
|
final prefs = await SharedPreferences.getInstance();
|
|
final secure = FakeSecureStorage();
|
|
final storage = CommunityStorage(secure: secure);
|
|
final subscriptions = [
|
|
BuzzPushSubscription(
|
|
filter: BuzzPushFilter(kinds: const [9], pTags: ['a' * 64]),
|
|
notificationClass: 'default',
|
|
),
|
|
];
|
|
var discoveries = 0;
|
|
final session = _Connected();
|
|
apnsDeviceToken.value = 'test-apns-token';
|
|
addTearDown(() => apnsDeviceToken.value = null);
|
|
final grant = <String, Object>{
|
|
'relayOrigin': 'wss://relay.example',
|
|
'relayPubkey': _descriptor.executorPubkey,
|
|
'installationId': 'b' * 32,
|
|
'endpointGrant': 'test-endpoint-grant',
|
|
'endpointHash': 'c' * 64,
|
|
'endpointEpoch': 1,
|
|
'generation': 1,
|
|
'expiresAt': DateTime.now().millisecondsSinceEpoch ~/ 1000 + 3600,
|
|
};
|
|
const nativePush = MethodChannel('buzz/push');
|
|
final messenger =
|
|
TestDefaultBinaryMessengerBinding.instance.defaultBinaryMessenger;
|
|
messenger.setMockMethodCallHandler(
|
|
nativePush,
|
|
(call) async => switch (call.method) {
|
|
'enrollPush' => grant,
|
|
'endpointGrants' => [grant],
|
|
'startRegistration' || 'syncPushSnapshot' => null,
|
|
_ => throw StateError('Unexpected native call ${call.method}'),
|
|
},
|
|
);
|
|
addTearDown(() => messenger.setMockMethodCallHandler(nativePush, null));
|
|
final community =
|
|
Community.create(
|
|
name: 'Team',
|
|
relayUrl: 'https://relay.example',
|
|
).copyWith(
|
|
nsec: nostr.Nip19.encode(
|
|
prefix: nostr.Nip19Prefix.nsec,
|
|
data: '1' * 64,
|
|
),
|
|
pushNotificationsEnabled: true,
|
|
pushLeaseInstallationId: 'd' * 32,
|
|
pushSubscriptionState: BuzzPushLeaseSubscriptionState.desired(
|
|
desired: subscriptions,
|
|
).withAccepted(subscriptions: subscriptions, generation: 7),
|
|
);
|
|
if (outcome == 'unset preference') {
|
|
final saved = community.toJson()..remove('pushNotificationsEnabledV2');
|
|
saved['pushNotificationsEnabled'] = false;
|
|
secure['buzz_communities'] = jsonEncode([saved]);
|
|
} else {
|
|
await storage.save(community);
|
|
}
|
|
await storage.saveActiveId(community.id);
|
|
|
|
final cleanup = Completer<void>();
|
|
final showingSettings = ValueNotifier(true);
|
|
addTearDown(showingSettings.dispose);
|
|
final snapshots = <List<Community>>[];
|
|
final tombstones = <int?>[];
|
|
await tester.pumpWidget(
|
|
ProviderScope(
|
|
overrides: [
|
|
savedPrefsProvider.overrideWithValue(prefs),
|
|
authProvider.overrideWith(_Auth.new),
|
|
communityStorageProvider.overrideWithValue(storage),
|
|
communitySnapshotWriterProvider.overrideWithValue((
|
|
communities,
|
|
) async {
|
|
snapshots.add(List.of(communities));
|
|
}),
|
|
communityPushLeaseDeactivatorProvider.overrideWithValue((
|
|
community, {
|
|
generation,
|
|
}) async {
|
|
tombstones.add(generation);
|
|
if (outcome == 'failed') throw StateError('relay unavailable');
|
|
if (outcome == 'pending') await cleanup.future;
|
|
await publishBuzzPushLeaseTombstone(
|
|
descriptor: _descriptor,
|
|
installationId: community.pushLeaseInstallationId!,
|
|
generation: generation!,
|
|
nsec: community.nsec!,
|
|
memberPubkey: pubkeyFromNsec(community.nsec)!,
|
|
submit: SignedEventRelay(
|
|
session: session,
|
|
nsec: community.nsec,
|
|
).submit,
|
|
);
|
|
}),
|
|
buzzPushLeaseRevocationStorageProvider.overrideWithValue(
|
|
BuzzPushLeaseRevocationStorage(secure: FakeSecureStorage()),
|
|
),
|
|
relaySessionProvider.overrideWith(() => session),
|
|
myPubkeyProvider.overrideWithValue(nostr.Keys('1' * 64).public),
|
|
buzzPushDescriptorFetcherProvider.overrideWithValue((_) async {
|
|
discoveries++;
|
|
return _descriptor;
|
|
}),
|
|
appLifecycleProvider.overrideWith(_Lifecycle.new),
|
|
],
|
|
child: BuzzPushBootstrap(
|
|
child: MaterialApp(
|
|
theme: AppTheme.light(),
|
|
home: ValueListenableBuilder(
|
|
valueListenable: showingSettings,
|
|
builder: (_, showing, _) => showing
|
|
? SettingsPage(
|
|
profileHeader: const SizedBox.shrink(),
|
|
identityRecoveryPageBuilder: (_) =>
|
|
const SizedBox.shrink(),
|
|
)
|
|
: const SizedBox.shrink(),
|
|
),
|
|
),
|
|
),
|
|
),
|
|
);
|
|
await tester.pumpAndSettle();
|
|
final container = ProviderScope.containerOf(
|
|
tester.element(find.byType(SettingsPage)),
|
|
);
|
|
expect(
|
|
container.read(activeCommunityProvider).value?.pushNotificationsEnabled,
|
|
isTrue,
|
|
reason:
|
|
'${container.read(activeCommunityProvider)} / ${container.read(communityListProvider)}',
|
|
);
|
|
expect(session.leases.single['active'], isTrue);
|
|
// Capability discovery plus the active publication.
|
|
expect(discoveries, 2);
|
|
expect(tester.widget<Switch>(find.byType(Switch)).value, isTrue);
|
|
expect(
|
|
tester.getSemantics(
|
|
find.byKey(const ValueKey('push-notifications-setting')),
|
|
),
|
|
isSemantics(
|
|
label: 'Notifications',
|
|
hasToggledState: true,
|
|
isToggled: true,
|
|
),
|
|
);
|
|
expect(
|
|
tester.getSize(find.byType(Switch)).height,
|
|
greaterThanOrEqualTo(48),
|
|
);
|
|
// Compare rendered row bounds, not just their padding parameters.
|
|
final notificationHeight = tester
|
|
.getSize(find.byKey(const ValueKey('push-notifications-enabled')))
|
|
.height;
|
|
final statusHeight = tester
|
|
.getSize(find.byKey(const ValueKey('settings-set-status')))
|
|
.height;
|
|
expect(
|
|
notificationHeight,
|
|
statusHeight,
|
|
reason: 'single-line settings rows share a height',
|
|
);
|
|
await tester.tap(find.byType(Switch));
|
|
await tester.pumpAndSettle();
|
|
final stored = (await storage.loadAll()).single;
|
|
expect(stored.pushNotificationsEnabled, isFalse);
|
|
expect(
|
|
stored.pushSubscriptionState.pendingTombstoneGeneration,
|
|
outcome == 'failed' || outcome == 'pending'
|
|
? greaterThanOrEqualTo(9)
|
|
: isNull,
|
|
);
|
|
expect(tombstones.first, 9);
|
|
expect(
|
|
tombstones.length,
|
|
lessThanOrEqualTo(2),
|
|
reason: 'failed cleanup must not defeat the retry backoff',
|
|
);
|
|
expect(discoveries, 2);
|
|
session.setStatus(SessionStatus.disconnected);
|
|
await tester.pumpAndSettle();
|
|
session.setStatus(SessionStatus.connected);
|
|
await tester.pumpAndSettle();
|
|
expect(
|
|
session.leases.where((lease) => lease['active'] == true),
|
|
hasLength(1),
|
|
);
|
|
expect(discoveries, 3);
|
|
expect(snapshots.last.single.pushNotificationsEnabled, isFalse);
|
|
final offSwitch = tester.widget<Switch>(find.byType(Switch));
|
|
expect(offSwitch.value, isFalse);
|
|
expect(offSwitch.onChanged, isNotNull);
|
|
// Closing and reopening Settings must not strand the off control either.
|
|
showingSettings.value = false;
|
|
await tester.pumpAndSettle();
|
|
showingSettings.value = true;
|
|
await tester.pumpAndSettle();
|
|
expect(tester.widget<Switch>(find.byType(Switch)).onChanged, isNotNull);
|
|
await tester.tap(find.text('Notifications'));
|
|
await tester.pumpAndSettle();
|
|
expect(tester.widget<Switch>(find.byType(Switch)).value, isTrue);
|
|
expect((await storage.loadAll()).single.pushNotificationsEnabled, isTrue);
|
|
expect(
|
|
session.leases.where((lease) => lease['active'] == true).length,
|
|
2,
|
|
reason:
|
|
're-enabling must publish an active lease before the renewal timer',
|
|
);
|
|
expect(session.leases.last['generation'], greaterThan(tombstones.last!));
|
|
if (outcome == 'pending') {
|
|
cleanup.complete();
|
|
await tester.pumpAndSettle();
|
|
expect(
|
|
(await storage.loadAll()).single.pushNotificationsEnabled,
|
|
isTrue,
|
|
);
|
|
}
|
|
final latestLease = session.leases.reduce(
|
|
(a, b) => (a['generation'] as int) > (b['generation'] as int) ? a : b,
|
|
);
|
|
expect(
|
|
latestLease['active'],
|
|
isTrue,
|
|
reason: 'a delayed old tombstone cannot supersede the new active lease',
|
|
);
|
|
expect(discoveries, 4);
|
|
// A real reconnect must still discover capability again.
|
|
(container.read(relaySessionProvider.notifier) as _Connected).setStatus(
|
|
SessionStatus.disconnected,
|
|
);
|
|
await tester.pumpAndSettle();
|
|
expect(container.read(currentRelayPushDescriptorProvider).value, isNull);
|
|
(container.read(relaySessionProvider.notifier) as _Connected).setStatus(
|
|
SessionStatus.connected,
|
|
);
|
|
await tester.pumpAndSettle();
|
|
expect(discoveries, 5);
|
|
expect(tester.widget<Switch>(find.byType(Switch)).onChanged, isNotNull);
|
|
expect(tester.takeException(), isNull);
|
|
await tester.pumpWidget(const SizedBox.shrink());
|
|
await tester.pumpAndSettle();
|
|
semantics.dispose();
|
|
debugDefaultTargetPlatformOverride = null;
|
|
});
|
|
}
|
|
}
|
|
|
|
class _Lifecycle extends AppLifecycleNotifier {
|
|
@override
|
|
AppLifecycleState build() => AppLifecycleState.resumed;
|
|
}
|
|
|
|
class _Auth extends AuthNotifier {
|
|
@override
|
|
Future<AuthState> build() async =>
|
|
const AuthState(status: AuthStatus.unauthenticated);
|
|
}
|
|
|
|
class _Connected extends RelaySessionNotifier {
|
|
final leases = <Map<String, dynamic>>[];
|
|
|
|
@override
|
|
Future<NostrEvent> publish(
|
|
NostrEvent event, {
|
|
Duration timeout = const Duration(seconds: 8),
|
|
}) async {
|
|
expect(event.kind, buzzPushLeaseKind);
|
|
final plaintext = nip44Decrypt(
|
|
getConversationKey('2' * 64, event.pubkey),
|
|
event.content,
|
|
);
|
|
leases.add(jsonDecode(plaintext) as Map<String, dynamic>);
|
|
return event;
|
|
}
|
|
|
|
void setStatus(SessionStatus status) => state = SessionState(status: status);
|
|
|
|
@override
|
|
SessionState build() => const SessionState(status: SessionStatus.connected);
|
|
}
|
|
|
|
final _descriptor = BuzzPushLeaseDescriptor(
|
|
origin: 'wss://relay.example',
|
|
executorKeyId: 'relay-v1',
|
|
executorPubkey: nostr.Keys('2' * 64).public,
|
|
transport: 'apns',
|
|
maxLeaseTtlSeconds: 3600,
|
|
maxContentLength: 4096,
|
|
maxPlaintextLength: 4096,
|
|
maxEndpointLength: 2048,
|
|
maxStringLength: 512,
|
|
);
|