mirror of
https://github.com/block/buzz.git
synced 2026-10-27 04:30:52 +00:00
82656ffea0
🤖 ## Summary In the mobile app, anyone who hasn't set a display name shows up as a raw 64-character hex key (e.g. `3a5d4f9c…`) — unreadable, and unrecognizable as the same identity across screens. Profile and Settings also let you copy that raw hex. Nostr public keys have a standard readable form — `npub1…`, the same encoding other Nostr apps and our desktop app already display. This PR makes every mobile identity surface render npub instead: - **Unnamed people everywhere** — message and thread authors, reactions, typing indicators, member lists, channel details, DM headers and tiles, inbox, search, forum cards, Pulse notes and reply context, mention suggestions, and invite rows — now show a compact npub label: first 8 + last 4 characters of the full npub joined by an ellipsis (`npub1abcd…wxyz`), the same truncation desktop uses. Previously these showed truncated raw hex. - **DM fallback avatars and blank names** — 1:1 DM tiles and headers key their fallback avatar to the same non-self counterpart the label names, including self-first participant order; a self-DM keeps its hex-key-derived initial. Blank or whitespace-only display names fall back to the compact npub instead of rendering empty, while nonblank authored names render verbatim (padding included). - **Profile sheet → "Copy public key"** now copies the full canonical npub — never raw hex. When the identity string isn't a valid public key, the copy tile is disabled, so a malformed key never reaches the clipboard. - **Settings → Identity (pubkey)** displays and copies the full npub; an invalid identity reads "Identity unavailable" with copy disabled. - **Invalid identities never leak truncated raw hex** into the UI anywhere — they render a neutral "Unknown identity" label. - **Unchanged on purpose:** display names and verified handles (NIP-05 — the `name@domain` badge) still render as before. Unnamed avatars keep distinct per-key initials, derived from the underlying hex key rather than the npub — otherwise every unnamed key would render the same "N" initial. Event IDs are not public keys, so they keep their hex truncation (in Pulse's "Replying to", the parent author shows npub while an event-id fallback still shows hex). The nevent share link, private keys, and internal hex storage are untouched. Inputs that accept a key (invite/member entry) accept both hex and npub and keep working in hex internally. ### Related issue N/A. Searched open issues/PRs for npub identity display on mobile — closest related: none found. Desktop's parallel npub standardization lives in the stacked desktop PRs (#7488 foundation, #7489 controls, #7495 display surfaces); this is the independent mobile slice (based directly on `main`, not on those branches). ### Testing At exact head `5a620e420a1fd57d9d8011ac26434eed32fcf765` (base: `main` `44316ff72`; 40 files, +1,345/−154): - Full mobile suite: 2,098 tests passing (`cd mobile && flutter test`); `flutter analyze` clean; `dart format --set-exit-if-changed .` clean — the same checks CI runs. - Widget/unit coverage at production seams: compact labels and hex-keyed avatar initials for DM headers/tiles, member rows, mention suggestions, and Pulse reply context; DM fallback avatars keyed to the labeled counterpart (self-first order and self-DMs); blank/whitespace display-name npub fallback with nonblank authored labels verbatim, including the Activity inbox sender and profile-sheet heading (each with its own empty/whitespace production-seam regression); full-npub copy and disabled-copy semantics in profile and settings; invalid-key suppression; and hex↔npub input round-trips. Verified via unit and widget tests — no device/simulator validation is claimed. ### Task provenance Buzz channel: `1f0e4a3d-7e01-4efe-bb16-843b357f85c9` Task: buzz://message?channel=1f0e4a3d-7e01-4efe-bb16-843b357f85c9&id=86b34eb4bd84a1472419e9af22636c011c0fe273e3c196f967d7a36996e149b6 --------- Signed-off-by: Logan Johnson <loganj@squareup.com> Co-authored-by: Larry <627498bd4bd1f281a16431e3c6cce3b5c25b6692798c78672298aefbf2f8f8b5@buzz.block.builderlab.xyz>
64 lines
2.1 KiB
Dart
64 lines
2.1 KiB
Dart
import 'package:flutter/foundation.dart';
|
|
|
|
import '../utils/string_utils.dart';
|
|
|
|
@immutable
|
|
class UserProfile {
|
|
final String pubkey;
|
|
final String? displayName;
|
|
final String? avatarUrl;
|
|
final String? about;
|
|
final String? nip05Handle;
|
|
|
|
/// NIP-OA verified owner pubkey from the profile's `auth` tag; non-null
|
|
/// means this identity is an agent (mirrors desktop's `ownerPubkey`).
|
|
final String? ownerPubkey;
|
|
|
|
bool get isAgent => ownerPubkey != null;
|
|
|
|
const UserProfile({
|
|
required this.pubkey,
|
|
this.displayName,
|
|
this.avatarUrl,
|
|
this.about,
|
|
this.nip05Handle,
|
|
this.ownerPubkey,
|
|
});
|
|
|
|
factory UserProfile.fromJson(Map<String, dynamic> json) => UserProfile(
|
|
pubkey: json['pubkey'] as String,
|
|
displayName: json['display_name'] as String?,
|
|
avatarUrl: json['avatar_url'] as String?,
|
|
about: json['about'] as String?,
|
|
nip05Handle: json['nip05_handle'] as String?,
|
|
);
|
|
|
|
/// Short label: display name, or the compact npub form of the public key.
|
|
///
|
|
/// Blank display names (empty or whitespace-only) fall back to the compact
|
|
/// npub too — relay profiles can carry them — so a valid identity never
|
|
/// renders an empty label, like [initial]. Nonblank names render as
|
|
/// authored: trim only tests blankness, so authored padding survives
|
|
/// (unlike [initial], which reads the trimmed padding).
|
|
String get label {
|
|
final name = displayName;
|
|
return name != null && name.trim().isNotEmpty ? name : shortPubkey(pubkey);
|
|
}
|
|
|
|
/// First letter for fallback avatar.
|
|
String get initial {
|
|
final name = displayName?.trim();
|
|
if (name != null && name.isNotEmpty) return name[0].toUpperCase();
|
|
// Hex-derived (not npub-derived) so unnamed identities keep distinct
|
|
// initials instead of every npub rendering `N`.
|
|
return pubkey.isNotEmpty ? pubkey[0].toUpperCase() : '?';
|
|
}
|
|
}
|
|
|
|
/// Optional profile handle shown beside a message author's display name.
|
|
String? messageUsernameLabel(UserProfile? profile) {
|
|
final handle = profile?.nip05Handle?.trim();
|
|
if (handle != null && handle.isNotEmpty) return handle;
|
|
return null;
|
|
}
|