mirror of
https://github.com/block/buzz.git
synced 2026-11-04 16:31:38 +00:00
Organization relays that enforce NIP-FI (federated identity) require a `Nostr-Federated-Identity` assertion on `/query`. The iOS notification service extension signed its `/query` with NIP-98 only, so the relay answered `401` and every push from an enforcing organization relay showed the generic "You have a new message." body. The app already mints these assertions in Dart from its organization account session, but that session lives in the app's own keychain, and assertions last minutes, so a cached one is useless by the time a push arrives. This change lets the extension mint its own: - **App:** whenever the organization `BuilderlabAccountClient` adopts or clears its session, the app writes or deletes a device-only keychain item in the group it already shares with the extension. The item holds the organization origin, the session credential and the organization's exact relay hosts (from `BUZZ_ORGANIZATION_RELAYS`). Builds without an organization never write it. - **Extension:** for a community whose relay host is one of those exact hosts, `BuzzRelayAssertionIssuer` requests an assertion from the organization issuer (`/api/goose/v1/buzz/identity/assertions`, session credential plus NIP-98 with the community's account key, the same request the app makes), checks it was issued for that key, and caches it in-process until 30 seconds before expiry. Both `/query` paths (message lookup and sender/channel enrichment) send it. Other relays get no header and never see the session. - Signing out awaits removal of the shared copy and fails if removal fails; each restore that finds no session retries the removal. - If issuance fails or the user is signed out, the extension sends the query without the header and the relay refuses it, which keeps today's generic fallback. Not covered here: relay-hosted avatars on enforcing relays still load without the assertion (the notification text and title are unaffected), hosted Builderlab communities, and Android. ### Validation Added tests: - `testOrganizationRelayQueriesCarryMintedAssertion`: against a stub relay that answers `401` without the assertion, two organization pushes resolve with message body and sender name from a single issuance, a non-organization relay gets neither the header nor the session, and after sign-out the notification falls back. Removing the header from the query path makes this test fail. - `testOrganizationAssertionIssuanceFailuresSendNoHeader`: refused, wrong-key, expired and header-injection responses produce no header. Subdomains and other ports of the organization relay host are never sent the session. - `builderlab_account_test.dart`: the shared copy follows exchange, restore and clear; a failed removal fails sign-out, and the next restore retries it. Focused existing validation: the full BuzzPushKit suite, the hosted Dart tests, `flutter analyze`, and an iOS device build of the app and extension. Not yet validated: a live push from the Block relay on a device. ## Before merge Live device push test: waived by Tom (2026-11-03). 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Signed-off-by: Tom Brow <tomb@squareup.com> Co-authored-by: Tom Brow <tomb@squareup.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
312 lines
12 KiB
Swift
312 lines
12 KiB
Swift
import BuzzPushKit
|
|
import Foundation
|
|
import Intents
|
|
import Security
|
|
import UserNotifications
|
|
|
|
final class NotificationService: UNNotificationServiceExtension {
|
|
private var handoff: BuzzNotificationHandoff<UNNotificationContent>?
|
|
private var resolvedScope: BuzzNotificationCacheScope?
|
|
private var bestAttemptContent: UNMutableNotificationContent?
|
|
private var restrictedFallbackContent: UNMutableNotificationContent?
|
|
private lazy var interactionCleanup = BuzzInteractionCleanupRetry(
|
|
containerURL: ageRestrictionContainerURL, deletion: interactionDeletionDeadline)
|
|
private lazy var communicationPresenter = BuzzCommunicationNotificationPresenter(
|
|
donate: { interaction, completion in interaction.donate(completion: completion) },
|
|
deleteAllInteractions: { [cleanup = interactionCleanup] completion in
|
|
cleanup.request(completion: completion)
|
|
},
|
|
updateContent: { content, intent in try content.updating(from: intent) }
|
|
)
|
|
private let interactionDeletionDeadline = BuzzInteractionDeletionDeadline(
|
|
timeout: 5,
|
|
deleteAllInteractions: { completion in
|
|
INInteraction.deleteAll(completion: completion)
|
|
},
|
|
scheduleTimeout: { delay, action in
|
|
DispatchQueue.global(qos: .utility).asyncAfter(
|
|
deadline: .now() + delay,
|
|
execute: action
|
|
)
|
|
}
|
|
)
|
|
private lazy var appGroupIdentifier =
|
|
Bundle.main.object(
|
|
forInfoDictionaryKey: "BuzzAppGroupIdentifier"
|
|
) as? String
|
|
// A session per notification keeps a long-lived extension process from reusing
|
|
// connections that went stale when the network path changed (for example a VPN
|
|
// coming up or dropping).
|
|
private var session: URLSession?
|
|
private var resolver: BuzzPushNotificationResolving?
|
|
private func makeResolver(session: URLSession) -> BuzzPushNotificationResolving {
|
|
let keychainAccessGroup =
|
|
Bundle.main.object(
|
|
forInfoDictionaryKey: "BuzzKeychainAccessGroup"
|
|
) as? String
|
|
return BuzzPushNotificationResolver(
|
|
session: session,
|
|
loadCommunitiesData: { [self] in
|
|
Self.loadPushSnapshotData(appGroupIdentifier: self.appGroupIdentifier)
|
|
},
|
|
loadPrivateKey: { communityID in
|
|
Self.loadPrivateKey(
|
|
communityID: communityID,
|
|
keychainAccessGroup: keychainAccessGroup
|
|
)
|
|
},
|
|
notificationCache: notificationCache,
|
|
avatarLoader: notificationAvatarLoader,
|
|
assertionIssuer: Self.assertionIssuer
|
|
)
|
|
}
|
|
|
|
/// Process-wide, so consecutive notifications reuse an assertion until it nears expiry.
|
|
private static let assertionIssuer: BuzzRelayAssertionIssuer = {
|
|
let keychainAccessGroup =
|
|
Bundle.main.object(forInfoDictionaryKey: "BuzzKeychainAccessGroup") as? String
|
|
return BuzzRelayAssertionIssuer(
|
|
session: URLSession(configuration: .ephemeral),
|
|
loadSession: { loadOrganizationSession(keychainAccessGroup: keychainAccessGroup) }
|
|
)
|
|
}()
|
|
|
|
/// The organization account session the app shares for NIP-FI assertion issuance.
|
|
private static func loadOrganizationSession(
|
|
keychainAccessGroup: String?
|
|
) -> BuzzOrganizationSession? {
|
|
var query: [String: Any] = [
|
|
kSecClass as String: kSecClassGenericPassword,
|
|
kSecAttrService as String: BuzzOrganizationSession.keychainService,
|
|
kSecAttrAccount as String: BuzzOrganizationSession.keychainAccount,
|
|
kSecReturnData as String: true,
|
|
kSecMatchLimit as String: kSecMatchLimitOne,
|
|
]
|
|
if let keychainAccessGroup, !keychainAccessGroup.isEmpty {
|
|
query[kSecAttrAccessGroup as String] = keychainAccessGroup
|
|
}
|
|
var item: CFTypeRef?
|
|
guard SecItemCopyMatching(query as CFDictionary, &item) == errSecSuccess,
|
|
let data = item as? Data
|
|
else { return nil }
|
|
return try? JSONDecoder().decode(BuzzOrganizationSession.self, from: data)
|
|
}
|
|
|
|
private var notificationCacheRoot: URL? {
|
|
FileManager.default.urls(for: .cachesDirectory, in: .userDomainMask).first?
|
|
.appendingPathComponent("notification-enrichment-v1", isDirectory: true)
|
|
}
|
|
|
|
private lazy var notificationCache: BuzzNotificationCache? = {
|
|
guard let directory = notificationCacheRoot else { return nil }
|
|
let cache = BuzzNotificationCache(directory: directory, isCurrent: { [weak self] scope in
|
|
self?.isCurrent(scope) == true
|
|
})
|
|
let scopes = Self.communities(appGroupIdentifier: appGroupIdentifier)
|
|
.compactMap(BuzzNotificationCacheScope.init(community:))
|
|
do { try cache.removeRevokedScopes(keeping: scopes) }
|
|
catch { NSLog("Notification cache cleanup failed: %@", String(describing: error)) }
|
|
return cache
|
|
}()
|
|
|
|
private lazy var notificationAvatarLoader: BuzzNotificationAvatarLoader? = {
|
|
guard let directory = notificationCacheRoot else { return nil }
|
|
let accessGroup = Bundle.main.object(forInfoDictionaryKey: "BuzzKeychainAccessGroup") as? String
|
|
return BuzzNotificationAvatarLoader(directory: directory,
|
|
privateKey: { Self.loadPrivateKey(communityID: $0, keychainAccessGroup: accessGroup) },
|
|
isCurrent: { [weak self] in self?.isCurrent($0) == true })
|
|
}()
|
|
|
|
private func isCurrent(_ scope: BuzzNotificationCacheScope) -> Bool {
|
|
let accessGroup = Bundle.main.object(forInfoDictionaryKey: "BuzzKeychainAccessGroup") as? String
|
|
return Self.communities(appGroupIdentifier: appGroupIdentifier).contains {
|
|
BuzzNotificationCacheScope(community: $0) == scope
|
|
} && scope.matchesAccountKey(
|
|
Self.loadPrivateKey(communityID: scope.communityID, keychainAccessGroup: accessGroup))
|
|
}
|
|
|
|
private static func communities(appGroupIdentifier: String?) -> [PushLeaseCommunity] {
|
|
guard let data = loadPushSnapshotData(appGroupIdentifier: appGroupIdentifier),
|
|
let snapshot = try? JSONDecoder().decode(PushLeaseSnapshot.self, from: data)
|
|
else { return [] }
|
|
return snapshot.communities
|
|
}
|
|
|
|
override func didReceive(
|
|
_ request: UNNotificationRequest,
|
|
withContentHandler contentHandler: @escaping (UNNotificationContent) -> Void
|
|
) {
|
|
resolvedScope = nil
|
|
handoff = BuzzNotificationHandoff(handler: contentHandler)
|
|
guard let content = request.content.mutableCopy() as? UNMutableNotificationContent else {
|
|
finish(request.content)
|
|
return
|
|
}
|
|
// Workaround until https://github.com/block/buzz/pull/8431 lands.
|
|
if content.sound == nil { content.sound = .default }
|
|
// Shown if the relay can't be reached in time. The gateway's fixed body is meant
|
|
// to be replaced and reads like an instruction to the user.
|
|
content.body = "You have a new message."
|
|
restrictedFallbackContent = Self.restrictedFallback(from: content)
|
|
bestAttemptContent = content
|
|
var cleanUserInfo = content.userInfo
|
|
cleanUserInfo.removeValue(forKey: BuzzPushNavigationTarget.userInfoKey)
|
|
content.userInfo = cleanUserInfo
|
|
|
|
let session = URLSession(configuration: .ephemeral)
|
|
self.session = session
|
|
let resolver = makeResolver(session: session)
|
|
self.resolver = resolver
|
|
resolver.resolve { [weak self] resolution in
|
|
guard let self else { return }
|
|
if let resolution {
|
|
guard let scope = resolution.notificationScope, self.isCurrent(scope),
|
|
self.resolver?.isStillAuthorized() == true
|
|
else {
|
|
self.finish(Self.restrictedFallback(from: content))
|
|
return
|
|
}
|
|
self.resolvedScope = scope
|
|
content.title = resolution.title
|
|
content.body = resolution.body
|
|
if let subtitle = resolution.subtitle {
|
|
content.subtitle = subtitle
|
|
}
|
|
if let threadIdentifier = resolution.threadIdentifier {
|
|
content.threadIdentifier = threadIdentifier
|
|
}
|
|
if let navigationTarget = resolution.navigationTarget {
|
|
var userInfo = content.userInfo
|
|
userInfo[BuzzPushNavigationTarget.userInfoKey] = navigationTarget.userInfoValue
|
|
content.userInfo = userInfo
|
|
}
|
|
self.bestAttemptContent = content
|
|
self.communicationPresenter.present(
|
|
ordinaryContent: content,
|
|
resolution: resolution,
|
|
isStillAllowed: { [weak self] in
|
|
guard let self else { return false }
|
|
return self.isCurrent(scope) && self.resolver?.isStillAuthorized() == true
|
|
&& !self.isAgeRestricted()
|
|
},
|
|
onDeletionFailure: { error in
|
|
NSLog("Notification cleanup retry failed: %@", String(describing: error))
|
|
}
|
|
) { [weak self] specializedContent in
|
|
self?.finish(specializedContent)
|
|
}
|
|
return
|
|
}
|
|
self.finish(content)
|
|
}
|
|
}
|
|
|
|
override func serviceExtensionTimeWillExpire() {
|
|
if let bestAttemptContent {
|
|
finish(bestAttemptContent)
|
|
}
|
|
}
|
|
|
|
private func finish(_ content: UNNotificationContent) {
|
|
// Cancelling on expiry also stops a retry that is running or about to start.
|
|
resolver?.cancel()
|
|
session?.invalidateAndCancel()
|
|
session = nil
|
|
handoff?.finish(
|
|
resolvedScope.map { isCurrent($0) && resolver?.isStillAuthorized() != false } == false
|
|
? Self.restrictedFallback(from: content) : content,
|
|
restrictedFallback: restrictedFallbackContent ?? Self.restrictedFallback(from: content),
|
|
handoffIfAllowed: { deliver in
|
|
BuzzAgeRestrictionSession.handoffIfAllowed(
|
|
containerURL: ageRestrictionContainerURL, deliver: deliver)
|
|
}
|
|
) { [self] in
|
|
// The service deadline cannot wait for Intents cleanup. The safe content
|
|
// has already been handed back synchronously, including on expiration.
|
|
let center = UNUserNotificationCenter.current()
|
|
center.removeAllDeliveredNotifications()
|
|
center.removeAllPendingNotificationRequests()
|
|
interactionCleanup.request { error in
|
|
if error != nil { NSLog("Notification cleanup failed; age access is unchanged.") }
|
|
center.removeAllDeliveredNotifications()
|
|
center.removeAllPendingNotificationRequests()
|
|
}
|
|
}
|
|
}
|
|
|
|
private var ageRestrictionContainerURL: URL? {
|
|
appGroupIdentifier.flatMap {
|
|
FileManager.default.containerURL(forSecurityApplicationGroupIdentifier: $0)
|
|
}
|
|
}
|
|
|
|
private func isAgeRestricted() -> Bool {
|
|
BuzzAgeRestrictionSession.isRestricted(containerURL: ageRestrictionContainerURL)
|
|
}
|
|
|
|
private static func restrictedFallback(
|
|
from content: UNNotificationContent
|
|
) -> UNMutableNotificationContent {
|
|
let fallback =
|
|
(content.mutableCopy() as? UNMutableNotificationContent)
|
|
?? UNMutableNotificationContent()
|
|
fallback.title = "Buzz"
|
|
fallback.subtitle = ""
|
|
fallback.body = "Open Buzz to view this message."
|
|
fallback.threadIdentifier = ""
|
|
var userInfo = fallback.userInfo
|
|
userInfo.removeValue(forKey: BuzzPushNavigationTarget.userInfoKey)
|
|
fallback.userInfo = userInfo
|
|
return fallback
|
|
}
|
|
|
|
private static func loadPrivateKey(
|
|
communityID: String,
|
|
keychainAccessGroup: String?
|
|
) -> String? {
|
|
var query: [String: Any] = [
|
|
kSecClass as String: kSecClassGenericPassword,
|
|
kSecAttrService as String: "buzz.push.nse.signing",
|
|
kSecAttrAccount as String: communityID,
|
|
kSecReturnData as String: true,
|
|
kSecMatchLimit as String: kSecMatchLimitOne,
|
|
]
|
|
if let keychainAccessGroup, !keychainAccessGroup.isEmpty {
|
|
query[kSecAttrAccessGroup as String] = keychainAccessGroup
|
|
}
|
|
var item: CFTypeRef?
|
|
guard SecItemCopyMatching(query as CFDictionary, &item) == errSecSuccess,
|
|
let data = item as? Data
|
|
else { return nil }
|
|
return String(data: data, encoding: .utf8)
|
|
}
|
|
|
|
private static func loadPushSnapshotData(appGroupIdentifier: String?) -> Data? {
|
|
loadAppGroupData(
|
|
fileName: BuzzPushPresentationCacheStore.fileName,
|
|
appGroupIdentifier: appGroupIdentifier,
|
|
maximumBytes: BuzzPushPresentationCacheStore.maximumSnapshotBytes
|
|
)
|
|
}
|
|
|
|
private static func loadAppGroupData(
|
|
fileName: String,
|
|
appGroupIdentifier: String?,
|
|
maximumBytes: Int? = nil
|
|
) -> Data? {
|
|
guard let appGroupIdentifier,
|
|
let container = FileManager.default.containerURL(
|
|
forSecurityApplicationGroupIdentifier: appGroupIdentifier
|
|
)
|
|
else { return nil }
|
|
let fileURL = container.appendingPathComponent(fileName)
|
|
if let maximumBytes {
|
|
guard let values = try? fileURL.resourceValues(forKeys: [.fileSizeKey]),
|
|
let fileSize = values.fileSize,
|
|
fileSize <= maximumBytes
|
|
else { return nil }
|
|
}
|
|
return try? Data(contentsOf: fileURL)
|
|
}
|
|
}
|