buzz/desktop/src/features/agents/lib/instanceInputForDefinition.test.mjs

import assert from "node:assert/strict";
import test from "node:test";

import {
  availableRuntimesForStart,
  buildInstanceInputForDefinition,
  resolveStartRuntimeForDefinition,
} from "./instanceInputForDefinition.ts";

// ── Phase 1B.3.5: the single definition→instance mapping ────────────────────
//
// Every surface that starts an agent from a definition maps through
// buildInstanceInputForDefinition + resolveStartRuntimeForDefinition +
// availableRuntimesForStart. These tests pin the decided rows:
//   row 1: refuse (actionable error) when the configured runtime is missing
//   row 2: harnessOverride = !persona.runtime || persona.runtime === runtime.id
//   row 3: avatar through resolveManagedAgentAvatarUrl (injectable upload)
//   row 4: create input NEVER contains definition env vars
//   row 6: runtime list acquisition is refetch-aware

const gooseRuntime = {
  id: "goose",
  label: "Goose",
  avatarUrl: "https://runtime/goose.png",
  availability: "available",
  command: "goose-cmd",
  binaryPath: "/bin/goose",
  defaultArgs: ["--acp"],
  mcpCommand: "goose-mcp",
  installHint: "",
  installInstructionsUrl: "",
  canAutoInstall: false,
  underlyingCliPath: null,
};

const claudeRuntime = {
  ...gooseRuntime,
  id: "claude",
  label: "Claude",
  command: "claude-cmd",
  mcpCommand: null,
};

const buzzAgentRuntime = {
  ...gooseRuntime,
  id: "buzz-agent",
  label: "Buzz Agent",
  command: "buzz-agent-cmd",
  mcpCommand: null,
};

function persona(overrides = {}) {
  return {
    id: "p-1",
    displayName: "Test Agent",
    systemPrompt: "prompt",
    model: null,
    runtime: "goose",
    avatarUrl: "https://example.com/a.png",
    envVars: { ANTHROPIC_API_KEY: "persona-secret" },
    isBuiltIn: false,
    ...overrides,
  };
}

test("row 4: create input never contains definition env vars", async () => {
  const input = await buildInstanceInputForDefinition(persona(), gooseRuntime);
  assert.equal(
    "envVars" in input,
    false,
    "definition env must never be seeded into the create input — " +
      "record.env_vars is overrides-only and spawn merges the live definition env",
  );
});

test("row 2: harnessOverride follows the backend-aligned formula", async () => {
  const match = await buildInstanceInputForDefinition(
    persona({ runtime: "goose" }),
    gooseRuntime,
  );
  assert.equal(match.harnessOverride, true, "picked == configured → true");

  const noPreference = await buildInstanceInputForDefinition(
    persona({ runtime: undefined }),
    gooseRuntime,
  );
  assert.equal(noPreference.harnessOverride, true, "no preference → true");

  const differs = await buildInstanceInputForDefinition(
    persona({ runtime: "claude" }),
    gooseRuntime,
  );
  assert.equal(
    differs.harnessOverride,
    false,
    "picked != configured → false (definition stays authoritative)",
  );
});

test("row 3: plain avatar URLs pass through; base64 data URIs upload via the injectable", async () => {
  const plain = await buildInstanceInputForDefinition(persona(), gooseRuntime);
  assert.equal(plain.avatarUrl, "https://example.com/a.png");

  const uploads = [];
  const uploaded = await buildInstanceInputForDefinition(
    persona({ avatarUrl: "data:image/png;base64,aGk=" }),
    gooseRuntime,
    async (bytes) => {
      uploads.push(bytes);
      return {
        url: "https://cdn/blob.png",
        sha256: "x",
        size: 2,
        type: "image/png",
        uploaded: 0,
      };
    },
  );
  assert.equal(uploaded.avatarUrl, "https://cdn/blob.png");
  assert.equal(uploads.length, 1, "upload must go through the injected fn");
});

test("row 3: failed persona avatar upload never substitutes the runtime avatar", async () => {
  const input = await buildInstanceInputForDefinition(
    persona({
      id: "builtin:fizz",
      displayName: "Fizz",
      avatarUrl: "data:image/png;base64,aGk=",
    }),
    claudeRuntime,
    async () => {
      throw new Error("upload failed");
    },
  );

  assert.equal(input.avatarUrl, undefined);
  assert.notEqual(input.avatarUrl, claudeRuntime.avatarUrl);
});

test("mapping carries the runtime and definition fields", async () => {
  const input = await buildInstanceInputForDefinition(persona(), gooseRuntime);
  assert.equal(input.name, "Test Agent");
  assert.equal(input.acpCommand, "buzz-acp");
  assert.equal(input.agentCommand, "goose-cmd");
  // B-5: agentArgs is intentionally empty at create time — spawn reads args
  // live from the definition on every start so definition edits take effect
  // without recreating the agent. Seeding from runtime.defaultArgs here would
  // freeze args at create-time and silently ignore later definition edits.
  assert.deepEqual(input.agentArgs, []);
  assert.equal(input.mcpCommand, "goose-mcp");
  assert.equal(input.personaId, "p-1");
  assert.equal(input.systemPrompt, "prompt");
  assert.equal(input.model, undefined);
  assert.equal(input.provider, undefined);
  assert.equal(input.spawnAfterCreate, true);
  assert.equal(input.startOnAppLaunch, true);
  assert.deepEqual(input.backend, { type: "local" });
});

test("no backend intent is byte-identical to the pre-intent mapping", async () => {
  // The 3 pre-B5 call sites (useManagedAgentActions, usePersonaActions,
  // UserProfilePanel) pass no intent; their output must not move.
  // B-5: agentArgs is [] — args are NOT seeded from the definition at create
  // time. Spawn reads live args from the definition on every start.
  const input = await buildInstanceInputForDefinition(persona(), gooseRuntime);
  assert.deepEqual(input, {
    name: "Test Agent",
    personaId: "p-1",
    systemPrompt: "prompt",
    avatarUrl: "https://example.com/a.png",
    acpCommand: "buzz-acp",
    agentCommand: "goose-cmd",
    agentArgs: [],
    mcpCommand: "goose-mcp",
    harnessOverride: true,
    model: undefined,
    provider: undefined,
    spawnAfterCreate: true,
    startOnAppLaunch: true,
    backend: { type: "local" },
  });
});

test("Buzz shared compute definition carries native provider and auto model", async () => {
  const input = await buildInstanceInputForDefinition(
    persona({
      runtime: "buzz-agent",
      provider: "relay-mesh",
      model: "auto",
    }),
    { ...gooseRuntime, id: "buzz-agent", command: "buzz-agent" },
  );
  assert.equal(input.agentCommand, "buzz-agent");
  assert.equal(input.provider, "relay-mesh");
  assert.equal(input.model, "auto");
  assert.equal(input.spawnAfterCreate, true);
  assert.equal(input.startOnAppLaunch, true);
});

test("provider intent forces startOnAppLaunch off and omits local commands", async () => {
  const input = await buildInstanceInputForDefinition(
    persona(),
    gooseRuntime,
    undefined,
    { type: "provider", id: "blox", config: { region: "us" } },
  );
  assert.deepEqual(input.backend, {
    type: "provider",
    id: "blox",
    config: { region: "us" },
  });
  assert.equal(input.startOnAppLaunch, false, "remote agents never auto-start");
  assert.equal(input.spawnAfterCreate, true);
  assert.equal(input.harnessOverride, false);
  // Provider agents spawn no local ACP — the legacy provider branch omitted
  // all local commands and model/provider, and so does the intent path.
  for (const key of [
    "acpCommand",
    "agentCommand",
    "agentArgs",
    "mcpCommand",
    "model",
    "provider",
    "envVars",
    "relayMesh",
  ]) {
    assert.equal(key in input, false, `provider intent must omit ${key}`);
  }
  assert.equal(input.personaId, "p-1", "definition link is kept");
  assert.equal(input.systemPrompt, "prompt");
});

test("row 1: refuses when the configured runtime is not available", () => {
  assert.throws(
    () =>
      resolveStartRuntimeForDefinition(persona({ runtime: "missing" }), [
        gooseRuntime,
        claudeRuntime,
      ]),
    /not available|No available runtime/i,
    "configured-but-missing runtime must refuse, never silently fall back",
  );
});

test("row 1: resolves the configured runtime when available", () => {
  const { runtime, warnings } = resolveStartRuntimeForDefinition(
    persona({ runtime: "claude" }),
    [gooseRuntime, claudeRuntime],
  );
  assert.equal(runtime.id, "claude");
  assert.deepEqual(warnings, []);
});

test("row 1: no preference resolves the default with no warnings", () => {
  const { runtime, warnings } = resolveStartRuntimeForDefinition(
    persona({ runtime: undefined }),
    [gooseRuntime, claudeRuntime],
  );
  assert.equal(runtime.id, "goose");
  assert.deepEqual(warnings, []);
});

test("row 1: refuses when no runtimes exist at all", () => {
  assert.throws(
    () => resolveStartRuntimeForDefinition(persona({ runtime: undefined }), []),
    /No available runtime/,
  );
});

test("row 6: fetched query uses cached data without refetching", async () => {
  let refetched = false;
  const runtimes = await availableRuntimesForStart({
    isFetched: true,
    data: [gooseRuntime, { ...claudeRuntime, availability: "missing" }],
    refetch: async () => {
      refetched = true;
      return { data: [] };
    },
  });
  assert.equal(refetched, false);
  assert.deepEqual(
    runtimes.map((r) => r.id),
    ["goose"],
    "unavailable runtimes are filtered out",
  );
});

test("row 6: unfetched query refetches instead of resolving empty", async () => {
  const runtimes = await availableRuntimesForStart({
    isFetched: false,
    data: undefined,
    refetch: async () => ({ data: [claudeRuntime] }),
  });
  assert.deepEqual(
    runtimes.map((r) => r.id),
    ["claude"],
    "an unfetched query must fetch, not spuriously report no runtimes",
  );
});

// ── item-13 regression: buzz-agent-first default runtime ─────────────────────
//
// Before this fix, resolveStartRuntimeForDefinition used runtimes[0] (catalog
// order: goose, claude, codex, buzz-agent), so an installed goose would beat
// the bundled buzz-agent sidecar as the default for runtime-less personas.
// The fix applies the preference order: buzz-agent → goose → first available.

test("item-13: goose+buzz-agent both available — persona with no runtime resolves buzz-agent", () => {
  const { runtime, warnings } = resolveStartRuntimeForDefinition(
    persona({ runtime: undefined }),
    [gooseRuntime, claudeRuntime, buzzAgentRuntime],
  );
  assert.equal(
    runtime.id,
    "buzz-agent",
    "buzz-agent must win over catalog-first goose for runtime-less personas",
  );
  assert.deepEqual(warnings, []);
});

test("item-13: goose-only available — persona with no runtime resolves goose", () => {
  const { runtime, warnings } = resolveStartRuntimeForDefinition(
    persona({ runtime: undefined }),
    [gooseRuntime, claudeRuntime],
  );
  assert.equal(runtime.id, "goose");
  assert.deepEqual(warnings, []);
});

test("item-13: no runtimes available — refuses with actionable error", () => {
  assert.throws(
    () => resolveStartRuntimeForDefinition(persona({ runtime: undefined }), []),
    /No available runtime/,
    "empty runtime list must throw, not silently return null",
  );
});