mirror of
https://github.com/block/buzz.git
synced 2026-11-12 20:31:12 +00:00
c7624cb41f
Review round on the lazy flip (Wren + Max, independently): the source-contract test only scanned direct spawn_agent_child call sites, so mutating a start_pair caller from true to false reintroduced eager init for a real Desktop flow while the test stayed green — the guard was narrower than the invariant it claimed. Both reviewers converged on the same best fix: delete the boolean seam instead of widening the parser. spawn_agent_child now writes BUZZ_ACP_LAZY_POOL=true unconditionally (with the full rationale at the write site), and the lazy parameter is gone from spawn_agent_child and start_pair — there are no legitimate eager Desktop callers, so the regression Max mutated into existence can no longer be expressed. The 70-line window scanner shrinks to spawn_lazy_pool_env_is_unconditional: the env write must be exactly one unconditional literal. Mutation-verified: making the write conditional reds the test; restored green. Co-authored-by: Tyler Longwell <tlongwell@block.xyz> Signed-off-by: Tyler Longwell <tlongwell@block.xyz>