mirror of
https://github.com/block/buzz.git
synced 2026-10-31 14:31:02 +00:00
Follow-up to #8650. This addresses the items from the [second-pass review](https://github.com/block/buzz/pull/8650#pullrequestreview-5700660448), which arrived after #8650 merged. - **Setting menu semantics.** Options in the shared `BuzzSettingMenu` (model, reasoning effort, and channel TTL) expose their checked state again. The trigger is announced as a button with enabled and expanded state, so a disabled "Reasoning effort" no longer reads as plain text. The `PopupMenuButton` this menu replaced also provided a named route and a "Dismiss menu" action. `MenuAnchor` does not provide them, so this PR does not restore them. - **Remote listing failures.** "Could not load agents" for a failed Builderlab listing now appears only in communities that support remote agents. For example, it no longer appears in a non-hosted community while signed in. - **Add agent during a community reload.** No change needed here. #8693 already disables Add while the page has no community. ### Validation - Added tests: setting-menu checked, button, enabled and expanded semantics; a failed remote listing stays hidden where remote agents are off. Both fail without these changes. - Mobile analysis is clean, and the Agents and shared widget tests pass locally after rebasing onto #8693. - Not covered: VoiceOver on a device. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Signed-off-by: Tom Brow <tomb@block.xyz> Co-authored-by: studio <dc2fc481343672df31a689840c09299972e704dac592e0da6f18486646a7ee3e@sprout-oss.stage.blox.sqprod.co>
175 lines
6.3 KiB
Dart
175 lines
6.3 KiB
Dart
import 'package:flutter/material.dart';
|
|
|
|
import '../theme/buzz_icons.dart';
|
|
import '../theme/theme.dart';
|
|
import 'anchored_popover_menu.dart';
|
|
|
|
/// One choice in a [BuzzSettingMenu].
|
|
class BuzzSettingMenuOption<T> {
|
|
final Key? key;
|
|
final String label;
|
|
final T value;
|
|
|
|
const BuzzSettingMenuOption({
|
|
this.key,
|
|
required this.label,
|
|
required this.value,
|
|
});
|
|
}
|
|
|
|
/// A bordered settings row showing its current value, opening a checked menu.
|
|
class BuzzSettingMenu<T> extends StatelessWidget {
|
|
final Key controlKey;
|
|
final bool enabled;
|
|
final String label;
|
|
final ValueChanged<T> onSelected;
|
|
final List<BuzzSettingMenuOption<T>> options;
|
|
final T? value;
|
|
final IconData? valueIcon;
|
|
final String valueLabel;
|
|
|
|
const BuzzSettingMenu({
|
|
super.key,
|
|
required this.controlKey,
|
|
required this.enabled,
|
|
required this.label,
|
|
required this.onSelected,
|
|
required this.options,
|
|
required this.value,
|
|
this.valueIcon,
|
|
required this.valueLabel,
|
|
});
|
|
|
|
@override
|
|
Widget build(BuildContext context) {
|
|
final shape = RoundedRectangleBorder(
|
|
side: BorderSide(color: context.colors.outlineVariant),
|
|
borderRadius: BorderRadius.circular(Radii.container),
|
|
);
|
|
// The menu spans the row, like Material's dropdown menus.
|
|
return LayoutBuilder(
|
|
builder: (context, constraints) => MenuAnchor(
|
|
alignmentOffset: const Offset(0, Grid.half),
|
|
// Match the app's shared popover surface.
|
|
style: MenuStyle(
|
|
shape: WidgetStatePropertyAll(appPopoverShape(context)),
|
|
backgroundColor: WidgetStatePropertyAll(appPopoverColor(context)),
|
|
shadowColor: WidgetStatePropertyAll(appPopoverShadowColor(context)),
|
|
elevation: const WidgetStatePropertyAll(appPopoverElevation),
|
|
padding: const WidgetStatePropertyAll(
|
|
EdgeInsets.symmetric(vertical: Grid.half),
|
|
),
|
|
),
|
|
menuChildren: [
|
|
for (final option in options)
|
|
// The check icon carries no semantics, so mark the selection on
|
|
// the item's own node.
|
|
MergeSemantics(
|
|
child: Semantics(
|
|
checked: option.value == value,
|
|
inMutuallyExclusiveGroup: true,
|
|
child: MenuItemButton(
|
|
key: option.key,
|
|
onPressed: () => onSelected(option.value),
|
|
style: MenuItemButton.styleFrom(
|
|
padding: const EdgeInsets.symmetric(
|
|
horizontal: Grid.twelve,
|
|
),
|
|
),
|
|
// A trailing check keeps labels flush with the menu's edge.
|
|
trailingIcon: option.value == value
|
|
? Icon(
|
|
Icons.check,
|
|
size: 20,
|
|
color: context.colors.primary,
|
|
)
|
|
: const SizedBox(width: 20),
|
|
// Root menu panels ignore size styles and shrink-wrap their items,
|
|
// so the label sets the width: the row's, less the item's padding,
|
|
// the check and the gap before it.
|
|
child: SizedBox(
|
|
width: constraints.maxWidth - Grid.twelve * 3 - 20,
|
|
child: Text(option.label),
|
|
),
|
|
),
|
|
),
|
|
),
|
|
],
|
|
builder: (context, menu, _) => Semantics(
|
|
button: true,
|
|
enabled: enabled,
|
|
expanded: menu.isOpen,
|
|
child: Tooltip(
|
|
message: '$label: $valueLabel',
|
|
// Draw on an ink surface so the tap ripple shows inside the border.
|
|
child: Material(
|
|
color: context.colors.surface,
|
|
shape: shape,
|
|
clipBehavior: Clip.antiAlias,
|
|
child: InkWell(
|
|
onTap: enabled
|
|
? () {
|
|
if (menu.isOpen) return menu.close();
|
|
// Drop the keyboard so it can't cover the menu.
|
|
FocusManager.instance.primaryFocus?.unfocus();
|
|
menu.open();
|
|
}
|
|
: null,
|
|
child: Padding(
|
|
key: controlKey,
|
|
padding: const EdgeInsets.symmetric(
|
|
horizontal: Grid.twelve,
|
|
vertical: Grid.xs,
|
|
),
|
|
child: Opacity(
|
|
opacity: enabled ? 1 : 0.5,
|
|
child: Row(
|
|
children: [
|
|
Expanded(
|
|
child: Text(
|
|
label,
|
|
style: context.textTheme.labelLarge?.copyWith(
|
|
color: context.colors.onSurface,
|
|
fontWeight: FontWeight.w600,
|
|
),
|
|
),
|
|
),
|
|
if (valueIcon case final icon?) ...[
|
|
Icon(
|
|
icon,
|
|
size: 16,
|
|
color: context.colors.onSurfaceVariant,
|
|
),
|
|
const SizedBox(width: Grid.half),
|
|
],
|
|
// Long values truncate instead of squeezing the label.
|
|
ConstrainedBox(
|
|
constraints: const BoxConstraints(maxWidth: 180),
|
|
child: Text(
|
|
valueLabel,
|
|
overflow: TextOverflow.ellipsis,
|
|
style: context.textTheme.bodyMedium?.copyWith(
|
|
color: context.colors.onSurface,
|
|
fontWeight: FontWeight.w500,
|
|
),
|
|
),
|
|
),
|
|
const SizedBox(width: Grid.half),
|
|
Icon(
|
|
BuzzIcons.chevronDown,
|
|
size: 16,
|
|
color: context.colors.onSurfaceVariant,
|
|
),
|
|
],
|
|
),
|
|
),
|
|
),
|
|
),
|
|
),
|
|
),
|
|
),
|
|
),
|
|
);
|
|
}
|
|
}
|