jerry/buzz

mirror of https://github.com/block/buzz.git synced 2026-11-05 00:41:28 +00:00

Files

Duncan d7b3b9948e fix(agents): address Thufir pass-3 review findings (IMPORTANT 1, 2, 3)

IMPORTANT 1 — set_persona_shared now calls refresh_team_catalog_heads_for_persona
after a successful publication, matching the post-save contract of
update_persona_and_publish. Before this fix, the publish-retry seam left every
shared 30178 containing the persona stale until restart.

Added a regression (test_publish_retry_seam_refreshes_affected_shared_team_head
in commands/teams/pending/tests.rs) proving the seam mechanism updates a shared
30178 head after a persona edit.

IMPORTANT 2 — removed the false 'it will be retried automatically' promise from
both terminal branches in agentSaveCoordinator.ts. A thrown publishRetry failure
means preparation failed before retain_event, so no durable pending row exists
and automatic retry is not guaranteed. New honest terminal copy: 'Reopen the
editor and save again to retry publishing.' Updated family-10/11 test assertions
to positively pin the corrected copy and explicitly reject the automatic-retry claim.

IMPORTANT 3 — added two mounted regressions in agentEditMergedInstanceNameGate.test.mjs
proving Save is disabled after clearing the visible instance name for unpooled and
pooled instances. Thufir's prescribed mutation (replace instanceName.trim().length > 0
with true in canSubmit) turns both tests RED before/2 after/0.

Co-authored-by: Will Pfleger <pfleger.will@gmail.com>
Signed-off-by: Will Pfleger <pfleger.will@gmail.com>

2026-08-29 15:57:51 -04:00