mirror of
https://github.com/block/buzz.git
synced 2026-10-28 04:51:40 +00:00
## Summary - Stop replaying the selected-agent pulse when a remembered agent remains addressed across a send. - Preserve the existing pulse for genuine selections and shake feedback for failed sends. ### Related issue Reported in Buzz: buzz://message?channel=2745947d-f905-4f31-8a3f-fc4485d3c36c&id=0cffab376186be9cc4e7f29027352cc1c7941aead48b3fed948f36181f4a59af ### Testing - `cd desktop && pnpm test` (5,556 passed) - `cd desktop && pnpm typecheck` - `cd desktop && pnpm check` - `cd desktop && pnpm build:e2e` - `cd desktop && pnpm exec playwright test tests/e2e/persistent-agent-audience.spec.ts --grep 'always-mentioned agents remain selected|failed always-mentioned send'` (2 passed) This changes animation timing only; the regression is covered by Playwright assertions on the pulse and shake versions, while a static screenshot is unchanged. Signed-off-by: Matt Toohey <contact@matttoohey.com>
868 lines
28 KiB
TypeScript
868 lines
28 KiB
TypeScript
import { expect, test, type Locator, type Page } from "@playwright/test";
|
|
|
|
import { waitForAnimations } from "../helpers/animations";
|
|
import { installMockBridge } from "../helpers/bridge";
|
|
|
|
const SHOTS = "test-results/persistent-agent-audience";
|
|
const CHANNEL_ID = "9a1657ac-f7aa-5db0-b632-d8bbeb6dfb50";
|
|
const AGENT_A = "a".repeat(64);
|
|
const AGENT_B = "b".repeat(64);
|
|
const THREAD_ROOT_ID = "mock-general-welcome";
|
|
const KEEP_MENTIONED_AGENTS_PINNED_STORAGE_KEY =
|
|
"buzz.messages.keepMentionedAgentsPinned";
|
|
|
|
test.beforeEach(async ({ page }) => {
|
|
await page.addInitScript((storageKey) => {
|
|
window.localStorage.removeItem(storageKey);
|
|
}, KEEP_MENTIONED_AGENTS_PINNED_STORAGE_KEY);
|
|
});
|
|
|
|
async function keepMentionedAgentsPinned(page: Page) {
|
|
await page.addInitScript((storageKey) => {
|
|
window.localStorage.setItem(storageKey, "true");
|
|
}, KEEP_MENTIONED_AGENTS_PINNED_STORAGE_KEY);
|
|
}
|
|
|
|
async function seedTheme(page: Page, theme: string, accent = "#c0a2f1") {
|
|
await page.addInitScript(
|
|
({ selectedTheme, selectedAccent }) => {
|
|
window.localStorage.setItem("buzz-theme", selectedTheme);
|
|
window.localStorage.setItem("buzz-accent-color", selectedAccent);
|
|
},
|
|
{ selectedTheme: theme, selectedAccent: accent },
|
|
);
|
|
}
|
|
|
|
async function automaticallyMention(
|
|
composer: ReturnType<typeof channelComposer>,
|
|
displayName: string,
|
|
) {
|
|
await composer.locator("[data-mention-picker-trigger]").click();
|
|
await composer
|
|
.getByTestId("mention-autocomplete")
|
|
.getByRole("button", { name: `Automatically mention ${displayName}` })
|
|
.click();
|
|
await expect(composer.getByTestId("message-input")).toContainText(
|
|
`@${displayName}`,
|
|
);
|
|
await composer.locator("[data-mention-picker-trigger]").click();
|
|
}
|
|
|
|
async function openGeneral(page: Page) {
|
|
await page.goto(`/#/channels/${CHANNEL_ID}`, {
|
|
waitUntil: "domcontentloaded",
|
|
});
|
|
await expect(page.getByTestId("chat-title")).toHaveText("general");
|
|
}
|
|
|
|
async function openThread(page: Page, threadRootId = THREAD_ROOT_ID) {
|
|
await page.goto(
|
|
`/#/channels/${CHANNEL_ID}?messageId=${threadRootId}&thread=${threadRootId}`,
|
|
{ waitUntil: "domcontentloaded" },
|
|
);
|
|
await expect(page.getByTestId("message-thread-panel")).toBeVisible();
|
|
}
|
|
|
|
function channelComposer(page: Page) {
|
|
return page.getByTestId("channel-composer-overlay");
|
|
}
|
|
|
|
function threadComposer(page: Page) {
|
|
return page.getByTestId("thread-composer-overlay");
|
|
}
|
|
|
|
async function readComposerCaret(input: Locator) {
|
|
return input.evaluate((element) => {
|
|
const selection = window.getSelection();
|
|
if (!selection?.anchorNode || !element.contains(selection.anchorNode)) {
|
|
return null;
|
|
}
|
|
const range = document.createRange();
|
|
range.selectNodeContents(element);
|
|
range.setEnd(selection.anchorNode, selection.anchorOffset);
|
|
return range.toString().length;
|
|
});
|
|
}
|
|
|
|
async function pressPrimaryShift(page: Page, key: "M") {
|
|
const isMac = await page.evaluate(() =>
|
|
/mac|iphone|ipad|ipod/i.test(navigator.platform),
|
|
);
|
|
await page.keyboard.press(`${isMac ? "Meta" : "Control"}+Shift+${key}`);
|
|
}
|
|
|
|
async function readOutgoingMentionPubkeys(page: Page, content: string) {
|
|
return page.evaluate((expectedContent) => {
|
|
const signedEvent = window.__BUZZ_E2E_SIGNED_EVENTS__?.find(
|
|
(event) => event.content === expectedContent,
|
|
);
|
|
if (signedEvent) {
|
|
return (signedEvent.tags ?? [])
|
|
.filter((tag) => tag[0] === "p" && tag[1])
|
|
.map((tag) => tag[1]);
|
|
}
|
|
|
|
for (const entry of window.__BUZZ_E2E_COMMAND_LOG__ ?? []) {
|
|
if (entry.command === "send_channel_message") {
|
|
const payload = entry.payload as
|
|
| { content?: string; mentionPubkeys?: string[] }
|
|
| undefined;
|
|
if (payload?.content === expectedContent) {
|
|
return payload.mentionPubkeys ?? [];
|
|
}
|
|
}
|
|
|
|
if (entry.command !== "plugin:websocket|send") continue;
|
|
const data = (
|
|
entry.payload as { message?: { data?: string } } | undefined
|
|
)?.message?.data;
|
|
if (!data) continue;
|
|
|
|
try {
|
|
const frame = JSON.parse(data) as [
|
|
string,
|
|
{ content?: string; tags?: string[][] },
|
|
];
|
|
if (frame[0] !== "EVENT" || frame[1]?.content !== expectedContent) {
|
|
continue;
|
|
}
|
|
return (frame[1].tags ?? [])
|
|
.filter((tag) => tag[0] === "p" && tag[1])
|
|
.map((tag) => tag[1]);
|
|
} catch {}
|
|
}
|
|
|
|
return null;
|
|
}, content);
|
|
}
|
|
|
|
async function emitMockMessage(
|
|
page: Page,
|
|
content: string,
|
|
mentionPubkeys: string[],
|
|
) {
|
|
await page.evaluate(
|
|
({ body, mentions }) => {
|
|
window.__BUZZ_E2E_EMIT_MOCK_MESSAGE__?.({
|
|
channelName: "general",
|
|
content: body,
|
|
mentionPubkeys: mentions,
|
|
});
|
|
},
|
|
{ body: content, mentions: mentionPubkeys },
|
|
);
|
|
}
|
|
|
|
async function installAudienceFixtures(
|
|
page: Page,
|
|
options: {
|
|
deferredComposerUploads?: boolean;
|
|
sendMessageDelayMs?: number;
|
|
sendMessageErrors?: string[];
|
|
uploadDelayMs?: number;
|
|
uploadDescriptors?: Array<{
|
|
filename: string;
|
|
sha256: string;
|
|
size: number;
|
|
type: string;
|
|
uploaded: number;
|
|
url: string;
|
|
}>;
|
|
usersBatchDelayMs?: number;
|
|
} = {},
|
|
) {
|
|
await installMockBridge(page, {
|
|
...options,
|
|
managedAgents: [
|
|
{
|
|
pubkey: AGENT_A,
|
|
name: "Morgarita",
|
|
status: "running",
|
|
channelNames: ["general"],
|
|
},
|
|
{
|
|
pubkey: AGENT_B,
|
|
name: "Vogue",
|
|
status: "running",
|
|
channelNames: ["general"],
|
|
},
|
|
],
|
|
});
|
|
}
|
|
|
|
test("keeps a queued-attachment send locked through upload and send settlement", async ({
|
|
page,
|
|
}) => {
|
|
await installAudienceFixtures(page, {
|
|
deferredComposerUploads: true,
|
|
uploadDelayMs: 2_000,
|
|
sendMessageDelayMs: 2_000,
|
|
uploadDescriptors: [
|
|
{
|
|
filename: "delayed-video.mp4",
|
|
sha256: "d".repeat(64),
|
|
size: 16,
|
|
type: "video/mp4",
|
|
uploaded: 1,
|
|
url: `https://mock.relay/media/${"d".repeat(64)}.mp4`,
|
|
},
|
|
],
|
|
});
|
|
await openGeneral(page);
|
|
|
|
const composer = channelComposer(page);
|
|
const composerForm = composer.getByTestId("message-composer");
|
|
const input = composer.getByTestId("message-input");
|
|
await input.fill("delayed upload");
|
|
|
|
const [chooser] = await Promise.all([
|
|
page.waitForEvent("filechooser"),
|
|
composer.getByRole("button", { name: "Attach file" }).click(),
|
|
]);
|
|
await chooser.setFiles({
|
|
buffer: Buffer.from("delayed video"),
|
|
mimeType: "video/mp4",
|
|
name: "delayed-video.mp4",
|
|
});
|
|
|
|
const sendAttempts = () =>
|
|
page.evaluate(
|
|
() =>
|
|
window.__BUZZ_E2E_COMMAND_LOG__?.filter(
|
|
(entry) => entry.command === "send_channel_message",
|
|
).length ?? 0,
|
|
);
|
|
const sendAttemptsBefore = await sendAttempts();
|
|
await input.press("Enter");
|
|
await expect(composer.getByTestId("composer-upload-progress")).toBeVisible();
|
|
|
|
// Observe the synchronous lock itself after upload has started. The exact
|
|
// premature-release mutation (`void uploadSettled; await Promise.resolve()`)
|
|
// has already cleared this attribute by this boundary, before any retryable
|
|
// downstream command or restored-audience timing can obscure the defect.
|
|
await expect(composerForm).toHaveAttribute("data-submit-locked", "true");
|
|
await input.press("Enter");
|
|
await input.press("Enter");
|
|
await expect(composerForm).toHaveAttribute("data-submit-locked", "true");
|
|
|
|
await expect.poll(sendAttempts).toBe(sendAttemptsBefore + 1);
|
|
|
|
// Command entry marks the independently delayed finishSend() window. Keep
|
|
// the synchronous lock held and fence repeated submits until it settles.
|
|
await expect(composer.getByTestId("composer-upload-progress")).toBeVisible();
|
|
await expect(composerForm).toHaveAttribute("data-submit-locked", "true");
|
|
await input.press("Enter");
|
|
await input.press("Enter");
|
|
await expect(composerForm).toHaveAttribute("data-submit-locked", "true");
|
|
|
|
await expect(
|
|
page
|
|
.getByTestId("message-row")
|
|
.filter({ hasText: "delayed upload" })
|
|
.last(),
|
|
).toBeVisible({ timeout: 5_000 });
|
|
await expect(composerForm).toHaveAttribute("data-submit-locked", "false");
|
|
});
|
|
|
|
test("automatically mentions multiple agents from the mention picker", async ({
|
|
page,
|
|
}) => {
|
|
await installAudienceFixtures(page);
|
|
await openGeneral(page);
|
|
|
|
const composer = channelComposer(page);
|
|
await automaticallyMention(composer, "Morgarita");
|
|
await automaticallyMention(composer, "Vogue");
|
|
|
|
await expect(
|
|
composer.getByTestId(`composer-address-lock-${AGENT_A}`),
|
|
).toBeVisible();
|
|
await expect(
|
|
composer.getByTestId(`composer-address-lock-${AGENT_B}`),
|
|
).toBeVisible();
|
|
await expect(
|
|
composer.getByRole("button", { name: "Manage automatic agent mentions" }),
|
|
).toBeVisible();
|
|
});
|
|
|
|
test("Tab inserts a one-time agent mention by default", async ({ page }) => {
|
|
await installAudienceFixtures(page);
|
|
await openGeneral(page);
|
|
|
|
const composer = channelComposer(page);
|
|
const input = composer.getByTestId("message-input");
|
|
await input.fill("@Mor");
|
|
await expect(composer.getByTestId("mention-autocomplete")).toBeVisible();
|
|
|
|
await input.press("Tab");
|
|
|
|
await expect(input).toHaveText("@Morgarita ");
|
|
await expect(composer.getByTestId("mention-autocomplete")).toHaveCount(0);
|
|
await expect(
|
|
composer.getByTestId(`composer-address-lock-${AGENT_A}`),
|
|
).toHaveCount(0);
|
|
const selectAllShortcut = await page.evaluate(() =>
|
|
/mac|iphone|ipad|ipod/i.test(navigator.platform) ? "Meta+A" : "Control+A",
|
|
);
|
|
await input.press(selectAllShortcut);
|
|
await input.press("Backspace");
|
|
await expect(input).toHaveText("");
|
|
await expect(
|
|
composer.getByTestId(`composer-address-lock-${AGENT_A}`),
|
|
).toHaveCount(0);
|
|
});
|
|
|
|
test("disabling automatic mentions leaves the composer empty after send", async ({
|
|
page,
|
|
}) => {
|
|
await keepMentionedAgentsPinned(page);
|
|
await installAudienceFixtures(page);
|
|
await openGeneral(page);
|
|
|
|
const composer = channelComposer(page);
|
|
const input = composer.getByTestId("message-input");
|
|
await composer.getByTestId("message-insert-mention").click();
|
|
await composer.getByTestId("mention-options-trigger").click();
|
|
const preference = composer.getByTestId("mention-keep-agents-pinned-toggle");
|
|
await expect(preference).toHaveAttribute("data-state", "checked");
|
|
await preference.click();
|
|
await expect(preference).toHaveAttribute("data-state", "unchecked");
|
|
await input.press("Escape");
|
|
|
|
await input.fill("@Mor");
|
|
await expect(composer.getByTestId("mention-autocomplete")).toBeVisible();
|
|
await input.press("Tab");
|
|
await input.type("test");
|
|
await expect(input).toHaveText("@Morgarita test");
|
|
await input.press("Enter");
|
|
|
|
await expect(input).toHaveText("");
|
|
await expect(input.locator(".agent-mention-highlight")).toHaveCount(0);
|
|
await expect(
|
|
composer.getByTestId(`composer-address-lock-${AGENT_A}`),
|
|
).toHaveCount(0);
|
|
await expect
|
|
.poll(() => readOutgoingMentionPubkeys(page, "@Morgarita test"))
|
|
.toContain(AGENT_A);
|
|
});
|
|
|
|
test("primary+Shift+M addresses the default agent, then selects the highlighted agent", async ({
|
|
page,
|
|
}) => {
|
|
await keepMentionedAgentsPinned(page);
|
|
await installAudienceFixtures(page);
|
|
await openGeneral(page);
|
|
|
|
const composer = channelComposer(page);
|
|
const input = composer.getByTestId("message-input");
|
|
await input.fill("draft text");
|
|
await pressPrimaryShift(page, "M");
|
|
|
|
await expect(input).toHaveText("@alice draft text");
|
|
await expect(input.locator(".agent-mention-highlight")).toHaveText("alice");
|
|
await expect(
|
|
page.getByTestId("composer-auto-pin-confirmation"),
|
|
).toContainText("alice will be mentioned automatically");
|
|
await pressPrimaryShift(page, "M");
|
|
await expect(input).toHaveText("draft text");
|
|
await pressPrimaryShift(page, "M");
|
|
await expect(input).toHaveText("@alice draft text");
|
|
await expect(
|
|
composer
|
|
.getByTestId("composer-address-locks")
|
|
.getByRole("button", { name: /^Stop automatically mentioning / }),
|
|
).toHaveCount(1);
|
|
|
|
await input.fill("@Vog");
|
|
const menu = composer.getByTestId("mention-autocomplete");
|
|
await expect(menu.getByTestId(`mention-suggestion-${AGENT_B}`)).toHaveClass(
|
|
/(?:^|\s)bg-accent(?:\s|$)/,
|
|
);
|
|
await pressPrimaryShift(page, "M");
|
|
|
|
await expect(menu).toHaveCount(0);
|
|
await expect(input).toHaveText("@Vogue ");
|
|
await expect(
|
|
composer.getByTestId(`composer-address-lock-${AGENT_B}`),
|
|
).toBeVisible();
|
|
await expect(
|
|
composer.getByTestId(`composer-address-lock-${AGENT_A}`),
|
|
).toHaveCount(0);
|
|
await expect(
|
|
composer
|
|
.getByTestId("composer-address-locks")
|
|
.getByRole("button", { name: /^Stop automatically mentioning / }),
|
|
).toHaveCount(1);
|
|
});
|
|
|
|
test("primary+Shift+M favors the most recently mentioned eligible agent", async ({
|
|
page,
|
|
}) => {
|
|
await installAudienceFixtures(page);
|
|
await openGeneral(page);
|
|
await emitMockMessage(page, "Please ask Vogue", [AGENT_B]);
|
|
|
|
const input = channelComposer(page).getByTestId("message-input");
|
|
await input.fill("draft text");
|
|
await input.press("ArrowLeft");
|
|
await input.press("ArrowLeft");
|
|
await expect.poll(() => readComposerCaret(input)).toBe(8);
|
|
await pressPrimaryShift(page, "M");
|
|
|
|
await expect(input).toHaveText("@Vogue draft text");
|
|
await expect.poll(() => readComposerCaret(input)).toBe(15);
|
|
await pressPrimaryShift(page, "M");
|
|
await expect(input).toHaveText("draft text");
|
|
await pressPrimaryShift(page, "M");
|
|
await expect(input).toHaveText("@Vogue draft text");
|
|
});
|
|
|
|
test("the mention button opens settings and can undo an address", async ({
|
|
page,
|
|
}) => {
|
|
await installAudienceFixtures(page);
|
|
await openGeneral(page);
|
|
|
|
const composer = channelComposer(page);
|
|
await automaticallyMention(composer, "Morgarita");
|
|
const input = composer.getByTestId("message-input");
|
|
const ingress = composer.getByRole("button", {
|
|
name: "Manage automatic agent mentions",
|
|
});
|
|
|
|
await input.type("draft text");
|
|
await ingress.click();
|
|
const menu = composer.getByTestId("mention-autocomplete");
|
|
await expect(menu).toBeVisible();
|
|
await expect(input).toHaveText("@Morgarita draft text");
|
|
await page.getByTestId("mention-options-trigger").click();
|
|
await expect(
|
|
page.getByTestId("mention-keep-agents-pinned-toggle"),
|
|
).toBeVisible();
|
|
const layerBox = await composer
|
|
.getByTestId("mention-autocomplete-layer")
|
|
.boundingBox();
|
|
const optionsBox = await page
|
|
.getByTestId("mention-options-trigger")
|
|
.boundingBox();
|
|
expect(layerBox).not.toBeNull();
|
|
expect(optionsBox).not.toBeNull();
|
|
if (!layerBox || !optionsBox) throw new Error("Mention tray is not laid out");
|
|
await page.mouse.click(layerBox.x + 4, optionsBox.y + optionsBox.height / 2);
|
|
await expect(menu).toHaveCount(0);
|
|
await expect(input).toHaveText("@Morgarita draft text");
|
|
await ingress.click();
|
|
await expect(menu).toBeVisible();
|
|
await expect(page.getByTestId("mention-options-trigger")).toHaveAttribute(
|
|
"aria-expanded",
|
|
"false",
|
|
);
|
|
await expect(
|
|
page.getByTestId("mention-keep-agents-pinned-toggle"),
|
|
).toHaveCount(0);
|
|
await ingress.click();
|
|
await expect(menu).toHaveCount(0);
|
|
await expect(input).toHaveText("@Morgarita draft text");
|
|
await ingress.click();
|
|
await expect(menu).toBeVisible();
|
|
await expect(page.getByTestId("user-profile-panel")).toHaveCount(0);
|
|
await expect(
|
|
menu.getByRole("button", {
|
|
name: "Stop automatically mentioning Morgarita",
|
|
}),
|
|
).toHaveAttribute("aria-pressed", "true");
|
|
|
|
await menu
|
|
.getByRole("button", { name: "Stop automatically mentioning Morgarita" })
|
|
.click();
|
|
await expect(input).toHaveText("draft text");
|
|
await expect(
|
|
composer.getByRole("button", { name: "Mention someone" }),
|
|
).toBeVisible();
|
|
await input.fill("");
|
|
|
|
await menu
|
|
.getByRole("button", { name: "Mention Morgarita", exact: true })
|
|
.click();
|
|
await expect(input).toHaveText("@Morgarita ");
|
|
await expect(
|
|
composer.getByTestId(`composer-address-lock-${AGENT_A}`),
|
|
).toBeVisible();
|
|
|
|
await input.type("later");
|
|
await input.press("Enter");
|
|
await expect(input).toHaveText("");
|
|
await expect
|
|
.poll(() => readOutgoingMentionPubkeys(page, "@Morgarita later"))
|
|
.toContain(AGENT_A);
|
|
await expect(
|
|
composer.getByTestId(`composer-address-lock-${AGENT_A}`),
|
|
).toHaveCount(0);
|
|
});
|
|
|
|
test("always-mentioned agents remain selected without replaying their animation while Enter-send resolves", async ({
|
|
page,
|
|
}) => {
|
|
await installAudienceFixtures(page, {
|
|
sendMessageDelayMs: 1_500,
|
|
usersBatchDelayMs: 1_500,
|
|
});
|
|
await openThread(page);
|
|
|
|
const composer = threadComposer(page);
|
|
await automaticallyMention(composer, "Morgarita");
|
|
const input = composer.getByTestId("message-input");
|
|
await input.evaluate((element) => {
|
|
const snapshots = [element.textContent ?? ""];
|
|
new MutationObserver(() =>
|
|
snapshots.push(element.textContent ?? ""),
|
|
).observe(element, { childList: true, characterData: true, subtree: true });
|
|
(
|
|
window as typeof window & { __BUZZ_COMPOSER_TEXT_SNAPSHOTS__?: string[] }
|
|
).__BUZZ_COMPOSER_TEXT_SNAPSHOTS__ = snapshots;
|
|
});
|
|
const avatar = composer.getByTestId(`composer-address-lock-${AGENT_A}`);
|
|
const initialPulseVersion = Number(
|
|
await avatar.getAttribute("data-pulse-version"),
|
|
);
|
|
await input.type("hello");
|
|
await input.evaluate((element) => {
|
|
const snapshots = (
|
|
window as typeof window & { __BUZZ_COMPOSER_TEXT_SNAPSHOTS__?: string[] }
|
|
).__BUZZ_COMPOSER_TEXT_SNAPSHOTS__;
|
|
snapshots?.splice(0, snapshots.length, element.textContent ?? "");
|
|
});
|
|
await input.press("Enter");
|
|
|
|
await expect(input).toHaveText("@Morgarita ", { timeout: 500 });
|
|
await expect
|
|
.poll(() =>
|
|
page.evaluate(
|
|
() =>
|
|
(
|
|
window as typeof window & {
|
|
__BUZZ_COMPOSER_TEXT_SNAPSHOTS__?: string[];
|
|
}
|
|
).__BUZZ_COMPOSER_TEXT_SNAPSHOTS__ ?? [],
|
|
),
|
|
)
|
|
.not.toContain("");
|
|
await expect(avatar).toHaveAttribute(
|
|
"data-pulse-version",
|
|
String(initialPulseVersion),
|
|
{ timeout: 500 },
|
|
);
|
|
await expect(
|
|
composer.getByRole("button", { name: "Manage automatic agent mentions" }),
|
|
).toBeVisible();
|
|
await expect(input).toBeFocused();
|
|
await expect(composer.getByTestId("mention-autocomplete")).toHaveCount(0);
|
|
|
|
await expect
|
|
.poll(() => readOutgoingMentionPubkeys(page, "@Morgarita hello"))
|
|
.toContain(AGENT_A);
|
|
await expect(input).toHaveText("@Morgarita ");
|
|
|
|
const sentRow = page
|
|
.getByTestId("message-row")
|
|
.filter({ hasText: "hello" })
|
|
.last();
|
|
const addressPrefix = sentRow.locator(
|
|
"[data-mention].agent-mention-highlight",
|
|
{ hasText: "Morgarita" },
|
|
);
|
|
await expect(addressPrefix).toBeVisible();
|
|
await expect(addressPrefix).toHaveText("Morgarita");
|
|
|
|
await input.type("follow up");
|
|
await input.press("Enter");
|
|
const inlineMentionRow = page
|
|
.getByTestId("message-row")
|
|
.filter({ hasText: "follow up" })
|
|
.last();
|
|
await expect(
|
|
inlineMentionRow.locator("[data-mention].agent-mention-highlight", {
|
|
hasText: "Morgarita",
|
|
}),
|
|
).toHaveCount(1);
|
|
});
|
|
|
|
test("a failed always-mentioned send shakes the composer avatar without replaying its selection animation", async ({
|
|
page,
|
|
}) => {
|
|
await installAudienceFixtures(page, {
|
|
sendMessageDelayMs: 500,
|
|
sendMessageErrors: ["simulated send failure"],
|
|
});
|
|
await openThread(page);
|
|
|
|
const composer = threadComposer(page);
|
|
await automaticallyMention(composer, "Morgarita");
|
|
const input = composer.getByTestId("message-input");
|
|
const avatar = composer.getByTestId(`composer-address-lock-${AGENT_A}`);
|
|
const initialPulseVersion = Number(
|
|
await avatar.getAttribute("data-pulse-version"),
|
|
);
|
|
await expect(avatar).toHaveAttribute("data-shake-version", "0");
|
|
|
|
await input.type("please retry");
|
|
await input.press("Enter");
|
|
|
|
await expect(avatar).toHaveAttribute(
|
|
"data-pulse-version",
|
|
String(initialPulseVersion),
|
|
{ timeout: 500 },
|
|
);
|
|
await expect(input).toHaveText("@Morgarita please retry");
|
|
await expect(avatar).toHaveAttribute("data-shake-version", "1");
|
|
});
|
|
|
|
test("a manual mention persists when automatic mentions are enabled", async ({
|
|
page,
|
|
}) => {
|
|
await keepMentionedAgentsPinned(page);
|
|
await installAudienceFixtures(page, { sendMessageDelayMs: 1_500 });
|
|
await openGeneral(page);
|
|
|
|
const composer = channelComposer(page);
|
|
const input = composer.getByTestId("message-input");
|
|
await input.fill("@Mor");
|
|
await expect(composer.getByTestId("mention-autocomplete")).toBeVisible();
|
|
await input.press("Tab");
|
|
await expect(input).toHaveText("@Morgarita ");
|
|
await expect(
|
|
composer.getByTestId(`composer-address-lock-${AGENT_A}`),
|
|
).toBeVisible();
|
|
|
|
const autoPinConfirmation = page.getByTestId(
|
|
"composer-auto-pin-confirmation",
|
|
);
|
|
await expect(autoPinConfirmation).toContainText(
|
|
"Morgarita will be mentioned automatically",
|
|
);
|
|
await expect(autoPinConfirmation).not.toContainText(
|
|
"Future messages in this channel will include this agent.",
|
|
);
|
|
await expect(autoPinConfirmation).toHaveAttribute("data-side", "right");
|
|
await expect(autoPinConfirmation.locator("span")).toHaveCSS(
|
|
"white-space",
|
|
"nowrap",
|
|
);
|
|
await expect(
|
|
page
|
|
.locator("[data-sonner-toast]")
|
|
.filter({ hasText: "Morgarita will be mentioned automatically" }),
|
|
).toHaveCount(0);
|
|
const addressControlBox = await composer
|
|
.getByTestId("composer-address-locks")
|
|
.locator("..")
|
|
.boundingBox();
|
|
const confirmationBox = await autoPinConfirmation.boundingBox();
|
|
expect(addressControlBox).not.toBeNull();
|
|
expect(confirmationBox).not.toBeNull();
|
|
if (!addressControlBox || !confirmationBox) {
|
|
throw new Error("Automatic mention confirmation is not laid out");
|
|
}
|
|
expect(confirmationBox.x).toBeGreaterThan(
|
|
addressControlBox.x + addressControlBox.width,
|
|
);
|
|
const turnOffAction = autoPinConfirmation.getByRole("button", {
|
|
name: "Turn off",
|
|
});
|
|
await expect(turnOffAction).toHaveRole("button");
|
|
await expect(turnOffAction).toHaveText("Turn off");
|
|
|
|
await input.press("Escape");
|
|
await expect(autoPinConfirmation).toHaveCount(0);
|
|
|
|
await input.type("hello");
|
|
await input.press("Enter");
|
|
|
|
await expect(input).toHaveText("@Morgarita ", { timeout: 2_500 });
|
|
await expect(input.locator("[data-placeholder]")).toHaveCount(0);
|
|
await expect(input).toBeFocused();
|
|
await expect(
|
|
composer.getByTestId(`composer-address-lock-${AGENT_A}`),
|
|
).toBeVisible({ timeout: 2_500 });
|
|
await expect(autoPinConfirmation).toHaveCount(0);
|
|
await expect
|
|
.poll(() => readOutgoingMentionPubkeys(page, "@Morgarita hello"))
|
|
.toContain(AGENT_A);
|
|
|
|
await input.fill("follow up");
|
|
await expect(
|
|
composer.getByTestId(`composer-address-lock-${AGENT_A}`),
|
|
).toHaveCount(0);
|
|
await input.press("Enter");
|
|
await expect
|
|
.poll(() => readOutgoingMentionPubkeys(page, "follow up"))
|
|
.not.toContain(AGENT_A);
|
|
});
|
|
|
|
test("the auto-pin popover can turn off automatic agent mentions", async ({
|
|
page,
|
|
}) => {
|
|
await keepMentionedAgentsPinned(page);
|
|
await installAudienceFixtures(page);
|
|
await openGeneral(page);
|
|
|
|
const composer = channelComposer(page);
|
|
const input = composer.getByTestId("message-input");
|
|
await input.fill("@Mor");
|
|
await expect(composer.getByTestId("mention-autocomplete")).toBeVisible();
|
|
await input.press("Tab");
|
|
await expect(input).toHaveText("@Morgarita ");
|
|
|
|
await expect(
|
|
composer.getByTestId(`composer-address-lock-${AGENT_A}`),
|
|
).toBeVisible();
|
|
const autoPinConfirmation = page.getByTestId(
|
|
"composer-auto-pin-confirmation",
|
|
);
|
|
await expect(autoPinConfirmation).toContainText(
|
|
"Morgarita will be mentioned automatically",
|
|
);
|
|
await autoPinConfirmation.getByRole("button", { name: "Turn off" }).click();
|
|
|
|
await expect(
|
|
composer.getByTestId(`composer-address-lock-${AGENT_A}`),
|
|
).toHaveCount(0);
|
|
await expect(autoPinConfirmation).toHaveCount(0);
|
|
|
|
await composer.getByTestId("message-insert-mention").click();
|
|
await expect(composer.getByTestId("mention-autocomplete")).toBeVisible();
|
|
await composer.getByTestId("mention-options-trigger").click();
|
|
await expect(
|
|
composer.getByTestId("mention-keep-agents-pinned-toggle"),
|
|
).toHaveAttribute("data-state", "unchecked");
|
|
|
|
await input.press("Escape");
|
|
await expect(composer.getByTestId("mention-autocomplete")).toHaveCount(0);
|
|
});
|
|
|
|
test("channel automatic mentions carry into threads and stay synchronized", async ({
|
|
page,
|
|
}) => {
|
|
await installAudienceFixtures(page);
|
|
await openGeneral(page);
|
|
await automaticallyMention(channelComposer(page), "Morgarita");
|
|
|
|
await openThread(page);
|
|
const channelAutomaticMention = channelComposer(page).getByTestId(
|
|
`composer-address-lock-${AGENT_A}`,
|
|
);
|
|
const threadAutomaticMention = threadComposer(page).getByTestId(
|
|
`composer-address-lock-${AGENT_A}`,
|
|
);
|
|
await expect(channelAutomaticMention).toBeVisible();
|
|
await expect(threadAutomaticMention).toBeVisible();
|
|
|
|
await threadComposer(page)
|
|
.getByTestId(`composer-address-lock-remove-${AGENT_A}`)
|
|
.click();
|
|
await expect(threadAutomaticMention).toHaveCount(0);
|
|
await expect(channelAutomaticMention).toHaveCount(0);
|
|
});
|
|
|
|
test("reduced motion removes addressed agents without spatial animation", async ({
|
|
page,
|
|
}) => {
|
|
await page.emulateMedia({ reducedMotion: "reduce" });
|
|
await keepMentionedAgentsPinned(page);
|
|
await installAudienceFixtures(page);
|
|
await openGeneral(page);
|
|
|
|
const composer = channelComposer(page);
|
|
const input = composer.getByTestId("message-input");
|
|
await input.fill("@Mor");
|
|
await expect(composer.getByTestId("mention-autocomplete")).toBeVisible();
|
|
await input.press("Tab");
|
|
const removeButton = composer.getByTestId(
|
|
`composer-address-lock-remove-${AGENT_A}`,
|
|
);
|
|
await expect(removeButton).toBeVisible();
|
|
await expect(removeButton).toHaveAttribute("style", /opacity: 1/);
|
|
await expect(removeButton).toHaveCSS("transform", "none");
|
|
|
|
await removeButton.click();
|
|
await expect(input).toHaveText("@Morgarita ");
|
|
await expect(removeButton).toHaveCount(0);
|
|
});
|
|
|
|
for (const theme of ["buzz", "buzz-dark"]) {
|
|
test(`captures the mention-button placement in ${theme}`, async ({
|
|
page,
|
|
}) => {
|
|
await seedTheme(page, theme);
|
|
await installAudienceFixtures(page);
|
|
await openThread(page);
|
|
const overlay = threadComposer(page);
|
|
const composer = overlay.getByTestId("message-composer");
|
|
await automaticallyMention(overlay, "Morgarita");
|
|
await automaticallyMention(overlay, "Vogue");
|
|
await overlay.getByTestId("message-input").focus();
|
|
await waitForAnimations(page);
|
|
await composer.screenshot({ path: `${SHOTS}/${theme}-mention-button.png` });
|
|
});
|
|
}
|
|
|
|
test("the mention-button placement fits the narrow composer", async ({
|
|
page,
|
|
}) => {
|
|
await page.setViewportSize({ width: 700, height: 760 });
|
|
await installAudienceFixtures(page);
|
|
await openThread(page);
|
|
const overlay = threadComposer(page);
|
|
const composer = overlay.getByTestId("message-composer");
|
|
await automaticallyMention(overlay, "Morgarita");
|
|
await automaticallyMention(overlay, "Vogue");
|
|
await expect(overlay.getByTestId("composer-address-locks")).toBeVisible();
|
|
await expect(
|
|
overlay.getByRole("button", { name: "Manage automatic agent mentions" }),
|
|
).toBeVisible();
|
|
await waitForAnimations(page);
|
|
await composer.screenshot({ path: `${SHOTS}/narrow-mention-button.png` });
|
|
});
|
|
|
|
test("captures the lightweight auto-pin popover", async ({ page }) => {
|
|
await seedTheme(page, "buzz-dark");
|
|
await installAudienceFixtures(page);
|
|
await openGeneral(page);
|
|
|
|
const composer = channelComposer(page);
|
|
const input = composer.getByTestId("message-input");
|
|
await input.fill("draft text");
|
|
await pressPrimaryShift(page, "M");
|
|
await expect(input).toHaveText("@alice draft text");
|
|
|
|
const addressControl = composer
|
|
.getByTestId("composer-address-locks")
|
|
.locator("..");
|
|
const confirmation = page.getByTestId("composer-auto-pin-confirmation");
|
|
await expect(confirmation).toContainText(
|
|
"alice will be mentioned automatically",
|
|
);
|
|
await waitForAnimations(page);
|
|
|
|
const addressBox = await addressControl.boundingBox();
|
|
const confirmationBox = await confirmation.boundingBox();
|
|
expect(addressBox).not.toBeNull();
|
|
expect(confirmationBox).not.toBeNull();
|
|
if (!addressBox || !confirmationBox) {
|
|
throw new Error("Popover is not laid out");
|
|
}
|
|
|
|
const left = addressBox.x - 14;
|
|
const top = Math.min(addressBox.y, confirmationBox.y) - 14;
|
|
const right = confirmationBox.x + confirmationBox.width + 14;
|
|
const bottom =
|
|
Math.max(
|
|
addressBox.y + addressBox.height,
|
|
confirmationBox.y + confirmationBox.height,
|
|
) + 14;
|
|
await page.screenshot({
|
|
path: `${SHOTS}/auto-pin-popover-dark.png`,
|
|
clip: { x: left, y: top, width: right - left, height: bottom - top },
|
|
});
|
|
});
|