mirror of
https://github.com/block/buzz.git
synced 2026-10-31 06:21:34 +00:00
This PR implements MVP, iOS-only,
[NIP-PL](8d2d0ff5ad/docs/nips/NIP-PL.md)-compliant
push notifications.
A relay with `BUZZ_PUSH_ENABLED` will send a push notification for any
message that appears in the in-app Notifications tab.
## Enrollment flow
The first time the client first connects to a relay with
`BUZZ_PUSH_ENABLED`:
```mermaid
sequenceDiagram
autonumber
participant App as Buzz iOS app
participant iOS
participant Relay as Buzz relay
participant Attest as Apple App Attest
participant Gateway as Push gateway
App->>Relay: Fetch NIP-11 push capability
Relay-->>App: Push profile, current relay public key, and limits
par
App->>iOS: Request notification permission
iOS-->>App: Permission result
and
App->>iOS: Register for remote notifications
iOS-->>App: Device token
end
App->>Gateway: Request installation challenge
Gateway-->>App: Single-use challenge
App->>Attest: Attest installation transcript
Attest-->>App: Attestation proof
App->>Gateway: Enroll device token and proof
Gateway-->>App: Installation handle
App->>Gateway: Request delegation challenge
Gateway-->>App: Single-use challenge
App->>Attest: Assert relay-key delegation
Attest-->>App: Assertion
App->>Gateway: Create delegation
Gateway-->>App: Opaque endpoint grant
App->>Relay: Publish encrypted push lease and filters
Relay-->>App: Lease acknowledged
```
## Push-time flow
When a notification-eligible event is received by the relay:
```mermaid
%%{init: {
"sequence": {
"actorMargin": 20,
"width": 110,
"messageMargin": 18,
"diagramMarginX": 8,
"wrap": true
}
}}%%
sequenceDiagram
autonumber
participant Relay as Buzz relay
participant Gateway as Push gateway
participant APNs as Apple Push<br/>Notification service
participant iOS
participant NSE as Notification service<br/>extension
Relay->>Gateway: POST /v1/deliveries/apns<br/>opaque endpoint grant, request ID, expiry, NIP-98 authorization
Gateway->>APNs: POST /3/device/{device-token}<br/>topic, request ID, expiry, constant mutable-content payload
APNs-->>Gateway: 200 OK: request accepted
Gateway-->>Relay: 200 OK: accepted status
APNs-->>iOS: Notification: constant reconnect alert<br/>mutable-content = 1
iOS->>NSE: Invoke extension<br/>original notification content
NSE->>Relay: POST /query: subscription filters, limit 10<br/>NIP-98 authorization
Relay-->>NSE: 200 OK: signed Nostr events<br/>kinds 9, 40002, 45001, or 45003
NSE->>iOS: Complete notification: title, body, subtitle<br/>thread ID, exact-message target
```
relay → push gateway → APNs -> NSE -> Notification Center
## Known limitations
The APNs wake payload is intentionally constant and opaque: it contains
no originating community or message identifier, in keeping with the
implemented NIP-PL privacy design.
The Notification Service Extension must therefore reconnect to the relay
and resolve eligible messages after each wake. Around overlapping wakes,
timing boundaries, or resolution windows, notification presentation may
occasionally omit an expected message or display a message more than
once.
This best-effort behavior is deliberately accepted for the current
implementation and will be measured during the internal rollout to
determine whether the user experience is acceptable before any broader
deployment; the implementation does not claim exactly-once presentation.
## Validation
Live end-to-end hardware validation used an internal remotely hosted
development relay and push gateway, the APNs sandbox, and a physical
iPhone 12 mini:
- A second real Buzz client published a uniquely marked message through
the hosted relay.
- The relay matched the message and sent the constant opaque wake
through the hosted gateway. The gateway made an actual APNs request; no
`simctl push` or simulated notification was used.
- The iPhone received the notification on its lock screen. The
Notification Service Extension reconnected to the relay, fetched the
event, verified its ID and signature, and replaced the placeholder
content with the real notification title and body.
- After the app populated its shared presentation cache, a final marked
notification visibly showed the sender display name, sender avatar, and
hashtag-prefixed channel name.
- Tapping a lock-screen notification opened Buzz and exercised the
notification-response path and navigated to the corresponding message.
Final validation with a dogfood-signed artifact and production App
Attest/APNs configuration remains a release step.
## Independent pre-reviews
- **First pass:**
[Carl](buzz://message?channel=18882f4c-289f-41db-942f-81f6f8066da1&id=74ab9a93bb227f3e762568f1cf9fee66d7495b0edc3918735ff787238b9cc585)
found missing transient retries, executor-key rotation suppression,
duplicate installation renewal, and an unauthenticated challenge write
amplifier. These were resolved by [retry-safe
bootstrap](https://github.com/block/buzz/pull/6269/changes/12c66ea62)
and [authenticated renewal plus a cross-replica
quota](https://github.com/block/buzz/pull/6269/changes/8e5ece0bd).
[sol-max](buzz://message?channel=ad83385f-8e9e-4461-9a35-c1bf2e208532&id=d26d53daa4684669e2ed354638241f13f36c3a97027fe8b4dd738aff09038962)
found delegation generation burning and an edited applied migration,
resolved by [exact-generation
revocation](https://github.com/block/buzz/pull/6269/changes/c26d2159d)
and a [forward-only
migration](https://github.com/block/buzz/pull/6269/changes/956c1d099).
[k3-max](buzz://message?channel=5e46055d-a766-4065-ae25-05d1e4aaa6b2&id=d43139138a0b15f806cbdbeeedd8f69d992cadf2e805876db6fdde6a34c7eda1)
found no blockers.
- **Exact-head re-review:**
[Carl](buzz://message?channel=18882f4c-289f-41db-942f-81f6f8066da1&id=a897721673459301b0cf26e8b85a1478d7ebbb56a4621f93d774c98d395b8f68),
[sol-max](buzz://message?channel=ad83385f-8e9e-4461-9a35-c1bf2e208532&id=fb2159f709ec68f74f7b21459acd76da0e8a7c5c0f3d469f99826b0cc2380849),
and
[k3-max](buzz://message?channel=5e46055d-a766-4065-ae25-05d1e4aaa6b2&id=2ce2842910435f562e9d9cc718595848f281b122c94605e523a4b964254b8bfb)
independently returned **NO BLOCKERS** at `7eb3a650b`; k3-max also
revalidated every remediation and the endpoint-specific App Attest
enrollment bound.
---------
Signed-off-by: Tom Brow <tomb@squareup.com>
Signed-off-by: Tom Brow <tomb@block.xyz>
Co-authored-by: Tom Brow <tomb@squareup.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Jordan Mecom <jm@squareup.com>
658 lines
23 KiB
Dart
658 lines
23 KiB
Dart
import 'dart:async';
|
|
import 'dart:convert';
|
|
|
|
import 'package:flutter_test/flutter_test.dart';
|
|
import 'package:hooks_riverpod/hooks_riverpod.dart';
|
|
import 'package:buzz/shared/community/community.dart';
|
|
import 'package:buzz/shared/community/community_provider.dart';
|
|
import 'package:buzz/shared/community/community_storage.dart';
|
|
import 'package:buzz/shared/push/push_subscription.dart';
|
|
import 'package:nostr/nostr.dart' as nostr;
|
|
|
|
import 'community_storage_test.dart';
|
|
|
|
void main() {
|
|
late FakeSecureStorage fakeSecure;
|
|
late CommunityStorage communityStorage;
|
|
late ProviderContainer container;
|
|
late List<List<Community>> snapshots;
|
|
late List<String> deactivatedCommunityIds;
|
|
late List<int?> deactivationGenerations;
|
|
late List<String> journaledCommunityIds;
|
|
late int revocationTriggers;
|
|
late CommunityPushLeaseRevocationTrigger revocationTrigger;
|
|
late CommunityPushLeaseDeactivator deactivator;
|
|
|
|
setUp(() {
|
|
fakeSecure = FakeSecureStorage();
|
|
communityStorage = CommunityStorage(secure: fakeSecure);
|
|
snapshots = [];
|
|
deactivatedCommunityIds = [];
|
|
deactivationGenerations = [];
|
|
journaledCommunityIds = [];
|
|
revocationTriggers = 0;
|
|
revocationTrigger = () async {
|
|
revocationTriggers += 1;
|
|
};
|
|
deactivator = (community, {generation}) async {
|
|
deactivatedCommunityIds.add(community.id);
|
|
deactivationGenerations.add(generation);
|
|
};
|
|
});
|
|
|
|
tearDown(() => container.dispose());
|
|
|
|
ProviderContainer createContainer() {
|
|
return ProviderContainer(
|
|
overrides: [
|
|
communityStorageProvider.overrideWithValue(communityStorage),
|
|
communitySnapshotWriterProvider.overrideWithValue((communities) async {
|
|
snapshots.add(List.of(communities));
|
|
}),
|
|
communityPushLeaseDeactivatorProvider.overrideWithValue(deactivator),
|
|
communityPushLeaseRevocationEnqueuerProvider.overrideWithValue((
|
|
community,
|
|
) async {
|
|
journaledCommunityIds.add(community.id);
|
|
return true;
|
|
}),
|
|
communityPushLeaseRevocationTriggerProvider.overrideWithValue(
|
|
revocationTrigger,
|
|
),
|
|
],
|
|
);
|
|
}
|
|
|
|
group('CommunityListNotifier', () {
|
|
test('loads empty list initially', () async {
|
|
container = createContainer();
|
|
final communities = await container.read(communityListProvider.future);
|
|
expect(communities, isEmpty);
|
|
expect(snapshots, [isEmpty]);
|
|
});
|
|
|
|
test('exports migrated communities on startup', () async {
|
|
final community = Community.create(
|
|
name: 'Migrated',
|
|
relayUrl: 'https://migrated.example.com',
|
|
nsec: nostr.Keys.generate().nsec,
|
|
);
|
|
// Seed legacy storage to exercise the same migration path as an app
|
|
// upgrade.
|
|
fakeSecure['buzz_workspaces'] = jsonEncode([community.toJson()]);
|
|
|
|
container = createContainer();
|
|
await container.read(communityListProvider.future);
|
|
|
|
expect(snapshots.single.single.id, community.id);
|
|
expect(fakeSecure['buzz_workspaces'], isNull);
|
|
});
|
|
|
|
test('skips an unchanged snapshot after provider invalidation', () async {
|
|
final community = Community.create(
|
|
name: 'Stored',
|
|
relayUrl: 'https://stored.example.com',
|
|
nsec: nostr.Keys.generate().nsec,
|
|
);
|
|
await communityStorage.save(community);
|
|
container = createContainer();
|
|
|
|
await container.read(communityListProvider.future);
|
|
container.invalidate(communityListProvider);
|
|
await container.read(communityListProvider.future);
|
|
|
|
expect(snapshots, hasLength(1));
|
|
});
|
|
|
|
test('addCommunity adds to list', () async {
|
|
container = createContainer();
|
|
await container.read(communityListProvider.future);
|
|
|
|
final ws = Community.create(
|
|
name: 'Test',
|
|
relayUrl: 'https://test.example.com',
|
|
);
|
|
await container.read(communityListProvider.notifier).addCommunity(ws);
|
|
|
|
final communities = await container.read(communityListProvider.future);
|
|
expect(communities, hasLength(1));
|
|
expect(communities.first.name, 'Test');
|
|
});
|
|
|
|
test(
|
|
'push notifications default off and opt-in survives restart',
|
|
() async {
|
|
container = createContainer();
|
|
await container.read(communityListProvider.future);
|
|
final community = Community.create(
|
|
name: 'Test',
|
|
relayUrl: 'https://test.example.com',
|
|
);
|
|
await container
|
|
.read(communityListProvider.notifier)
|
|
.addCommunity(community);
|
|
expect(
|
|
(await container.read(
|
|
communityListProvider.future,
|
|
)).single.pushNotificationsEnabled,
|
|
isFalse,
|
|
);
|
|
|
|
await container
|
|
.read(communityListProvider.notifier)
|
|
.setPushNotificationsEnabled(community.id, true);
|
|
container.dispose();
|
|
container = createContainer();
|
|
|
|
expect(
|
|
(await container.read(
|
|
communityListProvider.future,
|
|
)).single.pushNotificationsEnabled,
|
|
isTrue,
|
|
);
|
|
},
|
|
);
|
|
|
|
test(
|
|
'lease retry reserves beyond a locally unaccepted generation',
|
|
() async {
|
|
container = createContainer();
|
|
await container.read(communityListProvider.future);
|
|
final subscription = BuzzPushSubscription(
|
|
filter: BuzzPushFilter(kinds: const [9], pTags: ['a' * 64]),
|
|
notificationClass: 'default',
|
|
);
|
|
final subscriptionState = BuzzPushLeaseSubscriptionState.desired(
|
|
desired: [subscription],
|
|
).withAccepted(subscriptions: [subscription], generation: 4);
|
|
final community =
|
|
Community.create(
|
|
name: 'Test',
|
|
relayUrl: 'https://test.example.com',
|
|
).copyWith(
|
|
pushNotificationsEnabled: true,
|
|
pushSubscriptionState: subscriptionState,
|
|
);
|
|
final notifier = container.read(communityListProvider.notifier);
|
|
await notifier.addCommunity(community);
|
|
|
|
expect(await notifier.reservePushLeaseGeneration(community.id), 5);
|
|
expect(await notifier.reservePushLeaseGeneration(community.id), 6);
|
|
final stored = (await communityStorage.loadAll()).single;
|
|
expect(stored.pushSubscriptionState.acceptedGeneration, 4);
|
|
expect(stored.pushSubscriptionState.generationCursor, 6);
|
|
},
|
|
);
|
|
|
|
test('older lease success cannot regress accepted generation', () async {
|
|
container = createContainer();
|
|
await container.read(communityListProvider.future);
|
|
final subscription = BuzzPushSubscription(
|
|
filter: BuzzPushFilter(kinds: const [9], pTags: ['a' * 64]),
|
|
notificationClass: 'default',
|
|
);
|
|
final community =
|
|
Community.create(
|
|
name: 'Test',
|
|
relayUrl: 'https://test.example.com',
|
|
).copyWith(
|
|
pushNotificationsEnabled: true,
|
|
pushSubscriptionState: BuzzPushLeaseSubscriptionState.desired(
|
|
desired: [subscription],
|
|
).withAccepted(subscriptions: [subscription], generation: 6),
|
|
);
|
|
final notifier = container.read(communityListProvider.notifier);
|
|
await notifier.addCommunity(community);
|
|
|
|
await notifier.markPushLeaseAccepted(
|
|
community.id,
|
|
subscriptions: const [],
|
|
generation: 5,
|
|
);
|
|
|
|
final stored = (await communityStorage.loadAll()).single;
|
|
expect(stored.pushSubscriptionState.acceptedGeneration, 6);
|
|
expect(
|
|
stored.pushSubscriptionState.accepted!.single.toJson(),
|
|
subscription.toJson(),
|
|
);
|
|
});
|
|
|
|
test('opt-out tombstones an in-flight first publication', () async {
|
|
container = createContainer();
|
|
await container.read(communityListProvider.future);
|
|
final subscription = BuzzPushSubscription(
|
|
filter: BuzzPushFilter(kinds: const [9], pTags: ['a' * 64]),
|
|
notificationClass: 'default',
|
|
);
|
|
final community =
|
|
Community.create(
|
|
name: 'Test',
|
|
relayUrl: 'https://test.example.com',
|
|
).copyWith(
|
|
pushNotificationsEnabled: true,
|
|
pushSubscriptionState: BuzzPushLeaseSubscriptionState.desired(
|
|
desired: [subscription],
|
|
),
|
|
);
|
|
final notifier = container.read(communityListProvider.notifier);
|
|
await notifier.addCommunity(community);
|
|
|
|
expect(await notifier.reservePushLeaseGeneration(community.id), 1);
|
|
await notifier.setPushNotificationsEnabled(community.id, false);
|
|
await notifier.markPushLeaseAccepted(
|
|
community.id,
|
|
subscriptions: [subscription],
|
|
generation: 1,
|
|
);
|
|
|
|
final stored = (await communityStorage.loadAll()).single;
|
|
expect(stored.pushNotificationsEnabled, isFalse);
|
|
expect(stored.pushSubscriptionState.acceptedGeneration, 2);
|
|
expect(stored.pushSubscriptionState.generationCursor, 2);
|
|
expect(stored.pushSubscriptionState.pendingTombstoneGeneration, isNull);
|
|
expect(deactivationGenerations, [2]);
|
|
});
|
|
|
|
test('opt-out persists first and publishes a higher tombstone', () async {
|
|
container = createContainer();
|
|
await container.read(communityListProvider.future);
|
|
final subscription = BuzzPushSubscription(
|
|
filter: BuzzPushFilter(kinds: const [9], pTags: ['a' * 64]),
|
|
notificationClass: 'default',
|
|
);
|
|
final community =
|
|
Community.create(
|
|
name: 'Test',
|
|
relayUrl: 'https://test.example.com',
|
|
).copyWith(
|
|
pushNotificationsEnabled: true,
|
|
pushSubscriptionState: BuzzPushLeaseSubscriptionState.desired(
|
|
desired: [subscription],
|
|
).withAccepted(subscriptions: [subscription], generation: 7),
|
|
);
|
|
final notifier = container.read(communityListProvider.notifier);
|
|
await notifier.addCommunity(community);
|
|
|
|
await notifier.setPushNotificationsEnabled(community.id, false);
|
|
|
|
final stored = (await communityStorage.loadAll()).single;
|
|
expect(stored.pushNotificationsEnabled, isFalse);
|
|
expect(stored.pushSubscriptionState.generationCursor, 8);
|
|
expect(stored.pushSubscriptionState.acceptedGeneration, 8);
|
|
expect(stored.pushSubscriptionState.pendingTombstoneGeneration, isNull);
|
|
expect(deactivatedCommunityIds, [community.id]);
|
|
expect(deactivationGenerations, [8]);
|
|
|
|
container.dispose();
|
|
container = createContainer();
|
|
expect(
|
|
(await container.read(
|
|
communityListProvider.future,
|
|
)).single.pushNotificationsEnabled,
|
|
isFalse,
|
|
);
|
|
});
|
|
|
|
test(
|
|
'failed opt-out tombstone retries after restart at a newer generation',
|
|
() async {
|
|
var failTombstone = true;
|
|
deactivator = (community, {generation}) async {
|
|
deactivatedCommunityIds.add(community.id);
|
|
deactivationGenerations.add(generation);
|
|
if (failTombstone) {
|
|
throw StateError('injected tombstone failure');
|
|
}
|
|
};
|
|
container = createContainer();
|
|
await container.read(communityListProvider.future);
|
|
final subscription = BuzzPushSubscription(
|
|
filter: BuzzPushFilter(kinds: const [9], pTags: ['a' * 64]),
|
|
notificationClass: 'default',
|
|
);
|
|
final community =
|
|
Community.create(
|
|
name: 'Test',
|
|
relayUrl: 'https://test.example.com',
|
|
).copyWith(
|
|
pushNotificationsEnabled: true,
|
|
pushSubscriptionState: BuzzPushLeaseSubscriptionState.desired(
|
|
desired: [subscription],
|
|
).withAccepted(subscriptions: [subscription], generation: 7),
|
|
);
|
|
await container
|
|
.read(communityListProvider.notifier)
|
|
.addCommunity(community);
|
|
|
|
await container
|
|
.read(communityListProvider.notifier)
|
|
.setPushNotificationsEnabled(community.id, false);
|
|
|
|
var stored = (await communityStorage.loadAll()).single;
|
|
expect(stored.pushNotificationsEnabled, isFalse);
|
|
expect(stored.pushSubscriptionState.acceptedGeneration, 7);
|
|
expect(stored.pushSubscriptionState.pendingTombstoneGeneration, 8);
|
|
expect(deactivationGenerations, [8]);
|
|
|
|
container.dispose();
|
|
failTombstone = false;
|
|
container = createContainer();
|
|
await container.read(communityListProvider.future);
|
|
await container
|
|
.read(communityListProvider.notifier)
|
|
.retryPendingPushLeaseTombstone(
|
|
community.id,
|
|
advanceGeneration: true,
|
|
);
|
|
|
|
stored = (await communityStorage.loadAll()).single;
|
|
expect(stored.pushNotificationsEnabled, isFalse);
|
|
expect(stored.pushSubscriptionState.acceptedGeneration, 9);
|
|
expect(stored.pushSubscriptionState.generationCursor, 9);
|
|
expect(stored.pushSubscriptionState.pendingTombstoneGeneration, isNull);
|
|
expect(deactivationGenerations, [8, 9]);
|
|
},
|
|
);
|
|
|
|
test('removeCommunity removes from list', () async {
|
|
container = createContainer();
|
|
await container.read(communityListProvider.future);
|
|
|
|
final ws = Community.create(
|
|
name: 'Test',
|
|
relayUrl: 'https://test.example.com',
|
|
);
|
|
await container.read(communityListProvider.notifier).addCommunity(ws);
|
|
await container
|
|
.read(communityListProvider.notifier)
|
|
.removeCommunity(ws.id);
|
|
|
|
final communities = await container.read(communityListProvider.future);
|
|
expect(communities, isEmpty);
|
|
expect(journaledCommunityIds, [ws.id]);
|
|
expect(deactivatedCommunityIds, isEmpty);
|
|
expect(revocationTriggers, 1);
|
|
});
|
|
|
|
test('remote tombstone attempt cannot block local removal', () async {
|
|
final remoteAttempt = Completer<void>();
|
|
revocationTrigger = () {
|
|
revocationTriggers += 1;
|
|
return remoteAttempt.future;
|
|
};
|
|
container = createContainer();
|
|
await container.read(communityListProvider.future);
|
|
final community = Community.create(
|
|
name: 'Test',
|
|
relayUrl: 'https://test.example.com',
|
|
);
|
|
final notifier = container.read(communityListProvider.notifier);
|
|
await notifier.addCommunity(community);
|
|
|
|
await notifier.removeCommunity(community.id);
|
|
|
|
expect(await communityStorage.loadAll(), isEmpty);
|
|
expect(journaledCommunityIds, [community.id]);
|
|
expect(revocationTriggers, 1);
|
|
remoteAttempt.complete();
|
|
});
|
|
|
|
test('journal persistence failure keeps community credentials', () async {
|
|
container = ProviderContainer(
|
|
overrides: [
|
|
communityStorageProvider.overrideWithValue(communityStorage),
|
|
communitySnapshotWriterProvider.overrideWithValue((_) async {}),
|
|
communityPushLeaseRevocationEnqueuerProvider.overrideWithValue((
|
|
_,
|
|
) async {
|
|
throw StateError('secure storage unavailable');
|
|
}),
|
|
communityPushLeaseRevocationTriggerProvider.overrideWithValue(
|
|
() async {},
|
|
),
|
|
],
|
|
);
|
|
await container.read(communityListProvider.future);
|
|
final community = Community.create(
|
|
name: 'Test',
|
|
relayUrl: 'https://test.example.com',
|
|
);
|
|
final notifier = container.read(communityListProvider.notifier);
|
|
await notifier.addCommunity(community);
|
|
|
|
await expectLater(
|
|
notifier.removeCommunity(community.id),
|
|
throwsStateError,
|
|
);
|
|
|
|
expect(
|
|
(await communityStorage.loadAll()).map((item) => item.id),
|
|
contains(community.id),
|
|
);
|
|
});
|
|
|
|
test(
|
|
'waits for transition teardown before removing active community',
|
|
() async {
|
|
container = createContainer();
|
|
await container.read(communityListProvider.future);
|
|
|
|
final ws1 = Community.create(
|
|
name: 'One',
|
|
relayUrl: 'https://one.example.com',
|
|
);
|
|
final ws2 = Community.create(
|
|
name: 'Two',
|
|
relayUrl: 'https://two.example.com',
|
|
);
|
|
final notifier = container.read(communityListProvider.notifier);
|
|
await notifier.addCommunity(ws1);
|
|
await notifier.addCommunity(ws2);
|
|
await notifier.switchCommunity(ws1.id);
|
|
final teardown = Completer<void>();
|
|
container
|
|
.read(communityTransitionProvider)
|
|
.register(() => teardown.future);
|
|
|
|
final removing = notifier.removeCommunity(ws1.id);
|
|
await Future<void>.delayed(Duration.zero);
|
|
|
|
expect(await communityStorage.loadActiveId(), ws1.id);
|
|
expect(
|
|
(await communityStorage.loadAll()).map((community) => community.id),
|
|
contains(ws1.id),
|
|
);
|
|
teardown.complete();
|
|
await removing;
|
|
expect(await communityStorage.loadActiveId(), ws2.id);
|
|
expect(
|
|
(await communityStorage.loadAll()).map((community) => community.id),
|
|
isNot(contains(ws1.id)),
|
|
);
|
|
},
|
|
);
|
|
|
|
test('renameCommunity updates name', () async {
|
|
container = createContainer();
|
|
await container.read(communityListProvider.future);
|
|
|
|
final ws = Community.create(
|
|
name: 'Original',
|
|
relayUrl: 'https://test.example.com',
|
|
);
|
|
await container.read(communityListProvider.notifier).addCommunity(ws);
|
|
await container
|
|
.read(communityListProvider.notifier)
|
|
.renameCommunity(ws.id, 'Renamed');
|
|
|
|
final communities = await container.read(communityListProvider.future);
|
|
expect(communities.first.name, 'Renamed');
|
|
});
|
|
|
|
test('waits for transition teardown before updating active ID', () async {
|
|
container = createContainer();
|
|
await container.read(communityListProvider.future);
|
|
|
|
final ws1 = Community.create(
|
|
name: 'One',
|
|
relayUrl: 'https://one.example.com',
|
|
);
|
|
final ws2 = Community.create(
|
|
name: 'Two',
|
|
relayUrl: 'https://two.example.com',
|
|
);
|
|
final notifier = container.read(communityListProvider.notifier);
|
|
await notifier.addCommunity(ws1);
|
|
await notifier.addCommunity(ws2);
|
|
await notifier.switchCommunity(ws1.id);
|
|
final teardown = Completer<void>();
|
|
container
|
|
.read(communityTransitionProvider)
|
|
.register(() => teardown.future);
|
|
|
|
final switching = notifier.switchCommunity(ws2.id);
|
|
await Future<void>.delayed(Duration.zero);
|
|
|
|
expect(await communityStorage.loadActiveId(), ws1.id);
|
|
teardown.complete();
|
|
await switching;
|
|
expect(await communityStorage.loadActiveId(), ws2.id);
|
|
});
|
|
|
|
test('overlapping transitions share one callback run', () async {
|
|
container = createContainer();
|
|
final coordinator = container.read(communityTransitionProvider);
|
|
final teardown = Completer<void>();
|
|
var calls = 0;
|
|
coordinator.register(() {
|
|
calls++;
|
|
return teardown.future;
|
|
});
|
|
|
|
var firstCompleted = false;
|
|
var secondCompleted = false;
|
|
final first = coordinator.run().then((_) => firstCompleted = true);
|
|
final second = coordinator.run().then((_) => secondCompleted = true);
|
|
await Future<void>.delayed(Duration.zero);
|
|
|
|
expect(calls, 1);
|
|
expect(firstCompleted, isFalse);
|
|
expect(secondCompleted, isFalse);
|
|
teardown.complete();
|
|
await Future.wait([first, second]);
|
|
expect(firstCompleted, isTrue);
|
|
expect(secondCompleted, isTrue);
|
|
});
|
|
|
|
test('a later transition starts a new callback run', () async {
|
|
container = createContainer();
|
|
final coordinator = container.read(communityTransitionProvider);
|
|
var calls = 0;
|
|
coordinator.register(() async => calls++);
|
|
|
|
await coordinator.run();
|
|
await coordinator.run();
|
|
|
|
expect(calls, 2);
|
|
});
|
|
|
|
test(
|
|
'transition callback failure does not block the active ID update',
|
|
() async {
|
|
container = createContainer();
|
|
await container.read(communityListProvider.future);
|
|
|
|
final ws1 = Community.create(
|
|
name: 'One',
|
|
relayUrl: 'https://one.example.com',
|
|
);
|
|
final ws2 = Community.create(
|
|
name: 'Two',
|
|
relayUrl: 'https://two.example.com',
|
|
);
|
|
final notifier = container.read(communityListProvider.notifier);
|
|
await notifier.addCommunity(ws1);
|
|
await notifier.addCommunity(ws2);
|
|
await notifier.switchCommunity(ws1.id);
|
|
container.read(communityTransitionProvider).register(() async {
|
|
throw StateError('native cleanup failed');
|
|
});
|
|
|
|
await notifier.switchCommunity(ws2.id);
|
|
|
|
expect(await communityStorage.loadActiveId(), ws2.id);
|
|
},
|
|
);
|
|
|
|
test('switchCommunity updates active ID', () async {
|
|
container = createContainer();
|
|
await container.read(communityListProvider.future);
|
|
|
|
final ws1 = Community.create(
|
|
name: 'One',
|
|
relayUrl: 'https://one.example.com',
|
|
);
|
|
final ws2 = Community.create(
|
|
name: 'Two',
|
|
relayUrl: 'https://two.example.com',
|
|
);
|
|
|
|
final notifier = container.read(communityListProvider.notifier);
|
|
await notifier.addCommunity(ws1);
|
|
await notifier.addCommunity(ws2);
|
|
await notifier.switchCommunity(ws2.id);
|
|
|
|
final activeId = await communityStorage.loadActiveId();
|
|
expect(activeId, ws2.id);
|
|
});
|
|
});
|
|
|
|
group('activeCommunityProvider', () {
|
|
test('returns null when no communities', () async {
|
|
container = createContainer();
|
|
final active = await container.read(activeCommunityProvider.future);
|
|
expect(active, isNull);
|
|
});
|
|
|
|
test('returns community matching active ID', () async {
|
|
container = createContainer();
|
|
await container.read(communityListProvider.future);
|
|
|
|
final ws = Community.create(
|
|
name: 'Test',
|
|
relayUrl: 'https://test.example.com',
|
|
);
|
|
final notifier = container.read(communityListProvider.notifier);
|
|
await notifier.addCommunity(ws);
|
|
await notifier.switchCommunity(ws.id);
|
|
|
|
final active = await container.read(activeCommunityProvider.future);
|
|
expect(active, isNotNull);
|
|
expect(active!.id, ws.id);
|
|
expect(active.name, 'Test');
|
|
});
|
|
|
|
test('falls back to first community if active ID is invalid', () async {
|
|
container = createContainer();
|
|
await container.read(communityListProvider.future);
|
|
|
|
final ws = Community.create(
|
|
name: 'Fallback',
|
|
relayUrl: 'https://test.example.com',
|
|
);
|
|
final notifier = container.read(communityListProvider.notifier);
|
|
await notifier.addCommunity(ws);
|
|
|
|
// Set an invalid active ID.
|
|
await communityStorage.saveActiveId('nonexistent-id');
|
|
|
|
// Re-read — should fall back.
|
|
container.invalidate(activeCommunityProvider);
|
|
final active = await container.read(activeCommunityProvider.future);
|
|
expect(active, isNotNull);
|
|
expect(active!.id, ws.id);
|
|
});
|
|
});
|
|
}
|