Files
buzz/mobile/test/shared/push/push_lease_revocation_outbox_test.dart
Tom Brow c432a111ca feat(mobile): push notifications MVP (#6269)
This PR implements MVP, iOS-only,
[NIP-PL](8d2d0ff5ad/docs/nips/NIP-PL.md)-compliant
push notifications.

A relay with `BUZZ_PUSH_ENABLED` will send a push notification for any
message that appears in the in-app Notifications tab.

## Enrollment flow
The first time the client first connects to a relay with
`BUZZ_PUSH_ENABLED`:
```mermaid
sequenceDiagram
    autonumber
    participant App as Buzz iOS app
    participant iOS
    participant Relay as Buzz relay
    participant Attest as Apple App Attest
    participant Gateway as Push gateway

    App->>Relay: Fetch NIP-11 push capability
    Relay-->>App: Push profile, current relay public key, and limits

    par
        App->>iOS: Request notification permission
        iOS-->>App: Permission result
    and
        App->>iOS: Register for remote notifications
        iOS-->>App: Device token
    end

    App->>Gateway: Request installation challenge
    Gateway-->>App: Single-use challenge
    App->>Attest: Attest installation transcript
    Attest-->>App: Attestation proof
    App->>Gateway: Enroll device token and proof
    Gateway-->>App: Installation handle

    App->>Gateway: Request delegation challenge
    Gateway-->>App: Single-use challenge
    App->>Attest: Assert relay-key delegation
    Attest-->>App: Assertion
    App->>Gateway: Create delegation
    Gateway-->>App: Opaque endpoint grant

    App->>Relay: Publish encrypted push lease and filters
    Relay-->>App: Lease acknowledged
```

## Push-time flow

When a notification-eligible event is received by the relay:

```mermaid
%%{init: {
  "sequence": {
    "actorMargin": 20,
    "width": 110,
    "messageMargin": 18,
    "diagramMarginX": 8,
    "wrap": true
  }
}}%%
sequenceDiagram
    autonumber
    participant Relay as Buzz relay
    participant Gateway as Push gateway
    participant APNs as Apple Push<br/>Notification service
    participant iOS
    participant NSE as Notification service<br/>extension

    Relay->>Gateway: POST /v1/deliveries/apns<br/>opaque endpoint grant, request ID, expiry, NIP-98 authorization

    Gateway->>APNs: POST /3/device/{device-token}<br/>topic, request ID, expiry, constant mutable-content payload
    APNs-->>Gateway: 200 OK: request accepted
    Gateway-->>Relay: 200 OK: accepted status

    APNs-->>iOS: Notification: constant reconnect alert<br/>mutable-content = 1
    iOS->>NSE: Invoke extension<br/>original notification content

    NSE->>Relay: POST /query: subscription filters, limit 10<br/>NIP-98 authorization
    Relay-->>NSE: 200 OK: signed Nostr events<br/>kinds 9, 40002, 45001, or 45003

    NSE->>iOS: Complete notification: title, body, subtitle<br/>thread ID, exact-message target
```

relay → push gateway → APNs -> NSE -> Notification Center

## Known limitations

The APNs wake payload is intentionally constant and opaque: it contains
no originating community or message identifier, in keeping with the
implemented NIP-PL privacy design.

The Notification Service Extension must therefore reconnect to the relay
and resolve eligible messages after each wake. Around overlapping wakes,
timing boundaries, or resolution windows, notification presentation may
occasionally omit an expected message or display a message more than
once.

This best-effort behavior is deliberately accepted for the current
implementation and will be measured during the internal rollout to
determine whether the user experience is acceptable before any broader
deployment; the implementation does not claim exactly-once presentation.

## Validation

Live end-to-end hardware validation used an internal remotely hosted
development relay and push gateway, the APNs sandbox, and a physical
iPhone 12 mini:

- A second real Buzz client published a uniquely marked message through
the hosted relay.
- The relay matched the message and sent the constant opaque wake
through the hosted gateway. The gateway made an actual APNs request; no
`simctl push` or simulated notification was used.
- The iPhone received the notification on its lock screen. The
Notification Service Extension reconnected to the relay, fetched the
event, verified its ID and signature, and replaced the placeholder
content with the real notification title and body.
- After the app populated its shared presentation cache, a final marked
notification visibly showed the sender display name, sender avatar, and
hashtag-prefixed channel name.
- Tapping a lock-screen notification opened Buzz and exercised the
notification-response path and navigated to the corresponding message.

Final validation with a dogfood-signed artifact and production App
Attest/APNs configuration remains a release step.

## Independent pre-reviews

- **First pass:**
[Carl](buzz://message?channel=18882f4c-289f-41db-942f-81f6f8066da1&id=74ab9a93bb227f3e762568f1cf9fee66d7495b0edc3918735ff787238b9cc585)
found missing transient retries, executor-key rotation suppression,
duplicate installation renewal, and an unauthenticated challenge write
amplifier. These were resolved by [retry-safe
bootstrap](https://github.com/block/buzz/pull/6269/changes/12c66ea62)
and [authenticated renewal plus a cross-replica
quota](https://github.com/block/buzz/pull/6269/changes/8e5ece0bd).
[sol-max](buzz://message?channel=ad83385f-8e9e-4461-9a35-c1bf2e208532&id=d26d53daa4684669e2ed354638241f13f36c3a97027fe8b4dd738aff09038962)
found delegation generation burning and an edited applied migration,
resolved by [exact-generation
revocation](https://github.com/block/buzz/pull/6269/changes/c26d2159d)
and a [forward-only
migration](https://github.com/block/buzz/pull/6269/changes/956c1d099).
[k3-max](buzz://message?channel=5e46055d-a766-4065-ae25-05d1e4aaa6b2&id=d43139138a0b15f806cbdbeeedd8f69d992cadf2e805876db6fdde6a34c7eda1)
found no blockers.
- **Exact-head re-review:**
[Carl](buzz://message?channel=18882f4c-289f-41db-942f-81f6f8066da1&id=a897721673459301b0cf26e8b85a1478d7ebbb56a4621f93d774c98d395b8f68),
[sol-max](buzz://message?channel=ad83385f-8e9e-4461-9a35-c1bf2e208532&id=fb2159f709ec68f74f7b21459acd76da0e8a7c5c0f3d469f99826b0cc2380849),
and
[k3-max](buzz://message?channel=5e46055d-a766-4065-ae25-05d1e4aaa6b2&id=2ce2842910435f562e9d9cc718595848f281b122c94605e523a4b964254b8bfb)
independently returned **NO BLOCKERS** at `7eb3a650b`; k3-max also
revalidated every remediation and the endpoint-specific App Attest
enrollment bound.

---------

Signed-off-by: Tom Brow <tomb@squareup.com>
Signed-off-by: Tom Brow <tomb@block.xyz>
Co-authored-by: Tom Brow <tomb@squareup.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Jordan Mecom <jm@squareup.com>
2026-08-28 15:15:09 -06:00

332 lines
9.3 KiB
Dart

import 'dart:async';
import 'package:buzz/shared/community/community.dart';
import 'package:buzz/shared/push/push_bridge.dart';
import 'package:buzz/shared/push/push_lease_revocation_outbox.dart';
import 'package:buzz/shared/push/push_subscription.dart';
import 'package:flutter_test/flutter_test.dart';
import 'package:nostr/nostr.dart' as nostr;
import '../community/community_storage_test.dart';
void main() {
late FakeSecureStorage secure;
late BuzzPushLeaseRevocationStorage storage;
late _Clock clock;
late _WakeScheduler scheduler;
late nostr.Keys keys;
setUp(() {
secure = FakeSecureStorage();
storage = BuzzPushLeaseRevocationStorage(secure: secure);
clock = _Clock(1_000_000);
scheduler = _WakeScheduler();
keys = nostr.Keys.generate();
});
test('community removal journals one precise lease address', () async {
final outbox = _outbox(
storage: storage,
clock: clock,
scheduler: scheduler,
publisher: (_) async {},
);
final community =
Community.create(
name: 'Test',
relayUrl: 'wss://relay.example',
nsec: keys.nsec,
).copyWith(
pubkey: keys.public,
pushNotificationsEnabled: true,
pushSubscriptionState: const BuzzPushLeaseSubscriptionState.desired()
.withReservedGeneration(4),
);
final grant = _grant(expiresAt: clock.seconds + 3600);
await outbox.enqueueCommunity(community, readGrants: () async => [grant]);
await outbox.enqueueCommunity(community, readGrants: () async => [grant]);
final records = await storage.loadAll();
expect(records, hasLength(1));
expect(
records.single.leaseAddress,
'${keys.public}|wss://relay.example|${community.pushLeaseInstallationId}',
);
expect(records.single.generation, 6);
expect(records.single.expiresAt, grant.expiresAt);
expect(records.single.relayUrl, 'https://relay.example/');
});
test('legacy community revokes its grant-addressed lease', () async {
final outbox = _outbox(
storage: storage,
clock: clock,
scheduler: scheduler,
publisher: (_) async {},
);
final community = Community(
id: 'legacy',
name: 'Legacy',
relayUrl: 'wss://relay.example',
pubkey: keys.public,
nsec: keys.nsec,
pushNotificationsEnabled: true,
pushSubscriptionState: const BuzzPushLeaseSubscriptionState.desired()
.withReservedGeneration(4),
addedAt: DateTime.fromMillisecondsSinceEpoch(0),
);
final grant = _grant(expiresAt: clock.seconds + 3600);
await outbox.enqueueCommunity(community, readGrants: () async => [grant]);
expect(
(await storage.loadAll()).single.leaseAddress,
'${keys.public}|wss://relay.example|${grant.installationId}',
);
});
test('concurrent reconnect and resume triggers share one attempt', () async {
final started = Completer<void>();
final release = Completer<void>();
var calls = 0;
final outbox = _outbox(
storage: storage,
clock: clock,
scheduler: scheduler,
publisher: (_) async {
calls += 1;
if (!started.isCompleted) started.complete();
await release.future;
},
);
await outbox.enqueue(_record(keys: keys, clock: clock));
final startup = outbox.start();
await started.future;
final reconnect = outbox.trigger();
final resume = outbox.trigger();
expect(calls, 1);
expect(identical(reconnect, resume), isTrue);
release.complete();
await Future.wait([startup, reconnect, resume]);
expect(calls, 1);
expect(await storage.loadAll(), isEmpty);
});
test('failure reserves durable backoff and restart waits for it', () async {
var failedCalls = 0;
final first = _outbox(
storage: storage,
clock: clock,
scheduler: scheduler,
publisher: (_) async {
failedCalls += 1;
throw StateError('offline');
},
);
await first.enqueue(_record(keys: keys, clock: clock));
await first.trigger();
final pending = (await storage.loadAll()).single;
expect(failedCalls, 1);
expect(pending.attemptCount, 1);
expect(pending.generation, 8);
expect(pending.nextAttemptAt, clock.seconds + 15);
var restartedCalls = 0;
final restarted = _outbox(
storage: storage,
clock: clock,
scheduler: scheduler,
publisher: (_) async => restartedCalls += 1,
);
await restarted.start();
await restarted.trigger();
await restarted.trigger();
expect(restartedCalls, 0);
clock.seconds = pending.nextAttemptAt;
await restarted.trigger();
expect(restartedCalls, 1);
expect(await storage.loadAll(), isEmpty);
});
test('repeated failed restarts cannot create a retry storm', () async {
await storage.replaceAll([_record(keys: keys, clock: clock)]);
var calls = 0;
for (var restart = 0; restart < 4; restart += 1) {
final outbox = _outbox(
storage: storage,
clock: clock,
scheduler: scheduler,
publisher: (_) async {
calls += 1;
throw StateError('offline');
},
);
await outbox.start();
await Future.wait([outbox.trigger(), outbox.trigger(), outbox.trigger()]);
outbox.dispose();
}
expect(calls, 1);
final pending = (await storage.loadAll()).single;
expect(pending.attemptCount, 1);
expect(pending.nextAttemptAt, greaterThan(clock.seconds));
});
test('retry delay grows exponentially and remains bounded', () async {
await storage.replaceAll([
_record(
keys: keys,
clock: clock,
).copyWith(expiresAt: clock.seconds + 10_000_000),
]);
final outbox = _outbox(
storage: storage,
clock: clock,
scheduler: scheduler,
publisher: (_) async => throw StateError('offline'),
);
final delays = <int>[];
for (var attempt = 0; attempt < 14; attempt += 1) {
await outbox.trigger();
final pending = (await storage.loadAll()).single;
delays.add(pending.nextAttemptAt - clock.seconds);
clock.seconds = pending.nextAttemptAt;
}
expect(delays.take(4), [15, 30, 60, 120]);
expect(delays.every((delay) => delay <= 6 * 60 * 60), isTrue);
expect(delays.last, 3 * 60 * 60);
});
test('expired lease is erased without a relay attempt', () async {
final expired = _record(
keys: keys,
clock: clock,
).copyWith(expiresAt: clock.seconds);
await storage.replaceAll([expired]);
var calls = 0;
final outbox = _outbox(
storage: storage,
clock: clock,
scheduler: scheduler,
publisher: (_) async => calls += 1,
);
await outbox.start();
expect(calls, 0);
expect(await storage.loadAll(), isEmpty);
});
test('different records are globally serialized', () async {
final firstStarted = Completer<void>();
final releaseFirst = Completer<void>();
var inFlight = 0;
var maximumInFlight = 0;
var calls = 0;
final outbox = _outbox(
storage: storage,
clock: clock,
scheduler: scheduler,
publisher: (_) async {
calls += 1;
inFlight += 1;
maximumInFlight = inFlight > maximumInFlight
? inFlight
: maximumInFlight;
if (calls == 1) {
firstStarted.complete();
await releaseFirst.future;
}
inFlight -= 1;
},
);
await outbox.enqueue(_record(keys: keys, clock: clock));
final otherKeys = nostr.Keys.generate();
await outbox.enqueue(
_record(keys: otherKeys, clock: clock, installationId: '1' * 32),
);
final draining = outbox.trigger();
await firstStarted.future;
expect(calls, 1);
releaseFirst.complete();
await draining;
expect(calls, 2);
expect(maximumInFlight, 1);
expect(await storage.loadAll(), isEmpty);
});
}
BuzzPushLeaseRevocationOutbox _outbox({
required BuzzPushLeaseRevocationStorage storage,
required _Clock clock,
required _WakeScheduler scheduler,
required BuzzPushLeaseRevocationPublisher publisher,
}) => BuzzPushLeaseRevocationOutbox(
storage: storage,
publisher: publisher,
now: clock.call,
jitter: () => 0,
reportError: (_, _) {},
scheduleWake: scheduler.schedule,
);
BuzzPushLeaseRevocationRecord _record({
required nostr.Keys keys,
required _Clock clock,
String installationId = '00000000000000000000000000000000',
}) => BuzzPushLeaseRevocationRecord(
relayUrl: 'https://relay.example',
relayOrigin: 'wss://relay.example',
memberPubkey: keys.public,
nsec: keys.nsec,
installationId: installationId,
generation: 7,
expiresAt: clock.seconds + 3600,
attemptCount: 0,
nextAttemptAt: clock.seconds,
);
BuzzPushEndpointGrant _grant({required int expiresAt}) => BuzzPushEndpointGrant(
relayOrigin: 'wss://relay.example',
relayPubkey: 'a' * 64,
installationId: '0' * 32,
endpointGrant: 'opaque',
endpointHash: 'b' * 64,
appProfile: 'buzz-ios-dogfood',
endpointEpoch: 1,
generation: 1,
expiresAt: expiresAt,
);
class _Clock {
_Clock(this.seconds);
int seconds;
DateTime call() => DateTime.fromMillisecondsSinceEpoch(seconds * 1000);
}
class _WakeScheduler {
final List<_ScheduledWake> _wakes = [];
void Function() schedule(Duration delay, void Function() callback) {
final wake = _ScheduledWake();
_wakes.add(wake);
return () => wake.cancelled = true;
}
}
class _ScheduledWake {
bool cancelled = false;
}