mirror of
https://github.com/block/buzz.git
synced 2026-10-27 12:40:30 +00:00
868e2f8f32
Buzz push currently selects an application profile, such as `dogfood`, during client registration. We want each gateway to serve one Apple app configured by the operator instead. This removes profile selection from the client, relay, and gateway, while allowing internal and public gateways to use their own Apple identities. This PR implements that model in the Buzz source and upstream deployment chart. Discovery, enrollment, grants, and leases no longer carry an application-profile selector. Each gateway has one configured Apple application and APNs transport. The protocol changes are incompatible with the old registration format, so relays advertise `buzz-push-v1` instead of `nip-pl`. Old clients do not discover the new push capability. Updated clients use separate Keychain records and register again. The [push notes](https://github.com/block/buzz/blob/push-capability-v1/docs/buzz-push.md) describe the experimental contract. Landing this PR is the first step. Publish the matching gateway image and upstream chart, then land the [shared chart update](https://github.com/squareup/cash-helm-charts/pull/5740) and [gateway deployment update](https://github.com/squareup/builderbot-platform-core-infrastructure/pull/1085). Before cutover, stop old gateway instances and check legacy registration state. Migrations refuse to proceed if old gateway installations or active relay leases remain; they do not delete that state. Physical-device verification remains necessary before production activation. ### Validation Gateway and focused Flutter push tests pass, as do the Swift package, simulator build, and native notification/enrichment tests. A local relay advertises `buzz-push-v1` without `nip-pl` or `app_profiles`. The PostgreSQL suite passed 868 tests; its two migration-test failures were corrected and pass a focused rerun together with the gateway cutover guard. Chart rendering and release-contract checks pass. Desktop JavaScript tests, desktop and web builds, native desktop compilation, mobile analysis/tests, and desktop native tests pass. The full Rust unit lane and prescribed `just test` command pass, including workspace integration tests against task-isolated local services. The production overlay now requires an explicitly supplied APNs topic, with omission and rendered-value regression coverage. The corrected Swift checksum assertion passes the complete package suite: 78 XCTest tests and 42 Swift Testing tests. No physical-device enrollment or production cutover is claimed. Local merge validation: the embedded migration test and formatting pass after reserving profile migration 0060 behind rollback migration 0059. The local pre-push Rust lane failed ACP timing/steering tests (`idle_resets_on_stdout_activity`, `keepalive_resets_idle_past_deadline`, and the failed/missing-outcome steering tests). ACP and its dependency manifests are unchanged by this branch; all four pass in an isolated single-thread rerun. The documented local-check exception skips only the Rust pre-push lane for publication; required CI remains mandatory. Mobile and desktop pre-push lanes passed. Combined migration validation: after rollback 0059 landed, the main merge preserves profile migration 0060 and both embedded migration assertions. The focused migration test and formatting pass. The next local push again failed only the unchanged ACP idle/keepalive timing tests (1053 passed, 2 failed, 3 ignored); other lanes passed. Publication uses the same documented local Rust-lane exception; required CI remains mandatory. Follow-up review fix: removed the legacy profile column from the copied-lease fixture. All four event-follow-up contract tests pass on isolated PostgreSQL databases, covering desired and migrated schemas in dual and app-only modes. Formatting passes. Publication retains the prior passing local-lane evidence and uses the authorized pre-push exception for the known unrelated ACP timing failures; required CI remains mandatory. --------- Signed-off-by: Tom Brow <tomb@block.xyz>
Age-check contract
Normal app, relay, and push startup do not depend on an age result. The only operation that can restrict access is a valid under-18 response from the current launch request. Errors, malformed responses, timeout, disposal, and late callbacks leave access allowed. There is one attempt per provider lifecycle, with no blocking retry or restart flow.
Production enforcement remains disabled. Dogfood builds can opt in with the
Flutter define BUZZ_AGE_GATING_ENABLED=true. This enables the same notifier used
by the native-channel and app tests. No real-device build is a PR prerequisite;
actual OS prompts, signing, and account behavior will be checked in pre-release testing.
Automated evidence
age_signal_provider_test.dart: real method-channel codec, allowed/under-18 boundaries, malformed payloads, exceptions, missing plugin, timeout, late completion, concurrent callers, invalidation, disposal, and the build opt-in.age_gate_app_test.dart: full app and push bootstrap remain mounted while the native response is pending or fails, and unmount only for a current under-18 response. Notification restoration failure does not gate app access.- Notification restriction leaves saved snapshots, signing keys, preferences, and remote leases intact. Only the confirming app process holds restriction authority; a later launch does not need storage restoration to allow access.
- Swift and Kotlin adapter tests: platform-specific bounds are normalized conservatively, including contradictory ranges and extreme integers. Android SDK task tests exercise shared access, minor response delivery, both failure stages, and retired callbacks through the production request coordinator.
- iOS simulator RunnerTests: the production method handlers deliver minor/error callbacks, allow notification restoration without app-group storage, and preserve snapshots through restriction, cleanup failure, and restoration.
- Swift notification tests: real cross-process lock contention suppresses presentation. Process exit releases restriction without cleanup. Missing, stale, and inaccessible lock files cannot establish a restriction.
Run the Flutter age-gate suite both with and without the pre-release testing define. A test must fail if pending/error becomes restricted or an expired request can restrict. The implementation was mutation-tested for pending and error blocking.
An already-running platform consent dialog cannot be proven dismissible by Dart unit tests. That behavior remains part of pre-release testing validation before general re-enablement. Old releases that permanently saved push opt-out preferences did not record their cause; this change does not guess which opt-outs to reverse.