Files
buzz/mobile/test/features/settings/notification_toggle_test.dart
Tom Brow dc4cdc4990 fix(mobile): reset community notification preferences (#8455)
Community notification choices now use `pushNotificationsEnabledV2`,
defaulting ON when absent. This gives every installed community a fresh
enabled preference, including communities previously disabled.
Subsequent explicit OFF choices persist per community through reloads
and reconnects. Previous values are deliberately discarded, not migrated
or preserved. There is no migration or compatibility read.

Enabled communities enter the existing APNs enrollment and active relay
lease publication path when connected to a push-capable relay. iOS still
controls notification display authorization. Notification eligibility
and lease addressing are unchanged.

Related work: [#8425](https://github.com/block/buzz/pull/8425).

### Validation

- Extended the settings integration test to load a saved community with
the previous preference OFF and no new preference and verify native
enrollment plus decrypted active lease publication, then OFF across
reconnect and ON again.
- The focused model test proves both previous values are ignored and
new-key OFF wins even when the previous key says ON. A temporary
compatibility-fallback mutation failed this test as expected; the
implementation was restored unchanged.
- Added storage coverage for independent community choices across
reloads; updated existing model round-trip coverage for the new key.
- Mobile dependency setup, formatting, analysis, and the full mobile
suite passed, including gateway-unconfigured coverage.
- Agent review found no blockers. Enrollment coverage uses the real
Flutter bootstrap, storage, signing, and lease construction with mocked
native and relay boundaries; no physical-device or live APNs delivery
test was run.

The fresh enabled preference is an intentional product exception to the
general zero-notification default in VISION.md. Subsequent user choices
and existing eligibility filters remain authoritative.

<!-- buzz-review-completed -->

---------

Signed-off-by: Tom Brow <tomb@block.xyz>
2026-10-19 10:09:25 -07:00

365 lines
14 KiB
Dart

import 'dart:async';
import 'dart:convert';
import 'package:buzz/features/settings/settings_page.dart';
import 'package:buzz/shared/auth/auth_provider.dart';
import 'package:buzz/shared/community/community.dart';
import 'package:buzz/shared/community/community_provider.dart';
import 'package:buzz/shared/community/community_storage.dart';
import 'package:buzz/shared/push/dev_push_lease.dart';
import 'package:buzz/shared/push/push_bootstrap.dart';
import 'package:buzz/shared/push/push_lease_revocation_outbox.dart';
import 'package:buzz/shared/crypto/nip44.dart';
import 'package:buzz/shared/relay/nostr_models.dart';
import 'package:buzz/shared/relay/signed_event_relay.dart';
import 'package:buzz/shared/push/push_bridge.dart';
import 'package:buzz/shared/push/push_relay_capability_provider.dart';
import 'package:buzz/shared/push/push_subscription.dart';
import 'package:buzz/shared/relay/app_lifecycle_provider.dart';
import 'package:buzz/shared/relay/relay_provider.dart';
import 'package:buzz/shared/relay/relay_session.dart';
import 'package:buzz/shared/theme/theme.dart';
import 'package:flutter/foundation.dart';
import 'package:flutter/material.dart';
import 'package:flutter/services.dart';
import 'package:flutter_test/flutter_test.dart';
import 'package:hooks_riverpod/hooks_riverpod.dart';
import 'package:package_info_plus/package_info_plus.dart';
import 'package:nostr/nostr.dart' as nostr;
import 'package:shared_preferences/shared_preferences.dart';
import '../../shared/community/community_storage_test.dart';
void main() {
TestWidgetsFlutterBinding.ensureInitialized();
setUpAll(() async {
final fonts = FontLoader('Inter')
..addFont(rootBundle.load('assets/fonts/InterVariable.ttf'));
await fonts.load();
});
for (final outcome in [
'accepted',
'failed',
'pending',
'scaled',
'unset preference',
]) {
testWidgets('off then on remains usable with $outcome cleanup', (
tester,
) async {
final semantics = tester.ensureSemantics();
// iPhone 12 mini width; use a wider screen for the 2x single-line case.
tester.view.physicalSize = Size(outcome == 'scaled' ? 430 : 375, 1800);
tester.view.devicePixelRatio = 1;
addTearDown(tester.view.reset);
if (outcome == 'scaled') {
tester.platformDispatcher.textScaleFactorTestValue = 2;
addTearDown(tester.platformDispatcher.clearTextScaleFactorTestValue);
}
debugDefaultTargetPlatformOverride = TargetPlatform.iOS;
addTearDown(() => debugDefaultTargetPlatformOverride = null);
PackageInfo.setMockInitialValues(
appName: 'Buzz',
packageName: 'buzz',
version: '1.0.0',
buildNumber: '1',
buildSignature: '',
);
SharedPreferences.setMockInitialValues({});
final prefs = await SharedPreferences.getInstance();
final secure = FakeSecureStorage();
final storage = CommunityStorage(secure: secure);
final subscriptions = [
BuzzPushSubscription(
filter: BuzzPushFilter(kinds: const [9], pTags: ['a' * 64]),
notificationClass: 'default',
),
];
var discoveries = 0;
final session = _Connected();
apnsDeviceToken.value = 'test-apns-token';
addTearDown(() => apnsDeviceToken.value = null);
final grant = <String, Object>{
'relayOrigin': 'wss://relay.example',
'relayPubkey': _descriptor.executorPubkey,
'installationId': 'b' * 32,
'endpointGrant': 'test-endpoint-grant',
'endpointHash': 'c' * 64,
'endpointEpoch': 1,
'generation': 1,
'expiresAt': DateTime.now().millisecondsSinceEpoch ~/ 1000 + 3600,
};
const nativePush = MethodChannel('buzz/push');
final messenger =
TestDefaultBinaryMessengerBinding.instance.defaultBinaryMessenger;
messenger.setMockMethodCallHandler(
nativePush,
(call) async => switch (call.method) {
'enrollPush' => grant,
'endpointGrants' => [grant],
'startRegistration' || 'syncPushSnapshot' => null,
_ => throw StateError('Unexpected native call ${call.method}'),
},
);
addTearDown(() => messenger.setMockMethodCallHandler(nativePush, null));
final community =
Community.create(
name: 'Team',
relayUrl: 'https://relay.example',
).copyWith(
nsec: nostr.Nip19.encode(
prefix: nostr.Nip19Prefix.nsec,
data: '1' * 64,
),
pushNotificationsEnabled: true,
pushLeaseInstallationId: 'd' * 32,
pushSubscriptionState: BuzzPushLeaseSubscriptionState.desired(
desired: subscriptions,
).withAccepted(subscriptions: subscriptions, generation: 7),
);
if (outcome == 'unset preference') {
final saved = community.toJson()..remove('pushNotificationsEnabledV2');
saved['pushNotificationsEnabled'] = false;
secure['buzz_communities'] = jsonEncode([saved]);
} else {
await storage.save(community);
}
await storage.saveActiveId(community.id);
final cleanup = Completer<void>();
final showingSettings = ValueNotifier(true);
addTearDown(showingSettings.dispose);
final snapshots = <List<Community>>[];
final tombstones = <int?>[];
await tester.pumpWidget(
ProviderScope(
overrides: [
savedPrefsProvider.overrideWithValue(prefs),
authProvider.overrideWith(_Auth.new),
communityStorageProvider.overrideWithValue(storage),
communitySnapshotWriterProvider.overrideWithValue((
communities,
) async {
snapshots.add(List.of(communities));
}),
communityPushLeaseDeactivatorProvider.overrideWithValue((
community, {
generation,
}) async {
tombstones.add(generation);
if (outcome == 'failed') throw StateError('relay unavailable');
if (outcome == 'pending') await cleanup.future;
await publishBuzzPushLeaseTombstone(
descriptor: _descriptor,
installationId: community.pushLeaseInstallationId!,
generation: generation!,
nsec: community.nsec!,
memberPubkey: pubkeyFromNsec(community.nsec)!,
submit: SignedEventRelay(
session: session,
nsec: community.nsec,
).submit,
);
}),
buzzPushLeaseRevocationStorageProvider.overrideWithValue(
BuzzPushLeaseRevocationStorage(secure: FakeSecureStorage()),
),
relaySessionProvider.overrideWith(() => session),
myPubkeyProvider.overrideWithValue(nostr.Keys('1' * 64).public),
buzzPushDescriptorFetcherProvider.overrideWithValue((_) async {
discoveries++;
return _descriptor;
}),
appLifecycleProvider.overrideWith(_Lifecycle.new),
buzzPushAuthorizationStatusReaderProvider.overrideWithValue(
() async => BuzzPushAuthorizationStatus.denied,
),
],
child: BuzzPushBootstrap(
child: MaterialApp(
theme: AppTheme.light(),
home: ValueListenableBuilder(
valueListenable: showingSettings,
builder: (_, showing, _) => showing
? SettingsPage(
profileHeader: const SizedBox.shrink(),
identityRecoveryPageBuilder: (_) =>
const SizedBox.shrink(),
)
: const SizedBox.shrink(),
),
),
),
),
);
await tester.pumpAndSettle();
final container = ProviderScope.containerOf(
tester.element(find.byType(SettingsPage)),
);
expect(
container.read(activeCommunityProvider).value?.pushNotificationsEnabled,
isTrue,
reason:
'${container.read(activeCommunityProvider)} / ${container.read(communityListProvider)}',
);
expect(session.leases.single['active'], isTrue);
// Capability discovery plus the active publication.
expect(discoveries, 2);
expect(tester.widget<Switch>(find.byType(Switch)).value, isTrue);
expect(
tester.getSemantics(
find.byKey(const ValueKey('push-notifications-setting')),
),
isSemantics(
label: 'Notifications',
hasToggledState: true,
isToggled: true,
),
);
expect(
tester.getSize(find.byType(Switch)).height,
greaterThanOrEqualTo(48),
);
// Compare rendered row bounds, not just their padding parameters.
final notificationHeight = tester
.getSize(find.byKey(const ValueKey('push-notifications-enabled')))
.height;
final statusHeight = tester
.getSize(find.byKey(const ValueKey('settings-set-status')))
.height;
expect(
notificationHeight,
statusHeight,
reason: 'single-line settings rows share a height',
);
await tester.tap(find.byType(Switch));
await tester.pumpAndSettle();
final stored = (await storage.loadAll()).single;
expect(stored.pushNotificationsEnabled, isFalse);
expect(
stored.pushSubscriptionState.pendingTombstoneGeneration,
outcome == 'failed' || outcome == 'pending'
? greaterThanOrEqualTo(9)
: isNull,
);
expect(tombstones.first, 9);
expect(
tombstones.length,
lessThanOrEqualTo(2),
reason: 'failed cleanup must not defeat the retry backoff',
);
expect(discoveries, 2);
session.setStatus(SessionStatus.disconnected);
await tester.pumpAndSettle();
session.setStatus(SessionStatus.connected);
await tester.pumpAndSettle();
expect(
session.leases.where((lease) => lease['active'] == true),
hasLength(1),
);
expect(discoveries, 3);
expect(snapshots.last.single.pushNotificationsEnabled, isFalse);
final offSwitch = tester.widget<Switch>(find.byType(Switch));
expect(offSwitch.value, isFalse);
expect(offSwitch.onChanged, isNotNull);
// Closing and reopening Settings must not strand the off control either.
showingSettings.value = false;
await tester.pumpAndSettle();
showingSettings.value = true;
await tester.pumpAndSettle();
expect(tester.widget<Switch>(find.byType(Switch)).onChanged, isNotNull);
await tester.tap(find.text('Notifications'));
await tester.pumpAndSettle();
expect(tester.widget<Switch>(find.byType(Switch)).value, isTrue);
expect((await storage.loadAll()).single.pushNotificationsEnabled, isTrue);
expect(
session.leases.where((lease) => lease['active'] == true).length,
2,
reason:
're-enabling must publish an active lease before the renewal timer',
);
expect(session.leases.last['generation'], greaterThan(tombstones.last!));
if (outcome == 'pending') {
cleanup.complete();
await tester.pumpAndSettle();
expect(
(await storage.loadAll()).single.pushNotificationsEnabled,
isTrue,
);
}
final latestLease = session.leases.reduce(
(a, b) => (a['generation'] as int) > (b['generation'] as int) ? a : b,
);
expect(
latestLease['active'],
isTrue,
reason: 'a delayed old tombstone cannot supersede the new active lease',
);
expect(discoveries, 4);
// A real reconnect must still discover capability again.
(container.read(relaySessionProvider.notifier) as _Connected).setStatus(
SessionStatus.disconnected,
);
await tester.pumpAndSettle();
expect(container.read(currentRelayPushDescriptorProvider).value, isNull);
(container.read(relaySessionProvider.notifier) as _Connected).setStatus(
SessionStatus.connected,
);
await tester.pumpAndSettle();
expect(discoveries, 5);
expect(tester.widget<Switch>(find.byType(Switch)).onChanged, isNotNull);
expect(tester.takeException(), isNull);
await tester.pumpWidget(const SizedBox.shrink());
await tester.pumpAndSettle();
semantics.dispose();
debugDefaultTargetPlatformOverride = null;
});
}
}
class _Lifecycle extends AppLifecycleNotifier {
@override
AppLifecycleState build() => AppLifecycleState.resumed;
}
class _Auth extends AuthNotifier {
@override
Future<AuthState> build() async =>
const AuthState(status: AuthStatus.unauthenticated);
}
class _Connected extends RelaySessionNotifier {
final leases = <Map<String, dynamic>>[];
@override
Future<NostrEvent> publish(
NostrEvent event, {
Duration timeout = const Duration(seconds: 8),
}) async {
expect(event.kind, buzzPushLeaseKind);
final plaintext = nip44Decrypt(
getConversationKey('2' * 64, event.pubkey),
event.content,
);
leases.add(jsonDecode(plaintext) as Map<String, dynamic>);
return event;
}
void setStatus(SessionStatus status) => state = SessionState(status: status);
@override
SessionState build() => const SessionState(status: SessionStatus.connected);
}
final _descriptor = BuzzPushLeaseDescriptor(
origin: 'wss://relay.example',
executorKeyId: 'relay-v1',
executorPubkey: nostr.Keys('2' * 64).public,
transport: 'apns',
maxLeaseTtlSeconds: 3600,
maxContentLength: 4096,
maxPlaintextLength: 4096,
maxEndpointLength: 2048,
maxStringLength: 512,
);