mirror of
https://github.com/block/buzz.git
synced 2026-10-27 12:40:30 +00:00
Community notification choices now use `pushNotificationsEnabledV2`, defaulting ON when absent. This gives every installed community a fresh enabled preference, including communities previously disabled. Subsequent explicit OFF choices persist per community through reloads and reconnects. Previous values are deliberately discarded, not migrated or preserved. There is no migration or compatibility read. Enabled communities enter the existing APNs enrollment and active relay lease publication path when connected to a push-capable relay. iOS still controls notification display authorization. Notification eligibility and lease addressing are unchanged. Related work: [#8425](https://github.com/block/buzz/pull/8425). ### Validation - Extended the settings integration test to load a saved community with the previous preference OFF and no new preference and verify native enrollment plus decrypted active lease publication, then OFF across reconnect and ON again. - The focused model test proves both previous values are ignored and new-key OFF wins even when the previous key says ON. A temporary compatibility-fallback mutation failed this test as expected; the implementation was restored unchanged. - Added storage coverage for independent community choices across reloads; updated existing model round-trip coverage for the new key. - Mobile dependency setup, formatting, analysis, and the full mobile suite passed, including gateway-unconfigured coverage. - Agent review found no blockers. Enrollment coverage uses the real Flutter bootstrap, storage, signing, and lease construction with mocked native and relay boundaries; no physical-device or live APNs delivery test was run. The fresh enabled preference is an intentional product exception to the general zero-notification default in VISION.md. Subsequent user choices and existing eligibility filters remain authoritative. <!-- buzz-review-completed --> --------- Signed-off-by: Tom Brow <tomb@block.xyz>
350 lines
11 KiB
Dart
350 lines
11 KiB
Dart
import 'dart:convert';
|
|
|
|
import 'package:flutter_secure_storage/flutter_secure_storage.dart';
|
|
import 'package:flutter_test/flutter_test.dart';
|
|
import 'package:buzz/shared/community/community.dart';
|
|
import 'package:buzz/shared/community/community_storage.dart';
|
|
import 'package:buzz/shared/push/push_subscription.dart';
|
|
|
|
/// In-memory fake that extends Fake to satisfy all FlutterSecureStorage
|
|
/// interface methods, but implements the core read/write/delete with real
|
|
/// in-memory logic.
|
|
class FakeSecureStorage extends Fake implements FlutterSecureStorage {
|
|
final Map<String, String> _data = {};
|
|
final Map<String, int> _writeCounts = {};
|
|
|
|
@override
|
|
Future<String?> read({
|
|
required String key,
|
|
AppleOptions? iOptions,
|
|
AndroidOptions? aOptions,
|
|
LinuxOptions? lOptions,
|
|
WebOptions? webOptions,
|
|
AppleOptions? mOptions,
|
|
WindowsOptions? wOptions,
|
|
}) async => _data[key];
|
|
|
|
@override
|
|
Future<void> write({
|
|
required String key,
|
|
required String? value,
|
|
AppleOptions? iOptions,
|
|
AndroidOptions? aOptions,
|
|
LinuxOptions? lOptions,
|
|
WebOptions? webOptions,
|
|
AppleOptions? mOptions,
|
|
WindowsOptions? wOptions,
|
|
}) async {
|
|
_writeCounts[key] = (_writeCounts[key] ?? 0) + 1;
|
|
if (value != null) {
|
|
_data[key] = value;
|
|
} else {
|
|
_data.remove(key);
|
|
}
|
|
}
|
|
|
|
@override
|
|
Future<void> delete({
|
|
required String key,
|
|
AppleOptions? iOptions,
|
|
AndroidOptions? aOptions,
|
|
LinuxOptions? lOptions,
|
|
WebOptions? webOptions,
|
|
AppleOptions? mOptions,
|
|
WindowsOptions? wOptions,
|
|
}) async => _data.remove(key);
|
|
|
|
@override
|
|
Future<Map<String, String>> readAll({
|
|
AppleOptions? iOptions,
|
|
AndroidOptions? aOptions,
|
|
LinuxOptions? lOptions,
|
|
WebOptions? webOptions,
|
|
AppleOptions? mOptions,
|
|
WindowsOptions? wOptions,
|
|
}) async => Map.from(_data);
|
|
|
|
@override
|
|
Future<void> deleteAll({
|
|
AppleOptions? iOptions,
|
|
AndroidOptions? aOptions,
|
|
LinuxOptions? lOptions,
|
|
WebOptions? webOptions,
|
|
AppleOptions? mOptions,
|
|
WindowsOptions? wOptions,
|
|
}) async => _data.clear();
|
|
|
|
@override
|
|
Future<bool> containsKey({
|
|
required String key,
|
|
AppleOptions? iOptions,
|
|
AndroidOptions? aOptions,
|
|
LinuxOptions? lOptions,
|
|
WebOptions? webOptions,
|
|
AppleOptions? mOptions,
|
|
WindowsOptions? wOptions,
|
|
}) async => _data.containsKey(key);
|
|
|
|
// Convenience for setting up test data.
|
|
String? operator [](String key) => _data[key];
|
|
void operator []=(String key, String value) => _data[key] = value;
|
|
int writeCount(String key) => _writeCounts[key] ?? 0;
|
|
}
|
|
|
|
void main() {
|
|
late FakeSecureStorage fakeSecure;
|
|
late CommunityStorage storage;
|
|
|
|
setUp(() {
|
|
fakeSecure = FakeSecureStorage();
|
|
storage = CommunityStorage(secure: fakeSecure);
|
|
});
|
|
|
|
group('CommunityStorage', () {
|
|
test('loadAll returns empty list when no data', () async {
|
|
final result = await storage.loadAll();
|
|
expect(result, isEmpty);
|
|
});
|
|
|
|
test('save and loadAll round-trips a community', () async {
|
|
final ws = Community.create(
|
|
name: 'Test',
|
|
relayUrl: 'https://relay.example.com',
|
|
pubkey: 'abc123',
|
|
);
|
|
|
|
await storage.save(ws);
|
|
final loaded = await storage.loadAll();
|
|
|
|
expect(loaded, hasLength(1));
|
|
expect(loaded.first.id, ws.id);
|
|
expect(loaded.first.name, 'Test');
|
|
expect(loaded.first.relayUrl, 'https://relay.example.com');
|
|
expect(loaded.first.pubkey, 'abc123');
|
|
expect(
|
|
loaded.first.pushSubscriptionState.authority,
|
|
BuzzPushLeaseSubscriptionAuthority.desired,
|
|
);
|
|
});
|
|
|
|
test('push choices persist independently across storage reloads', () async {
|
|
final first = Community.create(
|
|
name: 'First',
|
|
relayUrl: 'https://first.example',
|
|
pubkey: 'a' * 64,
|
|
);
|
|
final second = Community.create(
|
|
name: 'Second',
|
|
relayUrl: 'https://second.example',
|
|
pubkey: 'b' * 64,
|
|
);
|
|
await storage.saveAll([first, second]);
|
|
await storage.save(first.copyWith(pushNotificationsEnabled: false));
|
|
|
|
final reloaded = CommunityStorage(secure: fakeSecure);
|
|
final communities = await reloaded.loadAll();
|
|
expect(communities.map((c) => c.pushNotificationsEnabled), [false, true]);
|
|
expect(communities.map((c) => c.pubkey), [first.pubkey, second.pubkey]);
|
|
await reloaded.save(communities.last.copyWith(name: 'Renamed'));
|
|
expect(
|
|
(await CommunityStorage(
|
|
secure: fakeSecure,
|
|
).loadAll()).map((c) => c.pushNotificationsEnabled),
|
|
[false, true],
|
|
);
|
|
});
|
|
|
|
test('round-trips desired push subscription state', () async {
|
|
final pubkey = 'a' * 64;
|
|
final subscriptions = buildDesiredBuzzPushSubscriptions(
|
|
myPubkey: pubkey,
|
|
channelIds: const ['123e4567-e89b-42d3-a456-426614174000'],
|
|
);
|
|
final community =
|
|
Community.create(
|
|
name: 'Push',
|
|
relayUrl: 'https://relay.example.com',
|
|
pubkey: pubkey,
|
|
).copyWith(
|
|
pushSubscriptionState: BuzzPushLeaseSubscriptionState.desired(
|
|
desired: subscriptions,
|
|
),
|
|
);
|
|
|
|
await storage.save(community);
|
|
final loaded = (await storage.loadAll()).single;
|
|
|
|
expect(
|
|
loaded.pushSubscriptionState.toJson(),
|
|
community.pushSubscriptionState.toJson(),
|
|
);
|
|
});
|
|
|
|
test('round-trips a pending push tombstone journal', () async {
|
|
final subscription = BuzzPushSubscription(
|
|
filter: BuzzPushFilter(kinds: const [9], pTags: ['a' * 64]),
|
|
notificationClass: 'default',
|
|
);
|
|
final state =
|
|
BuzzPushLeaseSubscriptionState.desired(desired: [subscription])
|
|
.withAccepted(subscriptions: [subscription], generation: 4)
|
|
.withPendingTombstone(5);
|
|
final community = Community.create(
|
|
name: 'Push',
|
|
relayUrl: 'https://relay.example.com',
|
|
).copyWith(pushSubscriptionState: state);
|
|
|
|
await storage.save(community);
|
|
final loaded = (await storage.loadAll()).single;
|
|
|
|
expect(loaded.pushSubscriptionState.toJson(), state.toJson());
|
|
expect(loaded.pushSubscriptionState.pendingTombstoneGeneration, 5);
|
|
});
|
|
|
|
test(
|
|
'migrates a disabled reserved generation into a tombstone journal',
|
|
() {
|
|
final community =
|
|
Community.create(
|
|
name: 'Push',
|
|
relayUrl: 'https://relay.example.com',
|
|
).copyWith(
|
|
pushNotificationsEnabled: false,
|
|
pushSubscriptionState:
|
|
const BuzzPushLeaseSubscriptionState.desired(
|
|
acceptedGeneration: 4,
|
|
generationCursor: 5,
|
|
),
|
|
);
|
|
final json = community.toJson();
|
|
(json['pushSubscriptionState'] as Map<String, dynamic>).remove(
|
|
'pendingTombstoneGeneration',
|
|
);
|
|
|
|
final migrated = Community.fromJson(json);
|
|
|
|
expect(migrated.pushSubscriptionState.pendingTombstoneGeneration, 5);
|
|
},
|
|
);
|
|
|
|
test('save updates existing community with same id', () async {
|
|
final ws = Community.create(
|
|
name: 'Original',
|
|
relayUrl: 'https://relay.example.com',
|
|
);
|
|
|
|
await storage.save(ws);
|
|
await storage.save(ws.copyWith(name: 'Updated'));
|
|
|
|
final loaded = await storage.loadAll();
|
|
expect(loaded, hasLength(1));
|
|
expect(loaded.first.name, 'Updated');
|
|
});
|
|
|
|
test('remove deletes a community', () async {
|
|
final ws1 = Community.create(
|
|
name: 'One',
|
|
relayUrl: 'https://one.example.com',
|
|
);
|
|
final ws2 = Community.create(
|
|
name: 'Two',
|
|
relayUrl: 'https://two.example.com',
|
|
);
|
|
|
|
await storage.save(ws1);
|
|
await storage.save(ws2);
|
|
await storage.remove(ws1.id);
|
|
|
|
final loaded = await storage.loadAll();
|
|
expect(loaded, hasLength(1));
|
|
expect(loaded.first.id, ws2.id);
|
|
});
|
|
|
|
test('active community ID persists', () async {
|
|
await storage.saveActiveId('ws-123');
|
|
final id = await storage.loadActiveId();
|
|
expect(id, 'ws-123');
|
|
});
|
|
|
|
test('clearActiveId removes active ID', () async {
|
|
await storage.saveActiveId('ws-123');
|
|
await storage.clearActiveId();
|
|
final id = await storage.loadActiveId();
|
|
expect(id, isNull);
|
|
});
|
|
|
|
group('migration', () {
|
|
test('migrates saved workspaces to communities', () async {
|
|
final legacy = Community.create(
|
|
name: 'Legacy',
|
|
relayUrl: 'https://legacy.example.com',
|
|
);
|
|
fakeSecure['buzz_workspaces'] = jsonEncode([legacy.toJson()]);
|
|
fakeSecure['buzz_active_workspace_id'] = legacy.id;
|
|
|
|
final loaded = await storage.loadAll();
|
|
|
|
expect(loaded.single.id, legacy.id);
|
|
expect(await storage.loadActiveId(), legacy.id);
|
|
expect(fakeSecure['buzz_communities'], isNotNull);
|
|
expect(fakeSecure['buzz_workspaces'], isNull);
|
|
expect(fakeSecure['buzz_active_workspace_id'], isNull);
|
|
});
|
|
|
|
test('migrates legacy keys to community on first load', () async {
|
|
fakeSecure['buzz_relay_url'] = 'https://legacy.example.com';
|
|
fakeSecure['buzz_token'] = 'legacy_token';
|
|
fakeSecure['buzz_pubkey'] = 'legacy_pub';
|
|
fakeSecure['buzz_nsec'] = 'legacy_nsec';
|
|
|
|
final loaded = await storage.loadAll();
|
|
|
|
expect(loaded, hasLength(1));
|
|
expect(loaded.first.relayUrl, 'https://legacy.example.com');
|
|
expect(loaded.first.pubkey, 'legacy_pub');
|
|
expect(loaded.first.nsec, 'legacy_nsec');
|
|
expect(loaded.first.name, isNotEmpty);
|
|
expect(
|
|
loaded.first.sensitiveActionPolicy,
|
|
SensitiveActionPolicy.disabledByUser,
|
|
);
|
|
|
|
// Legacy keys should be deleted.
|
|
expect(fakeSecure['buzz_relay_url'], isNull);
|
|
expect(fakeSecure['buzz_token'], isNull);
|
|
expect(fakeSecure['buzz_pubkey'], isNull);
|
|
expect(fakeSecure['buzz_nsec'], isNull);
|
|
|
|
// Active ID should be set.
|
|
final activeId = await storage.loadActiveId();
|
|
expect(activeId, loaded.first.id);
|
|
});
|
|
|
|
test('does not migrate when no legacy keys exist', () async {
|
|
final loaded = await storage.loadAll();
|
|
expect(loaded, isEmpty);
|
|
});
|
|
|
|
test('does not re-migrate after first load', () async {
|
|
fakeSecure['buzz_relay_url'] = 'https://legacy.example.com';
|
|
fakeSecure['buzz_token'] = 'legacy_token';
|
|
|
|
final first = await storage.loadAll();
|
|
expect(first, hasLength(1));
|
|
|
|
final second = await storage.loadAll();
|
|
expect(second, hasLength(1));
|
|
expect(second.first.id, first.first.id);
|
|
});
|
|
|
|
test('migration generates name from localhost URL', () async {
|
|
fakeSecure['buzz_relay_url'] = 'http://localhost:3000';
|
|
fakeSecure['buzz_token'] = 'tok';
|
|
|
|
final loaded = await storage.loadAll();
|
|
expect(loaded.first.name, 'Local Dev');
|
|
});
|
|
});
|
|
});
|
|
}
|