mirror of
https://github.com/block/buzz.git
synced 2026-11-06 01:11:33 +00:00
e120d6dfaa
Per tho's clarification, the manifest is preview-only by design — a bad
rebase had widened it to include stable entries with an explicit `tier`
field. Restoring the original shape:
- Rename `features.json` -> `preview-features.json` (loader, alias,
ts-config, vite alias, test-loader-hooks, helpers, log strings).
- Drop the 4 stable entries from the manifest. Only the 4 preview
features remain (workflows, projects, pulse, forum).
- Drop the `tier` field from the schema, types, and Zod validator —
manifest membership is now sufficient ("in the file = preview;
absent = stable, fail-open").
- Simplify `resolveEnabled(featureId, overrides)` — once you're inside
it, the feature is preview by definition.
- `useFeatureEnabled`: in-manifest -> check overrides; otherwise return
true (fail-open).
- `usePreviewFeatureWarning`: gate on manifest membership instead of
`tier === 'preview'`.
- Settings: `ExperimentalFeaturesCard` lists every desktop feature in
the manifest directly; SettingsView feature gate uses the new
`resolveEnabled` signature.
- Tests: rewrote `resolveEnabled.test.mjs` for the new signature; helper
drops the tier filter.
Per Marge's review on the previous push, `screenshot-feature-flags.ts`
was dropped from smoke testMatch but no CI step invoked the dedicated
screenshot config — coverage was dark. Adding a `Desktop screenshot e2e`
step in `.github/workflows/ci.yml` that runs `--config=
playwright-screenshot.config.ts` after the smoke step, restoring
coverage without dirtying smoke.
Signed-off-by: npub1223z34hd7vtwc6qj4s7flsxkj644nlre2nthu7lrrmkumhu3xddsrx9r6w <52a228d6edf316ec6812ac3c9fc0d696ab59fc7954d77e7be31eedcddf91335b@sprout-oss.stage.blox.sqprod.co>
37 lines
1.2 KiB
JavaScript
37 lines
1.2 KiB
JavaScript
import { fileURLToPath } from "node:url";
|
|
import path from "node:path";
|
|
|
|
const srcRoot = path.resolve(
|
|
path.dirname(fileURLToPath(import.meta.url)),
|
|
"src",
|
|
);
|
|
|
|
const repoRoot = path.resolve(
|
|
path.dirname(fileURLToPath(import.meta.url)),
|
|
"..",
|
|
);
|
|
|
|
export function resolve(specifier, context, nextResolve) {
|
|
if (specifier === "@features-manifest") {
|
|
const resolved = path.join(repoRoot, "preview-features.json");
|
|
return nextResolve(resolved, context);
|
|
}
|
|
if (specifier.startsWith("@/")) {
|
|
const resolved = `${srcRoot}/${specifier.slice(2)}.ts`;
|
|
return nextResolve(resolved, context);
|
|
}
|
|
// Resolve extensionless relative TS imports (e.g. `./parseImeta`) — the app's
|
|
// bundler adds the extension, but node's ESM resolver does not. Without this,
|
|
// any .ts that relative-imports a sibling .ts can't be imported from a test,
|
|
// which previously forced stale inlined copies of the source under test.
|
|
if (
|
|
(specifier.startsWith("./") || specifier.startsWith("../")) &&
|
|
!path.extname(specifier) &&
|
|
context.parentURL
|
|
) {
|
|
const resolved = new URL(`${specifier}.ts`, context.parentURL).href;
|
|
return nextResolve(resolved, context);
|
|
}
|
|
return nextResolve(specifier, context);
|
|
}
|