mirror of
https://github.com/block/buzz.git
synced 2026-10-30 14:01:37 +00:00
This PR implements MVP, iOS-only,
[NIP-PL](8d2d0ff5ad/docs/nips/NIP-PL.md)-compliant
push notifications.
A relay with `BUZZ_PUSH_ENABLED` will send a push notification for any
message that appears in the in-app Notifications tab.
## Enrollment flow
The first time the client first connects to a relay with
`BUZZ_PUSH_ENABLED`:
```mermaid
sequenceDiagram
autonumber
participant App as Buzz iOS app
participant iOS
participant Relay as Buzz relay
participant Attest as Apple App Attest
participant Gateway as Push gateway
App->>Relay: Fetch NIP-11 push capability
Relay-->>App: Push profile, current relay public key, and limits
par
App->>iOS: Request notification permission
iOS-->>App: Permission result
and
App->>iOS: Register for remote notifications
iOS-->>App: Device token
end
App->>Gateway: Request installation challenge
Gateway-->>App: Single-use challenge
App->>Attest: Attest installation transcript
Attest-->>App: Attestation proof
App->>Gateway: Enroll device token and proof
Gateway-->>App: Installation handle
App->>Gateway: Request delegation challenge
Gateway-->>App: Single-use challenge
App->>Attest: Assert relay-key delegation
Attest-->>App: Assertion
App->>Gateway: Create delegation
Gateway-->>App: Opaque endpoint grant
App->>Relay: Publish encrypted push lease and filters
Relay-->>App: Lease acknowledged
```
## Push-time flow
When a notification-eligible event is received by the relay:
```mermaid
%%{init: {
"sequence": {
"actorMargin": 20,
"width": 110,
"messageMargin": 18,
"diagramMarginX": 8,
"wrap": true
}
}}%%
sequenceDiagram
autonumber
participant Relay as Buzz relay
participant Gateway as Push gateway
participant APNs as Apple Push<br/>Notification service
participant iOS
participant NSE as Notification service<br/>extension
Relay->>Gateway: POST /v1/deliveries/apns<br/>opaque endpoint grant, request ID, expiry, NIP-98 authorization
Gateway->>APNs: POST /3/device/{device-token}<br/>topic, request ID, expiry, constant mutable-content payload
APNs-->>Gateway: 200 OK: request accepted
Gateway-->>Relay: 200 OK: accepted status
APNs-->>iOS: Notification: constant reconnect alert<br/>mutable-content = 1
iOS->>NSE: Invoke extension<br/>original notification content
NSE->>Relay: POST /query: subscription filters, limit 10<br/>NIP-98 authorization
Relay-->>NSE: 200 OK: signed Nostr events<br/>kinds 9, 40002, 45001, or 45003
NSE->>iOS: Complete notification: title, body, subtitle<br/>thread ID, exact-message target
```
relay → push gateway → APNs -> NSE -> Notification Center
## Known limitations
The APNs wake payload is intentionally constant and opaque: it contains
no originating community or message identifier, in keeping with the
implemented NIP-PL privacy design.
The Notification Service Extension must therefore reconnect to the relay
and resolve eligible messages after each wake. Around overlapping wakes,
timing boundaries, or resolution windows, notification presentation may
occasionally omit an expected message or display a message more than
once.
This best-effort behavior is deliberately accepted for the current
implementation and will be measured during the internal rollout to
determine whether the user experience is acceptable before any broader
deployment; the implementation does not claim exactly-once presentation.
## Validation
Live end-to-end hardware validation used an internal remotely hosted
development relay and push gateway, the APNs sandbox, and a physical
iPhone 12 mini:
- A second real Buzz client published a uniquely marked message through
the hosted relay.
- The relay matched the message and sent the constant opaque wake
through the hosted gateway. The gateway made an actual APNs request; no
`simctl push` or simulated notification was used.
- The iPhone received the notification on its lock screen. The
Notification Service Extension reconnected to the relay, fetched the
event, verified its ID and signature, and replaced the placeholder
content with the real notification title and body.
- After the app populated its shared presentation cache, a final marked
notification visibly showed the sender display name, sender avatar, and
hashtag-prefixed channel name.
- Tapping a lock-screen notification opened Buzz and exercised the
notification-response path and navigated to the corresponding message.
Final validation with a dogfood-signed artifact and production App
Attest/APNs configuration remains a release step.
## Independent pre-reviews
- **First pass:**
[Carl](buzz://message?channel=18882f4c-289f-41db-942f-81f6f8066da1&id=74ab9a93bb227f3e762568f1cf9fee66d7495b0edc3918735ff787238b9cc585)
found missing transient retries, executor-key rotation suppression,
duplicate installation renewal, and an unauthenticated challenge write
amplifier. These were resolved by [retry-safe
bootstrap](https://github.com/block/buzz/pull/6269/changes/12c66ea62)
and [authenticated renewal plus a cross-replica
quota](https://github.com/block/buzz/pull/6269/changes/8e5ece0bd).
[sol-max](buzz://message?channel=ad83385f-8e9e-4461-9a35-c1bf2e208532&id=d26d53daa4684669e2ed354638241f13f36c3a97027fe8b4dd738aff09038962)
found delegation generation burning and an edited applied migration,
resolved by [exact-generation
revocation](https://github.com/block/buzz/pull/6269/changes/c26d2159d)
and a [forward-only
migration](https://github.com/block/buzz/pull/6269/changes/956c1d099).
[k3-max](buzz://message?channel=5e46055d-a766-4065-ae25-05d1e4aaa6b2&id=d43139138a0b15f806cbdbeeedd8f69d992cadf2e805876db6fdde6a34c7eda1)
found no blockers.
- **Exact-head re-review:**
[Carl](buzz://message?channel=18882f4c-289f-41db-942f-81f6f8066da1&id=a897721673459301b0cf26e8b85a1478d7ebbb56a4621f93d774c98d395b8f68),
[sol-max](buzz://message?channel=ad83385f-8e9e-4461-9a35-c1bf2e208532&id=fb2159f709ec68f74f7b21459acd76da0e8a7c5c0f3d469f99826b0cc2380849),
and
[k3-max](buzz://message?channel=5e46055d-a766-4065-ae25-05d1e4aaa6b2&id=2ce2842910435f562e9d9cc718595848f281b122c94605e523a4b964254b8bfb)
independently returned **NO BLOCKERS** at `7eb3a650b`; k3-max also
revalidated every remediation and the endpoint-specific App Attest
enrollment bound.
---------
Signed-off-by: Tom Brow <tomb@squareup.com>
Signed-off-by: Tom Brow <tomb@block.xyz>
Co-authored-by: Tom Brow <tomb@squareup.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Jordan Mecom <jm@squareup.com>
228 lines
9.5 KiB
Swift
228 lines
9.5 KiB
Swift
import Foundation
|
|
|
|
/// Errors thrown by the canonical transcript encoder.
|
|
public enum BuzzPushTranscriptError: Error, Equatable {
|
|
/// A string field contained non-ASCII scalars. NIP-PL admits only ASCII
|
|
/// authority-bearing strings; rather than guess at UTF-8-vs-escaping
|
|
/// behavior we fail closed.
|
|
case nonASCIIInput(field: String)
|
|
}
|
|
|
|
/// Canonical NIP-PL App Attest transcript encoder.
|
|
///
|
|
/// NIP-PL ("Exact App Attest transcript construction") pins the exact bytes
|
|
/// every App Attest operation signs:
|
|
///
|
|
/// <domain> + "\n" + <compact ordered JSON object>
|
|
///
|
|
/// The JSON object has no insignificant whitespace, members appear in a fixed
|
|
/// per-route order, integers use shortest decimal notation, and strings use
|
|
/// minimal JSON escaping (quotation mark, reverse solidus, U+0000..U+001F).
|
|
/// The gateway builds the same bytes with serde_json and compares hashes, so
|
|
/// any byte difference is a silent `401 invalid_attestation`. This encoder is
|
|
/// hand-rolled for that reason: `JSONSerialization` escapes `/` as `\/` and
|
|
/// does not guarantee member order, so it must never be used for transcripts.
|
|
///
|
|
/// Ground truth: `crates/buzz-push-gateway/tests/vectors/app_attest_transcripts.json`,
|
|
/// generated and asserted by the gateway's own encoder. The tests in this
|
|
/// package replay those vectors byte-for-byte.
|
|
///
|
|
/// The `audience` member of each transcript is a **fixed protocol constant**
|
|
/// defined by NIP-PL (`https://push.buzz.xyz/v1/...`). It is a cross-route
|
|
/// domain-separation string, not a deployment URL: the gateway hardcodes it
|
|
/// regardless of where it is hosted, so clients must never derive it from a
|
|
/// discovered gateway base URL or relay host.
|
|
public enum BuzzPushTranscript {
|
|
// MARK: Domains
|
|
|
|
public static let enrollDomain = "buzz.push.enroll.v1"
|
|
public static let delegateDomain = "buzz.push.delegate.v1"
|
|
public static let rotateEndpointDomain = "buzz.push.rotate-endpoint.v1"
|
|
public static let revokeDelegationDomain = "buzz.push.revoke-delegation.v1"
|
|
public static let revokeInstallationDomain = "buzz.push.revoke-installation.v1"
|
|
|
|
// MARK: Fixed audiences (protocol constants, see type docs)
|
|
|
|
public static let enrollAudience = "https://push.buzz.xyz/v1/installations"
|
|
public static let delegateAudience = "https://push.buzz.xyz/v1/delegations"
|
|
public static let rotateEndpointAudience = "https://push.buzz.xyz/v1/installations/endpoint"
|
|
public static let revokeDelegationAudience = "https://push.buzz.xyz/v1/delegations/revoke"
|
|
public static let revokeInstallationAudience = "https://push.buzz.xyz/v1/installations/revoke"
|
|
|
|
/// Wire version pinned by NIP-PL. Every transcript carries `"v":1`.
|
|
public static let wireVersion: Int64 = 1
|
|
|
|
// MARK: Transcripts
|
|
|
|
/// `buzz.push.enroll.v1` — these exact bytes are the App Attest
|
|
/// `clientData` supplied to attestation verification.
|
|
public static func enroll(
|
|
challengeId: UUID,
|
|
challenge: String,
|
|
keyId: String,
|
|
appProfile: String,
|
|
endpoint: String,
|
|
endpointEpoch: Int64,
|
|
expiresAt: Int64
|
|
) throws -> Data {
|
|
var o = CanonicalObject()
|
|
o.int("v", wireVersion)
|
|
try o.string("audience", Self.enrollAudience)
|
|
o.uuid("challenge_id", challengeId)
|
|
try o.string("challenge", challenge, field: "challenge")
|
|
try o.string("key_id", keyId, field: "key_id")
|
|
try o.string("app_profile", appProfile, field: "app_profile")
|
|
try o.string("endpoint", endpoint, field: "endpoint")
|
|
o.int("endpoint_epoch", endpointEpoch)
|
|
o.int("expires_at", expiresAt)
|
|
return encode(domain: enrollDomain, object: o)
|
|
}
|
|
|
|
/// `buzz.push.delegate.v1` — `SHA-256(bytes)` is the assertion
|
|
/// `clientDataHash`.
|
|
public static func delegate(
|
|
challengeId: UUID,
|
|
challenge: String,
|
|
installationHandle: UUID,
|
|
endpointEpoch: Int64,
|
|
generation: Int64,
|
|
relayPubkey: String,
|
|
notBefore: Int64,
|
|
expiresAt: Int64
|
|
) throws -> Data {
|
|
var o = CanonicalObject()
|
|
o.int("v", wireVersion)
|
|
try o.string("audience", Self.delegateAudience)
|
|
o.uuid("challenge_id", challengeId)
|
|
try o.string("challenge", challenge, field: "challenge")
|
|
o.uuid("installation_handle", installationHandle)
|
|
o.int("endpoint_epoch", endpointEpoch)
|
|
o.int("generation", generation)
|
|
try o.string("relay_pubkey", relayPubkey, field: "relay_pubkey")
|
|
o.int("not_before", notBefore)
|
|
o.int("expires_at", expiresAt)
|
|
return encode(domain: delegateDomain, object: o)
|
|
}
|
|
|
|
/// `buzz.push.rotate-endpoint.v1` — `SHA-256(bytes)` is the assertion
|
|
/// `clientDataHash`.
|
|
public static func rotateEndpoint(
|
|
challengeId: UUID,
|
|
challenge: String,
|
|
installationHandle: UUID,
|
|
endpointEpoch: Int64,
|
|
newEndpointEpoch: Int64,
|
|
endpoint: String
|
|
) throws -> Data {
|
|
var o = CanonicalObject()
|
|
o.int("v", wireVersion)
|
|
try o.string("audience", Self.rotateEndpointAudience)
|
|
o.uuid("challenge_id", challengeId)
|
|
try o.string("challenge", challenge, field: "challenge")
|
|
o.uuid("installation_handle", installationHandle)
|
|
o.int("endpoint_epoch", endpointEpoch)
|
|
o.int("new_endpoint_epoch", newEndpointEpoch)
|
|
try o.string("endpoint", endpoint, field: "endpoint")
|
|
return encode(domain: rotateEndpointDomain, object: o)
|
|
}
|
|
|
|
/// `buzz.push.revoke-delegation.v1` — `SHA-256(bytes)` is the assertion
|
|
/// `clientDataHash`.
|
|
public static func revokeDelegation(
|
|
challengeId: UUID,
|
|
challenge: String,
|
|
installationHandle: UUID,
|
|
relayPubkey: String,
|
|
generation: Int64
|
|
) throws -> Data {
|
|
var o = CanonicalObject()
|
|
o.int("v", wireVersion)
|
|
try o.string("audience", Self.revokeDelegationAudience)
|
|
o.uuid("challenge_id", challengeId)
|
|
try o.string("challenge", challenge, field: "challenge")
|
|
o.uuid("installation_handle", installationHandle)
|
|
try o.string("relay_pubkey", relayPubkey, field: "relay_pubkey")
|
|
o.int("generation", generation)
|
|
return encode(domain: revokeDelegationDomain, object: o)
|
|
}
|
|
|
|
/// `buzz.push.revoke-installation.v1` — `SHA-256(bytes)` is the assertion
|
|
/// `clientDataHash`.
|
|
public static func revokeInstallation(
|
|
challengeId: UUID,
|
|
challenge: String,
|
|
installationHandle: UUID,
|
|
endpointEpoch: Int64,
|
|
newEndpointEpoch: Int64
|
|
) throws -> Data {
|
|
var o = CanonicalObject()
|
|
o.int("v", wireVersion)
|
|
try o.string("audience", Self.revokeInstallationAudience)
|
|
o.uuid("challenge_id", challengeId)
|
|
try o.string("challenge", challenge, field: "challenge")
|
|
o.uuid("installation_handle", installationHandle)
|
|
o.int("endpoint_epoch", endpointEpoch)
|
|
o.int("new_endpoint_epoch", newEndpointEpoch)
|
|
return encode(domain: revokeInstallationDomain, object: o)
|
|
}
|
|
|
|
// MARK: Internals
|
|
|
|
private static func encode(domain: String, object: CanonicalObject) -> Data {
|
|
Data((domain + "\n" + object.encoded()).utf8)
|
|
}
|
|
|
|
/// Ordered compact JSON object writer. Emission order == call order;
|
|
/// there is deliberately no sorting, no whitespace, and no `Encodable`
|
|
/// round-trip anywhere near these bytes.
|
|
struct CanonicalObject {
|
|
private var members: [String] = []
|
|
|
|
mutating func int(_ key: String, _ value: Int64) {
|
|
// Swift's Int64 description is shortest decimal notation, which
|
|
// is what the spec pins and what serde_json emits.
|
|
members.append("\"\(key)\":\(value)")
|
|
}
|
|
|
|
mutating func uuid(_ key: String, _ value: UUID) {
|
|
// Canonical lowercase-hyphenated form, matching uuid::Uuid's
|
|
// serde serialization. Foundation's uuidString is uppercase.
|
|
members.append("\"\(key)\":\"\(value.uuidString.lowercased())\"")
|
|
}
|
|
|
|
mutating func string(_ key: String, _ value: String, field: String? = nil) throws {
|
|
members.append("\"\(key)\":\"\(try Self.escape(value, field: field ?? key))\"")
|
|
}
|
|
|
|
func encoded() -> String {
|
|
"{" + members.joined(separator: ",") + "}"
|
|
}
|
|
|
|
/// Minimal JSON string escaping, byte-identical to serde_json:
|
|
/// `"` and `\` get two-character escapes; U+0008, U+0009, U+000A,
|
|
/// U+000C, U+000D get their short forms; the remaining C0 controls
|
|
/// get lowercase `\u00xx`. Nothing else is escaped (in particular
|
|
/// `/` is NOT escaped — the JSONSerialization behavior that makes it
|
|
/// unusable here). Non-ASCII input is rejected outright.
|
|
static func escape(_ s: String, field: String) throws -> String {
|
|
var out = String()
|
|
out.reserveCapacity(s.count)
|
|
for scalar in s.unicodeScalars {
|
|
switch scalar.value {
|
|
case 0x22: out += "\\\""
|
|
case 0x5C: out += "\\\\"
|
|
case 0x08: out += "\\b"
|
|
case 0x09: out += "\\t"
|
|
case 0x0A: out += "\\n"
|
|
case 0x0C: out += "\\f"
|
|
case 0x0D: out += "\\r"
|
|
case 0x00...0x1F: out += String(format: "\\u%04x", scalar.value)
|
|
case 0x20...0x7E: out.unicodeScalars.append(scalar)
|
|
default: throw BuzzPushTranscriptError.nonASCIIInput(field: field)
|
|
}
|
|
}
|
|
return out
|
|
}
|
|
}
|
|
}
|