mirror of
https://github.com/block/buzz.git
synced 2026-11-08 10:21:46 +00:00
e7243887e4
Realizing upscroll made the reading row jump down then snap back — a
reversal frame pair, most visible on WebKit where the ResizeObserver for
a content-visibility realization delivers one frame LATE (paint N, RO
N+1). This lands design-of-record (c): a single ungated RO mid-history
corrector plus a per-rAF sampler, coordinating ONLY through a shared
row-height cache — no engine branch. The on-time observer per engine is
the sole writer:
- Chromium: the RO delivers pre-paint, so the ungated RO corrects at N
(by the anchor's own measured drift) and refreshes the cache; the
rAF then sees residual ~0 and no-ops.
- WebKit: the RO is late, so the rAF (whose synchronous
getBoundingClientRect forces this frame's layout) corrects at N; the
late RO no-ops against the rAF-refreshed cache.
The RO path is deliberately UNGATED by the rAF path's observed/above
agreement cross-check: that gate suppresses the rAF band walk's
straddler-miscount fabrication, a risk the RO does not have (its entries
are ground truth for which rows resized). Applying the gate to the RO
strangled the on-time Chromium observer and regressed it to 16
reversals. Straddler safety on the RO path comes instead from the
safe-margin reading anchor (snapshotReadingAnchor +
READING_ANCHOR_SAFE_MARGIN_PX), which sits a notch below the realization
band so a row realizing across the fold is above the anchor and summed
into the drift correctly — documented as a load-bearing invariant at the
site so a later refactor cannot strip it thinking the `changed` trigger
covers straddlers (it does not; the margin does).
Own red/green E2E fixture (upscroll-raf-correction.perf.ts), verified on
both Playwright engines against a stamped build:
Chromium 0 reversals max 0.0px RO 21 rAF 0
WebKit 2 reversals max 14.5px rAF 24 RO 0 (residual 0.0)
Asserts are a layered stack so a vacuous pass cannot slip through: a
build-stamp stale-`dist` guard, LIVENESS (some correction fired),
PRIMARY correctness (reversals <= 4, maxReversalPx <= 34, engine-
agnostic), and per-engine MECHANISM in both directions (chromium
roFires>0 && rafFires===0; webkit rafFires>0 && maxRoResidual<=0.5).
Layering self-test confirmed: disabling the ungated-RO write flips
PRIMARY red at 16 while LIVENESS stays green.
The hook is the sole cross-engine reading-anchor scroll writer and its
correctness lives in the per-site provenance comments, so it crossed the
1000-line file-size limit (888 at HEAD); added a documented, narrowly-
scoped override queued to split the mid-history corrector into a sibling.
Co-authored-by: Tyler Longwell <tlongwell@block.xyz>
Signed-off-by: Tyler Longwell <tlongwell@block.xyz>
282 lines
17 KiB
JavaScript
282 lines
17 KiB
JavaScript
import path from "node:path";
|
||
import { fileURLToPath } from "node:url";
|
||
import { runFileSizeCheck } from "../../scripts/check-file-sizes-core.mjs";
|
||
|
||
const __dirname = path.dirname(fileURLToPath(import.meta.url));
|
||
const projectRoot = path.resolve(__dirname, "..");
|
||
|
||
const MAX_LINES = 1000;
|
||
|
||
const rules = [
|
||
{ root: "src-tauri/src", extensions: new Set([".rs"]), maxLines: MAX_LINES },
|
||
{
|
||
root: "src/app",
|
||
extensions: new Set([".ts", ".tsx"]),
|
||
maxLines: MAX_LINES,
|
||
},
|
||
{
|
||
root: "src/features",
|
||
extensions: new Set([".ts", ".tsx"]),
|
||
maxLines: MAX_LINES,
|
||
},
|
||
{
|
||
root: "src/shared/api",
|
||
extensions: new Set([".ts", ".tsx"]),
|
||
maxLines: MAX_LINES,
|
||
},
|
||
{
|
||
root: "src/shared/context",
|
||
extensions: new Set([".ts", ".tsx"]),
|
||
maxLines: MAX_LINES,
|
||
},
|
||
{
|
||
root: "src/shared/lib",
|
||
extensions: new Set([".ts", ".tsx"]),
|
||
maxLines: MAX_LINES,
|
||
},
|
||
{
|
||
root: "src/shared/ui",
|
||
extensions: new Set([".ts", ".tsx"]),
|
||
maxLines: MAX_LINES,
|
||
},
|
||
{
|
||
root: "src/shared/styles",
|
||
extensions: new Set([".css"]),
|
||
maxLines: MAX_LINES,
|
||
},
|
||
];
|
||
|
||
// TEMP — these files exceed the 1000-line limit and are queued to be split.
|
||
// Do not add to this list; split the file instead. Remove each entry as its
|
||
// file is broken up. Tracked as a follow-up.
|
||
const overrides = new Map([
|
||
// persona-events rebase: build_deploy_payload threads `state` for the
|
||
// read-time relay-URL workspace fallback while keeping the create-time env
|
||
// pin (the credential-leak guard). Load-bearing feature growth from the
|
||
// rebase, queued to split with the rest of this list.
|
||
// persona-refresh-on-spawn: re-snapshot + retain_managed_agent_pending call
|
||
// in start_local_agent_with_preflight adds ~23 lines. Queued to split.
|
||
// rebase onto main (2026-06-25): main's agents.rs grew by ~17 lines since
|
||
// config-bridge: get_agent_config_surface/write_agent_config_field/put_agent_session_config
|
||
// commands add ~40 lines. Queued to split.
|
||
// branch cut; override bumped to cover the merged total. Queued to split.
|
||
// persona-blank-fallback: persona_snapshot_with_agent_config_fallback call
|
||
// sites add ~4 lines (extra fallback params + inline comments). build_deploy_payload
|
||
// fix (blank-persona provider/model fallback) adds ~6 lines. Bug fix.
|
||
// archive/mod_tests.rs carries the full test module for archive/mod.rs:
|
||
// unit tests + 4 real-relay integration tests (ignored, live-relay only).
|
||
// Production logic in mod.rs is now ~527 lines (under 1000). mod_tests.rs
|
||
// is test-only content; the override covers the test growth accumulated
|
||
// across the local-archive + agent-metric-archive PR series. store_tests.rs
|
||
// (~731 lines) is under 1000 so needs no override.
|
||
["src-tauri/src/archive/mod_tests.rs", 1208],
|
||
// unified-agent-model 1A.1: profile reconcile split to agents_profile.rs,
|
||
// ratcheting 1443 -> 1295. Queued to split further in the A2 fold.
|
||
["src-tauri/src/commands/agents.rs", 1295],
|
||
// #1418 read-path fix: get_thread_replies' blocker fix (shared TIMELINE_KINDS
|
||
// const + build_thread_replies_filter helper, mirroring the channel sibling so
|
||
// the two p-gate filters can't drift) plus two guard unit tests. The file was
|
||
// already at 995; this load-bearing correctness fix crossed 1000. Not generic
|
||
// debt growth. Approved override; queued to split with the rest of this list.
|
||
["src-tauri/src/commands/messages.rs", 1082],
|
||
// Residual repos_dir integration in ensure_nest_at: REPOS is provisioned
|
||
// outside NEST_DIRS (it may be a symlink), so it needs its own create +
|
||
// chmod-only-when-real-dir handling plus integration test coverage. The
|
||
// self-contained repos_dir functions and their unit tests live in repos.rs;
|
||
// this is the seam that must stay in nest.rs. Approved override; still queued
|
||
// to split with the rest of this list.
|
||
// dev-nest namespace: OnceLock<Option<PathBuf>> + init_nest_dir + constants
|
||
// added to plumb the dev/prod discriminator. Load-bearing for the D2 nest fix.
|
||
// dev-build CLI symlink: cli_link_name helper + is_dev param on
|
||
// ensure_cli_symlink + prod/dev test variants add ~68 lines. Load-bearing;
|
||
// queued to split with the rest of this list.
|
||
// +4 lines: adopt shared create_symlink wrapper (behavior-preserving refactor
|
||
// for multi-line rustfmt expansion of the skills symlink call site).
|
||
// unified-agent-model 1A.1: inline test module moved to nest/tests.rs,
|
||
// ratcheting 1575 -> 679 (under the 1000 default; entry kept as a ratchet).
|
||
["src-tauri/src/managed_agents/nest.rs", 679],
|
||
// harness-persona-sync: persona-runtime resolution threaded into the spawn
|
||
// path here. Load-bearing feature growth; queued to split in the resolver
|
||
// unify refactor followup. +26 for resolve_effective_prompt_model_provider
|
||
// re-introduced after 826d735fe removal (config-bridge caller still needs it).
|
||
// PGID resolution helper + PID-recycling safety guard added for orphan sweep.
|
||
// activity-feed threads avatar_url into build_managed_agent_summary for the
|
||
// assistant-bubble pinned snapshot.
|
||
// +1 for agent_pubkey field in setup payload (config-nudge card wire).
|
||
// persona-blank-fallback: resolve_effective_prompt_model_provider gains a
|
||
// record_provider param + applies persona_field_with_record_fallback. +5 lines.
|
||
["src-tauri/src/managed_agents/runtime.rs", 2213],
|
||
// config-bridge setup-payload env-boundary fix adds readiness wiring in
|
||
// spawn_agent_child; load-bearing security fix, queued to split.
|
||
["src-tauri/src/managed_agents/config_bridge/reader.rs", 1016],
|
||
// config-bridge-aware requirements: goose_requirements + injection tests
|
||
// (4 new tests in goose_file_config_tests module) + test-determinism fixes
|
||
// for the 3 existing goose tests that previously read real disk config.
|
||
// New file in this PR; queued to split.
|
||
// +2 readiness integration tests for flat-DATABRICKS_HOST canonicalization fix.
|
||
// +1 cargo fmt whitespace reformat (readiness.rs closures inline after rebase).
|
||
// +2 unit tests for cli_login_requirements resolve_command integration (DMG PATH fix).
|
||
["src-tauri/src/managed_agents/readiness.rs", 1215],
|
||
// applyWorkspace reposDir parameter plus the validateReposDir binding,
|
||
// threaded through Tauri invokes for configurable repos_dir, plus the
|
||
// harness-persona-sync `harnessOverride` create-input bit — load-bearing
|
||
// parameter plumbing, not generic debt growth. Approved override; still
|
||
// queued to split. Read-path lanes 1+2 add server-side fetch bindings
|
||
// (getThreadReplies + getChannelMessagesBefore) and paged people-search
|
||
// reachability — load-bearing reachability plumbing, not generic debt.
|
||
// #1418 read-path fix: +3 doc-only lines correcting the getThreadReplies
|
||
// contract (replies-only, root excluded — the query keys on root_event_id,
|
||
// which root rows lack). Documentation accuracy, not code growth.
|
||
// linux-updater isAutoUpdateSupported() binding + onboarding has_profile_event field.
|
||
// config-bridge-aware requirements: getRuntimeFileConfig command adds ~15 lines.
|
||
// +26 lines from PRs landing on main between prior rebase and this rebase.
|
||
// baked-env-required-badge: getBakedBuildEnvKeys wrapper adds ~16 lines. Queued to split.
|
||
// restart-badge: started the queued split — start/stopManagedAgent moved to
|
||
// tauriManagedAgents.ts; limit ratcheted down 1388 → 1380 to bank the headroom.
|
||
["src/shared/api/tauri.ts", 1380],
|
||
// readiness-gate: PersonaDialog.tsx threads computeLocalModeGate +
|
||
// requiredCredentialEnvKeys + RequiredFieldLabel so the "New agent" dialog
|
||
// shows required markers and credential amber rows (parity with
|
||
// CreateAgentDialog). +23 lines of gate wiring. Queued to split.
|
||
// config-bridge-aware requirements: useRuntimeFileConfigQuery wiring adds
|
||
// ~16 lines. Queued to split.
|
||
// baked-env-required-badge: useBakedBuildEnvKeysQuery + bakedEnvKeys wiring
|
||
// + correct exclusion-semantics for requiredEnvKeys adds ~14 lines. Queued to split.
|
||
["src/features/agents/ui/PersonaDialog.tsx", 1046],
|
||
// harness-persona-sync feature growth, queued to split in the resolver-unify
|
||
// refactor followup. discovery.rs is dominated by the new test module
|
||
// (the effective_agent_command / divergent / create-time override matrix);
|
||
// alias-preservation coverage extends that matrix so create-time persona
|
||
// agents keep an installed runtime alias when the primary command is absent.
|
||
// Load-bearing, not generic debt.
|
||
// config-bridge: schema-driven field extraction adds ~26 lines. Queued to split.
|
||
// config-parity: max_tokens_env_var + context_limit_env_var fields added to
|
||
// KnownAcpRuntime (2 fields × 4 runtimes + discovery tests = ~13 lines).
|
||
// Load-bearing — required for buzz-agent normalized config parity.
|
||
// same-runtime-pin: update_time_agent_command_override + its override /
|
||
// same-runtime / alias / sentinel / non-override / persona-less test matrix
|
||
// (~135 lines, mostly tests) so a deliberate Custom pin survives the update
|
||
// path instead of being dropped back to inherit. Load-bearing, not debt.
|
||
// unified-agent-model 1A.1: inline test module moved to discovery/tests.rs,
|
||
// ratcheting 1259 -> 802 (under the 1000 default; entry kept as a ratchet).
|
||
["src-tauri/src/managed_agents/discovery.rs", 802],
|
||
// migration_tests.rs carries the harness-sync migration coverage plus the
|
||
// patch_json_records owner-only writeback regression test (SECURITY.md:90
|
||
// crash-safe 0o600 fallback). Load-bearing security + feature coverage, not
|
||
// generic debt growth. Approved override; still queued to split. Event-sync
|
||
// (persona/team event reconcile) tests were split out to event_sync_tests.rs
|
||
// and the limit ratcheted 1410 → 1110.
|
||
// unified-agent-model 1A.1: materialize tests live with their module in
|
||
// migration/materialize.rs; ratchet held at 1110.
|
||
["src-tauri/src/migration_tests.rs", 1110],
|
||
["src-tauri/src/nostr_convert.rs", 1126],
|
||
["src/shared/api/relayClientSession.ts", 1022],
|
||
// Boot-time event sync (persona/team/agent event reconcile) was split out
|
||
// to event_sync.rs, ratcheting this limit 1575 → 1310. Remaining content is
|
||
// the pre-identity data migrations; still queued to split further.
|
||
// unified-agent-model 1A.1: materialize_agent_runtimes split to
|
||
// migration/materialize.rs, ratcheting 1310 -> 1297.
|
||
["src-tauri/src/migration.rs", 1297],
|
||
// onMarkRead + isUnread prop threading (mirrors the onMarkUnread prop
|
||
// already here) for the single-toggle mark-read/unread menu item — a small
|
||
// overage from load-bearing per-message plumbing, not generic debt growth.
|
||
// Approved override; still queued to split with the rest of this list.
|
||
["src/features/messages/ui/MessageThreadPanel.tsx", 1006],
|
||
// W4a realizing-upscroll reversal fix (design-of-record (c), targets #1662):
|
||
// the hook is the sole cross-engine reading-anchor scroll writer, and the
|
||
// fix's correctness lives in WHY each observer wins per engine — so the
|
||
// ungated-RO mid-history corrector, the safe-margin straddler-guard invariant
|
||
// (Quinn's merge-bar checklist #4), the one-clock/single-writer reasoning, and
|
||
// the build-stamp/probe contract are all documented AT their sites. The file
|
||
// was 888 lines at HEAD; this fix's code + load-bearing provenance comments
|
||
// crossed 1000. Comment-dominated overage on a correctness fix, not generic
|
||
// debt growth. Approved override; queued to split (extract the mid-history
|
||
// corrector + band walk into a sibling module) with the rest of this list.
|
||
["src/features/messages/ui/useAnchoredScroll.ts", 1140],
|
||
// AgentConfigPanel footer fold into ProfileFieldGroup for the config-bridge
|
||
// panel — a small overage from load-bearing UI plumbing, not generic debt
|
||
// growth. Approved override; still queued to split with the rest of this list.
|
||
// +135 for AgentInfoFocusedView/DiagnosticsFocusedView/ChannelsFocusedView
|
||
// props restored after 826d735fe removal (UserProfilePanel.tsx still needs them).
|
||
["src/features/profile/ui/UserProfilePanelSections.tsx", 1140],
|
||
// +14 for openEditAgent event subscription (config-nudge card "Open Edit Agent" action).
|
||
["src/features/profile/ui/UserProfilePanel.tsx", 1014],
|
||
// PersistBackend enum + marker-on-keyring-success plumbing and its three
|
||
// fail-closed regression tests (silent identity rotation on keyring outage).
|
||
// A small overage from load-bearing security plumbing on a file already at
|
||
// 893 lines, not generic debt growth. Approved override; still queued to split.
|
||
// cross-process keychain race fix (D3): interprocess lock + BlobLockGuard +
|
||
// uid-keyed lockfile path + behavioral tests add ~303 lines. Load-bearing
|
||
// security fix for the lost-update race that stranded agent keys.
|
||
["src-tauri/src/secret_store.rs", 1043],
|
||
["src-tauri/src/app_state.rs", 1033],
|
||
// multi-slot splitting + no-op suppression (#1309): the ReadStateManager
|
||
// class grew from ~700 lines to ~1019 with the addition of
|
||
// splitContextsIntoBudgetedSlots (pure fn + 5 tests), publishSplitSlots,
|
||
// publishOneSlot, deleteExtraSlots, and the no-op suppression integration
|
||
// test. Load-bearing feature growth, queued to split publishSplitSlots path
|
||
// into readStateManagerSplit.ts.
|
||
["src/features/channels/readState/readStateManager.ts", 1030],
|
||
// review feedback on #1492 restored the two-line load-bearing comment
|
||
// documenting why `lastMessageAt` must not be an `activeReadAt` fallback
|
||
// (reply-inclusive; would clear unread state early). The file was already
|
||
// at the 1000 ceiling; comment-only overage, not code growth. Queued to
|
||
// split with the rest of this list.
|
||
["src/features/channels/ui/ChannelScreen.tsx", 1002],
|
||
// Shared UI was added to this guard after splitting globals/markdown so
|
||
// large shared renderers cannot grow further while follow-up splits land.
|
||
// +33 for config-nudge detect-and-render + author-auth gate (normalizePubkey guard).
|
||
["src/shared/ui/markdown.tsx", 2152],
|
||
["src/shared/ui/VideoPlayer.tsx", 2199],
|
||
["src/shared/ui/sidebar.tsx", 1042],
|
||
// permission-outcome (fix #1381 regression): pendingPermissions state map,
|
||
// describePermissionOutcome helper, jsonRpcId key helper (handles both
|
||
// string and finite-number JSON-RPC ids per spec), and the acp_write
|
||
// response correlation branch are all tightly coupled to the existing
|
||
// request handler. Load-bearing logic growth, not generic debt. Queued to
|
||
// split into a dedicated permission module in the next transcript refactor.
|
||
// +123: observer parity — 4 new named session/update classifier cases
|
||
// (current_mode_update, usage_update, available_commands_update,
|
||
// config_option_update) + replaceLifecycleItem helper for usage coalescing +
|
||
// system-prompt ordering fix (turnId: null for per-channel items).
|
||
// Load-bearing feature growth; queued to split in next transcript refactor.
|
||
["src/features/agents/ui/agentSessionTranscript.ts", 1167],
|
||
// catalog module; agent_models.rs retains the thin wrapper (~50 lines).
|
||
// File still exceeds 1000 due to OpenAI/Anthropic discovery + subprocess
|
||
// fallback. Queued to split into dedicated discovery modules.
|
||
// Kept activity-feed design fixture: realistic prompt context and tool-heavy
|
||
// chatter for render-class test/reference coverage. Queued to split with the
|
||
// rest of this list if it grows further.
|
||
// +2: baked build env folded under merged_env in both get_agent_models and
|
||
// discover_agent_models so in-process discovery sees baked provider config on
|
||
// a GUI-launched DMG (the discovery_env_with_baked_floor fold).
|
||
// +3: provider tri-state applied in update_managed_agent handler
|
||
// (if let Some(provider_update) = input.provider { record.provider = provider_update; }).
|
||
// +8: harness_override thread-through in update_managed_agent so a deliberate
|
||
// Custom pin routes to update_time_agent_command_override (comment + call).
|
||
["src-tauri/src/commands/agent_models.rs", 1079],
|
||
// draft-persistence predicate: submit-time `loadDraft` check + inline comment
|
||
// + deps-array entry in submitMessage closes the never-persisted-boundary
|
||
// defect (Thufir Pass-3 finding). Load-bearing correctness fix; queued to
|
||
// split MessageComposer into submit/edit/media sub-modules.
|
||
// +18: pendingImetaForPersistRef (local snapshot ref) + synchronous restore
|
||
// path writes in the draft-key effect body, fixing the image-drop bug on
|
||
// top-level nav switch (StrictMode simulate-unmount race on remount).
|
||
// +12 autoSubmitDraftKey/onAutoSubmitComplete props + onAutoSubmitCompleteRef
|
||
// + mount-only useEffect for the Drafts-panel "Send message" confirm-dialog
|
||
// flow. Load-bearing feature growth; queued to split with the rest of this
|
||
// list.
|
||
// +3: onLinkShortcutRef wiring (ref decl + editor option + assignment) for
|
||
// the ⌘K link-editor shortcut, mirroring the existing onEditLinkRef
|
||
// pattern. Queued to split with the rest of this list.
|
||
["src/features/messages/ui/MessageComposer.tsx", 1036],
|
||
]);
|
||
|
||
await runFileSizeCheck({
|
||
projectRoot,
|
||
rules,
|
||
overrides,
|
||
label: "Desktop",
|
||
scriptPath: "desktop/scripts/check-file-sizes.mjs",
|
||
});
|