buzz/desktop/src/features/agents/lib/friendlyAgentLastError.test.mjs

import assert from "node:assert/strict";
import test from "node:test";

import {
  friendlyAgentLastError,
  friendlyTurnErrorCopy,
  CLI_ACP_INTERNAL_ERROR_COPY,
  MODEL_NOT_FOUND_COPY,
  RELAY_MESH_DENIED_COPY,
} from "./friendlyAgentLastError.ts";

test("null lastError → null", () => {
  assert.equal(friendlyAgentLastError(null), null);
});

test("empty/whitespace lastError → null", () => {
  assert.equal(friendlyAgentLastError(""), null);
  assert.equal(friendlyAgentLastError("   "), null);
});

test("buzz-acp wrapped auth failure → denied copy", () => {
  const result = friendlyAgentLastError(
    "Agent reported error: llm auth: 401 unauthorized: ...",
  );
  assert.deepEqual(result, {
    severity: "denied",
    copy: RELAY_MESH_DENIED_COPY,
  });
});

test("unwrapped buzz-agent prefix → denied copy", () => {
  // buzz-agent's AgentError::LlmAuth Display is "llm auth: <body>"; if the
  // desktop ever picks that up directly (no AcpError wrapper), we should
  // still recognize it as denial.
  const result = friendlyAgentLastError("llm auth: 403 forbidden");
  assert.deepEqual(result, {
    severity: "denied",
    copy: RELAY_MESH_DENIED_COPY,
  });
});

test("generic harness exit message → passthrough", () => {
  const result = friendlyAgentLastError("harness exited with status code 137");
  assert.deepEqual(result, {
    severity: "generic",
    copy: "harness exited with status code 137",
  });
});

test("trims whitespace before matching", () => {
  const result = friendlyAgentLastError(
    "  Agent reported error: llm auth: nope\n",
  );
  assert.equal(result?.severity, "denied");
  assert.equal(result?.copy, RELAY_MESH_DENIED_COPY);
});

test("substring 'llm auth:' that isn't at start is NOT treated as denial", () => {
  // Some other failure that happens to mention 'llm auth:' deep in a message
  // — we only promote when the failure *is* an auth failure, signalled by
  // the prefix. Anything else stays passthrough so we don't lie about the
  // cause of an unrelated crash.
  const result = friendlyAgentLastError(
    "harness exited with status code 1: stderr mentions llm auth: misleadingly",
  );
  assert.equal(result?.severity, "generic");
  assert.ok(result?.copy.startsWith("harness exited"));
});

test("non-auth Agent reported error stays generic", () => {
  const result = friendlyAgentLastError(
    "Agent reported error: llm: 500 internal server error",
  );
  assert.equal(result?.severity, "generic");
  assert.equal(
    result?.copy,
    "Agent reported error: llm: 500 internal server error",
  );
});

test("code -32002 → model-not-found copy (severity: denied)", () => {
  const result = friendlyAgentLastError(
    "Agent reported error: llm model not found: (goose-claude-opus-4-8) 404 Not Found: ...",
    -32002,
  );
  assert.deepEqual(result, {
    severity: "denied",
    copy: MODEL_NOT_FOUND_COPY,
  });
});

test("code -32001 → relay mesh denied copy (structured path)", () => {
  const result = friendlyAgentLastError("any error text", -32001);
  assert.deepEqual(result, {
    severity: "denied",
    copy: RELAY_MESH_DENIED_COPY,
  });
});

test("code null falls through to legacy string matching", () => {
  const result = friendlyAgentLastError(
    "Agent reported error: llm auth: 401 unauthorized",
    null,
  );
  assert.deepEqual(result, {
    severity: "denied",
    copy: RELAY_MESH_DENIED_COPY,
  });
});

test("code undefined falls through to legacy string matching", () => {
  const result = friendlyAgentLastError(
    "Agent reported error: llm auth: 403 forbidden",
    undefined,
  );
  assert.deepEqual(result, {
    severity: "denied",
    copy: RELAY_MESH_DENIED_COPY,
  });
});

test("unknown code falls through to generic", () => {
  const result = friendlyAgentLastError("some error", -99999);
  assert.deepEqual(result, {
    severity: "generic",
    copy: "some error",
  });
});

test("friendlyTurnErrorCopy: numeric code -32002 → model-not-found copy", () => {
  assert.equal(
    friendlyTurnErrorCopy("raw error", -32002),
    MODEL_NOT_FOUND_COPY,
  );
});

test("friendlyTurnErrorCopy: string-encoded code coerces to number", () => {
  assert.equal(
    friendlyTurnErrorCopy("raw error", "-32001"),
    RELAY_MESH_DENIED_COPY,
  );
});

test("friendlyTurnErrorCopy: missing code falls back to raw text", () => {
  assert.equal(friendlyTurnErrorCopy("raw error", undefined), "raw error");
  assert.equal(friendlyTurnErrorCopy("raw error", null), "raw error");
});

test("friendlyTurnErrorCopy: unknown code passes raw text through", () => {
  assert.equal(friendlyTurnErrorCopy("raw error", 12345), "raw error");
});

// --- structured-code hardening ---

test("unknown code prevents string-pattern cross-classification", () => {
  // code -32003 is structured and unrecognized — must NOT fall through to
  // the legacy string path that would wrongly promote this to denied.
  const result = friendlyAgentLastError(
    "llm auth: rate limiter denial",
    -32003,
  );
  assert.deepEqual(result, {
    severity: "generic",
    copy: "llm auth: rate limiter denial",
  });
});

test("NaN code param treated as absent — string path applies", () => {
  // NaN is not finite; falls back to string matching.
  const result = friendlyAgentLastError("llm auth: denied", NaN);
  assert.deepEqual(result, {
    severity: "denied",
    copy: RELAY_MESH_DENIED_COPY,
  });
});

test("embedded code -32001 recovered from message when code param is null", () => {
  const result = friendlyAgentLastError(
    "Agent reported error (code -32001): llm auth: 401",
    null,
  );
  assert.deepEqual(result, {
    severity: "denied",
    copy: RELAY_MESH_DENIED_COPY,
  });
});

test("embedded code -32002 recovered from message when code param is undefined", () => {
  const result = friendlyAgentLastError(
    "Agent reported error (code -32002): llm model not found: x",
    undefined,
  );
  assert.deepEqual(result, {
    severity: "denied",
    copy: MODEL_NOT_FOUND_COPY,
  });
});

test("embedded unknown code is authoritative — no cross-classification", () => {
  const result = friendlyAgentLastError(
    "Agent reported error (code -32099): llm auth: weird",
    null,
  );
  assert.deepEqual(result, {
    severity: "generic",
    copy: "Agent reported error (code -32099): llm auth: weird",
  });
});

test("friendlyTurnErrorCopy: garbage string code coerces to NaN → string path", () => {
  // "garbage" → NaN → not finite → null → string prefix matches "llm auth:".
  assert.equal(
    friendlyTurnErrorCopy("llm auth: denied", "garbage"),
    RELAY_MESH_DENIED_COPY,
  );
});

// --- -32603 internal error (Fix #2: CLI-ACP unsupported model hint) ---

test("code -32603 bare 'Internal error' → cli-acp internal error hint (severity: generic)", () => {
  const result = friendlyAgentLastError("Internal error", -32603);
  assert.deepEqual(result, {
    severity: "generic",
    copy: CLI_ACP_INTERNAL_ERROR_COPY,
  });
});

test("code -32603 bare Internal error (wrapped) → cli-acp internal error hint", () => {
  // The ACP wrapper form "Agent reported error (code -32603): Internal error"
  // is treated as bare — the remainder after stripping the prefix is
  // "Internal error", which maps to the hint.
  const result = friendlyAgentLastError(
    "Agent reported error (code -32603): Internal error",
    -32603,
  );
  assert.deepEqual(result, {
    severity: "generic",
    copy: CLI_ACP_INTERNAL_ERROR_COPY,
  });
});

test("code -32603 with specific message → original message preserved, NOT hint", () => {
  // If the adapter provides detail beyond "Internal error", preserve it —
  // don't bury actionable information with a broad codex-specific hint.
  const result = friendlyAgentLastError(
    "Internal error: model gpt-5.6-sol rejected by adapter",
    -32603,
  );
  assert.deepEqual(result, {
    severity: "generic",
    copy: "Internal error: model gpt-5.6-sol rejected by adapter",
  });
});

test("embedded code -32603 recovered from message when code param is null", () => {
  const result = friendlyAgentLastError(
    "Agent reported error (code -32603): Internal error",
    null,
  );
  assert.deepEqual(result, {
    severity: "generic",
    copy: CLI_ACP_INTERNAL_ERROR_COPY,
  });
});

test("embedded code -32603 with specific detail → original message preserved", () => {
  // Embedded code path also preserves specific detail.
  const result = friendlyAgentLastError(
    "Agent reported error (code -32603): model not in registry",
    null,
  );
  assert.deepEqual(result, {
    severity: "generic",
    copy: "model not in registry",
  });
});

test("code -32603 structured param + wrapped specific detail → clean message, NOT wrapper", () => {
  // Real path: storage.rs stores message = full wrapped line, code = parsed finite.
  // The transport wrapper must be stripped; only the adapter detail reaches the UI.
  const result = friendlyAgentLastError(
    "Agent reported error (code -32603): model not in registry",
    -32603,
  );
  assert.deepEqual(result, {
    severity: "generic",
    copy: "model not in registry",
  });
});

test("friendlyTurnErrorCopy: -32603 structured param + wrapped specific detail → clean message", () => {
  // friendlyTurnErrorCopy is the transcript path (agentSessionTranscript.ts).
  assert.equal(
    friendlyTurnErrorCopy(
      "Agent reported error (code -32603): model not in registry",
      -32603,
    ),
    "model not in registry",
  );
});

test("friendlyTurnErrorCopy: code -32603 bare Internal error → cli-acp internal error hint", () => {
  assert.equal(
    friendlyTurnErrorCopy("Internal error", -32603),
    CLI_ACP_INTERNAL_ERROR_COPY,
  );
});

test("-32603 does not affect -32001/-32002 classification (regression)", () => {
  assert.deepEqual(friendlyAgentLastError("any", -32001), {
    severity: "denied",
    copy: RELAY_MESH_DENIED_COPY,
  });
  assert.deepEqual(friendlyAgentLastError("any", -32002), {
    severity: "denied",
    copy: MODEL_NOT_FOUND_COPY,
  });
});