mirror of
https://github.com/block/buzz.git
synced 2026-10-27 20:41:57 +00:00
59328d5ae3
## Why Thread-scoped ACP sessions from #6732 need an opt-in desktop rollout that preserves today’s channel policy by default. ## What - Add the default-off “Thread Scoped ACP Sessions” toggle under Settings → Experiments using the existing feature-override persistence. - Map the persisted setting to `BUZZ_ACP_SESSION_POLICY=channel|thread` for every local and provider-backed managed ACP launch. Changes apply when managed agents next start; DMs remain conversation-scoped by the backend. - Keep the desktop setting authoritative over descriptor environment and cover the UI, persistence, local spawn, provider payload, and existing Projects/Workflows experiments. ## Risk Assessment Low. The experiment defaults off and explicitly preserves `channel`; changes are limited to managed-agent launch configuration. Existing running agents are unchanged until their next start. ## Testing - `. ./bin/activate-hermit && just ci` — passed on the final restacked tree, including 5,674 desktop tests, 2,796 Tauri tests, and 1,860 mobile tests. - `cd desktop && pnpm build:e2e && pnpm exec playwright test tests/e2e/experimental-features.spec.ts --project=smoke` — 1 passed. - `. ./bin/activate-hermit && cargo test --manifest-path desktop/src-tauri/Cargo.toml session_policy --lib` — 4 passed. - `. ./bin/activate-hermit && cargo test --manifest-path desktop/src-tauri/Cargo.toml commands::agents::deploy::tests --lib` — 15 passed. - `. ./bin/activate-hermit && cargo test -p buzz-backend-kubernetes --test wire_fixtures` — 4 passed. ## Stack Info Stacked on #6732. This PR depends on #6732 and should merge after it. Generated with Codex --------- Signed-off-by: Salman Mohammed <smohammed@squareup.com> Signed-off-by: Leo <5faf251baee50ee6bcde338aef6acdd70bb3e60115664c2cd490d94a55dfc488@buzz.block.builderlab.xyz> Co-authored-by: Leo <5faf251baee50ee6bcde338aef6acdd70bb3e60115664c2cd490d94a55dfc488@buzz.block.builderlab.xyz>
33 lines
812 B
TypeScript
33 lines
812 B
TypeScript
import { expect, type Page } from "@playwright/test";
|
|
|
|
type SettingsSection =
|
|
| "profile"
|
|
| "notifications"
|
|
| "voice"
|
|
| "agents"
|
|
| "channel-templates"
|
|
| "compute"
|
|
| "experimental"
|
|
| "appearance"
|
|
| "shortcuts"
|
|
| "hosted-communities"
|
|
| "tokens"
|
|
| "community-members"
|
|
| "mobile"
|
|
| "updates";
|
|
|
|
export async function openProfileMenu(page: Page) {
|
|
await page.getByTestId("open-settings").click();
|
|
await expect(page.getByTestId("profile-popover")).toBeVisible();
|
|
}
|
|
|
|
export async function openSettings(page: Page, section?: SettingsSection) {
|
|
await openProfileMenu(page);
|
|
await page.getByTestId("profile-popover-settings").click();
|
|
await expect(page.getByTestId("settings-view")).toBeVisible();
|
|
|
|
if (section) {
|
|
await page.getByTestId(`settings-nav-${section}`).click();
|
|
}
|
|
}
|