Files
buzz/mobile/ios/Runner/NativeMessagePresentationCoordinator.swift
Tom Brow f6f6d9a673 chore(mobile): delete dead code with no remaining UI path (#8880)
## Summary

Deletes mobile code that no longer has a user-reachable path and has no
counterpart in buzz-app, so it is unlikely to come back for parity. Net:
104 files, about 5,500 lines removed. No intended behavior change.

- **iOS native message menu and action surface:**
`NativeMessageMenu.swift` and `NativeMessageActionSurface.swift`, the
`message`/`supportsMessage` coordinator branches, and the Dart selection
hook. Dart stopped creating this view in
[#8280](https://github.com/block/buzz/pull/8280). The native reactions
sheet in the same coordinator is kept.
- **Old home quick-actions launcher and `ComposeMorphIcon`:** only
instantiated in tests since the nav-bar creation actions replaced them.
- **Retired local theme stack:** `ThemeNotifier`, `AccentNotifier`,
`SchemeNotifier`, `adaptive_theme.dart`, `AccentPickerPage`, the
appearance-mode sheet and their helpers. These predate per-community
theme sync. The legacy prefs migration in
`community_theme_preference.dart` is kept.
- **Unused widgets:** `ProfileAvatar` and `MaskedAvatarBadge`.
- **Push permission-status plumbing:** the iOS
`notificationAuthorizationStatus`/`openNotificationSettings` handlers,
plus the uncalled strict age-gate snapshot registration and its Swift
`syncAgeGatePushSnapshot` path.
- **Orphaned files** with no importer: `profile_text_edit_sheet`,
`editor_option_button`, `retained_page_transition`,
`tappable_flapping_bee`, `agent_model_info`, `community_bot_profiles`,
`sheet_divider`, `success_haptic`.
- **Uncalled helpers:** the `pickAndUpload*`/camera helpers in
`media_upload.dart`, unused `NostrFilters` builders,
`mediaGetHeadersFor*`, and about 20 other uncalled functions, providers
and styles.
- **Removed-UI leftovers:** the never-wired invite directory providers,
`AuthNotifier.signOut` and `removeActiveCommunityForSignOut` (the Sign
out row is gone), `renameCommunity`,
`HomePage.profilePageBuilder`/`SettingsPage.embedded`, and the
create-forum branches of the create-channel sheet. Forum viewing is
unchanged.

Tests that only covered deleted code are removed. Tests of surviving
code that used deleted helpers as drivers were repointed to the
surviving API.

An audit of `mobile/android` found no dead Kotlin, resources, manifest
entries or Gradle dependencies, so Android code is unchanged.

## Validation

- `flutter analyze`: no issues.
- After rebasing onto main
([93b8b8f](https://github.com/block/buzz/commit/93b8b8febc)), `just
mobile-check` is clean (format and analyze), and `just mobile-test`
passes (4,070 passed, 35 skipped, 0 failed, plus the push-unconfigured
and secp256k1 suites).
- `dart format`: clean.
- Android: `just mobile-build-android` builds the debug APK, and
`./gradlew :app:testDebugUnitTest` passes.
- iOS: `build-for-testing` succeeds and BuzzPushKit `swift test` passes
(65 tests). In RunnerTests, 97 of 98 pass.
`testNativeNavigationTitleExpandsAgainAtTop` fails, but it fails the
same way on unmodified `main` (acf56fff6f) on the same machine (Xcode
27, iPhone 17 Pro simulator), so it is not caused by this change.
- Agent review of the diff ran. Its one blocker (stale `project.pbxproj`
entries for the deleted Swift files) is fixed.
- In-app smoke run at
[66141c1](66141c10b9):
a debug build on a fresh iPhone 17 Pro simulator (iOS 27), signed in to
the internal community. The following flows all worked with no errors:
- Home: the New menu (channel, DM, workspace, chat) and the
create-channel sheet, including its channel-type options.
- A chat, with the message action sheet (reactions row, Reply, Copy
link, Remind me, Mark unread, Copy text, Edit and Delete).
  - Appearance: the previews, and cycling the System and Light modes.
- Settings: the profile header, the display name editor, and Edit photo
(Image and Emoji tabs).
  - The Agents directory.
- Search, including the Channels filter, plus opening a team channel
from the results.
- Tapping a reaction summary, which opens the native iOS Reactions
sheet.
- The recording isn't attached here because it shows internal channels
and messages.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Signed-off-by: Tom Brow <tomb@squareup.com>
Co-authored-by: Tom Brow <tomb@squareup.com>
Co-authored-by: studio <dc2fc481343672df31a689840c09299972e704dac592e0da6f18486646a7ee3e@buzz.block.builderlab.xyz>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-01 14:09:50 -08:00

107 lines
4.4 KiB
Swift

import Flutter
import UIKit
/// Owns one UIKit reaction-details surface and completes its Flutter request on dismissal.
final class NativeMessagePresentationCoordinator: NSObject, UIAdaptivePresentationControllerDelegate {
private let channel: FlutterMethodChannel
private weak var parent: UIViewController?
private weak var presented: UIViewController?
private var pendingResult: FlutterResult?
private var requestID: String?
private var terminalValue: [String: String]?
init(messenger: FlutterBinaryMessenger, parentViewController: UIViewController?) {
channel = FlutterMethodChannel(name: "buzz/native_message_presentation", binaryMessenger: messenger)
parent = parentViewController
super.init()
channel.setMethodCallHandler { [weak self] call, result in
guard let self else { result(nil); return }
self.handle(call, result: result)
}
}
private func handle(_ call: FlutterMethodCall, result: @escaping FlutterResult) {
guard let data = call.arguments as? [String: Any] else { result(nil); return }
if call.method == "updateReactions" {
if data["requestId"] as? String == requestID,
let sheet = presented as? NativeReactionDetailsViewController,
let reactions = data["reactions"] as? [[String: Any]] {
sheet.updateReactions(reactions)
}
result([:])
return
}
if call.method == "updateProfiles" {
if data["requestId"] as? String == requestID,
let sheet = presented as? NativeReactionDetailsViewController,
let profiles = data["profiles"] as? [String: [String: Any]] {
sheet.updateProfiles(profiles)
}
result([:])
return
}
guard call.method == "reactions" else {
result(FlutterMethodNotImplemented)
return
}
// Ignore a second long press while presentation/dismissal is in flight.
guard pendingResult == nil else { result(["busy": true]); return }
let root = parent ?? UIApplication.shared.connectedScenes
.compactMap { $0 as? UIWindowScene }
.filter { $0.activationState == .foregroundActive }
.flatMap(\.windows).first(where: \.isKeyWindow)?.rootViewController
guard let parent = root, parent.view.window != nil else { result(nil); return }
guard parent.presentedViewController == nil else { result(["busy": true]); return }
let controller = NativeReactionDetailsViewController(data: data)
controller.onClose = { [weak self] in self?.dismiss([:]) }
controller.onAddReaction = { [weak self] in
self?.dismiss(["action": "addReaction"])
}
controller.onToggle = { [weak self] emoji in
self?.channel.invokeMethod("toggleReaction", arguments: [
"requestId": data["requestId"] as? String ?? "", "emoji": emoji,
])
}
controller.modalPresentationStyle = .pageSheet
if let presentation = controller.sheetPresentationController {
presentation.overrideTraitCollection = UITraitCollection(userInterfaceStyle: controller.overrideUserInterfaceStyle)
presentation.detents = [.medium(), .large()]
presentation.prefersGrabberVisible = true
presentation.prefersScrollingExpandsWhenScrolledToEdge = true
}
controller.overrideUserInterfaceStyle = data["dark"] as? Bool == true ? .dark : .light
pendingResult = result
requestID = data["requestId"] as? String
presented = controller
controller.presentationController?.delegate = self
UIImpactFeedbackGenerator(style: .medium).impactOccurred()
parent.present(controller, animated: !UIAccessibility.isReduceMotionEnabled)
}
private func dismiss(_ value: [String: String]) {
guard pendingResult != nil, terminalValue == nil else { return }
terminalValue = value
guard let presented else { complete(value); return }
let completion: () -> Void = { [weak self] in
guard let self, self.presented === presented else { return }
self.complete(value)
}
presented.dismiss(animated: !UIAccessibility.isReduceMotionEnabled, completion: completion)
}
func presentationControllerDidDismiss(_ presentationController: UIPresentationController) {
guard presented === presentationController.presentedViewController else { return }
complete([:])
}
private func complete(_ value: [String: String]) {
let result = pendingResult
let terminal = terminalValue ?? value
terminalValue = nil
pendingResult = nil
presented = nil
requestID = nil
result?(terminal)
}
}