From 7f5ebca3fb11f7cdb28cc4f5a7cdd3fc04887636 Mon Sep 17 00:00:00 2001 From: WhiskeyJack96 Date: Wed, 15 Oct 2025 01:34:49 -0700 Subject: [PATCH] Make write and edit permissions consistent (#92) Currently edit requires a permissions call and write does not. This means that if clients want to allow users to approve `Write` calls they need to add handling to `HandleFileWrite` but if they do that then edits get _two_ permissions checks. Alternatively we could remove the write tool from approved tools (which would make more sense to me) but I'm assuming its there for a good reason, if not happy to change to remove it instead! --------- Co-authored-by: Ben Brandt --- src/acp-agent.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/src/acp-agent.ts b/src/acp-agent.ts index 099b41dd..2cc34fb5 100644 --- a/src/acp-agent.ts +++ b/src/acp-agent.ts @@ -191,7 +191,6 @@ export class ClaudeAcpAgent implements Agent { disallowedTools.push("Read"); } if (this.clientCapabilities?.fs?.writeTextFile) { - allowedTools.push(toolNames.write); disallowedTools.push("Write", "Edit"); } if (this.clientCapabilities?.terminal) {