jerry/OpenBB
1
0
Fork 0
mirror of https://github.com/OpenBB-finance/OpenBB.git synced 2026-10-27 20:42:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

[BugFix] yFinance ETF Info: Try Different Field When Missing fundInceptionDate (#6260)

Browse Source 
* try different field when missing the inceptionDate

* wrap that in try-except

* pylint
This commit is contained in:
Danglewood
2024-03-30 07:32:32 -07:00
committed by GitHub
parent 76405567e5
commit 42a8c8f790
1 changed files with 20 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
openbb_platform/providers/yfinance/openbb_yfinance/models/etf_info.py
View File

@@ -190,7 +190,9 @@ class YFinanceEtfInfoData(EtfInfoData):
@classmethod
def validate_date(cls, v):
"""Validate first stock price date."""
return datetime.utcfromtimestamp(v).date().strftime("%Y-%m-%d") if v else None
if isinstance(v, datetime):
return v.date().strftime("%Y-%m-%d")
return datetime.fromtimestamp(v).date().strftime("%Y-%m-%d") if v else None
class YFinanceEtfInfoFetcher(
@@ -249,6 +251,7 @@ class YFinanceEtfInfoFetcher(
"fiveYearAverageReturn",
"beta3Year",
"longBusinessSummary",
"firstTradeDateEpochUtc",
]
async def get_one(symbol):
@@ -262,9 +265,22 @@ class YFinanceEtfInfoFetcher(
if ticker:
quote_type = ticker.pop("quoteType", "")
if quote_type == "ETF":
for field in fields:
if field in ticker:
result[field] = ticker.get(field, None)
try:
for field in fields:
if field in ticker and ticker.get(field) is not None:
result[field] = ticker.get(field, None)
if "firstTradeDateEpochUtc" in result:
_first_trade = result.pop("firstTradeDateEpochUtc")
if (
"fundInceptionDate" not in result
and _first_trade is not None
):
result["fundInceptionDate"] = datetime.fromtimestamp(
_first_trade
)
except Exception as e:
_warn(f"Error processing data for {symbol}: {e}")
result = {}
if quote_type != "ETF":
_warn(f"{symbol} is not an ETF.")
if result: