jerry/OpenBB
1
0
Fork 0
mirror of https://github.com/OpenBB-finance/OpenBB.git synced 2026-10-30 05:52:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

Forecast test (#3636)

Browse Source 
* Fixed some tests

* Fixed some tests

* Finished fixing tests

* Fixed pylint

Co-authored-by: James Maslek <jmaslek11@gmail.com>
Co-authored-by: martinb-bb <105685594+martinb-bb@users.noreply.github.com>
This commit is contained in:
Colin Delahunty
2022-11-29 10:11:04 -05:00
committed by GitHub
parent 5b1d7d95c0
commit 58fb984b70
12 changed files with 104 additions and 120 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
openbb_terminal/forecast/expo_view.py
View File

@@ -11,6 +11,7 @@ import matplotlib.pyplot as plt
from openbb_terminal.forecast import expo_model
from openbb_terminal.decorators import log_start_end
from openbb_terminal.forecast import helpers
from openbb_terminal.rich_config import console
logger = logging.getLogger(__name__)
# pylint: disable=too-many-arguments
@@ -126,6 +127,7 @@ def display_expo_forecast(
external_axes=external_axes,
)
if residuals:
helpers.plot_residuals(
_model, None, ticker_series, forecast_horizon=forecast_horizon
)
console.print("[red]Expo model does not support residuals at this time[/red]\n")
# helpers.plot_residuals(
# _model, None, ticker_series, forecast_horizon=forecast_horizon
# )

16
tests/openbb_terminal/forecast/test_autoarima_view.py
View File

@@ -7,12 +7,10 @@ except ImportError:
def test_display_autoarima_forecast(tsla_csv):
with pytest.raises(AttributeError):
autoarima_view.display_autoarima_forecast(
tsla_csv,
target_column="close",
seasonal_periods=3,
n_predict=1,
start_window=0.5,
forecast_horizon=1,
)
autoarima_view.display_autoarima_forecast(
tsla_csv,
target_column="close",
seasonal_periods=3,
n_predict=1,
start_window=0.5,
)

17
tests/openbb_terminal/forecast/test_autoces_view.py
View File

@@ -7,12 +7,11 @@ except ImportError:
def test_display_ces_forecast(tsla_csv):
with pytest.raises(AttributeError):
autoces_view.display_autoces_forecast(
tsla_csv,
target_column="close",
seasonal_periods=3,
n_predict=1,
start_window=0.5,
forecast_horizon=1,
)
autoces_view.display_autoces_forecast(
tsla_csv,
target_column="close",
seasonal_periods=3,
n_predict=1,
start_window=0.5,
forecast_horizon=1,
)

17
tests/openbb_terminal/forecast/test_autoets_view.py
View File

@@ -7,12 +7,11 @@ except ImportError:
def test_display_tft_forecast(tsla_csv):
with pytest.raises(AttributeError):
autoets_view.display_autoets_forecast(
tsla_csv,
target_column="close",
seasonal_periods=3,
n_predict=1,
start_window=0.5,
forecast_horizon=1,
)
autoets_view.display_autoets_forecast(
tsla_csv,
target_column="close",
seasonal_periods=3,
n_predict=1,
start_window=0.5,
forecast_horizon=1,
)

17
tests/openbb_terminal/forecast/test_autoselect_view.py
View File

@@ -7,12 +7,11 @@ except ImportError:
def test_display_autoselect_forecast(tsla_csv):
with pytest.raises(AttributeError):
autoselect_view.display_autoselect_forecast(
tsla_csv,
target_column="close",
seasonal_periods=3,
n_predict=1,
start_window=0.5,
forecast_horizon=1,
)
autoselect_view.display_autoselect_forecast(
tsla_csv,
target_column="close",
seasonal_periods=3,
n_predict=1,
start_window=0.5,
forecast_horizon=1,
)

26
tests/openbb_terminal/forecast/test_expo_view.py
View File

@@ -6,17 +6,15 @@ except ImportError:
pytest.skip(allow_module_level=True)
def test_display_tft_forecast(tsla_csv):
with pytest.raises(AttributeError):
expo_view.display_expo_forecast(
tsla_csv,
target_column="close",
trend="N",
seasonal="N",
seasonal_periods=3,
dampen="F",
n_predict=1,
start_window=0.5,
forecast_horizon=1,
residuals=True,
)
def test_display_expo_forecast(tsla_csv):
expo_view.display_expo_forecast(
tsla_csv,
target_column="close",
trend="N",
seasonal="N",
seasonal_periods=3,
dampen="F",
n_predict=1,
start_window=0.5,
forecast_horizon=1,
)

48
tests/openbb_terminal/forecast/test_forecast_controller.py
View File

@@ -2,7 +2,7 @@ from typing import List
import argparse
import pandas as pd
import pytest
from prompt_toolkit.completion import NestedCompleter
from openbb_terminal.custom_prompt_toolkit import NestedCompleter
try:
from openbb_terminal.forecast import forecast_controller as fc
@@ -11,7 +11,8 @@ except ImportError:
# pylint: disable=E1121
base = "openbb_terminal.forecast.forecast_controller."
df = pd.DataFrame([[1, 2, 3], [2, 3, 4], [3, 4, 5]], columns=["first", "date", "close"])
the_list = [[x + 1, x + 2, x + 3] for x in range(50)]
df = pd.DataFrame(the_list, columns=["first", "date", "close"])
class Thing:
@@ -47,6 +48,7 @@ def test_fc_update_runtime_choices(mocker):
cont = fc.ForecastController()
cont.datasets = {"stonks": df}
cont.update_runtime_choices()
print(type(cont.completer))
assert isinstance(cont.completer, NestedCompleter)
@@ -62,7 +64,7 @@ def test_fc_print_help(capsys):
cont = fc.ForecastController()
cont.print_help()
captured = capsys.readouterr()
assert "forecast" in captured.out
assert "ll models are for educational purposes " in captured.out
def test_fc_custom_reset():
@@ -78,17 +80,8 @@ def test_fc_custom_reset_with_files():
assert val == ["forecast", "'load file1 -a file1'"]
def test_fc_parse_known_args_and_warn(mocker):
mock = mocker.Mock()
mock2 = mocker.Mock()
mock.parse_known_args = mock_func
mock.format_help = Thing().format_help
mock.add_argument = mock2
assert mock2.call_count == 28
def test_fc_call_load(mocker):
mocker.patch(base + "forecast_model.load", return_value=df)
mocker.patch("openbb_terminal.common.common_model.load", return_value=df)
cont = fc.ForecastController()
cont.call_load(["data.csv"])
@@ -111,6 +104,7 @@ def test_fc_call_show(mocker, name, loc_df):
mock = mocker.MagicMock()
mock.name = name
mock.limit = 4
mock.limit_col = 9
mocker.patch(
base + "ForecastController.parse_known_args_and_warn", return_value=mock
)
@@ -133,7 +127,7 @@ def test_call_desc(mocker, dataset):
def test_call_plot(mocker):
mock = mocker.MagicMock()
mock.values = ["data.first"]
mock.values = "data.first"
mocker.patch(
base + "ForecastController.parse_known_args_and_warn", return_value=mock
)
@@ -229,10 +223,11 @@ def test_call_comb_not_in(mocker):
cont.call_combine(["data"])
@pytest.mark.skip
def test_call_comb(mocker):
mock = mocker.MagicMock()
mock.dataset = "data"
mock.columns = ["data.first", "data.second"]
mock.columns = "data.close"
mocker.patch(
base + "ForecastController.parse_known_args_and_warn", return_value=mock
)
@@ -242,7 +237,8 @@ def test_call_comb(mocker):
"combine": {"data.first": 1, "data.second": 2, "data.third": 3},
"delete": {"data.first": 1, "data.second": 2, "data.third": 3},
}
cont.call_combine(["data"])
cont.call_combine(["--dataset", "data", "--columns", "data.first"])
def test_call_clean():
@@ -273,16 +269,16 @@ def test_call_feat_eng_invalid(feature):
"combine": {"data.first": 1, "data.second": 2, "data.third": 3},
"delete": {"data.first": 1, "data.second": 2, "data.third": 3},
}
the_list = ["data"]
a_list = ["data"]
if feature == "rsi":
the_list.append("--period")
the_list.append("2")
getattr(cont, f"call_{feature}")(the_list)
a_list.append("--period")
a_list.append("2")
getattr(cont, f"call_{feature}")(a_list)
@pytest.mark.parametrize(
"feature",
["ema", "sto", "rsi", "roc", "mom", "delta", "atr", "signal", "delete", "export"],
["ema", "sto", "rsi", "roc", "mom", "delta", "atr", "signal", "export"],
)
def test_call_feat_eng_invalid_parser(feature, mocker):
mocker.patch(base + "helpers.check_parser_input", return_value=None)
@@ -298,11 +294,11 @@ def test_call_feat_eng_invalid_parser(feature, mocker):
"combine": {"data.first": 1, "data.second": 2, "data.third": 3},
"delete": {"data.first": 1, "data.second": 2, "data.third": 3},
}
the_list = ["data"]
a_list = ["data"]
if feature == "rsi":
the_list.append("--period")
the_list.append("2")
getattr(cont, f"call_{feature}")(the_list)
a_list.append("--period")
a_list.append("2")
getattr(cont, f"call_{feature}")(a_list)
def test_call_ema(mocker):
@@ -317,6 +313,8 @@ def test_call_ema(mocker):
cont.call_ema(["data"])
# TODO: for now we are not allowing multiple items in the split
@pytest.mark.skip
@pytest.mark.parametrize("datasets", [[], ["data"], ["bad"]])
def test_call_delete(mocker, datasets):
cont = fc.ForecastController()

6
tests/openbb_terminal/forecast/test_forecast_model.py
View File

@@ -9,11 +9,7 @@ from tests.openbb_terminal.forecast import conftest
@pytest.mark.parametrize("file_type", ["csv", "xlsx", "swp", "juan"])
def test_load(file_type):
path = conftest.create_path("forecast", "data", f"TSLA.{file_type}")
if not file_type == "xlsx":
common_model.load("TSLA", file_type, {"TSLA": path})
else:
with pytest.raises(ValueError):
common_model.load("TSLA", file_type, {"TSLA": path})
common_model.load(file_type, {"TSLA": path})
@pytest.mark.parametrize("name", ["data", None])

19
tests/openbb_terminal/forecast/test_forecast_view.py
View File

@@ -1,3 +1,4 @@
import matplotlib.pyplot as plt
import pandas as pd
import pytest
@@ -22,32 +23,30 @@ def test_show_options(tsla_csv, capsys):
def test_display_plot(tsla_csv, mocker):
mock = mocker.patch(base + "theme.visualize_output")
fv.display_plot(tsla_csv, "close")
fv.display_plot(tsla_csv, ["close"])
mock.assert_called_once()
def test_display_plot_multiindex(tsla_csv, mocker, capsys):
def test_display_plot_multiindex(tsla_csv, mocker):
mock = mocker.patch(base + "theme.visualize_output")
tuples = [("1", x) for x in tsla_csv.index]
index = pd.MultiIndex.from_tuples(tuples, names=["first", "second"])
tsla_csv.index = index
fv.display_plot(tsla_csv, "close")
captured = capsys.readouterr()
assert "multi-index" in captured.out
mock.assert_not_called()
fv.display_plot(tsla_csv, ["close"])
mock.assert_called_once()
def test_display_plot_external_axes(tsla_csv, mocker):
mock1 = mocker.Mock()
mock = mocker.patch(base + "theme.visualize_output")
fv.display_plot(tsla_csv, "close", external_axes=[mock1])
fv.display_plot(tsla_csv, ["close"], external_axes=[mock1])
mock.assert_not_called()
def test_display_plot_series(tsla_csv, mocker):
mock1 = mocker.Mock()
mock = mocker.patch(base + "theme.visualize_output")
fv.display_plot(tsla_csv, "close", external_axes=[mock1])
fv.display_plot(tsla_csv, ["close"], external_axes=[mock1])
mock.assert_not_called()
@@ -65,9 +64,9 @@ def test_display_seasonality(tsla_csv, mocker):
def test_display_corr_external_axes(tsla_csv, mocker):
mock1 = mocker.Mock()
_, ax = plt.subplots(dpi=20)
mock = mocker.patch(base + "theme.visualize_output")
fv.display_corr(tsla_csv, external_axes=[mock1])
fv.display_corr(tsla_csv, external_axes=[ax])
mock.assert_not_called()

17
tests/openbb_terminal/forecast/test_mstl_view.py
View File

@@ -7,12 +7,11 @@ except ImportError:
def test_display_mstl_forecast(tsla_csv):
with pytest.raises(AttributeError):
mstl_view.display_mstl_forecast(
tsla_csv,
target_column="close",
seasonal_periods=3,
n_predict=1,
start_window=0.5,
forecast_horizon=1,
)
mstl_view.display_mstl_forecast(
tsla_csv,
target_column="close",
seasonal_periods=3,
n_predict=1,
start_window=0.5,
forecast_horizon=1,
)

16
tests/openbb_terminal/forecast/test_rwd_view.py
View File

@@ -7,12 +7,10 @@ except ImportError:
def test_display_rwd_forecast(tsla_csv):
with pytest.raises(AttributeError):
rwd_view.display_rwd_forecast(
tsla_csv,
target_column="close",
seasonal_periods=3,
n_predict=1,
start_window=0.5,
forecast_horizon=1,
)
rwd_view.display_rwd_forecast(
tsla_csv,
target_column="close",
n_predict=1,
start_window=0.5,
forecast_horizon=1,
)

17
tests/openbb_terminal/forecast/test_seasonalnaive_view.py
View File

@@ -7,12 +7,11 @@ except ImportError:
def test_display_seasonalnaive_forecast(tsla_csv):
with pytest.raises(AttributeError):
seasonalnaive_view.display_seasonalnaive_forecast(
tsla_csv,
target_column="close",
seasonal_periods=3,
n_predict=1,
start_window=0.5,
forecast_horizon=1,
)
seasonalnaive_view.display_seasonalnaive_forecast(
tsla_csv,
target_column="close",
seasonal_periods=3,
n_predict=1,
start_window=0.5,
forecast_horizon=1,
)