jerry/OpenBB
1
0
Fork 0
mirror of https://github.com/OpenBB-finance/OpenBB.git synced 2026-10-27 20:42:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix symbol validator in standard models (#5839)

Browse Source 
Co-authored-by: Pratyush Shukla <ps4534@nyu.edu>
This commit is contained in:
Danglewood
2023-12-05 06:36:28 -08:00
committed by GitHub
parent 2cfac126f1
commit 974bb8bbca
3 changed files with 3 additions and 45 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
openbb_platform/core/openbb_core/provider/standard_models/balance_sheet.py
View File

@@ -29,25 +29,11 @@ class BalanceSheetQueryParams(QueryParams):
default=5, description=QUERY_DESCRIPTIONS.get("limit", "")
)
# pylint: disable=inconsistent-return-statements
@field_validator("symbol", mode="before", check_fields=False)
@classmethod
def upper_symbol(cls, v: Union[str, List[str], Set[str]]):
"""Convert symbol to uppercase."""
if isinstance(v, str):
if v.isdigit() or v.isalpha():
return v.upper()
raise ValueError(f"Invalid symbol: {v}. Must be either a ticker or CIK.")
if isinstance(v, List):
symbols = []
for symbol in v:
if symbol.isdigit() or symbol.isalpha():
symbols.append(symbol.upper())
else:
raise ValueError(
f"Invalid symbol: {symbol}. Must be either a ticker or CIK."
)
return ",".join(symbols)
return v.split(",")[0].upper() if "," in v else v.upper()
class BalanceSheetData(Data):

16
openbb_platform/core/openbb_core/provider/standard_models/cash_flow.py
View File

@@ -26,25 +26,11 @@ class CashFlowStatementQueryParams(QueryParams):
default=5, description=QUERY_DESCRIPTIONS.get("limit", "")
)
# pylint: disable=inconsistent-return-statements
@field_validator("symbol", mode="before", check_fields=False)
@classmethod
def upper_symbol(cls, v: Union[str, List[str], Set[str]]):
"""Convert symbol to uppercase."""
if isinstance(v, str):
if v.isdigit() or v.isalpha():
return v.upper()
raise ValueError(f"Invalid symbol: {v}. Must be either a ticker or CIK.")
if isinstance(v, List):
symbols = []
for symbol in v:
if symbol.isdigit() or symbol.isalpha():
symbols.append(symbol.upper())
else:
raise ValueError(
f"Invalid symbol: {symbol}. Must be either a ticker or CIK."
)
return ",".join(symbols)
return v.split(",")[0].upper() if "," in v else v.upper()
class CashFlowStatementData(Data):

16
openbb_platform/core/openbb_core/provider/standard_models/income_statement.py
View File

@@ -26,25 +26,11 @@ class IncomeStatementQueryParams(QueryParams):
default=5, description=QUERY_DESCRIPTIONS.get("limit", "")
)
# pylint: disable=inconsistent-return-statements
@field_validator("symbol", mode="before", check_fields=False)
@classmethod
def upper_symbol(cls, v: Union[str, List[str], Set[str]]):
"""Convert symbol to uppercase."""
if isinstance(v, str):
if v.isdigit() or v.isalpha():
return v.upper()
raise ValueError(f"Invalid symbol: {v}. Must be either a ticker or CIK.")
if isinstance(v, List):
symbols = []
for symbol in v:
if symbol.isdigit() or symbol.isalpha():
symbols.append(symbol.upper())
else:
raise ValueError(
f"Invalid symbol: {symbol}. Must be either a ticker or CIK."
)
return ",".join(symbols)
return v.split(",")[0].upper() if "," in v else v.upper()
class IncomeStatementData(Data):