jerry/OpenBB
1
0
Fork 0
mirror of https://github.com/OpenBB-finance/OpenBB.git synced 2026-11-09 02:42:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

[BugFix] Safely Access openapi_extra When None (#7077)

Browse Source 
* safely access openapi_extra

* fix that

* unused code
This commit is contained in:
Danglewood
2025-03-27 20:20:42 -07:00
committed by GitHub
parent c6d7b63f72
commit e9c95b928b
3 changed files with 12 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
openbb_platform/core/openbb_core/api/router/commands.py
View File

@@ -185,7 +185,11 @@ def build_api_wrapper(
func: Callable = route.endpoint # type: ignore
path: str = route.path # type: ignore
no_validate = route.openapi_extra.get("no_validate")
no_validate = (
openapi_extra.get("no_validate")
if (openapi_extra := getattr(route, "openapi_extra", None))
else None
)
new_signature = build_new_signature(path=path, func=func)
new_annotations_map = build_new_annotation_map(sig=new_signature)
func.__signature__ = new_signature # type: ignore

2
openbb_platform/core/openbb_core/app/router.py
View File

@@ -423,7 +423,7 @@ class CommandMap:
coverage_map: Dict[Any, Any] = {}
for route in api_router.routes:
openapi_extra = getattr(route, "openapi_extra")
openapi_extra = getattr(route, "openapi_extra", None)
if openapi_extra:
model = openapi_extra.get("model", None)
if model:

38
openbb_platform/core/openbb_core/app/static/package_builder.py
View File

@@ -320,7 +320,7 @@ class ImportDefinition:
def get_function_hint_type_list(cls, route) -> List[Type]:
"""Get the hint type list from the function."""
no_validate = route.openapi_extra.get("no_validate")
no_validate = getattr(route, "openapi_extra", {}).get("no_validate")
func = route.endpoint
sig = signature(func)
@@ -533,7 +533,11 @@ class ClassDefinition:
if route.openapi_extra
else None
),
examples=(route.openapi_extra.get("examples", []) or []),
examples=(
route.openapi_extra.get("examples", [])
if route.openapi_extra
else []
),
)
else:
doc += " /" if path else " /"
@@ -1689,36 +1693,6 @@ class DocstringGenerator:
provider_param: Union[Parameter, dict] = {}
chart_param: Union[Parameter, dict] = {}
def process_param(param_name, param_type, description, kwarg_info=None):
"""Process parameter info and add provider-specific choices info."""
formatted_description = description
# Check if we have provider-specific choices information for this parameter
if kwarg_info and param_name in kwarg_info:
param_info = kwarg_info[param_name]
for provider, details in param_info.items():
if "choices" in details and details["choices"]:
multiple_items = details.get("multiple_items_allowed", False)
multiple_text = (
" Multiple comma separated items allowed."
if multiple_items
else ""
)
# For parameters with many choices (like form_type for SEC)
if len(details["choices"]) > 20:
formatted_description += (
f" (provider: {provider}){multiple_text}"
)
# For parameters with reasonable number of choices
else:
choices_str = ", ".join(
[f"'{c}'" for c in details["choices"]]
)
formatted_description += f"\nChoices for {provider}: {choices_str}{multiple_text}"
return formatted_description
# Description summary
if "description" in sections:
docstring = summary.strip("\n").replace("\n ", f"\n{create_indent(2)}")