Commit Graph

3085 Commits

Author SHA1 Message Date
montezdesousa
ec9a88e8fa Fill missing static data (sector, industry, country and region) on portfolio creation (#2072)
* pull sector industry country data from yfinance

* fix imports with missing info

* run black on helper

* fix tests

* fix tests

* fix linting

* autofill stock data and display progress bar

* redirect stock data file

* substitute only stocks not provided by user

* reset benchmark when new portfolio is loaded (bug fix)

* rewrite help, will be fixed in previous pr

* fix mypy

* fix linting

* fix linting with open

* format progress bar

* run black

* avoid clearing of all fields

* reformat error message

* improve returns calculation performance

* general linting

Co-authored-by: Jeroen Bouma <jer.bouma@gmail.com>
Co-authored-by: Theodore Aptekarev <aptekarev@gmail.com>
2022-07-18 18:47:45 +01:00
montezdesousa
82b6411cab remove cumulative returns functionalities (#2103)
Co-authored-by: Jeroen Bouma <jer.bouma@gmail.com>
Co-authored-by: Theodore Aptekarev <aptekarev@gmail.com>
2022-07-18 18:50:59 +03:00
Chavithra
1995344965 Tests : mock api call (#2105) 2022-07-18 17:51:12 +03:00
DidierRLopes
b75629054f Make sec fillings link clickable in report (#2104)
* Make sec fillings link clickable in report

* remove regressions from autocompleter
2022-07-18 16:27:21 +03:00
Jalil F
96ed08daaa [Bugfix#2094] Fix handling of balances when user has no tokens. (#2095)
* Add edge case handlers for crypto balance. Resolves OpenBB-finance/OpenBBTerminal#2094

* Clear print statement.

* Run previous df generation.

* Run pure row merge.

* Fixing spacing.

* Adding test and fixing previous test failures.

* Clear comment.

* Adding vcr test.

* revert to old poetry.lock

Co-authored-by: DidierRLopes <dro.lopes@campus.fct.unl.pt>
2022-07-17 13:33:16 +01:00
Theodore Aptekarev
c5c2f3f8d4 Update jupyterlab deps to resolve dependabot alerts (#2082)
* Remove old naming leftovers

* Update jupyterlab deps

* Bump jsdom to a patched version

Co-authored-by: Colin Delahunty <72827203+colin99d@users.noreply.github.com>
2022-07-17 12:45:02 +03:00
montezdesousa
0f6852cf0c Fixes error message on portfolio menu help (#2088)
* fix message display on help

* rewrite expected on print help

* fix linting
2022-07-15 10:21:02 +01:00
pftp-jz
5fc2635648 adding data range for VaR (#2087)
* adding data range for VaR

* Update qa_controller.py
2022-07-14 18:41:57 +01:00
Jeroen Bouma
73a31f8f00 Add buttons linking to the installation page (#2086)
* Add in Install Terminal link

* Add in CSS and HTML for a button that links to terminal installation

* Because Jose said so

* Jose forced me to

* Last change forced by Jose

* No rel:
2022-07-14 14:52:20 +02:00
Jeroen Bouma
0fa9936651 Add in DeFi, DD and NFT guides from the Crypto menu (#2083)
* Url fix

* Add in Crypto DD Guide

* Add in NFT Guide

* Add in Messari

* Typo

* Add in DeFI Guide

* Update _index.md

* Update _index.md

* Update _index.md

* Remove images

* Fix links

* More fixes

* Spelling

* Let links open new page instead

* Fix another link:
2022-07-13 14:45:11 +01:00
ghbcode
51b6c6ca76 Corrected wording (#2080) 2022-07-13 09:15:12 -04:00
James Maslek
9e7cf49e91 sources goofed (#2079) 2022-07-13 07:44:15 +01:00
Jeroen Bouma
05e809a881 Add Crypto discovery, onchain and overview menu (#2073)
* Add onchain, ov and disc pages

* Fix broken links

* Fix links

* Update _index.md

* Update _index.md

* Update _index.md

* Remove images
2022-07-13 06:58:04 +02:00
pftp-jz
88c091b204 Updating README.md from top folder, CONTRIBUTING.md wrong link (#2075)
The 'OpenBB-finance/OpenBBTerminal' repository doesn't contain the 'openbb_terminal/CONTRIBUTING.md' path in 'main'.

CONTRIBUTING.md link was pointed to openbb_terminal folder, when it was supposed to be pointed to the main folder
Also both are pointing to master folder, and they are being redirected via "Branch not found, redirected to default branch." :
        Maybe update to https://github.com/OpenBB-finance/OpenBBTerminal/blob/main/CONTRIBUTING.md ?
but either way https://github.com/OpenBB-finance/OpenBBTerminal/tree/master/CONTRIBUTING.md would still redirect correctly
2022-07-12 21:13:37 -04:00
James Maslek
8263d84398 Fix oanda key issue (#2077) 2022-07-12 19:49:47 -04:00
DidierRLopes
e91e6c00f9 fix regression introduced (#2076) 2022-07-12 23:05:15 +01:00
DidierRLopes
b6f52429d1 allow user to set flag (#2074) 2022-07-12 19:54:12 +01:00
DidierRLopes
9e220e8f3c Creates a controller to specify sources (#2069)
* Add all data sources to data_sources_default.json so we can have a list in one place

* create menu to get and set data sources

* improve settings controller

* james request

* improve helper message

* minor improvement

* fix tests
2022-07-12 18:56:52 +01:00
Chavithra
0dfd53f28a Portoflio : add pa export command for Degiro (#2065)
* Portoflio : add pa export command for Degiro

* Update controller + tests

* Tests

* Degiro : update pa export format

* Fixing Premium

* Black

* Show index
2022-07-12 19:38:34 +02:00
montezdesousa
4c0b1135a9 Economic calendar command (#2043)
* add ecocal command to menu

* add menu legend

* run black and pylint

* fix date input

* add command to main.yml

* sort and remove duplicates

* run black on model

* fetch user timezone automatically

* remove tz option and None displays

* adds choices to controller

* fix dates corner case

* create test for get_economic_calendar

* write tests for investingcom_view

* fix ycrv model

* remove unused imports

* rewrite expected for economy print help

* rewrite expected for portfolio model

* fix linting

* fix linting

* try to pass pylint again

* create _index.md

* complete docstrings

* rewrite expected  on portfolio model

* Update _index.md

* Update _index.md

* change -i default to all

* rewrite portfolio model and mark vcr

* run black on test changes

* revert changes on tests

* add limit to nr of events

Co-authored-by: Jeroen Bouma <jer.bouma@gmail.com>
2022-07-12 16:22:48 +01:00
Theodore Aptekarev
5267af2876 Bump python version (#2061)
* Add python 3.9 conda environment

* Bump dependency versions

* Bump default python version in github actions to 3.9

* Update install documentation

* Update tests

* Bump black version in conda environments

* Skip test_display_norm in econometrics menu tests

* Bump black and tensorflow versions in pyproject toml

* Attempt to fix failing concurrent windows tests

* Skip test_display_norm in econometrics menu tests

* Bump python in conda test workflows

* Update requirements.txt

* Fix old version fallback tag
2022-07-12 16:30:59 +03:00
montezdesousa
dfd6d49056 Fixes portfolio_model.py tests (#2071)
* fix portfolio tests

* run black on test file

* remove unused argument
2022-07-12 11:41:59 +02:00
James Maslek
72e2e78ad2 Get rid of datetime and market open closes in default stock load (#2067)
* Get rid of datetime and market open closes in default stock load

* fix portfolio tests
2022-07-11 15:55:26 -04:00
montezdesousa
2c3e10a128 Overhaul Portfolio class (#2021)
* adds pythonic portfolio class

* start calculate trades refactoring

* adds comments to portfolio model - delete afterwards

* finish calculate trades refactoring

* restore original portfolio_model.py

* implement calculate_allocations

* adapt and test controller load, show, bench, alloc and perf

* add old code that was ok

* adapt controller

* adapt portfolio_view

* run black on pythonic_portfolio.py

* fix crypto bug

* change column name in example datasets

* substitute portfolio_model.py

* update show command

* push cumulative returns calculation to model

* fix last change in cumulative returns

* add comments on possibly unused code

* run black on changes

* bring metrics from helper to model

* push rolling metrics from view to model

* Details and linting

* Fix tests

* remove empty attribute and rename class

* fix view and controller rf

* change returns calculation method

* remove CASH from code

* remove cash from tickers_list

* run black on changes

* change function name

* adapt to PortfolioModel

* fix tests

* fix tests on help

* fix linting

* call metrics from PortfolioModel

* call drawdown from model

* fix some mypy issues

* fix remaining mypy issues

* fix test

* Fix linting

* Remove unused function

* Small fixes

* Remove old code and adjust summary to simply work

* Update the Excel since CASH is no longer a thing

* Fix tests

* Update the csvs

* Updates to usage of full_shares and more details

* Fix -t flag for perf

Co-authored-by: Jeroen Bouma <jer.bouma@gmail.com>
2022-07-08 17:59:09 +02:00
James Maslek
b229ed7570 Fix the available sorting columns in divcal (#2059) 2022-07-07 21:51:50 +01:00
James Maslek
311bdef099 Stop consuming first element of list (#2058) 2022-07-07 15:34:59 -04:00
James Maslek
d1e97c7ac4 Update data sources json to allow submenu loading (#2057)
* update data sources json

* missed one

* fix test
2022-07-07 19:05:57 +01:00
hjoaquim
e2eab7dc1f Fixes #2044 Stocks/Load - Cannot load monthly/weekly interval with Polygon as source. (#2051)
* fixed polygon timespan, it wasn't using the montly/weekly flags

* validate if the column exists before proceeding with the sort

* if the stock dataframe is empty we'll keep the previous behaviour. also, added quotes to keep the formatting the same as the original message.

Co-authored-by: Chavithra <chavithra@gmail.com>
2022-07-07 16:01:13 +02:00
hjoaquim
583d1632e6 added verification for windows. if start is prior to 1970, convert it to 1970-01-02 (1 day buffer in case of timezone adjustments) (#2056)
reference_1 : https://stackoverflow.com/questions/2518706/python-mktime-overflow-error
reference_2 : https://discuss.python.org/t/please-help-getting-try-except-working-for-yfinance-download/11682/6

Co-authored-by: Chavithra <chavithra@gmail.com>
2022-07-07 13:30:51 +01:00
DidierRLopes
0276784b35 Update defaults.ini (#2035)
* update defaults.ini

* fix arg

* Make arg more robust when you use ini file

* Fix tests

Co-authored-by: JerBouma <jer.bouma@gmail.com>
2022-07-07 13:39:29 +02:00
northern-64bit
89297fadc4 Adding new portfolio metrics (#2029)
* Making pa active + pa minor features

Makes pa actice and adds country to the df. The groupby command also gets percents of holding allocation. It also fixes warnings and prepares for a later pr that I'm currently working on.

* Fix linting

* black linter

* Fixes

Should fix everything

* Linting

* Making pa controller to base class standard

* Fix linting

* first metrics

* Adding calmar ratio

* Adding metrics to controller

* Linting

* Linting

* Test fixes

* Test fixes

* Adding tests

* Linting

* Restructuring added tests

* Linting

* Updating hugo website and fixing help

* Fixing commands

* Fix kelly criterion command

* Fixing tests

* Linting

* More linting

Co-authored-by: DidierRLopes <dro.lopes@campus.fct.unl.pt>
Co-authored-by: Jeroen Bouma <jer.bouma@gmail.com>
2022-07-07 10:14:16 +02:00
Jeroen Bouma
b749d6e3c6 Improvements within the Terminal for the Documentation (#2048)
* Change about us to open_terminal_documentation

* Change the home menu to be more compact

* Make changes to menu layout and change bottom bar

* Change about command to send you to the documentation and add about to bottom bar

* Add in about choices to all menus

* Adjust wording

* Adjust the website to match terminal commands and make adjustments for common menus

* Update the website and small change to about command

* Small adjustment to about command

* Remove update command

* Add some more info about arguments

* Fix broken link

* Add pro tip

* Update keys to work well with about

* Fix some common paths

* Add back in the update command with exception if packaged application

* Remove update comment

* Fix all the things

* Make about more robust and also add in exe

* Make sure that there are actual commands and menus
2022-07-06 13:52:26 +01:00
northern-64bit
5188884105 Crypto api fixes (#1959)
* Making pa active + pa minor features

Makes pa actice and adds country to the df. The groupby command also gets percents of holding allocation. It also fixes warnings and prepares for a later pr that I'm currently working on.

* Fix linting

* black linter

* Fixes

Should fix everything

* Linting

* Making pa controller to base class standard

* Fix linting

* Refactor API to accept Crypto Symbol as an input argument

* Crypto API fixes

* Fixes

* Linting

* Linting

* More linting

* Fixes

* Tests : cryptocurrency/helper

* Tests : cryptocurrency/glassnode

* Pytest : Cryptocurrency/due_diligence

* Pytest : cryptocurrency/discovery

* Pytest : cryptocurrency/due_diligence

* Remove not a needed function argument

* Linting

* Test fixes

* Fixing mentioned fixes

* Test fixes

* Tests: cryptocurrency/defi

* Fix linting

* Final test fixes

Co-Authored-By: Chavithra <6114398+Chavithra@users.noreply.github.com>

* Fix merge

* Linting

* Fixing error

* Linting

* Removed long link

Co-authored-by: DidierRLopes <dro.lopes@campus.fct.unl.pt>
Co-authored-by: Minh Hoang <nminh.hoang1023@gmail.com>
Co-authored-by: minhhoang1023 <40023817+minhhoang1023@users.noreply.github.com>
Co-authored-by: Chavithra PARANA <chavithra@gmail.com>
Co-authored-by: Chavithra <6114398+Chavithra@users.noreply.github.com>
2022-07-06 13:08:32 +01:00
DidierRLopes
cda2e81af5 add labels automatically when issue is created (#2033)
Co-authored-by: Theodore Aptekarev <aptekarev@gmail.com>
2022-07-06 00:50:52 +01:00
northern-64bit
85ce998d57 Making the news command pretty with more data (#2045)
* Formatting news command

* Linting

* Linting
2022-07-05 23:31:24 +01:00
DidierRLopes
ac4820cdef Fix trading hours bringing ticker in (#2038)
* fix trading hours bringing ticker in

* fix conditions that were not accounted for

Co-authored-by: Jeroen Bouma <jer.bouma@gmail.com>
2022-07-05 13:22:41 +01:00
DidierRLopes
eba85a56c5 Fix sorting of candle data (#2032)
* fix sorting of candle data

* fix adjclose sorting

Co-authored-by: minhhoang1023 <40023817+minhhoang1023@users.noreply.github.com>
Co-authored-by: Jeroen Bouma <jer.bouma@gmail.com>
2022-07-04 11:21:55 +01:00
DidierRLopes
3d3ee96874 Remove print and fix issue with str on sia/vis (#2034)
* remove print and fix issue with str on sia/vis

* fix tests

Co-authored-by: Jeroen Bouma <jer.bouma@gmail.com>
2022-07-04 10:08:14 +01:00
DidierRLopes
0517135bc9 Fix volatility of crypto (#2039)
* fix volatility of crypto

* fix wrong annual value being used

Co-authored-by: minhhoang1023 <40023817+minhhoang1023@users.noreply.github.com>
2022-07-04 09:22:25 +02:00
DidierRLopes
2ffaace7c3 fix documentation (#2037)
Co-authored-by: minhhoang1023 <40023817+minhhoang1023@users.noreply.github.com>
2022-07-03 23:44:57 +01:00
DidierRLopes
17fc484651 fix messari spelling (#2036)
Co-authored-by: minhhoang1023 <40023817+minhhoang1023@users.noreply.github.com>
2022-07-03 22:34:39 +01:00
DidierRLopes
066d347c63 replace curve brackets by square ones (#2040) 2022-07-03 21:31:04 +01:00
soggyomelette
45f0a0a049 Fixes #2018 and updates default dates in dd_controller.py (#2028)
* Fixes #2018 and updates default dates in dd_controller.py

* Fixing linting

Co-authored-by: Chavithra PARANA <chavithra@gmail.com>
2022-07-02 12:07:53 +01:00
soggyomelette
7849b5668b Adds a test for binance key as asked for in #2006 (#2026)
* Adds a test for binance key as asked for in #2006

* Update keys_controller.py

* Update keys_controller.py

* fixing linting

* fixing tests

* fixing linting

* fix tests

* fix linting

* fix linting

* fix linting

Co-authored-by: DidierRLopes <dro.lopes@campus.fct.unl.pt>
2022-07-02 12:06:51 +01:00
Jeroen Bouma
a4d1d071ca Add in guide to Scripts & Routines (#2027)
* Small detail

* Add in Scripts guide

* Add template script

* Add Scripts to menu

* Update Scripts guide

* Add section on Scripts & Routines in the Getting Started guide

* Update _index.md

* Get rid of images
2022-07-02 12:06:24 +01:00
Paul Symonds
0f0e769156 Update stocks_helper.py (#2025)
* Update stocks_helper.py

When a stock is returned:

Market: CLOSEDSENIOR PLC 10p

Fixed to show:

Market: CLOSED
Company: SENIOT PLC 10p

* Update stocks_helper.py

Added logic for US if source requires .US. without this logic Datetime is printed twice.

* Update stocks_helper.py

Updated logic to fix pyLint Error.

* Update stocks_helper.py

* Update stocks_helper.py

Further testing revealed Upper and Lower case issues, if .upper() is used it throws errors.

This function uses yfinance to return info data for tickers. 

Yahoo does not have .US suffix for US stocks but other feeds may (will) have this.

Some testing gave the following:

Stock:                                                                                                                                                            │
                                                                                                                                                              
Datetime:                                                                                                                                                         
Timezone:                                                                                                                                                         
Exchange:                                                                                                                                                         
Market:                                                                                                                                                           
Currency:                                                                                                                                                         
Company:  

or:

Datetime: 2022 Jul 01 07:51
Timezone: Europe/London
Exchange: LSE
Currency: GBp
Market:   OPENSENIOR PLC 10P


or this:

Datetime: 
Datetime: 2022 Jul 01 02:44
Timezone: America/New_York
Currency: USD
Market:   CLOSED
Company:  

Final Result is this:

Datetime: 2022 Jul 01 02:51
Timezone: America/New_York
Currency: USD
Market:   CLOSED
Company:  Apple Inc.


I don't think this function is overly complex and could do with a refactor at some point.

* Update stocks_helper.py

fixed Black error

* Simplified if statement

* Reverted poetry

Co-authored-by: colin99d <colin99delahunty@gmail.com>
Co-authored-by: Colin Delahunty <72827203+colin99d@users.noreply.github.com>
2022-07-01 11:18:56 -04:00
James Simmons
951c94db97 Adding integration tests to intel mac workflow (#2020) 2022-07-01 13:49:34 +01:00
Jeroen Bouma
c98c467e47 Add in Economy Guide to the website (#2016)
* Add in Economy Guide (WIP)

* Add in Example text

* Update _index.md

* Remove images

Co-authored-by: DidierRLopes <dro.lopes@campus.fct.unl.pt>
2022-06-30 15:47:01 +02:00
Jeroen Bouma
d0aaa9ab5e Add in Cryptocurrency guide and remove the old 'Guides' folder (#2015)
* Add in Crypto guide

* Remove redundant folder

* Fix links
2022-06-30 14:01:41 +01:00
Jeroen Bouma
ddef89d115 Add in Forex Menu guide and apply redirect to a terminal page that shouldn't exist (#2011)
* Add redirect

* Add in Forex guide

* Update _index.md

* Remove images

Co-authored-by: DidierRLopes <dro.lopes@campus.fct.unl.pt>
2022-06-30 09:35:14 +02:00