jerry/buzz
1
0
Fork 0
mirror of https://github.com/block/buzz.git synced 2026-10-27 04:30:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

Attach hidden connection action to labelled wordmark

Browse Source 
Keep the developer entry without a keyboard path by product decision.

Co-authored-by: Terp <5856f6900e8e0a4e0ea1f4f8d2ee33e4753d2119bc122f94ecafc660b46c0511@buzz.block.builderlab.xyz>
Signed-off-by: kenny lopez <klopez4212@gmail.com>
This commit is contained in:
kenny lopez
2026-10-26 19:25:17 +00:00
parent f83702333d
commit 0b27e8c8ce
2 changed files with 121 additions and 88 deletions
Download Patch File Download Diff File Expand all files Collapse all files

176
mobile/lib/features/pairing/pairing_page/pairing_welcome_view.dart
View File

@@ -323,38 +323,42 @@ class _PairingWelcomeView extends HookWidget {
setupContent == null &&
!signInPending &&
!isBusy;
final welcome = Semantics(
customSemanticsActions: canRevealOptions
? {
const CustomSemanticsAction(label: 'More connection options'):
revealOptions,
}
: null,
child: Padding(
padding: const EdgeInsets.symmetric(
horizontal: Grid.gutter,
vertical: Grid.sm,
),
child: CustomScrollView(
// Stay fixed when the welcome content fits; allow only real overflow
// (such as the pairing form above the keyboard), with no rubber banding.
physics: const ClampingScrollPhysics(),
slivers: [
SliverFillRemaining(
hasScrollBody: false,
child: Column(
children: [
Expanded(
child: _TwoFingerDoubleTapSurface(
onDoubleTap: canRevealOptions ? revealOptions : null,
child: Center(
child: Column(
mainAxisSize: MainAxisSize.min,
children: [
ConstrainedBox(
constraints: const BoxConstraints(maxWidth: 320),
child: AspectRatio(
aspectRatio: 777 / 326,
final welcome = Padding(
padding: const EdgeInsets.symmetric(
horizontal: Grid.gutter,
vertical: Grid.sm,
),
child: CustomScrollView(
// Stay fixed when the welcome content fits; allow only real overflow
// (such as the pairing form above the keyboard), with no rubber banding.
physics: const ClampingScrollPhysics(),
slivers: [
SliverFillRemaining(
hasScrollBody: false,
child: Column(
children: [
Expanded(
child: _TwoFingerDoubleTapSurface(
onDoubleTap: canRevealOptions ? revealOptions : null,
child: Center(
child: Column(
mainAxisSize: MainAxisSize.min,
children: [
ConstrainedBox(
constraints: const BoxConstraints(maxWidth: 320),
child: AspectRatio(
aspectRatio: 777 / 326,
child: Semantics(
// Hidden developer entry intentionally has no
// keyboard shortcut. Keep its assistive action
// on the existing labelled wordmark node.
customSemanticsActions: canRevealOptions
? {
const CustomSemanticsAction(
label: 'More connection options',
): revealOptions,
}
: null,
child: OnboardingWordmark(
key: const Key('pairing-buzz-wordmark'),
color: context._onboardingIsDark
@@ -363,73 +367,71 @@ class _PairingWelcomeView extends HookWidget {
),
),
),
const SizedBox(height: Grid.xxs),
Text(
'Your people, your agents, your projects —\nall in one place.',
textAlign: TextAlign.center,
style: context.textTheme.bodyLarge?.copyWith(
color: context._onboardingInk,
),
),
const SizedBox(height: Grid.xxs),
Text(
'Your people, your agents, your projects —\nall in one place.',
textAlign: TextAlign.center,
style: context.textTheme.bodyLarge?.copyWith(
color: context._onboardingInk,
),
],
),
),
],
),
),
),
const SizedBox(height: Grid.md),
ConstrainedBox(
constraints: const BoxConstraints(maxWidth: 440),
child: SizedBox(
width: double.infinity,
child: setupContent != null
? setupContent!
: !connectionLanding
? actions(2)
: ClipRect(
child: Stack(
alignment: Alignment.bottomCenter,
children: [
for (var page = 1; page < 5; page++)
ExcludeFocus(
),
const SizedBox(height: Grid.md),
ConstrainedBox(
constraints: const BoxConstraints(maxWidth: 440),
child: SizedBox(
width: double.infinity,
child: setupContent != null
? setupContent!
: !connectionLanding
? actions(2)
: ClipRect(
child: Stack(
alignment: Alignment.bottomCenter,
children: [
for (var page = 1; page < 5; page++)
ExcludeFocus(
excluding: page != selectedPage,
child: ExcludeSemantics(
excluding: page != selectedPage,
child: ExcludeSemantics(
excluding: page != selectedPage,
child: IgnorePointer(
ignoring: page != selectedPage,
child: AnimatedSlide(
key: ValueKey(
'welcome-panel-$page',
),
offset: Offset(
page == selectedPage
? 0
: page == 1
? -1
: 1,
0,
),
duration: revealDuration,
curve: page == selectedPage
? Curves.easeOutQuad
: Curves.easeOutCubic.flipped,
child: SizedBox(
width: double.infinity,
child: actions(page),
),
child: IgnorePointer(
ignoring: page != selectedPage,
child: AnimatedSlide(
key: ValueKey('welcome-panel-$page'),
offset: Offset(
page == selectedPage
? 0
: page == 1
? -1
: 1,
0,
),
duration: revealDuration,
curve: page == selectedPage
? Curves.easeOutQuad
: Curves.easeOutCubic.flipped,
child: SizedBox(
width: double.infinity,
child: actions(page),
),
),
),
),
],
),
),
],
),
),
),
),
],
),
),
],
),
],
),
),
],
),
);
return PopScope(

33
mobile/test/features/onboarding/hosted_communities_test.dart
View File

@@ -1,3 +1,5 @@
import 'dart:ui' as ui;
import 'package:buzz/shared/hosted/hosted_community_creation.dart';
import 'package:buzz/shared/hosted/hosted_environment.dart';
import 'package:buzz/features/onboarding/hosted_connect_page.dart';
@@ -10,6 +12,7 @@ import 'package:buzz/shared/hosted/builderlab_account.dart';
import 'package:buzz/shared/hosted/hosted_community_connection.dart';
import 'package:flutter/material.dart';
import 'package:flutter/services.dart';
import 'package:flutter/semantics.dart';
import 'package:flutter/foundation.dart';
import 'package:flutter_secure_storage/flutter_secure_storage.dart';
import 'package:flutter_test/flutter_test.dart';
@@ -46,7 +49,7 @@ void main() {
),
);
await tester.pumpAndSettle();
await revealOptions(tester);
await revealOptionsWithSemantics(tester);
await tester.pumpAndSettle();
tester.view.physicalSize = const Size(420, 900);
await tester.pumpAndSettle();
@@ -322,3 +325,31 @@ Future<void> revealOptions(WidgetTester tester) async {
await tester.pump(const Duration(milliseconds: 50));
}
}
Future<void> revealOptionsWithSemantics(WidgetTester tester) async {
final handle = tester.ensureSemantics();
try {
await tester.pump();
final wordmark = tester.getSemantics(find.bySemanticsLabel('Buzz'));
final data = wordmark.getSemanticsData();
final actionIds = data.customSemanticsActionIds!;
expect(actionIds, hasLength(1));
expect(
CustomSemanticsAction.getAction(actionIds.single)!.label,
'More connection options',
);
// The action belongs to the wordmark, never an unlabelled page-sized stop.
expect(data.label, 'Buzz');
expect(wordmark.rect.height, lessThan(200));
wordmark.owner!.performAction(
wordmark.id,
ui.SemanticsAction.customAction,
actionIds.single,
);
await tester.pumpAndSettle();
expect(find.text('Enter a community link').hitTestable(), findsOneWidget);
expect(find.text('Use a pairing code').hitTestable(), findsOneWidget);
} finally {
handle.dispose();
}
}