jerry/buzz
1
0
Fork 0
mirror of https://github.com/block/buzz.git synced 2026-11-08 10:21:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(beehive): filter agent roster by owner

Browse Source 
Signed-off-by: BetterCallSol <886fabdb38ceb1aede220bc237b7bb34736490f12a7d79e235e5ecfd63a36514@buzz.block.builderlab.xyz>
This commit is contained in:
BetterCallSol
2026-09-16 13:35:59 -04:00
parent 9aef40a3f6
commit 1085eadf45
2 changed files with 9 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
beehive/src/relay-directory.ts
View File

@@ -98,7 +98,9 @@ export async function relayDirectory(viewer: string, transport: DirectoryQuery,
row = undefined;
if (p && typeof p.name === 'string' && Number.isInteger(p.parallelism) && Number(p.parallelism) >= 0 && Number(p.parallelism) <= 4294967295 && ['owner-only','allowlist','anyone'].includes(String(p.respond_to)) && (p.respond_to_allowlist === undefined || Array.isArray(p.respond_to_allowlist) && p.respond_to_allowlist.every(v => typeof v === 'string')) && ['persona_id','system_prompt','model','provider','persona_source_version'].every(k => p[k] === undefined || p[k] === null || typeof p[k] === 'string')) row = { publicKey:agent,name:clean(p.name,agent),owner:policy.pubkey,status,channels:[] };
}
if (row && (channels.has(agent) || row.owner === viewer)) result.push({ ...row,channels:[...(channels.get(agent) ?? [])].sort() });
// The management directory is the signed-in owner's roster, not a channel
// participant browser. Channel membership only annotates owned rows.
if (row?.owner === viewer) result.push({ ...row,channels:[...(channels.get(agent) ?? [])].sort() });
}
return result.sort((a,b) => a.name.localeCompare(b.name) || a.publicKey.localeCompare(b.publicKey));
}

12
beehive/test/relay-directory.test.ts
View File

@@ -23,7 +23,7 @@ function queryFixture(events: Event[], calls: DirectoryFilter[][] = []): Directo
}
const signal = () => new AbortController().signal;
test('full canonical discovery finds viewer-owned channel-less and cross-owner membership-visible agents, not arbitrary kind0 or host metadata', async () => {
test('full canonical discovery returns only viewer-owned agents and does not promote channel peers, arbitrary kind0, or host metadata', async () => {
const calls: DirectoryFilter[][] = [];
const result = await relayDirectory(viewer,queryFixture([
policy(viewerSecret,a,'Owned'), profile(aSecret,viewerSecret),
@@ -31,7 +31,7 @@ test('full canonical discovery finds viewer-owned channel-less and cross-owner m
event(bSecret,10100,[],{name:'Old name',status:'online',host:'fake-execution-authority',channel_ids:['forged']}),
profile(newKey(),viewerSecret),policy(otherSecret,a,'Forged policy'),
],calls),signal());
assert.deepEqual(result,[{publicKey:a,name:'Owned',owner:viewer,status:'unknown',channels:[]},{publicKey:b,name:'Shared',owner:other,status:'online',channels:['channel']}]);
assert.deepEqual(result,[{publicKey:a,name:'Owned',owner:viewer,status:'unknown',channels:[]}]);
assert.deepEqual(calls[0],[{kinds:[30177],authors:[viewer],limit:500}]);
assert.deepEqual(calls[1],[{kinds:[39002],authors:[relay],'#p':[viewer],limit:500}]);
for (const batch of calls.slice(2)) { assert.ok(batch.length <= 10); for (const f of batch) { assert.equal(f.authors.length,1); assert.equal(f.limit,1); } }
@@ -39,17 +39,17 @@ test('full canonical discovery finds viewer-owned channel-less and cross-owner m
assert.deepEqual(new Set(policies.map(f => JSON.stringify(f))),new Set([{kinds:[30177],authors:[viewer],'#d':[a],limit:1},{kinds:[30177],authors:[other],'#d':[b],limit:1}].map(v=>JSON.stringify(v))));
});
test('membership role, current membership removal, verified owner and malformed latest policy control discovery', async () => {
test('membership never promotes unowned agents and malformed latest owned policy controls discovery', async () => {
const legacy = event(bSecret,10100,[],{name:'Legacy',status:'running'});
assert.equal((await relayDirectory(viewer,queryFixture([legacy,member([['p',viewer],['p',b]])]),signal())).length,0);
const known = policy(viewerSecret,b,'Seed only');
const result = await relayDirectory(viewer,queryFixture([known,legacy,member([['p',viewer],['p',b]])]),signal());
assert.equal(result[0]?.status,'unknown'); assert.equal(result[0]?.owner,undefined);
assert.equal(result.length,0,'channel membership does not add an agent without verified viewer ownership');
assert.equal((await relayDirectory(viewer,queryFixture([known,legacy]),signal())).length,0,'unverified owned coordinate alone does not retain a legacy agent');
const removed = event(relaySecret,39002,[['d','channel'],['p',viewer]],{},101);
assert.equal((await relayDirectory(viewer,queryFixture([legacy,member(),removed]),signal())).length,0);
const malformed = event(otherSecret,30177,[['d',b]],{name:'Missing required fields'});
assert.equal((await relayDirectory(viewer,queryFixture([legacy,member(),profile(bSecret,otherSecret),malformed]),signal())).length,0,'malformed authenticated policy reserves identity instead of reviving legacy');
const malformed = event(viewerSecret,30177,[['d',a]],{name:'Missing required fields'},101);
assert.equal((await relayDirectory(viewer,queryFixture([event(aSecret,10100,[],{name:'Legacy',status:'online'}),profile(aSecret,viewerSecret),policy(viewerSecret,a,'Owned'),malformed]),signal())).length,0,'malformed authenticated policy reserves identity instead of reviving legacy');
});
test('NIP-OA requires one canonical tag and checks every condition against profile timestamp', () => {