jerry/buzz
1
0
Fork 0
mirror of https://github.com/block/buzz.git synced 2026-11-02 15:31:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

Address review feedback round 3

Browse Source 
Reserve disabled management rows until permissions resolve so cold-cache menus remain safe and stable.

Co-authored-by: npub1ux8n2yfs8qfvgd75s7kyhar2mztac355v6vmrz4juc9l3msw4pgstums9e <e18f3511303812c437d487ac4bf46ad897dc46946699b18ab2e60bf8ee0ea851@sprout-oss.stage.blox.sqprod.co>
Signed-off-by: npub1ux8n2yfs8qfvgd75s7kyhar2mztac355v6vmrz4juc9l3msw4pgstums9e <e18f3511303812c437d487ac4bf46ad897dc46946699b18ab2e60bf8ee0ea851@sprout-oss.stage.blox.sqprod.co>
This commit is contained in:
npub1ux8n2yfs8qfvgd75s7kyhar2mztac355v6vmrz4juc9l3msw4pgstums9e
2026-07-13 18:21:58 -07:00
parent 7fac474ea9
commit 1eaf0e04a9
1 changed files with 15 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
desktop/src/features/sidebar/ui/ChannelContextMenu.tsx
View File

@@ -61,7 +61,7 @@ export function ChannelContextMenu({
return (
<ContextMenu modal={modal} onOpenChange={setOpen}>
<ContextMenuTrigger asChild>{children}</ContextMenuTrigger>
<ContextMenuContent forceMount className={open ? undefined : "hidden"}>
<ContextMenuContent>
<ChannelContextMenuItems {...contentProps} menuOpen={open} />
</ContextMenuContent>
</ContextMenu>
@@ -238,22 +238,18 @@ export function ChannelContextMenuItems({
selfMember?.role === "owner" ||
selfMember?.role === "admin" ||
canManageOwnedAgentChannel;
// Snapshot capabilities for each open session. Permission responses that
// arrive after the menu opens apply on the next open instead of inserting
// immediate actions beneath the user's pointer.
const [showManagementActions, setShowManagementActions] =
React.useState(false);
const menuWasOpenRef = React.useRef(false);
React.useLayoutEffect(() => {
if (menuOpen && !menuWasOpenRef.current) {
setShowManagementActions(
channel.channelType !== "dm" &&
channel.archivedAt === null &&
canManageChannel,
);
}
menuWasOpenRef.current = menuOpen;
}, [canManageChannel, channel.archivedAt, channel.channelType, menuOpen]);
const managementActionsAreResolved =
menuOpen &&
membersQuery.data !== undefined &&
(ownerPubkeys.length === 0 || ownerProfilesQuery.data !== undefined);
const managementActionsAreEligible =
channel.channelType !== "dm" && channel.archivedAt === null;
// Reserve the final two action rows while permissions load. If the viewer can
// manage this channel, the rows become actionable without changing the menu
// geometry; otherwise they disappear without ever exposing Archive.
const showManagementActions =
managementActionsAreEligible &&
(!managementActionsAreResolved || canManageChannel);
const showStar = Boolean(onStarChannel && onUnstarChannel);
const showReadToggle = hasUnread
? Boolean(onMarkChannelRead)
@@ -284,6 +280,7 @@ export function ChannelContextMenuItems({
<>
<ContextMenuSeparator />
<ContextMenuItem
disabled={!managementActionsAreResolved}
onSelect={() =>
deferMenuAction(() =>
openChannelManagement(channel.id, { edit: true }),
@@ -297,6 +294,7 @@ export function ChannelContextMenuItems({
</ContextMenuItem>
<ContextMenuItem
className="text-destructive focus:text-destructive"
disabled={!managementActionsAreResolved}
onSelect={() =>
deferMenuAction(() => {
void archiveChannelMutation.mutateAsync().catch((error) => {