jerry/buzz
1
0
Fork 0
mirror of https://github.com/block/buzz.git synced 2026-10-30 22:11:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(desktop): show full pop-out prompts

Browse Source 
Co-authored-by: Rizz <302abe414ca6e3134763d2539bfcf145aea2a63fe5f8455204ed602fd40cf381@buzz.block.builderlab.xyz>
Signed-off-by: Taylor Ho <taylorkmho@gmail.com>
This commit is contained in:
Taylor Ho
2026-08-24 05:01:16 -07:00
committed by Rizz
parent 32227296bd
commit 2e697be1b2
3 changed files with 42 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
desktop/src/features/agents/ui/AgentSessionToolItem/CompactMessageSummary.tsx
View File

@@ -55,7 +55,7 @@ export function CompactMessageSummary({
const { openProfilePanel } = useProfilePanel();
const isCompactPreview = variant === "compactPreview";
const isDedicatedActivityWindow = isAgentActivityWindow();
const shouldClampBubble = !isCompactPreview;
const shouldClampBubble = !isCompactPreview && !isDedicatedActivityWindow;
const effectiveMessageLink = isDedicatedActivityWindow ? null : messageLink;
const [bubbleRef, hasBubbleOverflow] =
useTranscriptBubbleOverflow(shouldClampBubble);

2
desktop/src/features/agents/ui/activityRenderClasses/UserMessageBubble.tsx
View File

@@ -36,7 +36,7 @@ export function UserMessageBubble({
const { openProfilePanel } = useProfilePanel();
const isCompactPreview = variant === "compactPreview";
const isDedicatedActivityWindow = isAgentActivityWindow();
const shouldClampBubble = !isCompactPreview;
const shouldClampBubble = !isCompactPreview && !isDedicatedActivityWindow;
const [bubbleRef, hasBubbleOverflow] =
useTranscriptBubbleOverflow(shouldClampBubble);
const text = item.text.trim();

41
desktop/tests/e2e/agent-activity-window.spec.ts
View File

@@ -73,7 +73,10 @@ test("keeps dedicated activity windows pinned to their original channel", async
sessionUpdate: "user_message_chunk",
messageId: "b".repeat(64),
authorPubkey: repositoryOwnerPubkey,
content: { type: "text", text: "Please inspect the feed" },
content: {
type: "text",
text: `${Array.from({ length: 11 }, (_, index) => `Prompt line ${index + 1}: inspect every detail in the dedicated activity feed.`).join("\n\n")}\n\nPrompt line 12: FINAL-PROMPT-LINE`,
},
},
},
},
@@ -210,6 +213,42 @@ test("keeps dedicated activity windows pinned to their original channel", async
"general",
);
const userMessage = panel.getByTestId("transcript-user-message");
const userBubble = userMessage.locator(":scope > div > div").first();
await expect(userBubble).toContainText("FINAL-PROMPT-LINE");
const promptTailGeometry = await userBubble.evaluate((bubble) => {
const walker = document.createTreeWalker(bubble, NodeFilter.SHOW_TEXT);
let tailNode: Text | null = null;
while (walker.nextNode()) {
const node = walker.currentNode as Text;
if (node.data.includes("FINAL-PROMPT-LINE")) {
tailNode = node;
break;
}
}
if (!tailNode)
throw new Error("Final prompt line text node was not found.");
const tailStart = tailNode.data.indexOf("FINAL-PROMPT-LINE");
const range = document.createRange();
range.setStart(tailNode, tailStart);
range.setEnd(tailNode, tailStart + "FINAL-PROMPT-LINE".length);
const bubbleRect = bubble.getBoundingClientRect();
const tailRect = range.getBoundingClientRect();
return {
bubbleBottom: bubbleRect.bottom,
bubbleTop: bubbleRect.top,
overflowY: getComputedStyle(bubble).overflowY,
tailBottom: tailRect.bottom,
tailTop: tailRect.top,
};
});
expect(promptTailGeometry.overflowY).toBe("visible");
expect(promptTailGeometry.tailTop).toBeGreaterThanOrEqual(
promptTailGeometry.bubbleTop,
);
expect(promptTailGeometry.tailBottom).toBeLessThanOrEqual(
promptTailGeometry.bubbleBottom + 1,
);
const userTimestamp = userMessage.locator("span[title]").last();
await expect(userTimestamp).toBeVisible();
await expect(userTimestamp).toHaveCSS("cursor", "default");