jerry/buzz
1
0
Fork 0
mirror of https://github.com/block/buzz.git synced 2026-10-29 21:41:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(desktop): guard document at settle entry; pin rotation in concurrent test

Browse Source 
Blind-review round 14 (Opus medium) P3s:

- settleChannelSwitchTrace guarded window but then read document
  (visibilityState, querySelector) unguarded — the document guard in
  ensureVisibilityWatcher was dead protection. The settle entry gate now
  covers both globals.
- The concurrent boundary test folded the rotated generation in behind
  if-let, so a regression where rotation never fires under contention
  would pass green with all 32 lines in the live file. The read is now
  unconditional, and the boundary comment's arithmetic is corrected
  (rotation triggers before the 23rd append).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Signed-off-by: Max Lampert <maxwell@squareup.com>
This commit is contained in:
Max Lampert
2026-08-25 02:00:20 -07:00
parent e0f4768ec7
commit 83eb45c8ee
2 changed files with 15 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
desktop/src-tauri/src/commands/perf_log.rs
View File

@@ -368,10 +368,12 @@ mod tests {
let _ = std::fs::remove_file(dir.join("switch-perf.jsonl.1"));
// 8 writers × 4 lines of 18 bytes on disk (17 chars + newline) = 576
// bytes against a 384-byte cap: the rotation boundary is crossed
// exactly once (at the 22nd line), so every line must land in either
// the live file or the single rotated generation. Unserialized
// metadata→rename→append interleavings drop lines or fail renames.
// bytes against a 384-byte cap: rotation triggers before the 23rd
// append (22 lines = 396 bytes ≥ 384) and the ≤10 lines that follow
// (≤180 bytes) cannot re-trigger it, so the boundary is crossed
// exactly once and every line must land in either the live file or
// the single rotated generation. Unserialized metadata→rename→append
// interleavings drop lines or fail renames.
let threads: Vec<_> = (0..8)
.map(|writer| {
let path = path.clone();
@@ -396,9 +398,12 @@ mod tests {
.lines()
.map(str::to_string)
.collect();
if let Ok(rotated) = std::fs::read_to_string(dir.join("switch-perf.jsonl.1")) {
lines.extend(rotated.lines().map(str::to_string));
}
// Unconditional: if rotation never fired under contention, the size
// cap is inoperative and this test must fail, not silently pass with
// all 32 lines in the live file.
let rotated = std::fs::read_to_string(dir.join("switch-perf.jsonl.1"))
.expect("rotation must have occurred under contention");
lines.extend(rotated.lines().map(str::to_string));
lines.sort();
let expected: Vec<String> = (0..8)
.flat_map(|writer| {

4
desktop/src/shared/lib/channelSwitchPerf.ts
View File

@@ -416,7 +416,9 @@ export function settleChannelSwitchTrace(channelId: string): void {
return;
}
const trace = settledTrace;
if (typeof window === "undefined") {
// Both globals gate the whole settle path: the wait loop reads
// document.visibilityState and querySelector unguarded past this point.
if (typeof window === "undefined" || typeof document === "undefined") {
activeTrace = null;
return;
}