refactor(sidebar): unwrap no-op managed-agents FeatureGate

managed-agents is tier: 'stable' in features.json, so the wrapper
always resolved to true — leftover from the original fail-open
blocker fix. Removed the wrapper, kept the SidebarMenuItem.

Biome + typecheck clean; agents.spec.ts, smoke.spec.ts, and the
screenshot-feature-flags suite all pass locally (27/27).

Signed-off-by: Taylor Ho <taylorkmho@gmail.com>
Signed-off-by: npub1223z34hd7vtwc6qj4s7flsxkj644nlre2nthu7lrrmkumhu3xddsrx9r6w <52a228d6edf316ec6812ac3c9fc0d696ab59fc7954d77e7be31eedcddf91335b@sprout-oss.stage.blox.sqprod.co>
This commit is contained in:
npub1223z34hd7vtwc6qj4s7flsxkj644nlre2nthu7lrrmkumhu3xddsrx9r6w
2026-06-08 13:36:59 -07:00
parent 0ca05eddc5
commit ab7c11f0f5

View File

@@ -472,28 +472,26 @@ export function AppSidebar({
</SidebarMenuButton>
</SidebarMenuItem>
</FeatureGate>
<FeatureGate feature="managed-agents">
<SidebarMenuItem>
<SidebarMenuButton
data-testid="open-agents-view"
isActive={selectedView === "agents"}
onClick={onSelectAgents}
tooltip="Agents"
type="button"
<SidebarMenuItem>
<SidebarMenuButton
data-testid="open-agents-view"
isActive={selectedView === "agents"}
onClick={onSelectAgents}
tooltip="Agents"
type="button"
>
<Bot className="h-4 w-4" />
<span>Agents</span>
</SidebarMenuButton>
{shouldShowAgentCount ? (
<SidebarMenuBadge
className="right-2 rounded-full bg-sidebar-accent/70 px-1.5 text-[11px] text-sidebar-foreground/75 peer-data-[active=true]/menu-button:bg-sidebar-active-foreground/20 peer-data-[active=true]/menu-button:text-sidebar-active-foreground"
data-testid="sidebar-agents-count"
>
<Bot className="h-4 w-4" />
<span>Agents</span>
</SidebarMenuButton>
{shouldShowAgentCount ? (
<SidebarMenuBadge
className="right-2 rounded-full bg-sidebar-accent/70 px-1.5 text-[11px] text-sidebar-foreground/75 peer-data-[active=true]/menu-button:bg-sidebar-active-foreground/20 peer-data-[active=true]/menu-button:text-sidebar-active-foreground"
data-testid="sidebar-agents-count"
>
{totalAgentCount}
</SidebarMenuBadge>
) : null}
</SidebarMenuItem>
</FeatureGate>
{totalAgentCount}
</SidebarMenuBadge>
) : null}
</SidebarMenuItem>
<FeatureGate feature="workflows">
<SidebarMenuItem>
<SidebarMenuButton