jerry/buzz
1
0
Fork 0
mirror of https://github.com/block/buzz.git synced 2026-10-31 06:21:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

Prefer newer agent turn outcomes

Browse Source 
Signed-off-by: kenny lopez <klopez4212@gmail.com>
This commit is contained in:
kenny lopez
2026-08-17 19:03:04 +01:00
parent 1fab22311f
commit d40c4ed894
2 changed files with 59 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
mobile/lib/features/channels/agent_activity/working_bots_provider.dart
View File

@@ -180,10 +180,10 @@ final workingBotPubkeysProvider = Provider.autoDispose
});
int _compareComposerTurnRecency(AgentTurnState a, AgentTurnState b) {
if (a.isWorking != b.isWorking) return a.isWorking ? 1 : -1;
final activity = a.lastActivityAt.compareTo(b.lastActivityAt);
if (activity != 0) return activity;
final started = a.startedAt.compareTo(b.startedAt);
if (started != 0) return started;
if (a.isWorking != b.isWorking) return a.isWorking ? 1 : -1;
return a.turnId.compareTo(b.turnId);
}

61
mobile/test/features/channels/agent_activity/working_bots_provider_test.dart
View File

@@ -305,8 +305,63 @@ void main() {
});
});
test('prefers live work over retained terminal history', () {
test('prefers a newer terminal outcome over stale working history', () {
final container = ProviderContainer(
overrides: [
currentPubkeyProvider.overrideWith((ref) => 'owner'),
channelMembersProvider(
_channelId,
).overrideWith((ref) async => const <ChannelMember>[]),
channelTypingProvider(
_channelId,
).overrideWith(() => _FakeTypingNotifier(const [])),
agentMentionPubkeysProvider(
_channelId,
).overrideWith((ref) => const {'agent-a'}),
agentOwnersProvider.overrideWithValue(
const AsyncData({'agent-a': 'owner'}),
),
userCacheProvider.overrideWith(_FakeUserCacheNotifier.new),
observerRelayProvider.overrideWith(
() => _FakeObserverRelayNotifier({
'agent-a': [_observerFrame('agent-a')],
}),
),
composerAgentTurnStatesProvider.overrideWithValue([
_turn(
'agent-a',
turnId: 'turn-old',
startedAt: DateTime.utc(2026, 8, 16, 11, 59),
lastActivityAt: DateTime.utc(2026, 8, 16, 12, 0, 1),
),
_turn(
'agent-a',
phase: AgentTurnPhase.error,
turnId: 'turn-new',
startedAt: DateTime.utc(2026, 8, 16, 12),
lastActivityAt: DateTime.utc(2026, 8, 16, 12, 0, 5),
),
]),
],
);
addTearDown(container.dispose);
final state = container.read(
composerActivityStateProvider((
channelId: _channelId,
threadHeadId: null,
)),
);
expect(state.agents.single.turnId, 'turn-new');
expect(state.agents.single.phase, AgentTurnPhase.error);
expect(state.agents.single.isWorking, isFalse);
expect(container.read(workingBotPubkeysProvider(_channelId)), isEmpty);
});
test('prefers live work when turn chronology is tied', () {
final receiptAt = DateTime.utc(2026, 8, 16, 12, 0, 5);
final startedAt = DateTime.utc(2026, 8, 16, 12, 0, 4);
final container = ProviderContainer(
overrides: [
currentPubkeyProvider.overrideWith((ref) => 'owner'),
@@ -333,13 +388,13 @@ void main() {
'agent-a',
phase: AgentTurnPhase.error,
turnId: 'turn-old',
startedAt: DateTime.utc(2026, 8, 16, 11, 59),
startedAt: startedAt,
lastActivityAt: receiptAt,
),
_turn(
'agent-a',
turnId: 'turn-new',
startedAt: DateTime.utc(2026, 8, 16, 12, 0, 4),
startedAt: startedAt,
lastActivityAt: receiptAt,
),
]),