jerry/buzz
1
0
Fork 0
mirror of https://github.com/block/buzz.git synced 2026-10-27 12:40:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

test(desktop): await channel E2E bridge readiness (#5886)

Browse Source 
## Summary

- wait for the channel mutation and cache invalidation E2E hooks before
using them
- make those hooks required after readiness instead of silently skipping
fixture setup
- keep the production channel settings behavior and assertion unchanged

## Why

On slower CI startup, `page.goto()` can resolve before the E2E bridge
installs its globals. The test used optional calls, so all three fixture
operations could silently do nothing and leave the seeded `General
discussion for everyone` description in React Query. The assertion then
failed deterministically, including both retries.

## Validation

At commit `5b4d5d290b316db5eef78c3596a17c7a270c8163`:

- `pnpm -C desktop build:e2e`
- focused Playwright test repeated 30 times: 30 passed
- `pnpm -C desktop exec biome check tests/e2e/channels.spec.ts`
- mandatory pre-push hooks passed on the exact pushed head:
`branch-skew`, `desktop-check`, `desktop-typecheck`, `mobile-test`,
`desktop-test`, `rust-tests`, and `desktop-tauri-checks`
- `git diff --check origin/main...HEAD`

Signed-off-by: Wes <wesbillman@users.noreply.github.com>
Co-authored-by: Carl <c7ebe626f000404285d3686e1dc74cc07cc60a9754a150041ba132e14bd3e2ec@buzz.block.builderlab.xyz>
This commit is contained in:
Wes
2026-08-14 11:29:37 -06:00
committed by GitHub
parent fd0ab47a1b
commit dbee2914ad
1 changed files with 10 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
desktop/tests/e2e/channels.spec.ts
View File

@@ -2724,24 +2724,29 @@ test("channel settings only prompt editors to add an empty description", async (
page,
}) => {
await page.goto("/");
await page.waitForFunction(
() =>
typeof window.__BUZZ_E2E_MUTATE_CHANNEL__ === "function" &&
typeof window.__BUZZ_E2E_INVALIDATE_CHANNELS__ === "function",
);
await page.evaluate(
async ({ generalChannelId, randomChannelId }) => {
const bridge = window as Window & {
__BUZZ_E2E_INVALIDATE_CHANNELS__?: () => Promise<void>;
__BUZZ_E2E_MUTATE_CHANNEL__?: (options: {
__BUZZ_E2E_INVALIDATE_CHANNELS__: () => Promise<void>;
__BUZZ_E2E_MUTATE_CHANNEL__: (options: {
channelId: string;
description?: string;
}) => void;
};
bridge.__BUZZ_E2E_MUTATE_CHANNEL__?.({
bridge.__BUZZ_E2E_MUTATE_CHANNEL__({
channelId: generalChannelId,
description: "",
});
bridge.__BUZZ_E2E_MUTATE_CHANNEL__?.({
bridge.__BUZZ_E2E_MUTATE_CHANNEL__({
channelId: randomChannelId,
description: "",
});
await bridge.__BUZZ_E2E_INVALIDATE_CHANNELS__?.();
await bridge.__BUZZ_E2E_INVALIDATE_CHANNELS__();
},
{
generalChannelId: GENERAL_CHANNEL_ID,