jerry/buzz
1
0
Fork 0
mirror of https://github.com/block/buzz.git synced 2026-10-31 06:21:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

test(desktop): cover workstream reviewer wait boundaries

Browse Source 
Signed-off-by: loganj <loganj@squareup.com>
This commit is contained in:
Logan Johnson
2026-08-18 17:44:32 +00:00
parent 9637be3b73
commit e98ee00139
1 changed files with 72 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

72
desktop/src/features/workstream-board/lib/workstreamWaits.test.mjs
View File

@@ -130,3 +130,75 @@ test("sorting authenticates the current owner by pubkey and remains stable acros
ordered,
);
});
test("derived reviewer waits cover all unapproved open review states and exclude approved or terminal states", () => {
const reference = {
kind: "github",
identity: "github:block/buzz#2",
rawUrl: "https://github.com/block/buzz/pull/2",
href: "https://github.com/block/buzz/pull/2",
owner: "block",
repository: "buzz",
number: 2,
};
for (const reviewState of [
"no-reviews",
"review-requested",
"changes-requested",
]) {
const states = new Map([
[
reference.identity,
{
status: "live",
provider: "github",
href: reference.href,
repository: "block/buzz",
number: 2,
title: "Two",
lifecycle: "open",
reviewState,
},
],
]);
assert.equal(
deriveReviewerWaits([reference], states).length,
1,
reviewState,
);
}
for (const lifecycle of ["draft", "merged", "closed"]) {
const states = new Map([
[
reference.identity,
{
status: "live",
provider: "github",
href: reference.href,
repository: "block/buzz",
number: 2,
title: "Two",
lifecycle,
reviewState: "review-requested",
},
],
]);
assert.equal(deriveReviewerWaits([reference], states).length, 0, lifecycle);
}
const approved = new Map([
[
reference.identity,
{
status: "live",
provider: "github",
href: reference.href,
repository: "block/buzz",
number: 2,
title: "Two",
lifecycle: "open",
reviewState: "approved",
},
],
]);
assert.equal(deriveReviewerWaits([reference], approved).length, 0);
});