jerry/buzz
1
0
Fork 0
mirror of https://github.com/block/buzz.git synced 2026-11-15 13:51:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

test(sidebar): move live-sub test to end of whole-blob suite to prevent microtask leakage

Browse Source 
The undecryptable-live-event test fires a live-event callback that spawns
a dangling async chain (void decryptAndParse().then(...)). When placed
mid-suite, trailing microtasks from that chain could interfere with
subsequent timer-based tests. Moving it last keeps the suite hermetic.

Also removes the console.log debug calls that were left in from development.

Co-authored-by: Will Pfleger <pfleger.will@gmail.com>
Signed-off-by: Will Pfleger <pfleger.will@gmail.com>
This commit is contained in:
Duncan
2026-08-29 17:34:45 -04:00
parent dc32f27975
commit ea51e246b5
1 changed files with 50 additions and 64 deletions
Download Patch File Download Diff File Expand all files Collapse all files

114
desktop/src/features/sidebar/lib/wholeBlobSync.shared.test.mjs
View File

@@ -423,70 +423,6 @@ export function runWholeBlobSyncSuite({
}
});
// ─── live-sub: undecryptable event advances watermark before decrypt ───────
test(`${label}: revert-fix: undecryptable live event advances watermark before decrypt attempt`, async () => {
let liveCallback = null;
mock.method(relayClient, "subscribeLive", (_filter, onEvent) => {
console.log(` [t12-${label}] subscribeLive mock fired`);
liveCallback = onEvent;
return Promise.resolve(async () => {});
});
const fw = makeFakeWindow();
const restore = installFakeWindow(fw);
try {
const manager = new SyncManager("pk-live", RELAY);
assert.equal(
fw.localStorage.getItem(
`buzz-sync-watermark.v1:${watermarkLane}:pk-live:${RELAY_KEY}`,
),
null,
"watermark starts absent",
);
console.log(
` [t12-${label}] about to await subscribeMethod=${subscribeMethod}`,
);
await manager[subscribeMethod](() => {});
console.log(
` [t12-${label}] subscribeMethod done, liveCallback=${!!liveCallback}`,
);
assert.ok(
liveCallback !== null,
"subscribeLive must have captured the callback",
);
liveCallback({
pubkey: "pk-live",
content: "!bad-cipher!",
created_at: 1700005555,
id: "live-evt-1",
});
console.log(
` [t12-${label}] liveCallback fired, awaiting setTimeout(0)`,
);
await new Promise((r) => setTimeout(r, 0));
console.log(` [t12-${label}] setTimeout(0) done, checking watermark`);
assert.ok(
Number(
fw.localStorage.getItem(
`buzz-sync-watermark.v1:${watermarkLane}:pk-live:${RELAY_KEY}`,
) ?? "0",
) >= 1700005555,
"live undecryptable event must advance the watermark before decrypt is attempted",
);
console.log(` [t12-${label}] watermark OK, calling manager.destroy()`);
manager.destroy();
console.log(` [t12-${label}] manager.destroy() done`);
} finally {
console.log(` [t12-${label}] finally: calling restore()`);
restore();
console.log(
` [t12-${label}] finally: restore() done, calling mock.reset()`,
);
mock.reset();
console.log(` [t12-${label}] finally: mock.reset() done`);
}
});
// ─── Overlapping publishes ─────────────────────────────────────────────────
test(`${label}: overlapping publishes: older completion does not erase a newer queued edit`, async () => {
@@ -908,4 +844,54 @@ export function runWholeBlobSyncSuite({
mock.reset();
}
});
// ─── live-sub: undecryptable event advances watermark before decrypt ───────
// NOTE: this test uses subscribeLive and fires a live-event callback that
// spawns a dangling async chain (void decryptAndParse().then(...)). Placing
// it last in the suite keeps those trailing microtasks from leaking into
// timer-based tests that follow it.
test(`${label}: revert-fix: undecryptable live event advances watermark before decrypt attempt`, async () => {
let liveCallback = null;
mock.method(relayClient, "subscribeLive", (_filter, onEvent) => {
liveCallback = onEvent;
return Promise.resolve(async () => {});
});
const fw = makeFakeWindow();
const restore = installFakeWindow(fw);
try {
const manager = new SyncManager("pk-live", RELAY);
assert.equal(
fw.localStorage.getItem(
`buzz-sync-watermark.v1:${watermarkLane}:pk-live:${RELAY_KEY}`,
),
null,
"watermark starts absent",
);
await manager[subscribeMethod](() => {});
assert.ok(
liveCallback !== null,
"subscribeLive must have captured the callback",
);
liveCallback({
pubkey: "pk-live",
content: "!bad-cipher!",
created_at: 1700005555,
id: "live-evt-1",
});
await new Promise((r) => setTimeout(r, 0));
assert.ok(
Number(
fw.localStorage.getItem(
`buzz-sync-watermark.v1:${watermarkLane}:pk-live:${RELAY_KEY}`,
) ?? "0",
) >= 1700005555,
"live undecryptable event must advance the watermark before decrypt is attempted",
);
manager.destroy();
} finally {
restore();
mock.reset();
}
});
}