jerry/buzz
1
0
Fork 0
mirror of https://github.com/block/buzz.git synced 2026-10-29 21:41:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(projects): serialize channel state authority

Browse Source 
Signed-off-by: John Tennant <jtennant@squareup.com>
This commit is contained in:
John Tennant
2026-08-31 22:34:20 -04:00
parent b051e85493
commit ee4157034a
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
crates/buzz-db/src/store/project_revision.rs
View File

@@ -167,16 +167,18 @@ impl Db {
let role = if actor.as_slice() == owner.as_slice() {
None
} else if let Some(home_channel_id) = home {
// Serialize the authorization read with roster mutations. Without
// the shared membership lock, an admin removal or demotion could
// commit while this transaction still acts on the stale role.
// Serialize the authorization read with roster mutations. The
// channel-row share lock also serializes archive/deletion. Without
// both, a revocation could commit while this transaction still
// acts on stale authority.
acquire_channel_membership_lock(&mut tx, community_id, home_channel_id).await?;
sqlx::query_scalar::<_, String>(
"SELECT cm.role::text FROM channel_members cm \
JOIN channels c ON c.community_id=cm.community_id AND c.id=cm.channel_id \
WHERE cm.community_id=$1 AND cm.channel_id=$2 AND cm.pubkey=$3 \
AND cm.removed_at IS NULL AND c.deleted_at IS NULL \
AND c.archived_at IS NULL",
AND c.archived_at IS NULL \
FOR SHARE OF c",
)
.bind(community_id.as_uuid())
.bind(home_channel_id)