test(buzz-acp): assert reject option ID in reject_once applied write

The reject_once_resolves_entry_with_applied_write test previously
asserted only map-empty and write-count=1. Thufir's mutation of
permission_response_selected emitting a hardcoded opt-allow-once
demonstrated the test would stay green on a wrong-optionId regression.

Inspect the single applied write's payload and assert
payload[result][outcome][optionId] == opt-reject-once, mirroring
the first-wins test's payload assertion at the ACK path.

Mutation proof: forcing permission_response_selected to emit
opt-allow-once regardless of selection makes this test FAIL
at the optionId assertion.

Co-authored-by: Will Pfleger <pfleger.will@gmail.com>
Signed-off-by: Will Pfleger <pfleger.will@gmail.com>
This commit is contained in:
Duncan
2026-09-01 18:49:53 -04:00
parent 96c9b7f692
commit fbeb9fafb3

View File

@@ -13131,19 +13131,6 @@ mod tests {
let short_idle = std::time::Duration::from_millis(100);
let ten_s = std::time::Duration::from_secs(10);
let applied_count = |o: &crate::observer::ObserverHandle| {
o.snapshot()
.into_iter()
.filter(|e| {
e.kind == "acp_write"
&& e.authorization
.as_ref()
.map(|a| a.reason.as_deref() == Some("applied"))
.unwrap_or(false)
})
.count()
};
// ── reject_once resolves the entry ────────────────────────────────────
{
let (tx, rx) = tokio::sync::mpsc::channel::<PermissionDecision>(4);
@@ -13166,11 +13153,31 @@ mod tests {
"entry must be resolved after reject_once decision; \
mutation: accepts() drops reject → entry stays pending → this fires"
);
// Collect the applied writes and assert exactly one, carrying the reject option ID.
let events = obs.snapshot();
let applied_writes: Vec<_> = events
.iter()
.filter(|e| {
e.kind == "acp_write"
&& e.authorization
.as_ref()
.map(|a| a.reason.as_deref() == Some("applied"))
.unwrap_or(false)
})
.collect();
assert_eq!(
applied_count(&obs),
applied_writes.len(),
1,
"exactly one applied ACP write must be emitted for reject_once; \
mutation: accepts() drops reject → zero writes → this fires"
mutation: accepts() drops reject → zero writes → this fires; got: {applied_writes:?}"
);
let payload = &applied_writes[0].payload;
assert_eq!(
payload["result"]["outcome"]["optionId"].as_str(),
Some("opt-reject-once"),
"applied write must carry the reject option ID; \
mutation: response helper emits wrong optionId → this fires; got: {payload}"
);
}
}